[PATCH] D37521: [Sema][Typo correction] Assertion failure in typo correction if chain of member function calls has multiple typos

iid_iunknown created this revision. This is a patch proposal for PR34507. Typo resolution can create new TypoExprs while transforming an expression. These TypoExprs are not transformed, they are present in the resulting expression and cause the `DelayedTypos.empty() && "Uncorrected typos!"` as

[PATCH] D37336: [clang-cl] Explicitly set object format to COFF in CL mode

iid_iunknown added a comment. Thanks for reviewing this! Repository: rL LLVM https://reviews.llvm.org/D37336 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37336: [clang-cl] Explicitly set object format to COFF in CL mode

iid_iunknown added a comment. > Do you think you can write a test for your patch that will work on the > buildbots we have? I am afraid, this is not possible with the existing buildbots. `--target` does not affect the default triple. There is `LLVM_TARGET_TRIPLE_ENV` that allows to override th

[PATCH] D37336: [clang-cl] Explicitly set object format to COFF in CL mode

iid_iunknown added a comment. In https://reviews.llvm.org/D37336#857802, @hans wrote: > But why isn't that failure showing on some buildbot, then? The test needs `system-windows` to run: // REQUIRES: system-windows There is no windows buildbot that builds clang defaulted to the AArch64 targ

[PATCH] D37336: [clang-cl] Explicitly set object format to COFF in CL mode

iid_iunknown created this revision. Herald added subscribers: kristof.beyls, aemerson. Currently object format is taken from the default target triple. For toolchains with a non-COFF default target this may result in an object format inappropriate for pc-windows and lead to compilation issues.

[PATCH] D34430: [Clang][TypoCorrection] Clang hangs in typo correction

iid_iunknown added a comment. A gentle reminder about this patch. Repository: rL LLVM https://reviews.llvm.org/D34430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34430: [Clang][TypoCorrection] Clang hangs in typo correction

iid_iunknown added a comment. No hang with this patch on the test case from PR33484. Clang reports a number of expected compilation errors instead. Repository: rL LLVM https://reviews.llvm.org/D34430 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D34430: [Clang][TypoCorrection] Clang hangs in typo correction

iid_iunknown updated this revision to Diff 103297. iid_iunknown added a comment. Fixed white spaces. Repository: rL LLVM https://reviews.llvm.org/D34430 Files: lib/Sema/SemaExprCXX.cpp Index: lib/Sema/SemaExprCXX.cpp === ---

[PATCH] D34430: [Clang][TypoCorrection] Clang hangs in typo correction

iid_iunknown created this revision. iid_iunknown added a project: clang. This is a patch for PR33484. The clang's typo correction logic may fall into an infinite loop when reaching the typo correction limit. When some complex expression has multiple typos in it, clang finds possible corrections

[PATCH] D16901: [Clang driver, ARM] Do not add +long-calls in PIC mode

iid_iunknown abandoned this revision. iid_iunknown added a comment. Abandoning the patch as it is too old. Repository: rL LLVM https://reviews.llvm.org/D16901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m