[PATCH] D133648: Clang, increase upper bound of partially initialized array sizes

OfekShochat marked an inline comment as done. OfekShochat added a comment. @efriedma would you be able to commit this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133648/new/ https://reviews.llvm.org/D133648 _

[PATCH] D133648: Clang, increase upper bound of partially initialized array sizes

OfekShochat marked an inline comment as done. OfekShochat added a comment. I created a diff for the AsmPrinter part, its at D133845 Comment at: clang/lib/Sema/SemaInit.cpp:866 ElementEntity.getKind() == InitializedEntity::EK_VectorEl

[PATCH] D133648: Clang, increase upper bound of partially initialized array sizes

OfekShochat updated this revision to Diff 459642. OfekShochat added a comment. Clang, increase upper bound of partially initialized array sizes fixes issue with emitting partially initialized constant arrays larger than 2^32. issue #57353 on github. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D133648: [Clang] changing behavior of constant array emission

OfekShochat created this revision. OfekShochat added a reviewer: klimek. Herald added a subscriber: hiraditya. Herald added a project: All. OfekShochat requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. fixes issue with emitt

[PATCH] D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32

OfekShochat added a comment. hello, solved the issue. it was, quite expectedly, a u64/unsigned problem in parsing, not codegen. no need to refactor this function. I will close this, thanks for the feedback and sorry for the hassle Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32

OfekShochat added a comment. Yeah. But it's really not clear how it does that, as it gets all the functions from the generated file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133570/new/ https://reviews.llvm.org/D133570 ___

[PATCH] D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32

OfekShochat added a subscriber: eli.friedman. OfekShochat added a comment. yep @eli.friedman. probably gonna scratch this idea, makes more sense to actually tackle the problem itself, which is that getArrayFiller doesnt return anything. trying to actually get to the problem, but its quite hard,

[PATCH] D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32

OfekShochat added a comment. hello again, I added two tests, one for llvm and one for clang. how do I run those specifically so I see I didnt do something wrong? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133570/new/ https://reviews.llvm.org/D1

[PATCH] D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32

OfekShochat added a comment. hmm, one problem, seems like nor clang and nor gcc can compile the example in the github issue fully, only to assembly. is there something like c -> llir, llir -> asm checks? in the issue, it did succeed to compile to either llir and asm, just not correctly Reposi

[PATCH] D133570: #57353 on github

OfekShochat added a comment. hello! thank you so much, Ill do that now, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133570/new/ https://reviews.llvm.org/D133570 ___ cfe-commits mailing list cfe

[PATCH] D133570: #57353 on github

OfekShochat added a comment. trying to fix the problem. probably going to split this into two patches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133570/new/ https://reviews.llvm.org/D133570 ___ cfe-co

[PATCH] D133570: #57353 on github

OfekShochat added a comment. its my first time contributing. this is probably very bad and goes against a lot of guidelines, but I wouldnt resist to fix them Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133570/new/ https://reviews.llvm.org/D13357

[PATCH] D133570: [Clang] changing behavior of constant array emission [AsmPrinter] changing Size from unsigned to uint64_t

OfekShochat created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. OfekShochat requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. fixes issue with emitting partially initialized constant arr