[PATCH] D153881: Create diagnostic group for definition deprecation warning

2023-07-13 Thread Nuri Amari via Phabricator via cfe-commits
nuriamari added a comment. In D153881#4497041 , @aaron.ballman wrote: > LGTM! Do you need me to land this on your behalf? If so, what name and email > address would you like me to use for patch attribution? (If I'm landing it, I > can fix up the releas

[PATCH] D153881: Create diagnostic group for definition deprecation warning

2023-07-10 Thread Nuri Amari via Phabricator via cfe-commits
nuriamari added inline comments. Comment at: clang/docs/ReleaseNotes.rst:373 (`#13920: `_) +- A new diagnostic warning group ``deprecated-redundant-constexpr-static-def`` is + added. This is to be used to control warnings ab

[PATCH] D153881: Create diagnostic group for definition deprecation warning

2023-07-10 Thread Nuri Amari via Phabricator via cfe-commits
nuriamari updated this revision to Diff 538751. nuriamari added a comment. - Create entry in release notes - Move test to appropriate location - Expand test to include `const` warning controlled in the same warning group Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D153881: Create diagnostic group for definition deprecation warning

2023-07-03 Thread Nuri Amari via Phabricator via cfe-commits
nuriamari added a comment. In D153881#4467127 , @aaron.ballman wrote: > I think it's a bit odd that we'd leave `const` under `-Wdeprecated` but > separate `constexpr` out into its own warning flag, but I'm also not opposed. Would moving both const and

[PATCH] D153881: Create diagnostic group for definition deprecation warning

2023-06-27 Thread Nuri Amari via Phabricator via cfe-commits
nuriamari created this revision. Herald added a project: All. nuriamari added reviewers: bruno, aaron.ballman. nuriamari added inline comments. nuriamari published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Comment at: clang/t