Re: [PATCH] D21599: [Libcxx][MIPS] Use LLVM CheckAtomic.cmake module to figure out whether we need to link with libatomic.

nitesh.jain added a comment. In http://reviews.llvm.org/D21599#481588, @dsanders wrote: > Have you tried a standalone build? I suspect HAVE_CXX_LIBATOMICS64 will never > be set for that case. If that's the case, adding 'include(CheckAtomic)' will > probably fix it. I never tried a standalone

Re: [PATCH] D21599: [Libcxx][MIPS] Use LLVM CheckAtomic.cmake module to figure out whether we need to link with libatomic.

nitesh.jain added a comment. In http://reviews.llvm.org/D21599#481553, @dsanders wrote: > What sets HAVE_CXX_LIBATOMICS64? I don't see a reference to LLVM's > CheckAtomic. The CheckAtomic.cmake module (http://reviews.llvm.org/D20896) in llvm will set HAVE_CXX_LIBATOMICS64 if library exit and

Re: [PATCH] D21599: [Libcxx][MIPS] Use LLVM CheckAtomic.cmake module to figure out whether we need to link with libatomic.

nitesh.jain added a comment. Hi Daniel/Vasileios Please could you find sometime to review this? Thanks Repository: rL LLVM http://reviews.llvm.org/D21599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D21599: [Libcxx][MIPS] Use LLVM CheckAtomic.cmake module to figure out whether we need to link with libatomic.

nitesh.jain created this revision. nitesh.jain added reviewers: dsanders, vkalintiris, joerg, jroelofs, EricWF, mclow.lists. nitesh.jain added subscribers: jaydeep, bhushan, slthakur, mohit.bhakkad, zturner, cfe-commits. nitesh.jain set the repository for this revision to rL LLVM. The patch http