[PATCH] D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment

ubsan added a comment. The ABI breakage was already there, in the difference between GCC and Clang - if one compiles against libc++ with gcc, it is not compatible with things that are compiled with clang. I frankly think that being ABI compatible with gcc (and correct according to the standard)

[PATCH] D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment

ubsan updated this revision to Diff 171247. ubsan added a comment. fix nits Repository: rC Clang https://reviews.llvm.org/D53207 Files: docs/ReleaseNotes.rst include/clang/AST/Stmt.h include/clang/ASTMatchers/ASTMatchers.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Ba

[PATCH] D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment

ubsan added a comment. I don't actually know how to send this upstream, since it's been accepted... How should I proceed? Repository: rC Clang https://reviews.llvm.org/D53207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment

ubsan updated this revision to Diff 170994. ubsan added a comment. Add ABI breakage information and reflow Repository: rC Clang https://reviews.llvm.org/D53207 Files: docs/ReleaseNotes.rst include/clang/AST/Stmt.h include/clang/ASTMatchers/ASTMatchers.h include/clang/Basic/Diagnostic

[PATCH] D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment

ubsan updated this revision to Diff 170814. ubsan added a comment. Finish doing the thing! all tests are passing, at least on the revision I'm running on :) @rsmith please check the thing! Repository: rC Clang https://reviews.llvm.org/D53207 Files: include/clang/AST/Stmt.h include/clan

[PATCH] D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment

ubsan added a comment. ... Yup, that'd do it. Thanks Richard! Repository: rC Clang https://reviews.llvm.org/D53207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment

ubsan added a comment. > Is it possible you have LLVM and Clang checked out at different revisions? > That's a common source of weird behavior, particularly in CodeGen tests. Unfortunately no - when I don't specifically don't set the type trait kind of `__alignof` to `UETT_PreferredAlignOf`, an

[PATCH] D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment

ubsan added a comment. I'm having real difficulty with this - I get really odd errors in seemingly unrelated tests when I change things. Repository: rC Clang https://reviews.llvm.org/D53207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment

ubsan updated this revision to Diff 169503. ubsan added a comment. add tests fix nits Repository: rC Clang https://reviews.llvm.org/D53207 Files: include/clang/ASTMatchers/ASTMatchers.h include/clang/Basic/LangOptions.h include/clang/Basic/TypeTraits.h lib/AST/ASTDumper.cpp lib/AS

[PATCH] D53207: Fix bug 26547 - alignof should return ABI alignment, not preferred alignment

ubsan created this revision. ubsan added a reviewer: rsmith. Herald added a subscriber: cfe-commits. - Add `UETT_PreferredAlignOf` to account for the difference between `__alignof` and `alignof` - `AlignOfType` now returns ABI alignment instead of preferred alignment iff clang-abi-compat > 7, an