[clang] [clang] Rename -Wdeprecated-switch-case to -Wdeprecated-declarations-switch-case (PR #141779)

nico wrote: The release notes here https://github.com/llvm/llvm-project/pull/138562/files#diff-ec770381d76c859f5f572db789175fe44410a72608f58ad5dbb14335ba56eb97R525 need updating too, right? https://github.com/llvm/llvm-project/pull/141779 ___ cfe-com

[clang] [llvm] Reland "Add macro to suppress -Wunnecessary-virtual-specifier" (PR #141091)

@@ -710,4 +710,28 @@ void AnnotateIgnoreWritesEnd(const char *file, int line); #define LLVM_PREFERRED_TYPE(T) #endif +/// \macro LLVM_VIRTUAL_ANCHOR_FUNCTION +/// This macro is used to adhere to LLVM's policy that each class with a vtable +/// must have at least one out-of-lin

[clang] [llvm] Reland "Add macro to suppress -Wunnecessary-virtual-specifier" (PR #141091)

@@ -710,4 +710,28 @@ void AnnotateIgnoreWritesEnd(const char *file, int line); #define LLVM_PREFERRED_TYPE(T) #endif +/// \macro LLVM_VIRTUAL_ANCHOR_FUNCTION +/// This macro is used to adhere to LLVM's policy that each class with a vtable +/// must have at least one out-of-lin

[clang] [llvm] Reland "Add macro to suppress -Wunnecessary-virtual-specifier" (PR #141091)

@@ -710,4 +710,28 @@ void AnnotateIgnoreWritesEnd(const char *file, int line); #define LLVM_PREFERRED_TYPE(T) #endif +/// \macro LLVM_VIRTUAL_ANCHOR_FUNCTION +/// This macro is used to adhere to LLVM's policy that each class with a vtable +/// must have at least one out-of-lin

[clang] [clang] Rename -Wdeprecated-switch-case to -Wdeprecated-declarations-switch-case (PR #141779)

https://github.com/nico approved this pull request. Thanks :) https://github.com/llvm/llvm-project/pull/141779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][X86] Add -m[no-]apxf to m_x86_Features_Group (PR #140874)

nico wrote: Looks like this breaks tests on macOS: http://45.33.8.238/macm1/107398/step_6.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/140874 ___ cfe-commits mailing list cfe-commits@

[clang-tools-extra] [clang-doc] Avoid reading files in unit tests (PR #141269)

nico wrote: Thanks! Can we stop generating config.h from config.h.cmake again too? That should no longer be needed now. https://github.com/llvm/llvm-project/pull/141269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

nico wrote: > As an alternative, we could disable the unit tests for the new feature, since > its expected to be experimental for some time, and move the testing into lit > tests. That sounds like a good way forward to me :) https://github.com/llvm/llvm-project/pull/138062 ___

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

nico wrote: Reading files from unit tests is a bit of an anti-pattern: It requires putting the absolute path to the tests somewhere (you're doing this with a config file here), and it means you easily run tests on a different machine than the one you're building on. Could you restructure this

[clang] [CIR] Add PointerLikeType interface support for cir::PointerType (PR #139768)

nico wrote: …aha, it looks it's behind CLANG_ENABLE_CIR already. https://github.com/llvm/llvm-project/pull/139768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add PointerLikeType interface support for cir::PointerType (PR #139768)

nico wrote: It looks like this adds a dependency of clang/ on mlir/. Is that correct? As far as I can tell, this is the first dependency from clang to mlir. (Test-only, but still.) Can we make that optional? https://github.com/llvm/llvm-project/pull/139768 _

[clang] [clang] Shard out some small gtest binaries (PR #138021)

https://github.com/nico approved this pull request. Very cool, thanks! Thoughts on https://github.com/llvm/llvm-project/pull/134196#discussion_r2068617059 ? :) https://github.com/llvm/llvm-project/pull/138021 ___ cfe-commits mailing list cfe-commits@

[clang] c2a62af - [clang] Another Wpreferred-type-bitfield-enum-conversion suppression fix!

Author: Nico Weber Date: 2025-04-30T10:08:45-04:00 New Revision: c2a62af2a51d58183bcd72ee8a86c37ddd526758 URL: https://github.com/llvm/llvm-project/commit/c2a62af2a51d58183bcd72ee8a86c37ddd526758 DIFF: https://github.com/llvm/llvm-project/commit/c2a62af2a51d58183bcd72ee8a86c37ddd526758.diff LO

[clang] 1b7d8b2 - [clang] prevent -Wunknown-warning-option with older clangs

Author: Nico Weber Date: 2025-04-30T09:56:52-04:00 New Revision: 1b7d8b2ee66672c5226f2a8d6b72b025070d9ede URL: https://github.com/llvm/llvm-project/commit/1b7d8b2ee66672c5226f2a8d6b72b025070d9ede DIFF: https://github.com/llvm/llvm-project/commit/1b7d8b2ee66672c5226f2a8d6b72b025070d9ede.diff LO

[clang] 1a14ef1 - [clang] Temporarily silence noisy warning for FPEvalMethod in another place

Author: Nico Weber Date: 2025-04-30T09:53:14-04:00 New Revision: 1a14ef1c89bf4632bf25a959142770f190dcaaf1 URL: https://github.com/llvm/llvm-project/commit/1a14ef1c89bf4632bf25a959142770f190dcaaf1 DIFF: https://github.com/llvm/llvm-project/commit/1a14ef1c89bf4632bf25a959142770f190dcaaf1.diff LO

[clang] 01e0296 - [clang] Temporarily silence noisy warning for FPEvalMethod

Author: Nico Weber Date: 2025-04-30T09:39:19-04:00 New Revision: 01e029602a8ae860852ad2dd8c6ea347c9200066 URL: https://github.com/llvm/llvm-project/commit/01e029602a8ae860852ad2dd8c6ea347c9200066 DIFF: https://github.com/llvm/llvm-project/commit/01e029602a8ae860852ad2dd8c6ea347c9200066.diff LO

[clang] Ensure bit-fields storing FPEvalMethodKind are wide enough to do so (PR #136515)

nico wrote: > After landing #116760 After landing #116785, right? https://github.com/llvm/llvm-project/pull/136515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove FEM_Indeterminable (PR #137247)

nico wrote: > What is the warning? => #137247 https://github.com/llvm/llvm-project/pull/137247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Merge gtest binaries into AllClangUnitTests (PR #134196)

@@ -304,7 +304,7 @@ getCodeModel(const CodeGenOptions &CodeGenOpts) { .Case("kernel", llvm::CodeModel::Kernel) .Case("medium", llvm::CodeModel::Medium) .Case("large", llvm::CodeModel::Large) -

[clang] [clang] Merge gtest binaries into AllClangUnitTests (PR #134196)

nico wrote: `BasicTests` and `FormatTests` had fairly few deps (they didn't need Sema etc) and compiled much fewer files than they presumably now do. Does it make sense to keep those as distinct binaries? https://github.com/llvm/llvm-project/pull/134196

[clang] [C11] Implement WG14 N1285 (temporary lifetimes) (PR #133472)

nico wrote: Looks like this breaks tests on macOS: http://45.33.8.238/macm1/104220/step_6.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/133472 ___ cfe-commits mailing list cfe-commits@

[clang] [C11] Implement WG14 N1285 (temporary lifetimes) (PR #133472)

nico wrote: Confirmed, bots are happy again. Thanks for the super fast fix, and sorry for the noise :) https://github.com/llvm/llvm-project/pull/133472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [clang][diagnostics] add '-Wundef-true' warning option (PR #128265)

nico wrote: This found a bug in chromium, https://crbug.com/403123830 Thanks for this cool warning! :) https://github.com/llvm/llvm-project/pull/128265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [clang] Automatically add the `returns_twice` attribute to certain functions even if `-fno-builtin` is set (PR #133511)

https://github.com/nico approved this pull request. https://github.com/llvm/llvm-project/pull/133511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Update Mach-O ptrauth driver defaults (PR #132834)

https://github.com/nico closed https://github.com/llvm/llvm-project/pull/132834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Update Mach-O ptrauth driver defaults (PR #132834)

nico wrote: Thanks! I'm feeling reasonably confident about this one and it's been a few days, so I'll hit the button :) https://github.com/llvm/llvm-project/pull/132834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [clang-cl] Accept the --warning-suppression-mappings= option (PR #133092)

https://github.com/nico closed https://github.com/llvm/llvm-project/pull/133092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Accept the --warning-suppression-mappings= option (PR #133092)

https://github.com/nico approved this pull request. https://github.com/llvm/llvm-project/pull/133092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

nico wrote: > Thanks, this will be fixed here: #133113 That also fixes an `Assertion `!isNull() && "Cannot retrieve a NULL type pointer"' failed.` we started seeing after this here landed (repro: https://issues.chromium.org/issues/406497227#comment3) It'd be good if we could either land that

[clang] [clang] Update Mach-O ptrauth driver defaults (PR #132834)

nico wrote: Looks like @ahmedbougacha might be out. @francisvm, could you take a look? https://github.com/llvm/llvm-project/pull/132834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Upstream Mach-O ptrauth driver defaults (PR #132834)

https://github.com/nico created https://github.com/llvm/llvm-project/pull/132834 None >From ec8faf518af6384203c776fdd9928ef06e9b5be7 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Mon, 24 Mar 2025 15:56:49 -0400 Subject: [PATCH] [clang] Upstream Mach-O ptrauth driver defaults --- clang/lib/D

[clang] [clang] Upstream Mach-O ptrauth driver defaults (PR #132834)

https://github.com/nico updated https://github.com/llvm/llvm-project/pull/132834 >From ec8faf518af6384203c776fdd9928ef06e9b5be7 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Mon, 24 Mar 2025 15:56:49 -0400 Subject: [PATCH 1/2] [clang] Upstream Mach-O ptrauth driver defaults --- clang/lib/Dri

[clang] Reland "[clang] Lower modf builtin using `llvm.modf` intrinsic" (PR #129885)

nico wrote: Here are a few ideas for possible paths forward: https://issues.chromium.org/issues/401571943#comment9 …actually, let me inline them: `if (Builder.getIsFPConstrained())` -> `if (Builder.getIsFPConstrained() && !isTargetingWin32())`? Alternatively, we could put an actual symbol in

[clang] [clang][HIP] Make some math not not work with AMDGCN SPIR-V (PR #128360)

nico wrote: This seems to break tests: http://45.33.8.238/linux/161683/step_6.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/128360 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] 13ca605 - Revert "default clause replaced by otherwise clause for metadirective in OpenMP 5.2 (#125648)"

Author: Nico Weber Date: 2025-02-21T12:31:32-05:00 New Revision: 13ca6050b07e64f2de08e19bd7be1e1d81207358 URL: https://github.com/llvm/llvm-project/commit/13ca6050b07e64f2de08e19bd7be1e1d81207358 DIFF: https://github.com/llvm/llvm-project/commit/13ca6050b07e64f2de08e19bd7be1e1d81207358.diff LO

[clang] default clause replaced by otherwise clause for metadirective in OpenMP 5.2 (PR #125648)

nico wrote: Looks like this also broke tests on macOS, see http://45.33.8.238/macm1/101361/step_6.txt Given that a bunch of failures have been reported several hours ago, I'll revert this for now. https://github.com/llvm/llvm-project/pull/125648 ___

[clang] Reapply "[Analyzer][CFG] Correctly handle rebuilt default arg and default init expression" (PR #127338)

nico wrote: > Thanks a lot for report this! 100% agree that we need to find the correct > source location. I'm not sure it's the same issue with #123064, I try to find > a reproducer. Sorry, I should've filed an issue with a reproducer. I did so now, #128195. It has a small stand-alone repro.

[clang] Reapply "[Analyzer][CFG] Correctly handle rebuilt default arg and default init expression" (PR #127338)

nico wrote: Thanks for the warning! It's a cool feature, but the diagnostic is IMHO not super great at the moment. I'm doing the cleanup for the warning in Chromium at the moment, and here's an example that's now analyzed (from

[clang] 44fcc5c - [clang] Disaqble test/Analysis/live-stmts.cpp on aarch64

Author: Nico Weber Date: 2025-02-10T18:04:01-05:00 New Revision: 44fcc5cdacc5ed33e096f50d05e1ab1260a944c0 URL: https://github.com/llvm/llvm-project/commit/44fcc5cdacc5ed33e096f50d05e1ab1260a944c0 DIFF: https://github.com/llvm/llvm-project/commit/44fcc5cdacc5ed33e096f50d05e1ab1260a944c0.diff LO

[clang] [clang] Handle f(no-)strict-overflow, f(no-)wrapv, f(no-)wrapv-pointer like gcc (PR #126524)

https://github.com/nico milestoned https://github.com/llvm/llvm-project/pull/126524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Handle f(no-)strict-overflow, f(no-)wrapv, f(no-)wrapv-pointer like gcc (PR #126524)

nico wrote: /cherry-pick https://github.com/llvm/llvm-project/commit/783275eb7b3ecde63bdb6ac1316c090bfc568bdd https://github.com/llvm/llvm-project/pull/126524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [clang] Handle f(no-)strict-overflow, f(no-)wrapv, f(no-)wrapv-pointer like gcc (PR #126524)

https://github.com/nico closed https://github.com/llvm/llvm-project/pull/126524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Handle f(no-)strict-overflow, f(no-)wrapv, f(no-)wrapv-pointer like gcc (PR #126524)

https://github.com/nico updated https://github.com/llvm/llvm-project/pull/126524 >From 5050dbd75fc7446985f4bebe5c7c0ab13e3ccbbb Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Mon, 10 Feb 2025 09:34:38 -0500 Subject: [PATCH 1/2] [clang] Handle f(no-)strict-overflow, f(no-)wrapv, f(no-)wrapv-poi

[clang] [clang] Handle f(no-)strict-overflow, f(no-)wrapv, f(no-)wrapv-pointer like gcc (PR #126524)

https://github.com/nico edited https://github.com/llvm/llvm-project/pull/126524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Handle f(no-)strict-overflow, f(no-)wrapv, f(no-)wrapv-pointer like gcc (PR #126524)

https://github.com/nico edited https://github.com/llvm/llvm-project/pull/126524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Handle f(no-)strict-overflow, f(no-)wrapv, f(no-)wrapv-pointe… (PR #126524)

https://github.com/nico created https://github.com/llvm/llvm-project/pull/126524 …r like gcc We now process all 6 options left-to-right and pick whatever is active at the end. Fixes #124868. >From 5050dbd75fc7446985f4bebe5c7c0ab13e3ccbbb Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Mon, 1

[clang] [clang] Expose -f(no-)strict-overflow as a clang-cl option (PR #126512)

nico wrote: /cherry-pick 71adb054024a1e9bd5ed4566beda74dea65362cd https://github.com/llvm/llvm-project/pull/126512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Expose -f(no-)strict-overflow as a clang-cl option (PR #126512)

https://github.com/nico milestoned https://github.com/llvm/llvm-project/pull/126512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Expose -f(no-)strict-overflow as a clang-cl option (PR #126512)

https://github.com/nico closed https://github.com/llvm/llvm-project/pull/126512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Expose -f(no-)strict-overflow as a clang-cl option (PR #126512)

nico wrote: Previously: #120787 https://github.com/llvm/llvm-project/pull/126512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Expose -f(no-)strict-overflow as a clang-cl option (PR #126512)

https://github.com/nico created https://github.com/llvm/llvm-project/pull/126512 Also move the -fno-strict-overflow option definition next to the -fstrict-overflow one while here. Also add test coverage for f(no-)wrapv-pointer being a clang-cl option. >From cbdad33ec9c868843cc92f9f43cfbd133ed6

[clang] [OpenMP][ASan] Enable ASan Instrumentation for AMDGPUOpenMPToolChain. (PR #124754)

nico wrote: This seems to break tests on my bot: http://45.33.8.238/linux/159455/step_6.txt Does the error make sense to you? https://github.com/llvm/llvm-project/pull/124754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [flang] [llvm] [Clang] Remove ARCMigrate (PR #119269)

@@ -22,7 +22,7 @@ config.host_cxx = "@CMAKE_CXX_COMPILER@" config.llvm_use_sanitizer = "@LLVM_USE_SANITIZER@" config.have_zlib = @LLVM_ENABLE_ZLIB@ config.have_zstd = @LLVM_ENABLE_ZSTD@ -config.clang_arcmt = @CLANG_ENABLE_ARCMT@ +config.clang_objc_rewriter = "@CLANG_ENABLE_OBJC

[clang] [clang-format] Fix annotating attrs in class/struct (PR #124634)

nico wrote: (Why drop the formatting test? Seems good to have an integration test for this, no?) https://github.com/llvm/llvm-project/pull/124634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [clang-format] Fix a bug in annotating angles containing FatArrow (PR #108671)

@@ -243,14 +244,16 @@ class AnnotatingParser { // operator that was misinterpreted because we are parsing template // parameters. // FIXME: This is getting out of hand, write a decent parser. - if (InExpr && !Line.startsWith(tok::kw_template) && + if

[clang] [Wunsafe-buffer-usage] Fix false positive when const sized array is indexed by const evaluatable expressions (PR #119340)

nico wrote: If you haven't, it'd be good to also add a minimal regression test for the assert :) https://github.com/llvm/llvm-project/pull/119340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [Clang] Add -fwrapv-pointer flag (PR #122486)

nico wrote: We (chromium) turned on fwrapv due to the pointer changes, and it had a bit of a perf hit. We'd probably switch to this, hoping it'd address the perf issues at least some. Matching gcc's behavior for -f flags both compilers have also makes sense, IMHO. https://github.com/llvm/llvm

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

nico wrote: Seems seems to break tests: http://45.33.8.238/linux/158130/step_11.txt Please take a look, and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/118771 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [Wunsafe-buffer-usage] Fix false positive when const sized array is indexed by const evaluatable expressions (PR #119340)

nico wrote: Reverted in 7dd34baf5505d689161c3a8678322a394d7a2929 for now. https://github.com/llvm/llvm-project/pull/119340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7dd34ba - Revert "[Wunsafe-buffer-usage] Fix false positive when const sized array is indexed by const evaluatable expressions (#119340)"

Author: Nico Weber Date: 2025-01-16T09:33:01-05:00 New Revision: 7dd34baf5505d689161c3a8678322a394d7a2929 URL: https://github.com/llvm/llvm-project/commit/7dd34baf5505d689161c3a8678322a394d7a2929 DIFF: https://github.com/llvm/llvm-project/commit/7dd34baf5505d689161c3a8678322a394d7a2929.diff LO

[clang] [Wunsafe-buffer-usage] Fix false positive when const sized array is indexed by const evaluatable expressions (PR #119340)

nico wrote: This makes clang assert on many inputs. Here's a repro: [repro.zip](https://github.com/user-attachments/files/18440860/repro.zip) ``` % ./input_file_parsers-161259.sh ... Assertion failed: (!isValueDependent() && "Expression evaluator can't be called on a dependent expression."), f

[clang] [clang-tools-extra] [flang] [clang] Extend diagnose_if to accept more detailed warning information, take 2 (PR #119712)

nico wrote: >From the commit message, it sounds like this might introduce warnings that >`-Werror` doesn't turn into warnings. Is that correct? We found in chromium (and other large projects) that non-fatal warnings get ignored and over time just lead to a ton of warning spam in build output,

[clang] 9ec9287 - Revert "[HLSL] Move length support out of the DirectX Backend (#121611)"

Author: Nico Weber Date: 2025-01-09T14:19:03-05:00 New Revision: 9ec92873ecc1c268a1d05e36b7b52e378860ea5b URL: https://github.com/llvm/llvm-project/commit/9ec92873ecc1c268a1d05e36b7b52e378860ea5b DIFF: https://github.com/llvm/llvm-project/commit/9ec92873ecc1c268a1d05e36b7b52e378860ea5b.diff LO

[clang] ab5133b - Revert "[Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (#120507)"

Author: Nico Weber Date: 2025-01-07T09:23:50-05:00 New Revision: ab5133bbc62af4686f305a3c7d85f74b9f5b949f URL: https://github.com/llvm/llvm-project/commit/ab5133bbc62af4686f305a3c7d85f74b9f5b949f DIFF: https://github.com/llvm/llvm-project/commit/ab5133bbc62af4686f305a3c7d85f74b9f5b949f.diff LO

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

nico wrote: Also fails here: http://45.33.8.238/linux/156731/step_6.txt http://45.33.8.238/macm1/98544/step_6.txt https://github.com/llvm/llvm-project/pull/120507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #120507)

nico wrote: Reverted in ab5133bbc62af4686f305a3c7d85f74b9f5b949f for now. https://github.com/llvm/llvm-project/pull/120507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Expose -f(no-)wrapv as clang-cl option (PR #120787)

https://github.com/nico closed https://github.com/llvm/llvm-project/pull/120787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a4deb80 - Revert "Reapply "[Driver][OHOS] Fix lld link issue for OHOS (#118192)" (#120159)"

Author: Nico Weber Date: 2025-01-02T09:13:40-05:00 New Revision: a4deb809be8f5ec3adec3626e9d700f6168d0e9f URL: https://github.com/llvm/llvm-project/commit/a4deb809be8f5ec3adec3626e9d700f6168d0e9f DIFF: https://github.com/llvm/llvm-project/commit/a4deb809be8f5ec3adec3626e9d700f6168d0e9f.diff LO

[clang] Reapply "[Driver][OHOS] Fix lld link issue for OHOS (#118192)" (PR #120159)

nico wrote: Here's a command you can use to reproduce this: ``` cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_ENABLE_PROJECTS='clang;lld;compiler-rt' -DLLVM_APPEND_VC_REV=NO -DLLVM_TARGETS_TO_BUILD='X86' -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF ../llvm-project/ll

[clang] Reapply "[Driver][OHOS] Fix lld link issue for OHOS (#118192)" (PR #120159)

nico wrote: I did remove the contents of out/gn/lib/clang/20/lib/linux, but `./lib/clang/20/lib/linux/libclang_rt.builtins-x86_64.a` just reappeared on the next build. I'm guessing this might break tests in cmake builds that use `-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF` (?) http://45.33.8.2

[clang] [clang] Expose -f(no-)wrapv as clang-cl option (PR #120787)

https://github.com/nico created https://github.com/llvm/llvm-project/pull/120787 Also move the -fno-wrapv option definition next to the -fwrapv one while here. >From 48b974d50a6b5d91f094663e446b94910a22f097 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Fri, 20 Dec 2024 14:25:20 -0500 Subject:

[clang] [compiler-rt] Move interceptors for libresolv functions to MSan (PR #119071)

nico wrote: @alanzhao1 has been trying to reproduce the problem, I think. I'm not sure what the current status is. https://github.com/llvm/llvm-project/pull/119071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] Reapply "[Driver][OHOS] Fix lld link issue for OHOS (#118192)" (PR #120159)

nico wrote: IIRC there are two possible compiler-rt directory layouts. @MaskRay worked on moving many platforms from one to another. I think the newer layout doesn't use platform suffixes. We shouldn't change where clang looks for things just for my bot. Thanks for figuring it out; I can dele

[clang] Fix lld link issue for OHOS (PR #118192)

nico wrote: Aha! Yes, that bot does do incremental builds. (As do many devs.) https://github.com/llvm/llvm-project/pull/118192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] Move interceptors for libresolv functions to MSan (PR #119071)

nico wrote: I'll try to find a Linux box tomorrow to get more details. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8728518597999528929/+/u/package_clang/stdout?format=raw is the full build output. If you ctrl-f for "cmake -G", you should find all cmake vars that that bot

[clang] [compiler-rt] Move interceptors for libresolv functions to MSan (PR #119071)

nico wrote: I reverted this in 1464b8ec8a675fd11dc7280db1c56aac03771b0a for now. https://github.com/llvm/llvm-project/pull/119071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1464b8e - Revert "Move interceptors for libresolv functions to MSan (#119071)"

Author: Nico Weber Date: 2024-12-15T14:04:56-05:00 New Revision: 1464b8ec8a675fd11dc7280db1c56aac03771b0a URL: https://github.com/llvm/llvm-project/commit/1464b8ec8a675fd11dc7280db1c56aac03771b0a DIFF: https://github.com/llvm/llvm-project/commit/1464b8ec8a675fd11dc7280db1c56aac03771b0a.diff LO

[clang] 5004622 - Revert "[Driver] Cache SanitizerArgs (NFC) (#119442)"

Author: Nico Weber Date: 2024-12-15T14:04:55-05:00 New Revision: 50046221b8e913ec6506eb96ce4c0cd267a5cc99 URL: https://github.com/llvm/llvm-project/commit/50046221b8e913ec6506eb96ce4c0cd267a5cc99 DIFF: https://github.com/llvm/llvm-project/commit/50046221b8e913ec6506eb96ce4c0cd267a5cc99.diff LO

[clang] [compiler-rt] Move interceptors for libresolv functions to MSan (PR #119071)

nico wrote: This broke Linux/dn_expand.cpp on our bots, see https://issues.chromium.org/issues/384188036 https://github.com/llvm/llvm-project/pull/119071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] Fix lld link issue for OHOS (PR #118192)

nico wrote: If all other bots are happy, then I'm doing something wrong probably. If you don't mind reverting, it'd be nice since then I can catch other, actual problems, with the bot, but it's not a requirement. https://github.com/llvm/llvm-project/pull/118192

[clang] Fix lld link issue for OHOS (PR #118192)

nico wrote: This broke check-clang on my linux box: http://45.33.8.238/linux/155432/step_6.txt That bot uses the GN build – are there any prerequisite changes elsewhere that I need to port to it? https://github.com/llvm/llvm-project/pull/118192 ___

[clang] [compiler-rt] [llvm] [X86] Support -march=diamondrapids (PR #113881)

nico wrote: Looks like this breaks tests: http://45.33.8.238/linux/153081/step_6.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/113881 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [Clang][HIP] Deprecate the AMDGCN_WAVEFRONT_SIZE macros (PR #112849)

@@ -0,0 +1,111 @@ +// REQUIRES: amdgpu-registered-target +// RUN: %clang -xhip --offload-arch=gfx1030 --offload-host-only -pedantic -nogpuinc -nogpulib -nobuiltininc -fsyntax-only -Xclang -verify %s +// RUN: %clang -xhip --offload-arch=gfx1030 --offload-device-only -pedantic -no

[clang] [Clang][HIP] Deprecate the AMDGCN_WAVEFRONT_SIZE macros (PR #112849)

@@ -0,0 +1,111 @@ +// REQUIRES: amdgpu-registered-target +// RUN: %clang -xhip --offload-arch=gfx1030 --offload-host-only -pedantic -nogpuinc -nogpulib -nobuiltininc -fsyntax-only -Xclang -verify %s +// RUN: %clang -xhip --offload-arch=gfx1030 --offload-device-only -pedantic -no

[clang] [clang][dataflow] Add a lattice to help cache const accessor methods (PR #111006)

@@ -0,0 +1,218 @@ +//===-- CachedConstAccessorsLattice.h ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang-tools-extra] [flang] [llvm] Reland 'Update llvm::Registry to work for LLVM shared library builds on windows' (#109024) (PR #112640)

nico wrote: This seems to break building of clang-tools-extra binaries: http://45.33.8.238/win/95986/step_3.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/112640 ___ cfe-commits mailing

[clang] [clang][dataflow] Add a lattice to help cache const accessor methods (PR #111006)

@@ -0,0 +1,218 @@ +//===-- CachedConstAccessorsLattice.h ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][dataflow] Disambiguate a ref to "internal" in CachedConstAccessorsLattice (PR #113601)

nico wrote: I think this'll fix the build, thanks! However, the root cause is probably that the `AST_MATCHER_P_OVERLOAD` instantiation in clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp is in an unnamed namespace that's inside namespace `clang::dataflow`, right? Shoul

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

nico wrote: Looks like this breaks check-clang: http://45.33.8.238/linux/149333/step_6.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/110198 ___ cfe-commits mailing list cfe-commits@list

[clang] [llvm] [AArch64] Implement intrinsics for SME2 FSCALE (PR #100128)

nico wrote: Thanks for merging the fix! At least on one of my bots, it helped and it's green again :) https://github.com/llvm/llvm-project/pull/100128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [llvm] [AArch64] Implement intrinsics for SME2 FSCALE (PR #100128)

nico wrote: The test is broken on trunk. It won't get more broken if you merge the fix. So please merge, and if it helps, great. https://github.com/llvm/llvm-project/pull/100128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [Driver] Add toolchain for X86_64 UEFI target (PR #76838)

nico wrote: Looks like this breaks tests on Mac: http://45.33.8.238/macm1/92471/step_6.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/76838 ___ cfe-commits mailing list cfe-commits@lists

[clang] [clang-tools-extra] Remove clang-pseudo (PR #109154)

@@ -181,16 +181,16 @@ llvm::Expected> getFoldingRanges(ParsedAST &AST) { // Related issue: https://github.com/clangd/clangd/issues/310 llvm::Expected> getFoldingRanges(const std::string &Code, bool LineFoldingOnly) { nico wrote: Should we revert 70914aa631561

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

nico wrote: @thurstond ^ https://github.com/llvm/llvm-project/pull/106588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

nico wrote: Looks like the _revert_ broke check-clang: http://45.33.8.238/linux/148045/step_6.txt Please take a look, and uh, mark that test as UNSUPPORTED if it takes a while to fix, I suppose. https://github.com/llvm/llvm-project/pull/106588 ___ c

[clang] [Utils] add update-verify-tests.py (PR #97369)

nico wrote: This breaks tests on windows: http://45.33.8.238/win/94083/step_6.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/97369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][test] Fix some windows driver tests with legacy runtime dir layout (PR #108452)

https://github.com/nico closed https://github.com/llvm/llvm-project/pull/108452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][test] Fix some windows driver tests with legacy runtime dir layout (PR #108452)

https://github.com/nico approved this pull request. https://github.com/llvm/llvm-project/pull/108452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Driver] Ensure `-fms-volatile` is set for x86 for `*-windows-msvc` triple on non cl driver modes (PR #107509)

nico wrote: (To be clear, I'm fine with landing this.) > non conforming two phase lookup by default would also be a concern. It is! There were quite a few discussions around this. Aha, see #42377. We usually say the goal is to have a very standards compliant impl, while also being able to par

[clang] c64dac2 - [clang] Fix noisy -Wcovered-switch-default warning after 1f70fcefa9 / #100278

Author: Nico Weber Date: 2024-09-06T09:17:45-04:00 New Revision: c64dac2e6c39f0f7f1c676857e7d34c764b4d632 URL: https://github.com/llvm/llvm-project/commit/c64dac2e6c39f0f7f1c676857e7d34c764b4d632 DIFF: https://github.com/llvm/llvm-project/commit/c64dac2e6c39f0f7f1c676857e7d34c764b4d632.diff LO

  1   2   3   4   5   6   7   8   9   10   >