[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/142019 >From 87004192b6c3bd7b0a4614525ec3f6a1fe4e925e Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Fri, 30 May 2025 08:09:45 -0700 Subject: [PATCH] Reapply "[clang][Sema] Declare builtins used in #pragma intrins

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/142019 >From 168d68391da043f136ed9ea2115d1cda50af7e3b Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Fri, 30 May 2025 08:09:45 -0700 Subject: [PATCH] Reapply "[clang][Sema] Declare builtins used in #pragma intrins

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Parser] Fix lookup of builtins with pragma intrinsic (PR #142019)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Parser] Fix lookup of builtins with pragma intrinsic (PR #142019)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/142019 >From 3cf1fcb8cc722bd60a91034d9ef47240bea6a751 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Fri, 30 May 2025 08:09:45 -0700 Subject: [PATCH] Reapply "[clang][Sema] Declare builtins used in #pragma intrins

[clang] [clang][Sema] Declare builtins used in #pragma intrinsic (PR #138205)

sarnex wrote: Sure, I was hoping I could find an easy fix really quickly but just reproing took me a while, I'll revert immediately in the future, thanks. https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.

[clang] Revert "[clang][Sema] Declare builtins used in #pragma intrinsic" (PR #141994)

sarnex wrote: Sorry for the trouble https://github.com/llvm/llvm-project/pull/141994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Parser] Fix lookup of builtins with pragma intrinsic (PR #142019)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Parser] Fix lookup of builtins with pragma intrinsic (PR #142019)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clang] Simplify device kernel attributes (PR #137882)

sarnex wrote: Any final comments on this @AaronBallman @erichkeane @arsenm @AlexVlx @yxsamliu, would appreciate a review, thanks! https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [clang][Parser] Fix lookup of builtins with pragma intrinsic (PR #142019)

https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/142019 None >From 5b0e367fcdb33763e3f4f94f8604db741801261d Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Thu, 29 May 2025 12:29:45 -0700 Subject: [PATCH] [clang][Parser] Fix lookup of builtins with pragma intrins

[clang] Revert "[clang][Sema] Declare builtins used in #pragma intrinsic" (PR #141994)

https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/141994 Reverts llvm/llvm-project#138205 Breaks Chrome. >From fb79103e3dca8a2a0f5732aefbc9cf71b967d357 Mon Sep 17 00:00:00 2001 From: Nick Sarnie Date: Thu, 29 May 2025 17:33:04 + Subject: [PATCH] Revert "[clang][S

[clang] [clang][Sema] Declare builtins used in #pragma intrinsic (PR #138205)

sarnex wrote: Chrome requested I revert https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver][OpenMP][SPIR-V] Fix SPIR-V OpenMP DeviceRTL expected file name (PR #141855)

https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/141855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver][OpenMP][SPIR-V] Fix SPIR-V OpenMP DeviceRTL expected file name (PR #141855)

sarnex wrote: Right now we don't even build the DeviceRTL for SPIR-V, however I do have it built locally and I ran into this issue there. https://github.com/llvm/llvm-project/pull/141855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [clang][Driver][OpenMP][SPIR-V] Fix SPIR-V OpenMP DeviceRTL expected file name (PR #141855)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/141855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver][OpenMP][SPIR-V] Fix SPIR-V OpenMP DeviceRTL expected file name (PR #141855)

https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/141855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver][OpenMP][SPIR-V] Fix SPIR-V OpenMP DeviceRTL expected file name (PR #141855)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/141855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Declare builtins used in #pragma intrinsic (PR #138205)

sarnex wrote: @alanzhao1 let me know if this is a big problem for Chrome and I can revert it, I'd prefer to try to fix it quickly first and if I can't then revert it, thanks. https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing lis

[clang] [clang][Sema] Declare builtins used in #pragma intrinsic (PR #138205)

sarnex wrote: It took me all day but I managed to reproduce the issue with Chromium, investigating more. https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [clang][Driver][OpenMP][SPIR-V] Fix SPIR-V OpenMP DeviceRTL expected file name (PR #141855)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/141855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver][OpenMP][SPIR-V] Fix SPIR-V OpenMP DeviceRTL expected file name (PR #141855)

https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/141855 None >From 18e18ca675a38ef6bf34a4450291ed9ebc85eb66 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 28 May 2025 14:00:46 -0700 Subject: [PATCH] [clang][Driver][OpenMP][SPIR-V] Fix SPIR-V OpenMP DeviceRT

[clang] [clang-tools-extra] [llvm] [clang] Simplify device kernel attributes (PR #137882)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/137882 >From 080a9d43ba6544d46c2b36c5dc6a5af421264580 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 7 May 2025 12:17:30 -0700 Subject: [PATCH 1/6] [clang] Simplify device kernel attributes Signed-off-by: Sar

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

sarnex wrote: Whoops, thanks! https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang][ARM][AArch64] Define intrinsics guarded by __has_builtin on all platforms" (#128222)" (PR #140910)

https://github.com/sarnex converted_to_draft https://github.com/llvm/llvm-project/pull/140910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang][ARM][AArch64] Define intrinsics guarded by __has_builtin on all platforms" (#128222)" (PR #140910)

sarnex wrote: Looks like the fix commit broke something again :( https://github.com/llvm/llvm-project/pull/140910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Declare builtins used in #pragma intrinsic (PR #138205)

sarnex wrote: Investigating, thanks. https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][SPIR-V] Fix OpenCL addrspace mapping when using non-zero default AS (PR #137187)

sarnex wrote: Ah ok thank you! I'm surprised this work effects anything as I was mostly doing it for upstream OMP SPV which doesnt' work yet :) https://github.com/llvm/llvm-project/pull/137187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/137882 >From 080a9d43ba6544d46c2b36c5dc6a5af421264580 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 7 May 2025 12:17:30 -0700 Subject: [PATCH 1/5] [clang] Simplify device kernel attributes Signed-off-by: Sar

[clang] [clang][SPIR-V] Fix OpenCL addrspace mapping when using non-zero default AS (PR #137187)

sarnex wrote: @yingcong-wu Hi, I'm not totally sure what you mean, did this change break something for you or did it fix something? Feel free to email me internally as well. Thanks https://github.com/llvm/llvm-project/pull/137187 ___ cfe-commits mail

[clang] [clang][Sema] Declare builtins used in #pragma intrinsic (PR #138205)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang][ARM][AArch64] Define intrinsics guarded by __has_builtin on all platforms" (#128222)" (PR #140910)

https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/140910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang][ARM][AArch64] Define intrinsics guarded by __has_builtin on all platforms" (#128222)" (PR #140910)

https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/140910 The original change caused issues on MSVC due to a new warning thrown inside MSVC headers. That was fixed [here](https://github.com/llvm/llvm-project/commit/95bd9eef42679f3d13e3279204c75372e2c062f0), so reapply

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

@@ -396,9 +396,12 @@ any option of a multiversioned function is undefined. }]; } -def SYCLKernelDocs : Documentation { +def DeviceKernelDocs : Documentation { let Category = DocCatFunction; + let Heading = "device_kernel"; sarnex wrote: done in latest c

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/137882 >From 080a9d43ba6544d46c2b36c5dc6a5af421264580 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 7 May 2025 12:17:30 -0700 Subject: [PATCH 1/5] [clang] Simplify device kernel attributes Signed-off-by: Sar

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

sarnex wrote: Thanks for the guidance and reviews! https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

@@ -1825,6 +1825,11 @@ class Sema final : public SemaBase { /// Set of no-builtin functions listed by \#pragma function. llvm::SmallSetVector MSFunctionNoBuiltins; + /// Map of BuiltinIDs to source locations that have #pragma intrinsic calls + /// that refer to them. +

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/138205 >From c66ec11d8170a0e4c0b2fc50bdae039fd9c208fb Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Thu, 1 May 2025 14:47:45 -0700 Subject: [PATCH 1/3] [clang][Sema] Don't warn for implicit uses of builtins in sy

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

@@ -1825,6 +1825,11 @@ class Sema final : public SemaBase { /// Set of no-builtin functions listed by \#pragma function. llvm::SmallSetVector MSFunctionNoBuiltins; + /// Map of BuiltinIDs to source locations that have #pragma intrinsic calls + /// that refer to them. +

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/138205 >From c66ec11d8170a0e4c0b2fc50bdae039fd9c208fb Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Thu, 1 May 2025 14:47:45 -0700 Subject: [PATCH 1/2] [clang][Sema] Don't warn for implicit uses of builtins in sy

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/137882 >From 080a9d43ba6544d46c2b36c5dc6a5af421264580 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 7 May 2025 12:17:30 -0700 Subject: [PATCH 1/4] [clang] Simplify device kernel attributes Signed-off-by: Sar

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

@@ -1538,11 +1533,32 @@ def CUDAShared : InheritableAttr { } def : MutualExclusions<[CUDAConstant, CUDAShared, HIPManaged]>; -def SYCLKernel : InheritableAttr { - let Spellings = [Clang<"sycl_kernel">]; - let Subjects = SubjectList<[FunctionTmpl]>; - let LangOpts = [SYCLDev

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

@@ -292,7 +292,7 @@ void NVPTXTargetCodeGenInfo::setTargetAttributes( } // Attach kernel metadata directly if compiling for NVPTX. - if (FD->hasAttr()) { + if (FD->hasAttr()) { F->setCallingConv(llvm::CallingConv::PTX_Kernel); sarnex wrote: Should

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

sarnex wrote: @rnk Any feedback on my above comment? Hopefully I can merge a solution to the issue soon. Thanks! https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

@@ -227,7 +227,7 @@ void SPIRVTargetCodeGenInfo::setCUDAKernelCallingConvention( // Convert HIP kernels to SPIR-V kernels. if (getABIInfo().getContext().getLangOpts().HIP) { FT = getABIInfo().getContext().adjustFunctionType( -FT, FT->getExtInfo().withCallingConv

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

@@ -1538,11 +1533,32 @@ def CUDAShared : InheritableAttr { } def : MutualExclusions<[CUDAConstant, CUDAShared, HIPManaged]>; -def SYCLKernel : InheritableAttr { - let Spellings = [Clang<"sycl_kernel">]; - let Subjects = SubjectList<[FunctionTmpl]>; - let LangOpts = [SYCLDev

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

@@ -1538,11 +1533,32 @@ def CUDAShared : InheritableAttr { } def : MutualExclusions<[CUDAConstant, CUDAShared, HIPManaged]>; -def SYCLKernel : InheritableAttr { - let Spellings = [Clang<"sycl_kernel">]; - let Subjects = SubjectList<[FunctionTmpl]>; - let LangOpts = [SYCLDev

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

@@ -1538,11 +1533,44 @@ def CUDAShared : InheritableAttr { } def : MutualExclusions<[CUDAConstant, CUDAShared, HIPManaged]>; -def SYCLKernel : InheritableAttr { - let Spellings = [Clang<"sycl_kernel">]; - let Subjects = SubjectList<[FunctionTmpl]>; - let LangOpts = [SYCLDev

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

@@ -1538,11 +1533,44 @@ def CUDAShared : InheritableAttr { } def : MutualExclusions<[CUDAConstant, CUDAShared, HIPManaged]>; -def SYCLKernel : InheritableAttr { - let Spellings = [Clang<"sycl_kernel">]; - let Subjects = SubjectList<[FunctionTmpl]>; - let LangOpts = [SYCLDev

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/137882 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Simplify device kernel attributes (PR #137882)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/137882 >From 080a9d43ba6544d46c2b36c5dc6a5af421264580 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 7 May 2025 12:17:30 -0700 Subject: [PATCH 1/2] [clang] Simplify device kernel attributes Signed-off-by: Sar

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

sarnex wrote: @AaronBallman I just pushed a first attempt to combine the attrs, however I'm not sure if it's much cleaner given the attrs have different subjects/allowed cases/expected warnings/etc. Do you mind taking a first look and seeing if you think the general direction is a good idea? T

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/137882 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[clang] [clang][NFC] Fix some more incorrectly formatted comments (PR #138342)

@@ -4911,8 +4911,8 @@ std::optional Type::getNullability() const { bool Type::canHaveNullability(bool ResultIfUnknown) const { QualType type = getCanonicalTypeInternal(); + // We'll only see canonical types here. sarnex wrote: done in latest commit, thank

[clang] [clang][NFC] Fix some more incorrectly formatted comments (PR #138342)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/138342 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

sarnex wrote: > That change was reverted for different reasons. I shouldn't have changed the > prototype of _mm_prefetch there, so I'm relanding it here: > https://github.com/llvm/llvm-project/pull/138360 Thanks, my bad, I should have looked at the problem in more detail. > So, winnt.h is sup

[clang] [clang][NFC] Fix some more incorrectly formatted comments (PR #138342)

https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/138342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Fix some more incorrectly formatted comments (PR #138342)

https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/138342 More fixes based on https://github.com/llvm/llvm-project/pull/138036 >From 5540b8d5bc0130b2089c219d49e856ab6817420b Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Fri, 2 May 2025 13:39:59 -0700 Subject: [PA

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

sarnex wrote: I think it's because we are explciitly marking these builtins as requiring a header. If they aren't declared that way then you won't see this warning and won't need this change. I made the builtins require a header based on feedback from @rnk in the earlier PR, and his suggestio

[clang] [clang][NFC] Fix some clang-format mistakes (PR #138036)

@@ -3997,7 +3996,7 @@ void CodeGenFunction::EmitFunctionEpilog(const CGFunctionInfo &FI, RV = SI->getValueOperand(); SI->eraseFromParent(); -// Otherwise, we have to do a simple load. + // Otherwise, we have to do a simple load. s

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Fix some clang-format mistakes (PR #138036)

https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/138036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/138205 Running CI >From c66ec11d8170a0e4c0b2fc50bdae039fd9c208fb Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Thu, 1 May 2025 14:47:45 -0700 Subject: [PATCH] [clang][Sema] Don't warn for implicit uses of builtin

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

sarnex wrote: > I was thinking that orthogonal calling conventions could be combined so that > we need fewer of them. e.g., if spir_kernel cannot be mixed with nvptx_kernel > in the same TU, then there's no need for two distinct internal > representations for the attributes, just two distinct

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

https://github.com/sarnex converted_to_draft https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

sarnex wrote: > Do we need yet another calling convention or is there a way we can start to > combine some of these for all the offloading languages? It seems we keep > re-implementing the same concepts multiple times for each language and it > would be nice to share as much of the frontend lo

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

@@ -1504,6 +1506,12 @@ def NVPTXKernel : InheritableAttr, TargetSpecificAttr { let Documentation = [Undocumented]; } +def SPIRKernel : InheritableAttr, TargetSpecificAttr { + let Spellings = [Clang<"spir_kernel">]; + let Subjects = SubjectList<[Function]>; + let Document

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Fix some clang-format mistakes (PR #138036)

https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/138036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Fix some clang-format mistakes (PR #138036)

sarnex wrote: Ignoring clang-format CI result https://github.com/llvm/llvm-project/pull/138036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/137882 >From be91732b261f7a4874a9b1789fbf9bff6359cd58 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 30 Apr 2025 13:59:46 -0700 Subject: [PATCH] [clang] Add spir_kernel attribute Signed-off-by: Sarnie, Nick

[clang] [clang][NFC] Format two files with CallingConv switches (PR #138000)

https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/138000 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Format two files with CallingConv switches (PR #138000)

https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/138000 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/137882 >From 20498a3ab88fc60dfd425958c350e0d80f21951f Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Tue, 29 Apr 2025 14:40:43 -0700 Subject: [PATCH] [clang] Add spir_kernel attribute Signed-off-by: Sarnie, Nick

[clang] [clang][NFC] Format two files with CallingConv switches (PR #138000)

https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/138000 I'm planning on modifying this code so format it so we can pass the formatting check. >From 3ae86aef81e0ae19e49a4c6db9869e327d4ad4fc Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 30 Apr 2025 10:33:58

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/137882 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/137882 >From 563660698c09d0e8b0d3e4d240d9a0ceae092493 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Tue, 29 Apr 2025 14:40:43 -0700 Subject: [PATCH] [clang] Add spir_kernel attribute Signed-off-by: Sarnie, Nick

  1   2   3   4   5   >