[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa added a comment. In D28462#1575262 , @sylvestre.ledru wrote: > @VelocityRa could you please add it to the release notes? > https://github.com/llvm-mirror/clang/blob/master/docs/ReleaseNotes.rst > I can commit the change if you need Yeah cou

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa updated this revision to Diff 192694. VelocityRa marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp lib/F

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:520 + + AlignMacroSequence(StartOfSequence, EndOfSequence, MinColumn, MaxColumn, + FoundMatchOnLine, AlignMacrosMatches, Changes); klimek wrote: > Why are we calli

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa updated this revision to Diff 191891. VelocityRa added a comment. Right, how's that? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp l

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:500 +if (Changes[i].NewlinesBefore != 0) { + EndOfSequence = i; + // If there is a blank line, or if the last line didn't contain any klimek wrote: > VelocityRa wrote: >

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa updated this revision to Diff 191493. VelocityRa marked 13 inline comments as done. VelocityRa added a comment. Diff updated. Some comments about the inline changes, since the rest were trivial: - `AlignMacroSequence` was inlined - `AlignMacros` was after that - `AlignMacrosMatches` ca

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa marked 11 inline comments as done. VelocityRa added a comment. Waiting for further feedback before pushing an update. Comment at: lib/Format/WhitespaceManager.cpp:436 +static void +AlignTokenSequenceAll(unsigned Start, unsigned End, unsigned Column, +

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa added a comment. In D28462#1376710 , @enyquist wrote: > Looks fine to me, although I confess I did not build and run it because I > don't have the time to set up the environment again, took a few hours last > time I built from scratch (side no

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa updated this revision to Diff 184010. VelocityRa added a comment. I extracted the logic of `AlignTokens` and `AlignTokenSequence` that aligning macros uses to the best of my ability. This new logic now resides in `AlignTokensAll` and `AlignTokenSequenceAll` (so that it may be re-used