naveen-seth wrote:
Yes, please.
https://github.com/llvm/llvm-project/pull/139457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
naveen-seth wrote:
Thank you for reviewing!
(And apologies for the formatting and coding-standard issues on my end!)
https://github.com/llvm/llvm-project/pull/139457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
>From 5f246435b9784113ada3f82328433487391f40ab Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Sun, 11 May 2025 14:24:00 +
Subject: [PATCH 1/8] [clang] Enforce 1-based indexing for command line source
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
>From 5f246435b9784113ada3f82328433487391f40ab Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Sun, 11 May 2025 14:24:00 +
Subject: [PATCH 1/7] [clang] Enforce 1-based indexing for command line source
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
>From 5f246435b9784113ada3f82328433487391f40ab Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Sun, 11 May 2025 14:24:00 +
Subject: [PATCH 1/7] [clang] Enforce 1-based indexing for command line source
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sa
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
>From 5f246435b9784113ada3f82328433487391f40ab Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Sun, 11 May 2025 14:24:00 +
Subject: [PATCH 1/6] [clang] Enforce 1-based indexing for command line source
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
>From 5f246435b9784113ada3f82328433487391f40ab Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Sun, 11 May 2025 14:24:00 +
Subject: [PATCH 1/3] [clang] Enforce 1-based indexing for command line source
@@ -0,0 +1,6 @@
+// RUN: not %clang_cc1 -fsyntax-only -code-completion-at=%s:0:1 %s -o -
+// RUN: not %clang_cc1 -fsyntax-only -code-completion-at=%s:1:0 %s -o -
+
+// Related to #139375
+// Clang uses 1-based indexing for source locations given from the
command-line.
+// Verify
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
>From 5f246435b9784113ada3f82328433487391f40ab Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Sun, 11 May 2025 14:24:00 +
Subject: [PATCH 1/2] [clang] Enforce 1-based indexing for command line source
naveen-seth wrote:
> Thanks for working on that. I think it might better to do that check where
> `ParsedSourceLocation::FromString` is called, so that we can have a proper
> front-end diagnostics for it (search for `err_fe_invalid_code_complete_file`
> and `OPT_code_completion_at`)
Thank you
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/139457
Fixes #139375
Clang expects command line source locations to be provided using 1-based
indexing.
Currently, Clang does not reject zero as invalid argument for column or line
number, which can cause Clang t
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/137711
Fixes #132692.
`clang -cc1` crashes when generating a module interface with
`emit-module-interface` or `emit-reduced-module-interface` using an input file
which is already a precompiled module (`.pcm`) fil
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/133462
>From 957a45312767a40b513bfd4f545c23fda9c4866f Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Tue, 8 Apr 2025 00:56:14 +
Subject: [PATCH] [clang][modules] Guard against bad -fmodule-file mappings
(#13
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/133462
>From a23ba4d51332180ff5d1b5bc9de2d0c6c04cbf66 Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Fri, 28 Mar 2025 06:59:06 +0100
Subject: [PATCH] [clang][modules] Guard against bad -fmodule-file mappings
(#1
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/133462
When using -fmodule-file== with incorrect inputs, the
compiler crashes in two scenarios:
1. A module is mapped to the right BMI file but one of its transitively
exported module dependencies is also mapped
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
naveen-seth wrote:
Hi, sorry! I left a comment earlier but noticed that a large part of the
explanation was incorrect and deleted it. Here is the fixed comment:
At first I thought that the issue can be fixed by just checking for duplicates
while parsing the command-line arguments, but that doe
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/133462
>From 74ace4fd3c71ff59f2d89680c0f1382d0f9933f4 Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Fri, 28 Mar 2025 06:59:06 +0100
Subject: [PATCH 1/2] [clang][modules] Guard against bad -fmodule-file mappings
naveen-seth wrote:
Hi @ChuanqiXu9, @mpark, @shafik,
For context, here is how this PR would change clang's behavior when replicating
the original crash in #132059:
The original crash, where the module `hello` wasn’t mapped to any BMI file,
would now display the following:
```bash
clang++ -fmo
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/133462
>From 74ace4fd3c71ff59f2d89680c0f1382d0f9933f4 Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Fri, 28 Mar 2025 06:59:06 +0100
Subject: [PATCH] [clang][modules] Guard against bad -fmodule-file mappings
(#1
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/133462
>From 804617c3083935d10f98b10e86f965e7508eb587 Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Fri, 28 Mar 2025 06:59:06 +0100
Subject: [PATCH] [clang][modules] Guard against bad -fmodule-file mappings
(#1
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/133462
>From cfbc14d381b5daed70ca812daac9ceed0039b5f6 Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Fri, 28 Mar 2025 06:59:06 +0100
Subject: [PATCH] [clang][modules] Guard against bad -fmodule-file mappings
(#1
https://github.com/naveen-seth reopened
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth closed
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
29 matches
Mail list logo
