[clang] [clang] Add `__bf16` Type Support Macros With Literal Suffix Support (PR #134214)

https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/134214 >From 620bdbed2b372b97b66147684d4ded5b666c7786 Mon Sep 17 00:00:00 2001 From: bassiounix Date: Thu, 3 Apr 2025 10:08:59 +0200 Subject: [PATCH 01/15] add `bf16`/`BF16` suffix support --- clang/include/clang/

[clang] [clang] Add `__bf16` Type Support Macros With Literal Suffix Support (PR #134214)

bassiounix wrote: I changed the commits and ran test at each step, I'm not sure why the last commit made the test failing! is `APFloat::BFloat` the reason? if so, how would I set the value? https://github.com/llvm/llvm-project/pull/134214 ___ cfe-commi

[clang] [clang] Add `__bf16` Type Support Macros With Literal Suffix Support (PR #134214)

https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/134214 >From 620bdbed2b372b97b66147684d4ded5b666c7786 Mon Sep 17 00:00:00 2001 From: bassiounix Date: Thu, 3 Apr 2025 10:08:59 +0200 Subject: [PATCH 01/10] add `bf16`/`BF16` suffix support --- clang/include/clang/

[clang] [clang] Add `__bf16` Type Support Macros With Literal Suffix Support (PR #134214)

https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/134214 >From 620bdbed2b372b97b66147684d4ded5b666c7786 Mon Sep 17 00:00:00 2001 From: bassiounix Date: Thu, 3 Apr 2025 10:08:59 +0200 Subject: [PATCH 01/18] add `bf16`/`BF16` suffix support --- clang/include/clang/

[clang] [clang] Add `__bf16` Type Support Macros With Literal Suffix Support (PR #134214)

https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/134214 >From 620bdbed2b372b97b66147684d4ded5b666c7786 Mon Sep 17 00:00:00 2001 From: bassiounix Date: Thu, 3 Apr 2025 10:08:59 +0200 Subject: [PATCH 01/12] add `bf16`/`BF16` suffix support --- clang/include/clang/

[clang] [clang] Add `__bf16` Type Support Macros With Literal Suffix Support (PR #134214)

https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/134214 >From 620bdbed2b372b97b66147684d4ded5b666c7786 Mon Sep 17 00:00:00 2001 From: bassiounix Date: Thu, 3 Apr 2025 10:08:59 +0200 Subject: [PATCH 01/17] add `bf16`/`BF16` suffix support --- clang/include/clang/

[clang] [clang] Add `__bf16` Type Support Macros With Literal Suffix Support (PR #134214)

https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/134214 >From 620bdbed2b372b97b66147684d4ded5b666c7786 Mon Sep 17 00:00:00 2001 From: bassiounix Date: Thu, 3 Apr 2025 10:08:59 +0200 Subject: [PATCH 01/17] add `bf16`/`BF16` suffix support --- clang/include/clang/

[clang] [clang] Add `__bf16` Type Support Macros With Literal Suffix Support (PR #134214)

https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/134214 >From 620bdbed2b372b97b66147684d4ded5b666c7786 Mon Sep 17 00:00:00 2001 From: bassiounix Date: Thu, 3 Apr 2025 10:08:59 +0200 Subject: [PATCH 01/16] add `bf16`/`BF16` suffix support --- clang/include/clang/

[clang] [clang] Add `__bf16` Type Support Macros With Literal Suffix Support (PR #134214)

https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/134214 >From 620bdbed2b372b97b66147684d4ded5b666c7786 Mon Sep 17 00:00:00 2001 From: bassiounix Date: Thu, 3 Apr 2025 10:08:59 +0200 Subject: [PATCH 01/17] add `bf16`/`BF16` suffix support --- clang/include/clang/

[clang] [clang] Add `__bf16` Type Support Macros With Literal Suffix Support (PR #134214)

bassiounix wrote: How do I do the last one, the target support part? https://github.com/llvm/llvm-project/pull/134214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [clang] Add `__bf16` Type Support Macros With Literal Suffix Support (PR #134214)

https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/134214 >From 620bdbed2b372b97b66147684d4ded5b666c7786 Mon Sep 17 00:00:00 2001 From: bassiounix Date: Thu, 3 Apr 2025 10:08:59 +0200 Subject: [PATCH 01/14] add `bf16`/`BF16` suffix support --- clang/include/clang/

[clang] [clang] Add `__bf16` Type Support Macros With Literal Suffix Support (PR #134214)

https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/134214 >From 620bdbed2b372b97b66147684d4ded5b666c7786 Mon Sep 17 00:00:00 2001 From: bassiounix Date: Thu, 3 Apr 2025 10:08:59 +0200 Subject: [PATCH 01/13] add `bf16`/`BF16` suffix support --- clang/include/clang/

[clang] [clang] Add `__bf16` Type Support Macros With Literal Suffix Support (PR #134214)

https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/134214 >From 620bdbed2b372b97b66147684d4ded5b666c7786 Mon Sep 17 00:00:00 2001 From: bassiounix Date: Thu, 3 Apr 2025 10:08:59 +0200 Subject: [PATCH 01/11] add `bf16`/`BF16` suffix support --- clang/include/clang/

[clang] [clang] Add `__bf16` Type Support Macros With Literal Suffix Support (PR #134214)

bassiounix wrote: Looks like that `BFloat16Format` for `amdgcn-amd-amdhsa` target is not properly initialized and the `hasBFloat16Type` method at [`clang/lib/Basic/Targets/AMDGPU.h`](https://github.com/llvm/llvm-project/blob/92923e517c2926eb94b7b6e403433ecf62953186/clang/lib/Basic/Targets/AMDGP

[clang] [clang] Add `__bf16` Type Support Macros With Literal Suffix Support (PR #134214)

https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/134214 >From 620bdbed2b372b97b66147684d4ded5b666c7786 Mon Sep 17 00:00:00 2001 From: bassiounix Date: Thu, 3 Apr 2025 10:08:59 +0200 Subject: [PATCH 1/3] add `bf16`/`BF16` suffix support --- clang/include/clang/Le

[clang] [clang] Add `__bf16` Type Support Macros With Literal Suffix Support (PR #134214)

https://github.com/bassiounix created https://github.com/llvm/llvm-project/pull/134214 closes #133660. I added the suffix support to this pr as the generated macros uses the `BF16` suffix. The only line I found in GCC which we don't seem to support as a macro is ```c #define __BFLT16_IS_IEC_

[clang] [clang:frontend] Move helper functions to common location for SemaSPIRV (PR #125045)

https://github.com/bassiounix closed https://github.com/llvm/llvm-project/pull/125045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang:frontend] Move helper functions to common location for SemaSPIRV (PR #125045)

bassiounix wrote: Huh.. this shouldn't fail! I tested locally before pushing the commits! Looks like these files aren't mine .. I guess .. https://github.com/llvm/llvm-project/pull/125045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [clang:frontend] Move helper functions to common location for SemaSPIRV (PR #125045)

https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/125045 >From d938f75b1a5638f013ae2f7fb4f0ac2f6e28c6a4 Mon Sep 17 00:00:00 2001 From: Muhammad Bassiouni Date: Thu, 30 Jan 2025 12:02:25 +0200 Subject: [PATCH 1/5] [clang:frontend] Move helper functions in SemaHLSL t

[clang] [clang:frontend] Move helper functions to common location for SemaSPIRV (PR #125045)

bassiounix wrote: > 1. If we were to introduce new helpers, then instead of making a new > header for this, these functions should just become member functions of the > `Sema` class. `Sema` or `SemaBase`? > 2. The new version of `CheckAllArgTypesAreCorrect()` is... way too > complic

[clang] [clang:frontend] Move helper functions to common location for SemaSPIRV (PR #125045)

https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/125045 >From d938f75b1a5638f013ae2f7fb4f0ac2f6e28c6a4 Mon Sep 17 00:00:00 2001 From: Muhammad Bassiouni Date: Thu, 30 Jan 2025 12:02:25 +0200 Subject: [PATCH 1/3] [clang:frontend] Move helper functions in SemaHLSL t

[clang] [clang:frontend] Move helper functions to common location for SemaSPIRV (PR #125045)

@@ -0,0 +1,65 @@ +#include "clang/Sema/Common.h" + +namespace clang { bassiounix wrote: fixed https://github.com/llvm/llvm-project/pull/125045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [clang:frontend] Move helper functions to common location for SemaSPIRV (PR #125045)

https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/125045 >From d938f75b1a5638f013ae2f7fb4f0ac2f6e28c6a4 Mon Sep 17 00:00:00 2001 From: Muhammad Bassiouni Date: Thu, 30 Jan 2025 12:02:25 +0200 Subject: [PATCH 1/2] [clang:frontend] Move helper functions in SemaHLSL t

[clang] [clang:frontend] Move helper functions to common location for SemaSPIRV (PR #125045)

https://github.com/bassiounix created https://github.com/llvm/llvm-project/pull/125045 Move helper functions out of `clang/lib/Sema/SemaHLSL.cpp` into a common location for `clang/lib/Sema/SemaSPIRV.cpp` to use. Moved functions are `CheckArgTypeIsCorrect` and `CheckAllArgTypesAreCorrect`. Thi