Author: Miklos Vajna
Date: 2020-09-18T21:43:18+02:00
New Revision: b168bbfae42e792542b4ced8729599524b9759c5
URL:
https://github.com/llvm/llvm-project/commit/b168bbfae42e792542b4ced8729599524b9759c5
DIFF:
https://github.com/llvm/llvm-project/commit/b168bbfae42e792542b4ced8729599524b9759c5.diff
Author: vmiklos
Date: Fri Jun 21 02:49:38 2019
New Revision: 364014
URL: http://llvm.org/viewvc/llvm-project?rev=364014&view=rev
Log:
[git-clang-format] recognize hxx as a C++ file
clangd, clang-tidy, etc does that already, no reason why
git-clang-format should skip hxx files.
Reviewed By: ilya-
Author: vmiklos
Date: Sun Jan 20 06:28:27 2019
New Revision: 351686
URL: http://llvm.org/viewvc/llvm-project?rev=351686&view=rev
Log:
[clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit
methods
Otherwise we don't warn on a struct containing a single public int, but
we warn
Author: vmiklos
Date: Thu Jan 10 23:59:47 2019
New Revision: 350922
URL: http://llvm.org/viewvc/llvm-project?rev=350922&view=rev
Log:
[clang-tidy] new check 'readability-redundant-preprocessor'
Finds potentially redundant preprocessor directives.
Reviewed By: aaron.ballman
Differential Revision
Author: vmiklos
Date: Mon Dec 24 09:47:32 2018
New Revision: 350056
URL: http://llvm.org/viewvc/llvm-project?rev=350056&view=rev
Log:
[clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix
And also enable it by default to be consistent with e.g.
modernize-use-using.
This he
Author: vmiklos
Date: Sun Oct 21 23:36:30 2018
New Revision: 344885
URL: http://llvm.org/viewvc/llvm-project?rev=344885&view=rev
Log:
ReleaseNotes: move readability-redundant-smartptr-get part down below new checks
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools
Author: vmiklos
Date: Sun Oct 21 12:16:25 2018
New Revision: 344871
URL: http://llvm.org/viewvc/llvm-project?rev=344871&view=rev
Log:
[clang-tidy] add IgnoreMacros option to readability-redundant-smartptr-get
And also enable it by default to be consistent with e.g. modernize-use-using.
This help
Author: vmiklos
Date: Sat Oct 13 00:58:05 2018
New Revision: 30
URL: http://llvm.org/viewvc/llvm-project?rev=30&view=rev
Log:
[clang-tidy] add IgnoreMacros option to modernize-use-equals-delete
And also enable it by default to be consistent with e.g. modernize-use-using.
This improves con
Author: vmiklos
Date: Mon Mar 19 07:43:59 2018
New Revision: 327854
URL: http://llvm.org/viewvc/llvm-project?rev=327854&view=rev
Log:
run-clang-tidy: forward clang-tidy exit status
Exit with a non-zero value in case any of the underlying clang-tidy
invocations exit with a non-zero value.
This is
Author: vmiklos
Date: Fri Jan 5 15:22:10 2018
New Revision: 321913
URL: http://llvm.org/viewvc/llvm-project?rev=321913&view=rev
Log:
clang-tidy: add IgnoreMacros option to
readability-inconsistent-declaration-parameter-name
And also enable it by default to be consistent with e.g. modernize-use-
Author: vmiklos
Date: Mon Sep 11 13:18:38 2017
New Revision: 312942
URL: http://llvm.org/viewvc/llvm-project?rev=312942&view=rev
Log:
clang-rename: let -force handle multiple renames
Summary:
The use case is that renaming multiple symbols in a large enough codebase is
much faster if all of these
Author: vmiklos
Date: Fri Jun 2 04:32:28 2017
New Revision: 304534
URL: http://llvm.org/viewvc/llvm-project?rev=304534&view=rev
Log:
clang-rename: add new -force option
Summary:
The use-case is when renaming a widely used name, like a lower-level
class in a codebase and clang-rename is s
Author: vmiklos
Date: Mon May 8 10:13:31 2017
New Revision: 302429
URL: http://llvm.org/viewvc/llvm-project?rev=302429&view=rev
Log:
clang-tidy: add IgnoreMacros option to modernize-use-default-member-init
Summary:
And also enable it by default to be consistent with e.g.
modernize-use-using.
Th
Author: vmiklos
Date: Sun Apr 23 11:07:06 2017
New Revision: 301130
URL: http://llvm.org/viewvc/llvm-project?rev=301130&view=rev
Log:
clang-rename: fix formatting
As detected by clang-format.
Modified:
clang-tools-extra/trunk/clang-rename/RenamingAction.cpp
clang-tools-extra/trunk/clang-
vmiklos added a comment.
As mentioned earlier, I have no problem with merging rename-at and rename-all.
https://reviews.llvm.org/D24567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
vmiklos added a comment.
Sure, I have no problems merging rename-all and rename-at, I added it as it
looked like a good idea at that time.
https://reviews.llvm.org/D24224
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
vmiklos added a comment.
Ah, if you mean you squashed this into https://reviews.llvm.org/D24192, then I
see what you mean, ignore me. :-)
https://reviews.llvm.org/D23651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
vmiklos added a comment.
Kirill, are you waiting for me on this one? AFAICS the patch in its current
form applies on top of current trunk, but no longer builds.
https://reviews.llvm.org/D23651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: vmiklos
Date: Tue Aug 30 02:24:57 2016
New Revision: 280063
URL: http://llvm.org/viewvc/llvm-project?rev=280063&view=rev
Log:
clang-rename: fix formatting in USRFinder
As detected by clang-format.
Modified:
clang-tools-extra/trunk/clang-rename/USRFinder.cpp
Modified: clang-tools-ext
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280062: clang-rename: improve error message when -old-name
is used and could not find… (authored by vmiklos).
Changed prior to commit:
https://reviews.llvm.org/D24002?vs=69644&id=69646#toc
Repository:
Author: vmiklos
Date: Tue Aug 30 02:23:24 2016
New Revision: 280062
URL: http://llvm.org/viewvc/llvm-project?rev=280062&view=rev
Log:
clang-rename: improve error message when -old-name is used and could not find
symbol
Old output was:
clang-rename: could not find symbol at
tools/clang/tools/ex
vmiklos marked an inline comment as done.
vmiklos added a comment.
> Probably something like "could not find symbol OldName" would be reasonable,
> too.
OK, changed.
https://reviews.llvm.org/D24002
___
cfe-commits mailing list
cfe-commits@lists.l
vmiklos updated this revision to Diff 69644.
https://reviews.llvm.org/D24002
Files:
clang-rename/USRFindingAction.cpp
test/clang-rename/InvalidOldName.cpp
Index: test/clang-rename/InvalidOldName.cpp
===
--- /dev/null
+++ test/cl
vmiklos created this revision.
vmiklos added reviewers: klimek, omtcyfz.
vmiklos added a subscriber: cfe-commits.
Old output was:
clang-rename: could not find symbol at
tools/clang/tools/extra/test/clang-rename/ClassFindByName.cpp:1:1 (offset 0).
https://reviews.llvm.org/D24002
Files:
clang
vmiklos added a comment.
> If I understood correctly, you and Alex are talking about different things.
Yes, sorry, the context of my above comment was the cl::opt instances in the
tool itself, not the various parameters to the different actions called from
the tool.
https://reviews.llvm.org/
vmiklos added a comment.
It is expected that either SymbolOffsets or OldNames is empty, and the size of
the non-empty container is the same as the size of the NewNames container. So
no, the code does not rely on the offsets and the old names having the same
length.
https://reviews.llvm.org/D2
vmiklos added a comment.
I can confirm that with this, the test script from the mail thread shows that
clang-rename is almost as fast as clang++ as expected. Thanks!
https://reviews.llvm.org/D23651
___
cfe-commits mailing list
cfe-commits@lists.llv
Hi Eugene,
On Wed, Aug 10, 2016 at 10:00:50PM -, Eugene Zelenko via cfe-commits
wrote:
> Modified: clang-tools-extra/trunk/docs/clang-rename.rst
> URL:
> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-rename.rst?rev=278295&r1=278294&r2=278295&view=diff
>
vmiklos added a comment.
In https://reviews.llvm.org/D23198#510269, @alexfh wrote:
> A few late comments.
I've addressed these in r278201.
Repository:
rL LLVM
https://reviews.llvm.org/D23198
___
cfe-commits mailing list
cfe-commits@lists.llvm.
Author: vmiklos
Date: Wed Aug 10 02:13:29 2016
New Revision: 278201
URL: http://llvm.org/viewvc/llvm-project?rev=278201&view=rev
Log:
clang-rename YAML reader: address post-commit comments
Modified:
clang-tools-extra/trunk/clang-rename/tool/ClangRename.cpp
clang-tools-extra/trunk/docs/cla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278145: clang-rename rename-all: support reading old/newname
pairs from a YAML file (authored by vmiklos).
Changed prior to commit:
https://reviews.llvm.org/D23198?vs=67215&id=67381#toc
Repository:
r
Author: vmiklos
Date: Tue Aug 9 13:20:41 2016
New Revision: 278145
URL: http://llvm.org/viewvc/llvm-project?rev=278145&view=rev
Log:
clang-rename rename-all: support reading old/newname pairs from a YAML file
This is handy in case by the time clang-rename is invoked, an external
tool already gen
vmiklos added inline comments.
Comment at: clang-rename/tool/ClangRename.cpp:65
@@ +64,3 @@
+
+ RenameAllInfo() : Offset(0) {}
+};
omtcyfz wrote:
> omtcyfz wrote:
> > vmiklos wrote:
> > > omtcyfz wrote:
> > > > AFAIK there's no need to do that, integer types are
vmiklos added inline comments.
Comment at: clang-rename/tool/ClangRename.cpp:65
@@ +64,3 @@
+
+ RenameAllInfo() : Offset(0) {}
+};
omtcyfz wrote:
> AFAIK there's no need to do that, integer types are by default initialized
> with 0, aren't they?
Are you sure? He
vmiklos added a comment.
> .cpp.rename-at.yaml?
I just discovered that lit provides %S that allows getting rid of the confusing
.cpp.yaml, I'm using that now.
> Ah, and yes, it's better to move *.yaml to extra/test/clang-rename/Inputs
Done.
https://reviews.llvm.org/D23198
___
vmiklos updated this revision to Diff 67215.
https://reviews.llvm.org/D23198
Files:
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/clang-rename/ClassTestMultiByNameYAML.cpp
test/clang-rename/Inputs/ClassTestMultiByNameYAMLRenameAll.yaml
test/clang-rename/Inputs/ClassTestMu
vmiklos marked 2 inline comments as done.
vmiklos added a comment.
> Would also be nice to support at least `offset + new-name` in YAML input
> files, too.
Done.
> Please move this block upwards [preferably right after line 42]. I consider
> information about limitations and editor more impo
vmiklos updated this revision to Diff 66993.
https://reviews.llvm.org/D23198
Files:
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/clang-rename/ClassTestMultiByNameYAML.cpp
test/clang-rename/ClassTestMultiByNameYAML.cpp.rename-all.yaml
test/clang-rename/ClassTestMultiByNam
vmiklos added inline comments.
Comment at: clang-rename/tool/ClangRename.cpp:140
@@ -116,1 +139,3 @@
cl::value_desc("filename"), cl::cat(*Category));
+ cl::opt Input(
+ "input", cl::desc("YAML file to load oldname-newname pairs from."),
omtcyfz wrote:
vmiklos added a comment.
As a side note, this is the last feature that LibreOffice's simple clang-based
rename tool
(https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/clang/rename.cxx)
supports, and clang-rename does not. (That one takes a CSV file, but in case
-export-fixes outp
vmiklos created this revision.
vmiklos added reviewers: klimek, omtcyfz.
vmiklos added a subscriber: cfe-commits.
This is handy in case by the time clang-rename is invoked, an external
tool already genereated a list of oldname -> newname pairs to handle.
https://reviews.llvm.org/D23198
Files:
vmiklos added a comment.
Thanks. Yes, I used the Linux-distro-provided clang-format-3.7, I didn't notice
that the trunk version now also sorts includes.
Repository:
rL LLVM
https://reviews.llvm.org/D23153
___
cfe-commits mailing list
cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277702: Run clang-format on clang-rename code (authored by
vmiklos).
Changed prior to commit:
https://reviews.llvm.org/D23153?vs=66766&id=66769#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2315
Author: vmiklos
Date: Thu Aug 4 02:43:29 2016
New Revision: 277702
URL: http://llvm.org/viewvc/llvm-project?rev=277702&view=rev
Log:
Run clang-format on clang-rename code
So that later commits don't introduce non-functional changes when
running clang-format before committing.
Reviewers: klimek
vmiklos created this revision.
vmiklos added reviewers: klimek, omtcyfz.
vmiklos added a subscriber: cfe-commits.
So that later commits don't introduce non-functional changes when
running clang-format before committing.
https://reviews.llvm.org/D23153
Files:
clang-rename/RenamingAction.h
cla
vmiklos added a comment.
Yes, I did that -- but I got no conflicts there. ;-)
Repository:
rL LLVM
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vmiklos
Date: Tue Aug 2 04:51:31 2016
New Revision: 277438
URL: http://llvm.org/viewvc/llvm-project?rev=277438&view=rev
Log:
clang-rename: split existing options into two new subcommands
- rename-at is meant to be integrated with editors and works mainly off
of a location in a file, an
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277438: clang-rename: split existing options into two new
subcommands (authored by vmiklos).
Changed prior to commit:
https://reviews.llvm.org/D21814?vs=66362&id=66448#toc
Repository:
rL LLVM
https:
vmiklos added a comment.
Rebased on top of r277356 and resolved conflicts. (A busy day, it seems. :-) )
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
vmiklos updated this revision to Diff 66362.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassTestMulti.cpp
test/c
vmiklos added a comment.
Rebased on top of r277339 and resolved conflicts.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos updated this revision to Diff 66304.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassTestMulti.cpp
test/c
vmiklos added a comment.
Great! Manuel, OK to land?
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos added a comment.
Yes, exactly, so not easy to customize I guess.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos added a comment.
In https://reviews.llvm.org/D21814#500621, @omtcyfz wrote:
> P.S. not sure whether we have to write `clang-rename: for the -new-name
> option: must be specified` out. We already launched `clang-rename` what else
> could've give us an error?
You mean how is that error
vmiklos added a comment.
> Just write a FIXME then, I think I may look into that on the next week or
> somewhen.
Done.
> Most of the time I use Foo->Bar renaming in tests
Done, I've renamed ClaN->KlaN to FooN->BarN.
https://reviews.llvm.org/D21814
___
vmiklos updated this revision to Diff 66110.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassTestMulti.cpp
test/c
vmiklos added a comment.
Rebased on top of r277131 and resolved conflicts.
> As for help message, look at clang-tidy. Is there a need in helpMain?
I think so; we have this chicken-and-egg problem (see earlier comments of this
review), that the options parser wants to know the option category, b
vmiklos updated this revision to Diff 66105.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassTestMulti.cpp
test/c
vmiklos added a subscriber: Eugene.Zelenko.
vmiklos added a comment.
> 1. Run `clang-format` or something, 80 char width limit is broken in
> `tool/ClangRename.cpp` dozen of times.
Done. I was afraid doing that, due to the changes not related to my patch, but
the result doesn't seem to be too b
vmiklos updated this revision to Diff 66099.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassTestMulti.cpp
test/c
vmiklos added a comment.
Is there anything I can help with to get this accepted, please? As far as I see
I addressed all so far mentioned concerns. Thanks.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
vmiklos added a comment.
Rebased on top of r276949 and resolved a failing test
(FunctionWithClassFindByName.cpp).
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
vmiklos updated this revision to Diff 65876.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassTestMulti.cpp
test/c
vmiklos added a subscriber: vmiklos.
vmiklos added a comment.
`:help leader` explains it. Or see this link:
http://learnvimscriptthehardway.stevelosh.com/chapters/06.html#leader. The
later describes 3 arguments for using `` instead of `,` directly.
https://reviews.llvm.org/D22854
__
vmiklos marked 2 inline comments as done.
vmiklos added a comment.
> rename-at isn't necessary here anymore since it's going to be default
> behavior IIUC
Indeed, it can be changed back now, done.
> docs should be fixed correspondingly; i.e. prefer to write clang-rename
> -offset=42 over
vmiklos updated this revision to Diff 65684.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassTestMulti.cpp
test/c
vmiklos added a comment.
Rebased on top of r276836 and resolved conflicts.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos updated this revision to Diff 65672.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
clang-rename/tool/clang-rename.py
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clan
vmiklos added a comment.
Rebased on top of r276684 and resolved conflicts.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos updated this revision to Diff 65417.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
clang-rename/tool/clang-rename.py
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clan
vmiklos updated this revision to Diff 65042.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
clang-rename/tool/clang-rename.py
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clan
vmiklos added a comment.
Done, that also allows not modifying most existing tests.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos added a comment.
In https://reviews.llvm.org/D21814#492540, @omtcyfz wrote:
> I'd be actually happy if instead of having `-rename-at` option we'd have this
> behavior by default unless `-rename-all` is used.
Not sure I understand this request. rename-at and rename-all all subcommands,
vmiklos marked an inline comment as done.
vmiklos added a comment.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos updated this revision to Diff 65031.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
clang-rename/tool/clang-rename.py
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clan
vmiklos added inline comments.
Comment at: clang-rename/RenamingAction.cpp:48
@@ +47,3 @@
+for (unsigned I = 0; I < NewNameList.size(); ++I) {
+ HandleOneRename(Context, NewNameList[I], PrevNameList[I], USRList[I]);
+}
klimek wrote:
> Question is whet
vmiklos updated this revision to Diff 64941.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
clang-rename/tool/clang-rename.py
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clan
vmiklos added a comment.
Rebased on top of r276282 and resolved conflicts.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos marked an inline comment as done.
vmiklos added a comment.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos added a comment.
> The patch looks fine to me (though I'm not sure if there are no new tests; if
> they are interface changes should be applied).
`make check-clang-tools` + the patch at r276098 passes for me at least. But any
pending test should be trivial to adapt.
> P.S. it seems lo
vmiklos updated this revision to Diff 64859.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
clang-rename/tool/clang-rename.py
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clan
vmiklos added a comment.
Is there anything I can help with to get this reviewed, please? As far as I see
it still applies cleanly on top of current trunk.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
vmiklos added a comment.
In https://reviews.llvm.org/D21814#486204, @omtcyfz wrote:
> - Can you please update diff? I changed most of the tests recently.
Sure, I actually wanted to ask if those test additions were meant to be test
renames. :-)
> - I think you should update `doc/clang-rename` i
vmiklos updated this revision to Diff 64231.
https://reviews.llvm.org/D21814
Files:
clang-rename/tool/ClangRename.cpp
clang-rename/tool/clang-rename.py
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassReplacements.cpp
test/clang-rename/ClassSimpleRena
vmiklos abandoned this revision.
vmiklos added a comment.
I see your point, then let me abandon this.
https://reviews.llvm.org/D22237
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos added a comment.
I've implemented the requested split of options, now there are two new
rename-at and rename-all subcommands. The only common options is -i and
-new-name, nothing else is shared, apart from the common options added by
`tooling::CommonOptionsParser`. The code is modeled a
vmiklos updated this revision to Diff 64204.
https://reviews.llvm.org/D21814
Files:
clang-rename/tool/ClangRename.cpp
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassReplacements.cpp
test/clang-rename/ClassSimpleRenaming.cpp
test/clang-rename/ClassTest.cpp
test/clang-rena
vmiklos added a comment.
I'm a bit confused.
On one hand, I want to use tooling::CommonOptionsParser to parse the options,
which needs a cl::OptionCategory as a parameter.
On the other hand, I want to parse the options, based on that I'll know what
subcommand was requested, and then I can choo
vmiklos added a comment.
The alternative is to change the `CommonOptionsParser` ctor to take a vector of
`OptionCategory&`, and in that case we can add the -extra-arg-before and other
options to all subcommands, but that means he'll have to adapt all client code,
i.e. all tools in clang-tools-e
vmiklos updated this revision to Diff 64027.
https://reviews.llvm.org/D22237
Files:
clang-rename/USRLocFinder.cpp
test/clang-rename/VirtualFunction.cpp
Index: test/clang-rename/VirtualFunction.cpp
===
--- /dev/null
+++ test/clan
vmiklos added a comment.
Forgot to add asserts for main() in the testcase.
https://reviews.llvm.org/D22237
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos updated this revision to Diff 64025.
https://reviews.llvm.org/D22237
Files:
clang-rename/USRLocFinder.cpp
test/clang-rename/VirtualFunction.cpp
Index: test/clang-rename/VirtualFunction.cpp
===
--- /dev/null
+++ test/clan
vmiklos added a subscriber: vmiklos.
vmiklos added a comment.
Can you please avoid adding VirtualFunction.cpp? http://reviews.llvm.org/D22237
would add it as well, but without the FIXME. Thanks! :-)
http://reviews.llvm.org/D22102
___
cfe-commits ma
vmiklos created this revision.
vmiklos added a reviewer: klimek.
vmiklos added a subscriber: cfe-commits.
Testcase by Kirill Bobyrev.
http://reviews.llvm.org/D22237
Files:
clang-rename/USRLocFinder.cpp
test/clang-rename/VirtualFunction.cpp
Index: test/clang-rename/VirtualFunction.cpp
==
vmiklos added a comment.
As far as I see `tooling::CommonOptionsParser` (in its current form) does not
handle cl::SubCommand instances. Should I fix that or would it be OK to switch
to using `cl::ParseCommandLineOptions` directly in clang-rename?
http://reviews.llvm.org/D21814
_
vmiklos added a comment.
In http://reviews.llvm.org/D22091#476756, @vmiklos wrote:
> Can you please postpone the cleanup till http://reviews.llvm.org/D21814 is
> reviewed? The two patches conflict with each other, I fear. Thanks. :-)
Ignore this, that one won't land as-is after all.
http://r
vmiklos added a comment.
Kirill: OK, so you're in the camp marked as b) by Manuel. Sure, the vim
integration is nice (I'm also a vim user), now that you mentioned it, I need to
go and try it myself. ;-) Given the above patch, probably it's obvious that I'm
more in camp a). I don't insist on hav
vmiklos added a subscriber: vmiklos.
vmiklos added a comment.
Can you please postpone the cleanup till http://reviews.llvm.org/D21814 is
reviewed? The two patches conflict with each other, I fear. Thanks. :-)
http://reviews.llvm.org/D22091
___
cfe-
vmiklos added a comment.
Manuel, do you have an opinion on this, please?
http://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 182 matches
Mail list logo
