MikeWeller wrote:
Is it @sam-mccall who needs to address remaining comments? Or how can we move
this along? I'd also be keen on getting this change merged.
https://github.com/llvm/llvm-project/pull/67228
___
cfe-commits mailing list
cfe-commits@lists.
https://github.com/MikeWeller updated
https://github.com/llvm/llvm-project/pull/88138
>From 483bd05ec3c0575ed6771ef093368d6be19f5d3f Mon Sep 17 00:00:00 2001
From: Mike Weller
Date: Tue, 9 Apr 2024 16:03:31 +0100
Subject: [PATCH 1/5] [clang-tidy] Ignore delete ctor in
`bugprone-forwarding-refe
@@ -286,6 +286,10 @@ Changes in existing checks
check by resolving fix-it overlaps in template code by disregarding implicit
instances.
+- Improved :doc:`bugprone-forwarding-reference-overload
+ `
+ check to not flag deleted constructors which are unable to hide anything
MikeWeller wrote:
FYI I don't have merge privs, not sure if I need to ping anybody. Then again I
still see "This workflow requires approval from a maintainer", possibly because
this is my first contribution?
https://github.com/llvm/llvm-project/pull/88138
__
https://github.com/MikeWeller updated
https://github.com/llvm/llvm-project/pull/88138
>From 483bd05ec3c0575ed6771ef093368d6be19f5d3f Mon Sep 17 00:00:00 2001
From: Mike Weller
Date: Tue, 9 Apr 2024 16:03:31 +0100
Subject: [PATCH 1/4] [clang-tidy] Ignore delete ctor in
`bugprone-forwarding-refe
https://github.com/MikeWeller updated
https://github.com/llvm/llvm-project/pull/88138
>From 483bd05ec3c0575ed6771ef093368d6be19f5d3f Mon Sep 17 00:00:00 2001
From: Mike Weller
Date: Tue, 9 Apr 2024 16:03:31 +0100
Subject: [PATCH 1/3] [clang-tidy] Ignore delete ctor in
`bugprone-forwarding-refe
MikeWeller wrote:
@PiotrZSL apologies, have put it in the correct location. Is there a way to
preview/check the `:doc:` thing? I assume there is some kind of
preprocessor/tool step for this? I copied what the rest are doing and put the
appropriate section of the
https://clang.llvm.org/extra/c
https://github.com/MikeWeller updated
https://github.com/llvm/llvm-project/pull/88138
>From 483bd05ec3c0575ed6771ef093368d6be19f5d3f Mon Sep 17 00:00:00 2001
From: Mike Weller
Date: Tue, 9 Apr 2024 16:03:31 +0100
Subject: [PATCH 1/2] [clang-tidy] Ignore delete ctor in
`bugprone-forwarding-refe
MikeWeller wrote:
Given the small size of the change I just did a rebase and force push to
resolve conflicts with the release notes.
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
https://github.com/MikeWeller updated
https://github.com/llvm/llvm-project/pull/88138
>From 483bd05ec3c0575ed6771ef093368d6be19f5d3f Mon Sep 17 00:00:00 2001
From: Mike Weller
Date: Tue, 9 Apr 2024 16:03:31 +0100
Subject: [PATCH] [clang-tidy] Ignore delete ctor in
`bugprone-forwarding-referenc
https://github.com/MikeWeller updated
https://github.com/llvm/llvm-project/pull/88138
>From 4cb9527430d3c7f9acc518427a29eae0aa7e00d1 Mon Sep 17 00:00:00 2001
From: Mike Weller
Date: Tue, 9 Apr 2024 16:03:31 +0100
Subject: [PATCH 1/2] [clang-tidy] Ignore delete ctor in
`bugprone-forwarding-refe
MikeWeller wrote:
Sorry, didn't realize there are release notes I can updated in the change
itself. Will do this Monday.
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/MikeWeller ready_for_review
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MikeWeller updated
https://github.com/llvm/llvm-project/pull/88138
>From 4cb9527430d3c7f9acc518427a29eae0aa7e00d1 Mon Sep 17 00:00:00 2001
From: Mike Weller
Date: Tue, 9 Apr 2024 16:03:31 +0100
Subject: [PATCH] [clang-tidy] Ignore delete ctor in
`bugprone-forwarding-referenc
@@ -251,3 +251,10 @@ class Test10 {
Test10(T &&Item, E e)
: e(e){}
};
+
+// A deleted ctor cannot hide anything
+class Test11 {
+public:
+ template
+ Test11(T&&) = delete;
MikeWeller wrote:
Although this is enough to trigger (or not after the fix) t
https://github.com/MikeWeller edited
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MikeWeller wrote:
https://github.com/llvm/llvm-project/issues/88128
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MikeWeller created
https://github.com/llvm/llvm-project/pull/88138
Fix `bugprone-forwarding-reference-overload` so it doesn't report a constructor
that is deleted.
>From 6c188e730f43467c3a7940c0ca6f6bd0bc8fc7f1 Mon Sep 17 00:00:00 2001
From: Mike Weller
Date: Tue, 9 Apr 202
18 matches
Mail list logo
