[clang] [OpenMP][NFC] Remove executable cases from declaration switch (PR #106438)

2024-08-28 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/106438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][NFC] Remove executable cases from declaration switch (PR #106438)

2024-08-28 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/106438 The executable directives are handled earlier. >From 3a7f341c33c0f91f2ca6f31762e71fcae6f1a69d Mon Sep 17 00:00:00 2001 From: Mike Rice Date: Wed, 28 Aug 2024 11:38:12 -0700 Subject: [PATCH] [OpenMP][NFC] R

[clang] [clang] Fix compile-time regression from attribute arg checking change (PR #101768)

2024-08-06 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/101768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix compile-time regression from attribute arg checking change (PR #101768)

2024-08-06 Thread Mike Rice via cfe-commits
mikerice1969 wrote: Thanks @nikic! https://github.com/llvm/llvm-project/pull/101768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Update argument checking tablegen code to use a 'full' name (PR #99993)

2024-08-03 Thread Mike Rice via cfe-commits
mikerice1969 wrote: Proposed fix for compile-time regression https://github.com/llvm/llvm-project/pull/101768 https://github.com/llvm/llvm-project/pull/3 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [clang] Fix compile-time regression from attribute arg checking change (PR #101768)

2024-08-02 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/101768 In 2acf77f987331c05520c5bfd849326909ffce983 code was added to use the 'full' name including syntax and scope. Instead of building up a large string for each name, add syntax and scope checks to the value

[clang] [clang] Update argument checking tablegen code to use a 'full' name (PR #99993)

2024-07-30 Thread Mike Rice via cfe-commits
mikerice1969 wrote: The old tablegen produced a single entry per name: `.Case("unroll", true)` The new tablegen can produce multiple entries: ``` .Case("Microsoft::unroll", true) .Case("Pragma::unroll", true) ``` I think we can instead produce something like this, one per name: ``` .Case("un

[clang] [clang] Update argument checking tablegen code to use a 'full' name (PR #99993)

2024-07-30 Thread Mike Rice via cfe-commits
mikerice1969 wrote: > You probably need to separately match the syntax and the name without > constructing a temporary `std::string`. @nikic Thanks. I'll look into improving this. If anyone thinks this should be reverted until then let me know, or just go ahead and revert it. https://github.c

[clang] [clang] Update argument checking tablegen code to use a 'full' name (PR #99993)

2024-07-30 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/3 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Update argument checking tablegen code to use a 'full' name (PR #99993)

2024-07-29 Thread Mike Rice via cfe-commits
mikerice1969 wrote: > That code was added very recently by #94056 and seem to be specific to the > `ptrauth_vtable_pointer` attribute. Perhaps we're lacking test coverage if > nothing breaks without that code? @AaronBallman The code is logically useless so there's no way to add tests that mak

[clang] [HLSL] Default and Relaxed Availability Diagnostics (PR #92704)

2024-07-26 Thread Mike Rice via cfe-commits
@@ -290,3 +294,296 @@ void SemaHLSL::DiagnoseAttrStageMismatch( << A << HLSLShaderAttr::ConvertShaderTypeToStr(Stage) << (AllowedStages.size() != 1) << join(StageStrings, ", "); } + +namespace { + +/// This class implements HLSL availability diagnostics for default

[clang] [clang][Sema][NFC] remove unreachable return statement (PR #100642)

2024-07-26 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/100642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Default and Relaxed Availability Diagnostics (PR #92704)

2024-07-25 Thread Mike Rice via cfe-commits
@@ -290,3 +294,296 @@ void SemaHLSL::DiagnoseAttrStageMismatch( << A << HLSLShaderAttr::ConvertShaderTypeToStr(Stage) << (AllowedStages.size() != 1) << join(StageStrings, ", "); } + +namespace { + +/// This class implements HLSL availability diagnostics for default

[clang] [analyzer][NFC] Factor out NoOwnershipChangeVisitor (PR #94357)

2024-07-25 Thread Mike Rice via cfe-commits
=?utf-8?q?Kristóf?= Umann Message-ID: In-Reply-To: @@ -804,23 +751,21 @@ class NoOwnershipChangeVisitor final : public NoStateChangeFuncVisitor { return false; } + bool hasResourceStateChanged(ProgramStateRef CallEnterState, + ProgramSt

[clang] [clang][Sema][NFC] remove unreachable return statement (PR #100642)

2024-07-25 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/100642 The switch now returns in every case so the end return is unreachable. >From 8804f18fcaf1a70bad10a8e66414f91556df23bd Mon Sep 17 00:00:00 2001 From: Mike Rice Date: Thu, 25 Jul 2024 11:35:11 -0700 Subject:

[clang] [Clang] Fix potential null pointer dereferences in Sema::AddInitializerToDecl (PR #94368)

2024-07-25 Thread Mike Rice via cfe-commits
@@ -13681,12 +13681,13 @@ void Sema::AddInitializerToDecl(Decl *RealDecl, Expr *Init, bool DirectInit) { } Init = Result.getAs(); +assert(Init && "Init must not be null"); + IsParenListInit = !InitSeq.steps().empty() && InitSeq.step_beg

[clang] [InstallAPI] Pick up input headers by directory traversal (PR #94508)

2024-07-25 Thread Mike Rice via cfe-commits
@@ -0,0 +1,300 @@ +//===- DirectoryScanner.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][NFC] remove unneeded nullptr checks after dereference (PR #100489)

2024-07-25 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/100489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] remove unneeded nullptr checks after dereference (PR #100489)

2024-07-24 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/100489 Fix static verifer concerns of null pointer checks after dereferencing the pointer. Update the assert to make it super clear it is not null and remove the checks.

[clang] [clang] Update argument checking tablegen code to use a 'full' name (PR #99993)

2024-07-23 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 updated https://github.com/llvm/llvm-project/pull/3 >From 5f8b68d9dfd7680adeadbae1d761dc03a2455685 Mon Sep 17 00:00:00 2001 From: Mike Rice Date: Mon, 22 Jul 2024 15:28:15 -0700 Subject: [PATCH 1/2] [clang] Update argument checking tablegen code to use a 'fu

[clang] [clang] Update argument checking tablegen code to use a 'full' name (PR #99993)

2024-07-23 Thread Mike Rice via cfe-commits
@@ -314,64 +314,92 @@ void Parser::ParseGNUAttributes(ParsedAttributes &Attrs, } /// Determine whether the given attribute has an identifier argument. -static bool attributeHasIdentifierArg(const IdentifierInfo &II) { +static bool attributeHasIdentifierArg(const IdentifierInfo

[clang] [clang] Update argument checking tablegen code to use a 'full' name (PR #99993)

2024-07-23 Thread Mike Rice via cfe-commits
mikerice1969 wrote: > Does this impact anything user-facing? e.g., should there be an additional > test somewhere in clang/test/Sema/ for this change? I don't think there is any user-visible issue with the one attribute that uses this. At least how the Parse code is written currently. The attr

[clang] [clang] Update argument checking tablegen code to use a 'full' name (PR #99993)

2024-07-22 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/3 In 92fc1eb0c1ae3813f2ac9208e2c74207aae9d23 the HLSLLoopHint attribute was added with an 'unroll' spelling. There is an existing LoopHint attribute with the same spelling. These attributes have different arg

[clang] [clang] Implement function pointer signing and authenticated function calls (PR #93906)

2024-07-16 Thread Mike Rice via cfe-commits
@@ -14,10 +14,144 @@ #ifndef LLVM_CLANG_BASIC_POINTERAUTHOPTIONS_H #define LLVM_CLANG_BASIC_POINTERAUTHOPTIONS_H +#include "clang/Basic/LLVM.h" +#include "clang/Basic/LangOptions.h" +#include "llvm/ADT/STLForwardCompat.h" +#include "llvm/Support/ErrorHandling.h" +#include "llv

[clang] [NFC][clang] Replace unchecked dyn_cast with cast (PR #98948)

2024-07-16 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/98948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][clang] Replace unchecked dyn_cast with cast (PR #98948)

2024-07-15 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/98948 BI__builtin_hlsl_elementwise_rcp is only invoked with a FixedVectorType so use cast to make this clear and satisfy the static verifier. >From 68b271a07bea190e515fb24e1ec0a833624078bc Mon Sep 17 00:00:00 200

[clang] [NFC][clang] Replace unreachable code in literal processing with assert (PR #96579)

2024-06-25 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/96579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [BitInt] Expose a _BitInt literal suffix in C++ (PR #86586)

2024-06-24 Thread Mike Rice via cfe-commits
@@ -1117,6 +1118,31 @@ NumericLiteralParser::NumericLiteralParser(StringRef TokSpelling, if (isImaginary) break; // Cannot be repeated. isImaginary = true; continue; // Success. +case '_': + if (isFPConstant) +break; // Invalid for floats

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-24 Thread Mike Rice via cfe-commits
@@ -2374,86 +2374,209 @@ Parser::DeclGroupPtrTy Parser::ParseOpenMPDeclarativeDirectiveWithExtDecl( case OMPD_unknown: Diag(Tok, diag::err_omp_unknown_directive); break; - case OMPD_parallel: - case OMPD_simd: - case OMPD_tile: - case OMPD_unroll: - case OMPD_ta

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-24 Thread Mike Rice via cfe-commits
@@ -2374,86 +2374,209 @@ Parser::DeclGroupPtrTy Parser::ParseOpenMPDeclarativeDirectiveWithExtDecl( case OMPD_unknown: Diag(Tok, diag::err_omp_unknown_directive); break; - case OMPD_parallel: - case OMPD_simd: - case OMPD_tile: - case OMPD_unroll: - case OMPD_ta

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-24 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 commented: I both like and hate the huge fully-covered switches we have. I like when I add new directives and know exactly where to add code. I hate having to read code like this though. Seems like this is going in the right direction. https://github.com/llvm/ll

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-24 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 edited https://github.com/llvm/llvm-project/pull/94691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Fix error handling of the adjust_args clause (PR #94696)

2024-06-24 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/94696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Fix teams nesting of region check (PR #94806)

2024-06-24 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/94806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][NFC] Fix argument order of SourceLocations for allocate clause (PR #94777)

2024-06-10 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/94777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP][NFC] Remove unnecessary nullptr check (PR #94680)

2024-06-10 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/94680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [BitInt] Expose a _BitInt literal suffix in C++ (PR #86586)

2024-06-07 Thread Mike Rice via cfe-commits
@@ -1117,6 +1118,31 @@ NumericLiteralParser::NumericLiteralParser(StringRef TokSpelling, if (isImaginary) break; // Cannot be repeated. isImaginary = true; continue; // Success. +case '_': + if (isFPConstant) +break; // Invalid for floats

[clang] [clang][OpenMP] Fix teams nesting of region check (PR #94806)

2024-06-07 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/94806 The static verifier flagged dead code in the check since the loop will only execute once and never reach the iterator increment. The loop needs to iterate twice to correctly diagnose when a statement is aft

[clang] [OpenMP][NFC] Fix argument order of SourceLocations for allocate clause (PR #94777)

2024-06-07 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/94777 Static verifier caught passing ColonLoc/LParenLoc in wrong order. Marked as NFC since these don't seem to be used for anything currently that I can think to test for. >From ae0438eda2b5fcffc70b991d2c496bac

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #86923)

2024-06-06 Thread Mike Rice via cfe-commits
@@ -201,14 +211,26 @@ template <> struct DominatingValue { class saved_type { enum Kind { ScalarLiteral, ScalarAddress, AggregateLiteral, AggregateAddress, ComplexAddress }; - -llvm::Value *Value; -llvm::Type *ElementType; +union { + struc

[clang] [clang][OpenMP] Fix error handling of the adjust_args clause (PR #94696)

2024-06-06 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/94696 Static verifier noticed the current code has logically dead code parsing the clause where IsComma is assigned. Fix this and improve the error message received when a bad adjust-op is specified. This will n

[clang] [clang][OpenMP][NFC] Remove unnecessary nullptr check (PR #94680)

2024-06-06 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/94680 Static verifier reports unchecked use of pointer after explicitly checking earlier in the function. It appears the pointer won't be a nullptr, so remove the unneeded check for consistency. >From 476c5a8580

[clang] [OpenMP][CodeGen] Improved codegen for combined loop directives (PR #87278)

2024-05-09 Thread Mike Rice via cfe-commits
@@ -6135,6 +6137,79 @@ processImplicitMapsWithDefaultMappers(Sema &S, DSAStackTy *Stack, } } +namespace { +/// A 'teams loop' with a nested 'loop bind(parallel)' or generic function +/// call in the associated loop-nest cannot be a 'parallel for'. +class TeamsLoopChecker fi

[clang-tools-extra] [clang-tidy] Ensure nullable variable is not accessed without validity test (PR #90173)

2024-04-26 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 approved this pull request. LGTM. Thanks! https://github.com/llvm/llvm-project/pull/90173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add fix-its to `readability-avoid-return-with-void-value` check (PR #81420)

2024-04-25 Thread Mike Rice via cfe-commits
Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= Message-ID: In-Reply-To: @@ -42,10 +44,30 @@ void AvoidReturnWithVoidValueCheck::check( const auto *VoidReturn = Result.Nodes.getNodeAs("void_return"); if (IgnoreMacros &

[clang] [NFC][clang][analyzer] Initialize pointer field in StreamOperationEvaluator (PR #89837)

2024-04-24 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/89837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][clang][analyzer] Initialize pointer field in StreamOperationEvaluator (PR #89837)

2024-04-24 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 edited https://github.com/llvm/llvm-project/pull/89837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][analyzer] Initialize pointer field in StreamOperationEvaluator (PR #89837)

2024-04-23 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/89837 Add an initializer for StreamSym, which is a pointer. The pointers in this class are set in the Init function, but all should be initialized in the constructor to avoid confusion and static verifier hits.

[clang] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` (PR #71709)

2024-04-23 Thread Mike Rice via cfe-commits
@@ -3597,8 +3597,13 @@ class ASTIdentifierTableTrait { /// doesn't check whether the name has macros defined; use PublicMacroIterator /// to check that. bool isInterestingIdentifier(const IdentifierInfo *II, uint64_t MacroOffset) { -if (MacroOffset || II->isPoisoned

[clang] [clang][CodeGen][OpenMP] Fix casting of atomic update of ptr types (PR #88215)

2024-04-12 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/88215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen][OpenMP] Fix casting of atomic update of ptr types (PR #88215)

2024-04-12 Thread Mike Rice via cfe-commits
mikerice1969 wrote: > We should really fix using cmpxchg here. Can you open an IR issue for it? Sure, I'll look into it and follow-up. Thanks for the review! https://github.com/llvm/llvm-project/pull/88215 ___ cfe-commits mailing list cfe-commits@list

[clang] [clang][CodeGen][OpenMP] Fix casting of atomic update of ptr types (PR #88215)

2024-04-09 Thread Mike Rice via cfe-commits
mikerice1969 wrote: See: https://godbolt.org/z/av7axb9as https://github.com/llvm/llvm-project/pull/88215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen][OpenMP] Fix casting of atomic update of ptr types (PR #88215)

2024-04-09 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/88215 In 4d5e834c5b7f0d90a6d543e182df602f6bc8, casts were removed for pointers but one case was missed. Add missing check. >From b1eaa2f5b13db4d63390a0358ad0f9b13cbe927f Mon Sep 17 00:00:00 2001 From: Mike Ri

[clang] [NFC][OpenMP] Split nesting_of_regions test (PR #87842)

2024-04-08 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/87842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][OpenMP] Split nesting_of_regions test (PR #87842)

2024-04-05 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 ready_for_review https://github.com/llvm/llvm-project/pull/87842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][OpenMP] Split nesting_of_regions test (PR #87842)

2024-04-05 Thread Mike Rice via cfe-commits
mikerice1969 wrote: This is one way to improve the overall test time. Open for other suggestions. ``` Before change: Slowest Tests: -- 144.09s: Clang :: OpenMP/nesting_of_regions.cpp 60.81s: Clang :: OpenMP/target_defaultma

[clang] [NFC][OpenMP] Split nesting_of_regions test (PR #87842)

2024-04-05 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/87842 This test is the bottleneck for OpenMP lit tests, running about twice as long as the others. Break it into five tests based on run lines with the same version. >From e184c8ec9b25b3e077a42646775755dd3a4b449

[clang-tools-extra] [clang-tidy] Fix result check after overwriteChangedFiles() (PR #86360)

2024-03-22 Thread Mike Rice via cfe-commits
mikerice1969 wrote: > This could use a test. I thought about it, but I have no idea how to write that test. Do you have an idea? https://github.com/llvm/llvm-project/pull/86360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang-tools-extra] [clang-tidy] Fix result check after overwriteChangedFiles() (PR #86360)

2024-03-22 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/86360 If any return from overwriteChangedFiles is true some fixes were not applied. >From 492e0fc4e146d7321003470a9cd0b4be4ae39d7a Mon Sep 17 00:00:00 2001 From: Mike Rice Date: Fri, 22 Mar 2024 16:02:54 -0700 Su

[clang-tools-extra] [clang-tidy][NFC] Remove unnecessary nullptr check on cast subexpr (PR #85473)

2024-03-18 Thread Mike Rice via cfe-commits
mikerice1969 wrote: I mentioned the assert just to make the point that setSubExpr is written so it doesn't return a nullptr. So it is not expected and the deference is ok. I went ahead with this change but feel free to update if you like. But adding a return when nullptr is seen here would co

[clang-tools-extra] [clang-tidy][NFC] Remove unnecessary nullptr check on cast subexpr (PR #85473)

2024-03-18 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/85473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] Remove unnecessary nullptr check on cast subexpr (PR #85473)

2024-03-15 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/85473 The value of SubExpr is not null since getSubExpr would assert in that case. Remove the nullptr check. This avoids confusion since SubExpr is used without check later in the function. >From 56c3ca2e2cfac7b

[clang] [llvm] [openmp] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2024-02-28 Thread Mike Rice via cfe-commits
mikerice1969 wrote: Hi @josemonsalve2 if you want to help move this along it would be best to break this into at least three separate PRs. 1) Parsing/Sema/Serialization 2) CodeGen 3) Extension checking framework In whatever order makes sense to you. We've added several extension directives in o

[clang] [OpenMP] Move unsupported structured bindings diagnostic (PR #80216)

2024-02-01 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/80216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Move unsupported structured bindings diagnostic (PR #80216)

2024-01-31 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/80216 Move the diagnostic so it fires only when doing an OpenMP capture, not for non-OpenMP captures. This allows non-OpenMP code to work when using OpenMP elsewhere, such as the code reported in https://github.c

[clang] [NFC] Remove unneeded nullptr checks after cast<> (PR #74674)

2023-12-07 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/74674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Remove unneeded nullptr checks after cast<> (PR #74674)

2023-12-06 Thread Mike Rice via cfe-commits
@@ -6454,8 +6454,7 @@ ConstantAddress CodeGenModule::GetAddrOfGlobalTemporary( !EvalResult.hasSideEffects()) Value = &EvalResult.Val; - LangAS AddrSpace = - VD ? GetGlobalVarAddressSpace(VD) : MaterializedType.getAddressSpace(); mikerice1969 wr

[clang] [NFC] Remove unneeded nullptr checks after cast<> (PR #74674)

2023-12-06 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/74674 Since VD is assigned from a cast it cannot be a nullptr or it would have asserted. Remove the subsequent checks to clear up any misunderstanding. >From 6b3b456534c21a74f12ac022ee99365dd3831dec Mon Sep 17 00

[compiler-rt] [flang] [clang-tools-extra] [llvm] [clang] [libc] [libcxx] [C23] Complete support for WG14 N2508 (PR #71398)

2023-11-17 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 approved this pull request. LGTM. Thanks! https://github.com/llvm/llvm-project/pull/71398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Replace getAs with castAs, dyn_cast with cast (NFC) (PR #72600)

2023-11-17 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/72600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] Replace getAs with castAs, dyn_cast with cast (NFC) (PR #72600)

2023-11-16 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/72600 Make the code clear that nullptrs are not expected. >From da715ea17cd3a23894826eac8cc8f7cd880b5e02 Mon Sep 17 00:00:00 2001 From: Mike Rice Date: Thu, 16 Nov 2023 18:30:47 -0800 Subject: [PATCH] Replace get

[clang] [clang-tools-extra] [llvm] [compiler-rt] [flang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

2023-11-16 Thread Mike Rice via cfe-commits
@@ -359,16 +359,34 @@ static Attr *handleCodeAlignAttr(Sema &S, Stmt *St, const ParsedAttr &A) { static void CheckForDuplicateCodeAlignAttrs(Sema &S, const SmallVectorImpl &Attrs) { - const Attr *A = nullptr; - for (const auto *I : Attrs) { -

[clang] [CodeGen] Add conditional to module cloning in bitcode linking (PR #72478)

2023-11-16 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 approved this pull request. LGTM. It fixes the performance problems we were seeing. Thanks! https://github.com/llvm/llvm-project/pull/72478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [CodeGen] Implement post-opt linking option for builtin bitocdes (PR #69371)

2023-11-15 Thread Mike Rice via cfe-commits
@@ -48,428 +49,365 @@ #include "llvm/Support/ToolOutputFile.h" #include "llvm/Support/YAMLTraits.h" #include "llvm/Transforms/IPO/Internalize.h" +#include "llvm/Transforms/Utils/Cloning.h" -#include #include using namespace clang; using namespace llvm; #define DEBUG_T

[clang] [OpenMP] Add a missing 'const' (NFC) (PR #71596)

2023-11-07 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/71596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Add a missing 'const' (NFC) (PR #71596)

2023-11-07 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/71596 None >From 41f147c79a0a32fa541e7fb99cb2053b8f4b7ea2 Mon Sep 17 00:00:00 2001 From: Mike Rice Date: Tue, 7 Nov 2023 14:51:55 -0800 Subject: [PATCH] [OpenMP] Add a missing 'const' (NFC) --- clang/include/cl

[libc] [clang] [clang-tools-extra] [libcxx] [flang] [llvm] [compiler-rt] [C23] Complete support for WG14 N2508 (PR #71398)

2023-11-06 Thread Mike Rice via cfe-commits
@@ -32,8 +32,8 @@ T tmain(T argc) { } switch (argc) { #pragma omp error // expected-error {{ERROR}} - case 1: -#pragma omp error // expected-error {{ERROR}} + case 1: // FIXME: error without 'at execution' is not a stand-alone directive and so this should be accepted. --

[clang] Remove malformed brief commands in comments (NFC) (PR #70746)

2023-10-31 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/70746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 57caadc - [MSVC] Allow declaration of multi-dim 'property' array fields

2023-04-05 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2023-04-05T10:29:37-07:00 New Revision: 57caadc57a30f2279099e5b86bb555b4aab621ce URL: https://github.com/llvm/llvm-project/commit/57caadc57a30f2279099e5b86bb555b4aab621ce DIFF: https://github.com/llvm/llvm-project/commit/57caadc57a30f2279099e5b86bb555b4aab621ce.diff LOG

[clang] e716b02 - [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

2023-02-07 Thread Mike Rice via cfe-commits
Author: Fazlay Rabbi Date: 2023-02-07T12:09:52-08:00 New Revision: e716b0204a5ae2a96289a335b2ab30a6c3fb09cf URL: https://github.com/llvm/llvm-project/commit/e716b0204a5ae2a96289a335b2ab30a6c3fb09cf DIFF: https://github.com/llvm/llvm-project/commit/e716b0204a5ae2a96289a335b2ab30a6c3fb09cf.diff

[clang] d27fb5e - [Serialization] Add support for (de)serializing #pragma pack

2023-02-07 Thread Mike Rice via cfe-commits
Author: Dustin Howett Date: 2023-02-07T11:37:02-08:00 New Revision: d27fb5efc5f2086fa157e7d836b61bae4d5f3734 URL: https://github.com/llvm/llvm-project/commit/d27fb5efc5f2086fa157e7d836b61bae4d5f3734 DIFF: https://github.com/llvm/llvm-project/commit/d27fb5efc5f2086fa157e7d836b61bae4d5f3734.diff

[clang] c52053b - [clang] Fix buildbot failure in delayed-template-with-pragma.cpp

2022-11-29 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2022-11-29T11:53:37-08:00 New Revision: c52053bd9961cc1854e86958ffb0f89e2cfe4e5f URL: https://github.com/llvm/llvm-project/commit/c52053bd9961cc1854e86958ffb0f89e2cfe4e5f DIFF: https://github.com/llvm/llvm-project/commit/c52053bd9961cc1854e86958ffb0f89e2cfe4e5f.diff LOG

[clang] 530eb26 - [clang] Add serialization for loop hint annotation tokens

2022-11-29 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2022-11-29T10:51:11-08:00 New Revision: 530eb263c0ec02fe8d107cbdb41ac6e482514a00 URL: https://github.com/llvm/llvm-project/commit/530eb263c0ec02fe8d107cbdb41ac6e482514a00 DIFF: https://github.com/llvm/llvm-project/commit/530eb263c0ec02fe8d107cbdb41ac6e482514a00.diff LOG

[clang] 56c1660 - [OpenMP] Initial parsing/sema for 'strict' modifier with 'num_tasks' clause

2022-11-18 Thread Mike Rice via cfe-commits
Author: Fazlay Rabbi Date: 2022-11-18T16:26:47-08:00 New Revision: 56c166017055595a9f26933e85bfd89e30c528d0 URL: https://github.com/llvm/llvm-project/commit/56c166017055595a9f26933e85bfd89e30c528d0 DIFF: https://github.com/llvm/llvm-project/commit/56c166017055595a9f26933e85bfd89e30c528d0.diff

[clang] ab9eac7 - [OpenMP] Initial parsing/sema for 'strict' modifier with 'grainsize' clause

2022-11-17 Thread Mike Rice via cfe-commits
Author: Fazlay Rabbi Date: 2022-11-17T20:59:07-08:00 New Revision: ab9eac762c35068e77f57795e660d06f578c9614 URL: https://github.com/llvm/llvm-project/commit/ab9eac762c35068e77f57795e660d06f578c9614 DIFF: https://github.com/llvm/llvm-project/commit/ab9eac762c35068e77f57795e660d06f578c9614.diff

[clang] c954cfe - Some uses of the preprocessor can result in multiple target regions on the

2022-11-04 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2022-11-04T12:54:22-07:00 New Revision: c954cfeb57a1c8c0996a34da64243bc7f7fe1107 URL: https://github.com/llvm/llvm-project/commit/c954cfeb57a1c8c0996a34da64243bc7f7fe1107 DIFF: https://github.com/llvm/llvm-project/commit/c954cfeb57a1c8c0996a34da64243bc7f7fe1107.diff LOG

[clang] 129904d - [OpenMP][NFC] Use OMPInteropInfo in the OMPDeclareVariantAttr attribute

2022-08-22 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2022-08-22T10:41:16-07:00 New Revision: 129904d5041ffad13747fd0ad77e44050d6c6aaa URL: https://github.com/llvm/llvm-project/commit/129904d5041ffad13747fd0ad77e44050d6c6aaa DIFF: https://github.com/llvm/llvm-project/commit/129904d5041ffad13747fd0ad77e44050d6c6aaa.diff LOG

[clang] 89167e3 - [OpenMP][NFC] Refactor code for interop parts of 'init' and 'append_args' clauses

2022-08-18 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2022-08-18T17:13:30-07:00 New Revision: 89167e3c5b008b44f1fa8a222652e7bdc62cfa8a URL: https://github.com/llvm/llvm-project/commit/89167e3c5b008b44f1fa8a222652e7bdc62cfa8a DIFF: https://github.com/llvm/llvm-project/commit/89167e3c5b008b44f1fa8a222652e7bdc62cfa8a.diff LOG

[clang] dd4c838 - [OpenMP] Allow data members in interop init/use/destroy clauses

2022-08-11 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2022-08-11T09:39:12-07:00 New Revision: dd4c838da30ad4b6d5dc0f700df0a6629469f719 URL: https://github.com/llvm/llvm-project/commit/dd4c838da30ad4b6d5dc0f700df0a6629469f719 DIFF: https://github.com/llvm/llvm-project/commit/dd4c838da30ad4b6d5dc0f700df0a6629469f719.diff LOG

[clang] a35141d - [OpenMP] Add handling cases when filter(tid) appears with default(none)

2022-06-22 Thread Mike Rice via cfe-commits
Author: Fazlay Rabbi Date: 2022-06-22T17:45:43-07:00 New Revision: a35141d395019c837d16419c6ef57662a6efefc5 URL: https://github.com/llvm/llvm-project/commit/a35141d395019c837d16419c6ef57662a6efefc5 DIFF: https://github.com/llvm/llvm-project/commit/a35141d395019c837d16419c6ef57662a6efefc5.diff

[clang] 48d6a6c - [OpenMP][NFC] update status for 'omp_all_memory' directive to 'done'

2022-06-02 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2022-06-02T17:31:33-07:00 New Revision: 48d6a6c9add90f3684de362907d5f05a0988244a URL: https://github.com/llvm/llvm-project/commit/48d6a6c9add90f3684de362907d5f05a0988244a DIFF: https://github.com/llvm/llvm-project/commit/48d6a6c9add90f3684de362907d5f05a0988244a.diff LOG

[clang] 0a5cfbf - [OpenMP] Use the align clause value from 'omp allocate' for globals

2022-05-26 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2022-05-26T09:51:48-07:00 New Revision: 0a5cfbf7b2e82e7980b66428e88b4e28e814d7bb URL: https://github.com/llvm/llvm-project/commit/0a5cfbf7b2e82e7980b66428e88b4e28e814d7bb DIFF: https://github.com/llvm/llvm-project/commit/0a5cfbf7b2e82e7980b66428e88b4e28e814d7bb.diff LOG

[clang] ba3f853 - [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'

2022-05-25 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2022-05-25T10:34:07-07:00 New Revision: ba3f85390bde10eab1cbdb68f744b8f5ab31859b URL: https://github.com/llvm/llvm-project/commit/ba3f85390bde10eab1cbdb68f744b8f5ab31859b DIFF: https://github.com/llvm/llvm-project/commit/ba3f85390bde10eab1cbdb68f744b8f5ab31859b.diff LOG

[clang] 9ba9371 - [OpenMP] Add parsing/sema support for omp_all_memory reserved locator

2022-05-24 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2022-05-24T10:28:59-07:00 New Revision: 9ba937112fa6d4076e4a98b587a334786b6c0d9c URL: https://github.com/llvm/llvm-project/commit/9ba937112fa6d4076e4a98b587a334786b6c0d9c DIFF: https://github.com/llvm/llvm-project/commit/9ba937112fa6d4076e4a98b587a334786b6c0d9c.diff LOG

[clang] 0d67c8a - [OpenMP] Fix declare simd use on in-class member template function

2022-05-13 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2022-05-13T08:24:55-07:00 New Revision: 0d67c8a51d61cb0fac91f265a424767f072c7d5c URL: https://github.com/llvm/llvm-project/commit/0d67c8a51d61cb0fac91f265a424767f072c7d5c DIFF: https://github.com/llvm/llvm-project/commit/0d67c8a51d61cb0fac91f265a424767f072c7d5c.diff LOG

[clang] 772b0c4 - [OpenMP] Fix mangling for linear parameters with negative stride

2022-05-11 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2022-05-11T14:02:09-07:00 New Revision: 772b0c44a4296a34cbc072c2a7cf294410d07a1a URL: https://github.com/llvm/llvm-project/commit/772b0c44a4296a34cbc072c2a7cf294410d07a1a DIFF: https://github.com/llvm/llvm-project/commit/772b0c44a4296a34cbc072c2a7cf294410d07a1a.diff LOG

[clang] 0dbaef6 - [OpenMP] Fix mangling for linear modifiers with variable stride

2022-05-10 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2022-05-10T14:12:44-07:00 New Revision: 0dbaef61b56f0ef0ab0cf38ea92ffc1f35bee3ff URL: https://github.com/llvm/llvm-project/commit/0dbaef61b56f0ef0ab0cf38ea92ffc1f35bee3ff DIFF: https://github.com/llvm/llvm-project/commit/0dbaef61b56f0ef0ab0cf38ea92ffc1f35bee3ff.diff LOG

[clang] 1a02519 - [OpenMP] Add mangling support for linear modifiers (ref,uval,val)

2022-05-10 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2022-05-10T09:56:55-07:00 New Revision: 1a02519bc504a12a12ba875db29c9e5901ed9bef URL: https://github.com/llvm/llvm-project/commit/1a02519bc504a12a12ba875db29c9e5901ed9bef DIFF: https://github.com/llvm/llvm-project/commit/1a02519bc504a12a12ba875db29c9e5901ed9bef.diff LOG

[clang] 37471cf - [clang][OpenMP] Local variable alignment incorrect with align clause

2022-05-03 Thread Mike Rice via cfe-commits
Author: David Pagan Date: 2022-05-03T13:10:01-07:00 New Revision: 37471cf2c3fd02fac0b0dc6e513cfe6098f37764 URL: https://github.com/llvm/llvm-project/commit/37471cf2c3fd02fac0b0dc6e513cfe6098f37764 DIFF: https://github.com/llvm/llvm-project/commit/37471cf2c3fd02fac0b0dc6e513cfe6098f37764.diff L

[clang] f82ec55 - [OpenMP] Initial parsing/sema for the 'omp target parallel loop' construct

2022-03-24 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2022-03-24T09:19:00-07:00 New Revision: f82ec5532b2f303732e547226816d7a668db3050 URL: https://github.com/llvm/llvm-project/commit/f82ec5532b2f303732e547226816d7a668db3050 DIFF: https://github.com/llvm/llvm-project/commit/f82ec5532b2f303732e547226816d7a668db3050.diff LOG

  1   2   >