[PATCH] D62391: [CodeComplete] Complete 'return true/false' in boolean functions

2019-05-28 Thread Mike Lothian via Phabricator via cfe-commits
FireBurn added a comment. Sorry for the noise, I'll do a bisect Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62391/new/ https://reviews.llvm.org/D62391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D62391: [CodeComplete] Complete 'return true/false' in boolean functions

2019-05-27 Thread Mike Lothian via Phabricator via cfe-commits
FireBurn added a comment. Could this commit be causing the following build failure of Chromium, this same version build a few days ago with clang from git: FAILED: obj/third_party/blink/renderer/bindings/core/v8/bindings_core_impl/v8_feature_policy.o clang++ -MMD -MF obj/third_party/blink/rend

[PATCH] D42742: [clangd] Use pthread instead of thread_local to support more runtimes.

2018-02-06 Thread Mike Lothian via Phabricator via cfe-commits
FireBurn added a comment. This breaks compilation for me on Gentoo's clang-.ebuild The following patch fixes things for me commit a4c071b16bbbc84bbb96d90b51bed8a12127 (HEAD -> master) Author: Mike Lothian Date: Tue Feb 6 09:55:41 2018 + [clangd] Fix include to use C