[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

2020-01-28 Thread Michael via Phabricator via cfe-commits
Alundra added a comment. @Wawha In the same style of this missing feature, I think you are also aware of the miss of clang-format about struct/array initializer like: https://bugs.llvm.org/show_bug.cgi?id=40411 Basically to have the break for braces after the '=' of the struct/array initializer

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

2019-12-29 Thread Michael via Phabricator via cfe-commits
Alundra added a comment. Please review and consider a merge of this change which looks to not have news since long time. It's useful for a lot of people and it's awesome that there is a ready or almost ready patchset about it. Thanks a lot! CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D29944: libclang: Print namespaces for typedefs and type aliases

2017-03-10 Thread Michael via Phabricator via cfe-commits
redm123 added a comment. I guess so. I don't think I'm allowed to commit. So I would appreciate it. Which release version would that be in? 4.1 I guess? Thanks for your help! https://reviews.llvm.org/D29944 ___ cfe-commits mailing list cfe-commits

[PATCH] D29944: libclang: Print namespaces for typedefs and type aliases

2017-03-02 Thread Michael via Phabricator via cfe-commits
redm123 added a comment. Any idea how to continue with that? Should I add another reviewer? Whom? https://reviews.llvm.org/D29944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29944: libclang: Print namespaces for typedefs and type aliases

2017-02-20 Thread Michael via Phabricator via cfe-commits
redm123 added inline comments. Comment at: test/Misc/diag-template-diffing.cpp:27 // CHECK-ELIDE-NOTREE: no matching function for call to 'f' -// CHECK-ELIDE-NOTREE: candidate function not viable: no known conversion from 'vector' to 'vector' for 1st argument +// CHECK-ELIDE-NO

[PATCH] D29944: libclang: Print namespaces for typedefs and type aliases

2017-02-20 Thread Michael via Phabricator via cfe-commits
redm123 added inline comments. Comment at: test/Misc/diag-template-diffing.cpp:27 // CHECK-ELIDE-NOTREE: no matching function for call to 'f' -// CHECK-ELIDE-NOTREE: candidate function not viable: no known conversion from 'vector' to 'vector' for 1st argument +// CHECK-ELIDE-NO

[PATCH] D29944: libclang: Print namespaces for typedefs and type aliases

2017-02-16 Thread Michael via Phabricator via cfe-commits
redm123 added a comment. In https://reviews.llvm.org/D29944#678033, @arphaman wrote: > Do these diagnostics have the full qualifiers for errors that occur with > record types instead of typedefs? Not sure what you mean by that, but as far as I can see all the changed errors refer to typedefs/

[PATCH] D29944: libclang: Print namespaces for typedefs and type aliases

2017-02-14 Thread Michael via Phabricator via cfe-commits
redm123 created this revision. Printing typedefs or type aliases using clang_getTypeSpelling() is missing the namespace they are defined in. This is in contrast to other types that always yield the full typename including namespaces. https://reviews.llvm.org/D29944 Files: lib/AST/TypePrinte