r307201 - Fix one more reference to lit.util.capture()

Author: mzolotukhin Date: Wed Jul 5 14:06:11 2017 New Revision: 307201 URL: http://llvm.org/viewvc/llvm-project?rev=307201&view=rev Log: Fix one more reference to lit.util.capture() The capture method was removed in r306643. Modified: cfe/trunk/utils/perf-training/lit.cfg cfe/trunk/util

Re: [PATCH] D19544: Pass for translating math intrinsics to math library calls.

mzolotukhin accepted this revision. mzolotukhin added a comment. This revision is now accepted and ready to land. LGTM with a small nit: could you please run `opt -instnamer` on your test (it'll replace `%0`, `%1`,... with `%tmp0`, `%tmp1` etc, making it easier to modify test in future)? Thanks

Re: [PATCH] D17976: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

> On Mar 8, 2016, at 5:44 PM, Roman Levenstein via cfe-commits > wrote: > > Forgot to add the mailing list when I created a patch. You don’t have cfe-commits in phabricator subscribers, so you probably won’t get notifications when someone replies there. It might make sense to resubmit the pat

Re: [libcxx] r249929 - Split out of .

, Eric Fiselier > <mailto:e...@efcs.ca>> wrote: >> >> Hi Michael, >> >> Sorry I'm holding this patch up in review. The fix is quite "novel" and I >> want to make sure we get it right. If we can't land it over the weekend I'll >

Re: [libcxx] r249929 - Split out of .

> want to make sure we get it right. If we can't land it over the weekend I'll > ask Richard to revert while we work on it. > > /Eric > > On Oct 23, 2015 10:13 PM, "Michael Zolotukhin via cfe-commits" > mailto:cfe-commits@lists.llvm.org>> wrote: &g

Re: [libcxx] r249929 - Split out of .

weekend I'll > ask Richard to revert while we work on it. > > /Eric > > On Oct 23, 2015 10:13 PM, "Michael Zolotukhin via cfe-commits" > mailto:cfe-commits@lists.llvm.org>> wrote: > Hi Richard, > > Is this patch ready for commit, or were you just ch

Re: [libcxx] r249929 - Split out of .

Hi Richard, Is this patch ready for commit, or were you just checking an idea? Our bots are still failing to build povray, so we’re really looking forward for some fix:) Thanks, Michael > On Oct 15, 2015, at 6:21 PM, Manman Ren via cfe-commits > wrote: > >> >> On Oct 15, 2015, at 1:41 PM, R

Re: [PATCH] D12821: Allow for C's "writing off the end" idiom in __builtin_object_size

mzolotukhin added a comment. FWIW, I'm really interested in seeing this patch in! Thanks, Michael http://reviews.llvm.org/D12821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

mzolotukhin abandoned this revision. mzolotukhin added a comment. We decided to go with an alternative way - with builtins instead of type attributes. The corresponding patch is http://reviews.llvm.org/D12313, and it's already reviewed and committed. http://reviews.llvm.org/D12221 _

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

mzolotukhin added a comment. Thanks, committed in r247374 with the requested changes! Michael Repository: rL LLVM http://reviews.llvm.org/D12785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247374: Docs: Document __builtin_nontemporal_load and __builtin_nontemporal_store. (authored by mzolotukhin). Changed prior to commit: http://reviews.llvm.org/D12785?vs=34521&id=34524#toc Repository:

r247374 - Docs: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

Author: mzolotukhin Date: Thu Sep 10 21:01:15 2015 New Revision: 247374 URL: http://llvm.org/viewvc/llvm-project?rev=247374&view=rev Log: Docs: Document __builtin_nontemporal_load and __builtin_nontemporal_store. Summary: In r247104 I added the builtins for generating non-temporal memory operatio

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

mzolotukhin updated this revision to Diff 34521. mzolotukhin added a comment. - Remove paragraph about changing program behavior (since we shouldn't change it anyway). http://reviews.llvm.org/D12785 Files: docs/LanguageExtensions.rst Index: docs/LanguageExtensions.rst ==

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

mzolotukhin added inline comments. Comment at: docs/LanguageExtensions.rst:1802-1807 @@ +1801,8 @@ + +For example, on AArch64 in the following code:: + + LDR X1, [X2] + LDNP X3, X4, [X1] + +the ``LDNP`` might be executed before the ``LDR``. In this case the load would +be perfor

r247360 - Docs: Add missing new line before a list.

Author: mzolotukhin Date: Thu Sep 10 18:56:10 2015 New Revision: 247360 URL: http://llvm.org/viewvc/llvm-project?rev=247360&view=rev Log: Docs: Add missing new line before a list. Modified: cfe/trunk/docs/LanguageExtensions.rst Modified: cfe/trunk/docs/LanguageExtensions.rst URL: http://llv

[PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

mzolotukhin created this revision. mzolotukhin added reviewers: hfinkel, rsmith. mzolotukhin added a subscriber: cfe-commits. In r247104 I added the builtins for generating non-temporal memory operations, but now I realized that they lack documentation. This patch adds some. http://reviews.llvm.o

Re: [PATCH] D12313: Introduce __builtin_nontemporal_store and __builtin_nontemporal_load.

mzolotukhin added a comment. Thanks, Hal, Richard! I committed the patch with requested changes in r247107. Michael Repository: rL LLVM http://reviews.llvm.org/D12313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: [PATCH] D12313: Introduce __builtin_nontemporal_store and __builtin_nontemporal_load.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247104: Introduce __builtin_nontemporal_store and __builtin_nontemporal_load. (authored by mzolotukhin). Changed prior to commit: http://reviews.llvm.org/D12313?vs=33492&id=34281#toc Repository: rL L

r247104 - Introduce __builtin_nontemporal_store and __builtin_nontemporal_load.

Author: mzolotukhin Date: Tue Sep 8 18:52:33 2015 New Revision: 247104 URL: http://llvm.org/viewvc/llvm-project?rev=247104&view=rev Log: Introduce __builtin_nontemporal_store and __builtin_nontemporal_load. Summary: Currently clang provides no general way to generate nontemporal loads/stores. Th

Re: [PATCH] D12313: Introduce __builtin_nontemporal_store and __builtin_nontemporal_load.

mzolotukhin added a comment. Hi Richard, Hal, Does the patch look good now? Thanks, Michael http://reviews.llvm.org/D12313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12313: Introduce __builtin_nontemporal_store and __builtin_nontemporal_load.

mzolotukhin added a comment. Gentle ping. http://reviews.llvm.org/D12313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12313: Introduce __builtin_nontemporal_store and __builtin_nontemporal_load.

mzolotukhin added a comment. Hi Hal, I added `Nontemporal` field to LValue and started to use it in `EmitStoreOfScalar`/`EmitLoadOfScalar`. Does it look like something you had in mind? Thanks, Michael http://reviews.llvm.org/D12313 ___ cfe-commi

Re: [PATCH] D12313: Introduce __builtin_nontemporal_store and __builtin_nontemporal_load.

mzolotukhin updated this revision to Diff 33492. mzolotukhin added a comment. - Use EmitStoreOfScalar and EmitLoadOfScalar for generating nontemporal loads and stores. - Rebase on TOT. http://reviews.llvm.org/D12313 Files: include/clang/Basic/Builtins.def include/clang/Basic/DiagnosticSema

Re: [PATCH] D12313: Introduce __builtin_nontemporal_store and __builtin_nontemporal_load.

mzolotukhin added a comment. > I still have this question: Oops, sorry - I missed that. I'll check how can we reuse that logic. Thanks, Michael http://reviews.llvm.org/D12313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

Re: [PATCH] D12313: Introduce __builtin_nontemporal_store and __builtin_nontemporal_load.

mzolotukhin added a comment. Hi Richard, Hal, and others, I updated the patch according to review remarks - now we support vector and boolean types too! Could you please take a look? Thanks, Michael Comment at: lib/CodeGen/CGBuiltin.cpp:128-129 @@ +127,4 @@ + Val = CGF.EmitT

Re: [PATCH] D12313: Introduce __builtin_nontemporal_store and __builtin_nontemporal_load.

mzolotukhin updated this revision to Diff 33396. mzolotukhin added a comment. Address review remarks: - Remove typed versions - indeed, we don't need them. - Allow vector types. - Properly handle bool-type (promote i1 to i8). - Check arguments number. - Simplify SemaBuiltinNontemporalOverloaded (

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

mzolotukhin added a comment. Hi, I implemented builtin-based version in http://reviews.llvm.org/D12313 - could you please take a look? Thanks, Michael http://reviews.llvm.org/D12221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D12313: Introduce __builtin_nontemporal_store and __builtin_nontemporal_load.

mzolotukhin created this revision. mzolotukhin added reviewers: rsmith, aaron.ballman, doug.gregor, t.p.northover, ab, mcrosier, hfinkel, majnemer. mzolotukhin added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Currently clang provides no general way to generate nontemporal loa

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

mzolotukhin added a comment. Thanks for the feedback everyone! I think at this point I'll try to return to builtins then. In my original patch I didn't have type overloading, so I'll need some time to add this. We can return back to type attributes later if we'd like to. And do I understand it

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

mzolotukhin added a comment. Oh, I see. So, you meant something like this? void foo(std::vector av, float * b, int N) { for (auto a: av) // << `a` doesn't have nontemporal attribute here for (int i = 0; i < N; i++) a[i] = b[i]+1; } One can easily work around it by usi

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

mzolotukhin added a comment. Hi all, Thanks for the feedback, please find my answers below: > What does it mean to have the attribute applied to non-pointer types like int > __attribute__((nontemporal)) i; ? The ACLE doesn't say but making it > erroneous might make sense. Perhaps it would be g

[PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

mzolotukhin created this revision. mzolotukhin added reviewers: hfinkel, doug.gregor, t.p.northover, ab, mcrosier. mzolotukhin added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Currently there is no way to generate nontemporal memory accesses for some architectures, e.g. for AA