[PATCH] D106349: [clang-format] respect AfterEnum for enums

2021-07-31 Thread Michael Zimmermann via Phabricator via cfe-commits
m1cha added a comment. Well it's pretty much exactly the same except for the change in `ShouldBreakBeforeBrace`. Somebody with more knowledge about clang-format than me should try to figure out why it's not needed. If it's actually not needed than this change does not need to be merged. CHANG

[PATCH] D106349: [clang-format] respect AfterEnum for enums

2021-07-29 Thread Michael Zimmermann via Phabricator via cfe-commits
m1cha added a comment. I don't have commit access. How does that even work? The documentation is very scarce about this but for security reasons I'd expect there to be a very limited set of people with commit access Here's my author info: `Michael Zimmermann ` CHANGES SINCE LAST ACTION http

[PATCH] D106349: [clang-format] respect AfterEnum for enums

2021-07-25 Thread Michael Zimmermann via Phabricator via cfe-commits
m1cha updated this revision to Diff 361493. m1cha added a comment. I've added a note to `ReleaseNotes.rst` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106349/new/ https://reviews.llvm.org/D106349 Files: clang/docs/ReleaseNotes.rst clang/lib/Format/UnwrappedLineParser.cpp clang/

[PATCH] D106349: [clang-format] respect AfterEnum for enums

2021-07-23 Thread Michael Zimmermann via Phabricator via cfe-commits
m1cha added a comment. In D106349#2897400 , @HazardyKnusperkeks wrote: > Looks good, could you also add a note in the relasenotes.rst? Sure Can I do something about the failing unittests? I don't know how they are related to the changes I made. CHAN

[PATCH] D106349: [clang-format] respect AfterEnum for enums

2021-07-22 Thread Michael Zimmermann via Phabricator via cfe-commits
m1cha updated this revision to Diff 360776. m1cha edited the summary of this revision. m1cha added a comment. - rebased to `main` - fixed the test `IndentAccessModifiers` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106349/new/ https://reviews.llvm.org/D106349 Files: clang/lib/Forma

[PATCH] D106349: [clang-format] respect AfterEnum for enums

2021-07-20 Thread Michael Zimmermann via Phabricator via cfe-commits
m1cha added a comment. I just noticed that phabricator strips the commit message so here it is: There is some similar looking code in `TokenAnnotator.cpp` but given that I've never worked on clang-format before I don't know what the purpose of that code is and how it's related to `UnwrappedLinePa

[PATCH] D106349: [clang-format] respect AfterEnum for enums

2021-07-20 Thread Michael Zimmermann via Phabricator via cfe-commits
m1cha created this revision. m1cha added a reviewer: MyDeveloperDay. m1cha requested review of this revision. Herald added a project: clang. See the commit message for more details. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106349 Files: clang/lib/Format/UnwrappedLinePa