mdtoguchi wrote:
> also:
>
> ```
> clang/lib/Driver/ToolChains/SYCL.h:27:17: warning: private field 'D' is not
> used [-Wunused-private-field]
> ```
@jroelofs, these should be addressed with
https://github.com/llvm/llvm-project/pull/121822
https://github.com/llvm/llvm-project/pull/117268
___
@@ -17,8 +17,7 @@ using namespace llvm::opt;
SYCLInstallationDetector::SYCLInstallationDetector(
const Driver &D, const llvm::Triple &HostTriple,
-const llvm::opt::ArgList &Args)
-: D(D) {}
+const llvm::opt::ArgList &Args) {}
mdtoguchi wrote:
mdtoguchi wrote:
Thanks @vitalybuka, makes sense to use the literal type here.
https://github.com/llvm/llvm-project/pull/121822
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mdtoguchi updated
https://github.com/llvm/llvm-project/pull/121822
>From 92796278b87c5713a0cf16119009c07f87568df5 Mon Sep 17 00:00:00 2001
From: Michael D Toguchi
Date: Mon, 6 Jan 2025 11:42:12 -0800
Subject: [PATCH 1/2] Driver][SYCL] Address sanitizer and test issue
The fol
mdtoguchi wrote:
I have posted a fix to address the sanitizer builds and build warning:
https://github.com/llvm/llvm-project/pull/121822
https://github.com/llvm/llvm-project/pull/117268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
https://github.com/mdtoguchi created
https://github.com/llvm/llvm-project/pull/121822
The following commit:
https://github.com/llvm/llvm-project/commit/d00f65c6acd9f0e1ddae83391f55eb9d232d2f9e
Caused sanitizer build issues and also a test issue when using %clang_cl.
Address these problems.
https://github.com/mdtoguchi updated
https://github.com/llvm/llvm-project/pull/117268
>From 3fdc74687dbf6da831a1c27995d9d7fef3a2a51f Mon Sep 17 00:00:00 2001
From: Michael Toguchi
Date: Fri, 15 Nov 2024 05:14:21 -0700
Subject: [PATCH 01/10] Reland - [Driver][SYCL] Add initial SYCL offload
comp
https://github.com/mdtoguchi updated
https://github.com/llvm/llvm-project/pull/117268
>From 3fdc74687dbf6da831a1c27995d9d7fef3a2a51f Mon Sep 17 00:00:00 2001
From: Michael Toguchi
Date: Fri, 15 Nov 2024 05:14:21 -0700
Subject: [PATCH 1/9] Reland - [Driver][SYCL] Add initial SYCL offload
compil
@@ -630,6 +630,11 @@ void toolchains::MinGW::AddHIPIncludeArgs(const ArgList
&DriverArgs,
RocmInstallation->AddHIPIncludeArgs(DriverArgs, CC1Args);
}
+void toolchains::MinGW::addSYCLIncludeArgs(const ArgList &DriverArgs,
+ ArgString
mdtoguchi wrote:
@MaskRay - thank you for the review. I have made the updates as suggested,
please have another look when time permits.
https://github.com/llvm/llvm-project/pull/117268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
https://github.com/mdtoguchi edited
https://github.com/llvm/llvm-project/pull/117268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mdtoguchi edited
https://github.com/llvm/llvm-project/pull/117268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mdtoguchi edited
https://github.com/llvm/llvm-project/pull/117268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mdtoguchi updated
https://github.com/llvm/llvm-project/pull/117268
>From 3fdc74687dbf6da831a1c27995d9d7fef3a2a51f Mon Sep 17 00:00:00 2001
From: Michael Toguchi
Date: Fri, 15 Nov 2024 05:14:21 -0700
Subject: [PATCH 1/7] Reland - [Driver][SYCL] Add initial SYCL offload
compil
mdtoguchi wrote:
Ping
https://github.com/llvm/llvm-project/pull/117268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,179 @@
+//===--- SYCL.cpp - SYCL Tool and ToolChain Implementations -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -6591,6 +6681,18 @@ const ToolChain &Driver::getOffloadingDeviceToolChain(
HostTC, Args);
break;
}
+case Action::OFK_SYCL:
+ switch (Target.getArch()) {
+ case llvm::Triple::spir:
+ case
https://github.com/mdtoguchi updated
https://github.com/llvm/llvm-project/pull/117268
>From 3fdc74687dbf6da831a1c27995d9d7fef3a2a51f Mon Sep 17 00:00:00 2001
From: Michael Toguchi
Date: Fri, 15 Nov 2024 05:14:21 -0700
Subject: [PATCH 1/4] Reland - [Driver][SYCL] Add initial SYCL offload
compil
mdtoguchi wrote:
Ping
https://github.com/llvm/llvm-project/pull/117268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mdtoguchi updated
https://github.com/llvm/llvm-project/pull/117268
>From 3fdc74687dbf6da831a1c27995d9d7fef3a2a51f Mon Sep 17 00:00:00 2001
From: Michael Toguchi
Date: Fri, 15 Nov 2024 05:14:21 -0700
Subject: [PATCH 1/2] Reland - [Driver][SYCL] Add initial SYCL offload
compil
@@ -0,0 +1,179 @@
+//===--- SYCL.cpp - SYCL Tool and ToolChain Implementations -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,179 @@
+//===--- SYCL.cpp - SYCL Tool and ToolChain Implementations -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -6591,6 +6681,18 @@ const ToolChain &Driver::getOffloadingDeviceToolChain(
HostTC, Args);
break;
}
+case Action::OFK_SYCL:
+ switch (Target.getArch()) {
+ case llvm::Triple::spir:
+ case
@@ -6782,16 +6783,21 @@ defm : FlangIgnoredDiagOpt<"frontend-loop-interchange">;
defm : FlangIgnoredDiagOpt<"target-lifetime">;
// C++ SYCL options
+let Group = sycl_Group in {
def fsycl : Flag<["-"], "fsycl">,
- Visibility<[ClangOption, CLOption]>,
- Group, HelpText<"Enabl
https://github.com/mdtoguchi created
https://github.com/llvm/llvm-project/pull/117268
…(#107493)
Introduces the SYCL based toolchain and initial toolchain construction when
using the '-fsycl' option. This option will enable SYCL based offloading,
creating a SPIR-V based IR file packaged into
@@ -0,0 +1,183 @@
+//===--- SYCL.cpp - SYCL Tool and ToolChain Implementations -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,183 @@
+//===--- SYCL.cpp - SYCL Tool and ToolChain Implementations -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
mdtoguchi wrote:
Thanks @AaronBallman. I'll look into it.
https://github.com/llvm/llvm-project/pull/107493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mdtoguchi wrote:
Ping
https://github.com/llvm/llvm-project/pull/107493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mdtoguchi wrote:
Ping
https://github.com/llvm/llvm-project/pull/107493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mdtoguchi updated
https://github.com/llvm/llvm-project/pull/107493
>From 411203429a789330f044d6d7b2c0216cf21d816b Mon Sep 17 00:00:00 2001
From: Michael D Toguchi
Date: Thu, 29 Aug 2024 16:39:42 -0700
Subject: [PATCH 1/9] [Driver][SYCL] Add initial SYCL offload compilation
s
https://github.com/mdtoguchi updated
https://github.com/llvm/llvm-project/pull/107493
>From 411203429a789330f044d6d7b2c0216cf21d816b Mon Sep 17 00:00:00 2001
From: Michael D Toguchi
Date: Thu, 29 Aug 2024 16:39:42 -0700
Subject: [PATCH 1/9] [Driver][SYCL] Add initial SYCL offload compilation
s
@@ -0,0 +1,184 @@
+//===--- SYCL.cpp - SYCL Tool and ToolChain Implementations -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/mdtoguchi updated
https://github.com/llvm/llvm-project/pull/107493
>From 411203429a789330f044d6d7b2c0216cf21d816b Mon Sep 17 00:00:00 2001
From: Michael D Toguchi
Date: Thu, 29 Aug 2024 16:39:42 -0700
Subject: [PATCH 1/8] [Driver][SYCL] Add initial SYCL offload compilation
s
mdtoguchi wrote:
Thanks for the review @bader, I have made updates and hope to have addressed
your concerns.
https://github.com/llvm/llvm-project/pull/107493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/mdtoguchi updated
https://github.com/llvm/llvm-project/pull/107493
>From 411203429a789330f044d6d7b2c0216cf21d816b Mon Sep 17 00:00:00 2001
From: Michael D Toguchi
Date: Thu, 29 Aug 2024 16:39:42 -0700
Subject: [PATCH 1/7] [Driver][SYCL] Add initial SYCL offload compilation
s
https://github.com/mdtoguchi updated
https://github.com/llvm/llvm-project/pull/107493
>From 411203429a789330f044d6d7b2c0216cf21d816b Mon Sep 17 00:00:00 2001
From: Michael D Toguchi
Date: Thu, 29 Aug 2024 16:39:42 -0700
Subject: [PATCH 1/6] [Driver][SYCL] Add initial SYCL offload compilation
s
@@ -767,6 +768,27 @@ Driver::OpenMPRuntimeKind Driver::getOpenMPRuntime(const
ArgList &Args) const {
return RT;
}
+static const char *getDefaultSYCLArch(Compilation &C) {
+ // If -fsycl is supplied we will assume SPIR-V
+ if (C.getDefaultToolChain().getTriple().getArch()
mdtoguchi wrote:
@bader, thanks for adding the SYCL label, can you also take a look at this PR?
https://github.com/llvm/llvm-project/pull/107493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
mdtoguchi wrote:
Ping
https://github.com/llvm/llvm-project/pull/107493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mdtoguchi wrote:
Hello - any additional feedback on this?
https://github.com/llvm/llvm-project/pull/107493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mdtoguchi updated
https://github.com/llvm/llvm-project/pull/107493
>From 411203429a789330f044d6d7b2c0216cf21d816b Mon Sep 17 00:00:00 2001
From: Michael D Toguchi
Date: Thu, 29 Aug 2024 16:39:42 -0700
Subject: [PATCH 1/4] [Driver][SYCL] Add initial SYCL offload compilation
s
@@ -5116,15 +5123,39 @@ void Clang::ConstructJob(Compilation &C, const
JobAction &JA,
if (const Arg *PF = Args.getLastArg(options::OPT_mprintf_kind_EQ))
PF->claim();
- if (Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false)) {
+ Arg *SYCLStdArg = Args.getLa
https://github.com/mdtoguchi updated
https://github.com/llvm/llvm-project/pull/107493
>From 411203429a789330f044d6d7b2c0216cf21d816b Mon Sep 17 00:00:00 2001
From: Michael D Toguchi
Date: Thu, 29 Aug 2024 16:39:42 -0700
Subject: [PATCH 1/3] [Driver][SYCL] Add initial SYCL offload compilation
s
@@ -0,0 +1,82 @@
+//===--- SYCL.h - SYCL ToolChain Implementations *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,77 @@
+///
+/// Perform several driver tests for SYCL offloading for JIT
+///
+
+/// Check the phases graph with -fsycl. Use of -fsycl enables offload
+// RUN: %clang -ccc-print-phases --target=x86_64-unknown-linux-gnu \
+// RUN: -fsycl %s 2>&1 \
+// RUN: | FileCheck
@@ -0,0 +1,202 @@
+//===--- SYCL.cpp - SYCL Tool and ToolChain Implementations -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -5116,15 +5123,39 @@ void Clang::ConstructJob(Compilation &C, const
JobAction &JA,
if (const Arg *PF = Args.getLastArg(options::OPT_mprintf_kind_EQ))
PF->claim();
- if (Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false)) {
+ Arg *SYCLStdArg = Args.getLa
https://github.com/mdtoguchi created
https://github.com/llvm/llvm-project/pull/107493
Introduces the SYCL based toolchain and initial toolchain construction when
using the '-fsycl' option. This option will enable SYCL based offloading,
creating a SPIR-V based IR file packaged into the compile
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
}
// Handle __FINITE_MATH_ONLY__ similarly.
- if (!HonorINFs && !HonorNaNs)
+ bool InfValues = true;
+ bool NanValues = true;
+ auto processArg = [&](const auto *Arg) {
@@ -3295,7 +3295,17 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
}
// Handle __FINITE_MATH_ONLY__ similarly.
- if (!HonorINFs && !HonorNaNs)
+ bool InfValues, NanValues = true;
mdtoguchi wrote:
`InfValues` isn't initi
@@ -3295,7 +3295,17 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
}
// Handle __FINITE_MATH_ONLY__ similarly.
- if (!HonorINFs && !HonorNaNs)
+ bool InfValues, NanValues = true;
+ auto processArg = [&](const auto *Arg) {
+if (Strin
https://github.com/mdtoguchi approved this pull request.
https://github.com/llvm/llvm-project/pull/81514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1046,30 +1046,35 @@ defm offload_uniform_block :
BoolFOption<"offload-uniform-block",
NegFlag,
BothFlags<[], [ClangOption], " that kernels are launched with uniform block
sizes (default true for CUDA/HIP and false otherwise)">>;
-def fcx_limited_range : Joined<["-"],
@@ -1046,30 +1046,35 @@ defm offload_uniform_block :
BoolFOption<"offload-uniform-block",
NegFlag,
BothFlags<[], [ClangOption], " that kernels are launched with uniform block
sizes (default true for CUDA/HIP and false otherwise)">>;
-def fcx_limited_range : Joined<["-"],
https://github.com/mdtoguchi approved this pull request.
https://github.com/llvm/llvm-project/pull/84567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -50,3 +61,5 @@
// CHECK-NOT: -complex-range=fortran
// WARN1: warning: overriding '-fcx-limited-range' option with
'-fcx-fortran-rules' [-Woverriding-option]
// WARN2: warning: overriding '-fcx-fortran-rules' option with
'-fcx-limited-range' [-Woverriding-option]
+// WARN3
57 matches
Mail list logo
