[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

2021-04-21 Thread Michael Holman via Phabricator via cfe-commits
Holman added a comment. Can someone help me get this checked in? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

2021-04-09 Thread Michael Holman via Phabricator via cfe-commits
Holman updated this revision to Diff 336497. Holman added a comment. Fix clang-format issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 Files: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp llvm/tes

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

2021-04-08 Thread Michael Holman via Phabricator via cfe-commits
Holman updated this revision to Diff 336274. Holman set the repository for this revision to rG LLVM Github Monorepo. Holman added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 Files:

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

2021-04-08 Thread Michael Holman via Phabricator via cfe-commits
Holman updated this revision to Diff 336223. Holman added a comment. Get PGO info from Module instead of adding new field to debug info. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 Files: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp Ind

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

2021-04-08 Thread Michael Holman via Phabricator via cfe-commits
Holman added a comment. In D4#2677566 , @rnk wrote: > IMO it's best to avoid adding fields to DICompileUnit if at all possible. > It's the "god object" / "katamari damacy" of module debug info. Is there > something about the IR module that indicates

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

2021-04-06 Thread Michael Holman via Phabricator via cfe-commits
Holman created this revision. Herald added subscribers: dexonsmith, wenlei, hiraditya. Holman requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This change adds debug information about whether PGO is being used or not. Micr