[PATCH] D156336: [clang][docs][OpenMP] Update status of OMPT support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99ce17b71c41: [clang][docs][OpenMP] Update status of OMPT support. (authored by mhalk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D156336: [clang][docs][OpenMP] Update status of OMPT support.

mhalk added a comment. Please, take a look as I've also marked the EMI callbacks as done and if the other added/changed descriptions match. Just want to point out: the lower section is `5.1` (I was a bit confused as many people talked about 5.2). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D156336: [clang][docs][OpenMP] Update status of OMPT support.

mhalk created this revision. mhalk added a reviewer: dhruvachak. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. mhalk requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a p

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d4e14c76b4e: [clang][OpenMP] Add interop support for multiple depend clauses (authored by mhalk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155692/new/

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

mhalk updated this revision to Diff 542130. mhalk added a comment. Fixed `HasNowaitClause` always set to zero Renamed corresponding variable to `DependenceList`, to better reflect its meaning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155692/ne

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

mhalk added a comment. As far as I can tell, no. This *should* already be covered by Ndeps + DepList from `__tgt_interop_init`'s signature: __tgt_interop_init(ident_t *LocRef, kmp_int32 Gtid, [...], kmp_int32 Ndeps, kmp_depend_info_t *DepList, kmp_int32 HaveNowait) Which is very similar t

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

mhalk added a comment. In D155692#4515265 , @tianshilei1992 wrote: > We don't need to update the interface function to indicate how many deps we > have? Which //interface function// exactly? `__tgt_interop_[init|use|destroy]`? Repository: rG LLVM G

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

mhalk updated this revision to Diff 542032. mhalk added a comment. Rebase + removed `RunCleanupsScope` for preparation w.r.t. D137607 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155692/new/ https://reviews.llvm

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

mhalk added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6986 +DependenceAddress = DependenciesArray.getPointer(); +CodeGenFunction::RunCleanupsScope LocalScope(*this); } ABataev wrote: > mhalk wrote: > > Not sure if this is useful h

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

mhalk added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6986 +DependenceAddress = DependenciesArray.getPointer(); +CodeGenFunction::RunCleanupsScope LocalScope(*this); } Not sure if this is useful here. Saw this `RunCleanupsScope` i

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

mhalk updated this revision to Diff 541942. mhalk added a comment. Fix accidental remove of `assert(...)`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155692/new/ https://reviews.llvm.org/D155692 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp cla

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

mhalk created this revision. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. mhalk requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. This patch removes t

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

mhalk updated this revision to Diff 507409. mhalk added a comment. Patch rework, implementing the mentioned changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145591/new/ https://reviews.llvm.org/D145591 Files: clang/include/clang/Basic/Diag

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

mhalk added a comment. In D145591#4182360 , @jhuber6 wrote: > I'm not a fan of the same warning being copied in 24 places. Why do we set > `LangOpts.IsOpenMP` on the GPU compilation side, couldn't we just filter out > the `-fopenmp` or whatever it is fo

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

mhalk added inline comments. Herald added a subscriber: sunshaoce. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8634 +def warn_hip_omp_target_directives : Warning< + "HIP does not support OpenMP target directives; directive has been ignored">, + InGroup; ---

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

mhalk added a comment. In D145591#4179144 , @tra wrote: > How is this different from compiling a C++ file with opemnp directives in it? > AFAICT neither clang nor gcc issue anywarnings: > https://godbolt.org/z/5Me3dnTdr > > What makes the warnings neces

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

mhalk created this revision. Herald added subscribers: guansong, yaxunl. Herald added a project: All. mhalk requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Adds a warning, issued by the clang sem