[PATCH] D62831: [CodeGen][ObjC] Add attribute "arc_retain_agnostic" to ObjC globals that are retain-agnostic

2019-06-10 Thread Michael Gottesman via Phabricator via cfe-commits
gottesmm added a comment. This is exactly what I was imagining! This will enable the frontend to opt into this optimization without having to touch the optimizer. One nit: can we use a different name than "arc_retain_agnostic". Have you considered something like "arc_inert"? My fear is that at

[PATCH] D41050: Fix over-release of return value of lambda implicitly converted to block

2017-12-10 Thread Michael Gottesman via Phabricator via cfe-commits
gottesmm added a comment. SGTM. Repository: rC Clang https://reviews.llvm.org/D41050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41050: Fix over-release of return value of lambda implicitly converted to block

2017-12-10 Thread Michael Gottesman via Phabricator via cfe-commits
gottesmm added a reviewer: dexonsmith. gottesmm added a comment. I do not work on objcarc any longer. +CC Duncan. Repository: rC Clang https://reviews.llvm.org/D41050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c