[clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-09-19 Thread Michael Buch via cfe-commits
Michael137 wrote: any objections to latest version @cor3ntin ? https://github.com/llvm/llvm-project/pull/122265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-09-17 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From f979958249187a1b89b4b87c46e90d63b6dc4042 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:14:40 +0100 Subject: [PATCH 1/2] [clang][DebugInfo] Emit unified (Itanium) mangled name to

[clang] [lldb] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-09-17 Thread Michael Buch via cfe-commits
https://github.com/Michael137 auto_merge_enabled https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fbb587c - [clang][docs] Fix formatting of structor_decl_linkage_names DocBrief

2025-09-16 Thread Michael Buch via cfe-commits
Author: Michael Buch Date: 2025-09-16T10:51:42+01:00 New Revision: fbb587c65653395dc97a360e0cd0d1cf9ed0e875 URL: https://github.com/llvm/llvm-project/commit/fbb587c65653395dc97a360e0cd0d1cf9ed0e875 DIFF: https://github.com/llvm/llvm-project/commit/fbb587c65653395dc97a360e0cd0d1cf9ed0e875.diff

[clang] [clang][AST] Added assert to prevent infinite recursion in computing layout (PR #154134)

2025-09-15 Thread Michael Buch via cfe-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/154134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-09-13 Thread Michael Buch via cfe-commits
Michael137 wrote: gentle ping https://github.com/llvm/llvm-project/pull/122265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [clang][Mangle] Inject structor type into mangled name when mangling for LLDB JIT expressions (PR #155485)

2025-09-09 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/155485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Added assert to prevent infinite recursion in computing layout (PR #154134)

2025-09-09 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/154134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-09-09 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From f979958249187a1b89b4b87c46e90d63b6dc4042 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:14:40 +0100 Subject: [PATCH 1/2] [clang][DebugInfo] Emit unified (Itanium) mangled name to

[clang] [lldb] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-09-09 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Added assert to prevent infinite recursion in computing layout (PR #154134)

2025-09-09 Thread Michael Buch via cfe-commits
@@ -187,6 +187,8 @@ void EmptySubobjectMap::ComputeEmptySubobjectSizes() { // Check the bases. for (const CXXBaseSpecifier &Base : Class->bases()) { const CXXRecordDecl *BaseDecl = Base.getType()->getAsCXXRecordDecl(); +// Assert to prevent infinite recursion. -

[clang] [clang][AST] Added assert to prevent infinite recursion in computing layout (PR #154134)

2025-09-09 Thread Michael Buch via cfe-commits
Michael137 wrote: I think @AaronBallman is currently OOO until the end of the month. I'll go ahead and LGTM it, but please give @cor3ntin (or another maintainer) some time to interject. https://github.com/llvm/llvm-project/pull/154134 ___ cfe-commits

[clang] [lldb] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-09-09 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From f979958249187a1b89b4b87c46e90d63b6dc4042 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:14:40 +0100 Subject: [PATCH 1/3] [clang][DebugInfo] Emit unified (Itanium) mangled name to

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-09-09 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/154142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Added assert to prevent infinite recursion in computing layout (PR #154134)

2025-09-09 Thread Michael Buch via cfe-commits
https://github.com/Michael137 auto_merge_enabled https://github.com/llvm/llvm-project/pull/154134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-09-09 Thread Michael Buch via cfe-commits
Michael137 wrote: > Might be fixed next build, I saw the Linux ones fail then go green right > after. Yea I hoped so too, but looks like that test run had both my changes. I think this is just not supported on Windows for now (i doubt this worked before the tests were added either). I XFAILed

[clang] [clang][AST] Added assert to prevent infinite recursion in computing layout (PR #154134)

2025-09-08 Thread Michael Buch via cfe-commits
Michael137 wrote: Personally i think the assert makes sense here (if a user can't ever create an AST like that, which IIUC they can't). Although it is true that we try not to assert on user input as Jonas mentioned, this was a bug in our LLDB's AST creation. Malformed DWARF can already cause a

[clang] [lldb] [clang][Mangle] Inject structor type into mangled name when mangling for LLDB JIT expressions (PR #155485)

2025-09-08 Thread Michael Buch via cfe-commits
Michael137 wrote: friendly ping https://github.com/llvm/llvm-project/pull/155485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-09-08 Thread Michael Buch via cfe-commits
@@ -2125,9 +2125,9 @@ bool DWARFASTParserClang::ParseTemplateDIE( if (tag == DW_TAG_template_value_parameter && uval64_valid) { if (auto value = MakeAPValue(ast, clang_type, uval64)) { template_param_infos.InsertArg( - name, clang::TemplateA

[clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-09-08 Thread Michael Buch via cfe-commits
@@ -48,7 +48,7 @@ int main() { // COMMON-SAME: templateParams: ![[PARAM:[0-9]+]] // COMMON: ![[PARAM]] = !{![[TEMPL_TYPE_PARAM:[0-9]+]]} // GDB: ![[TEMPL_TYPE_PARAM]] = !DITemplateTypeParameter(name: "T", type: ![[BAR_INT_TY]]) -// LLDB:![[TEMPL_TYPE_PARAM

[clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-09-06 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From a9e13ad8d2a7a95d431dddcced611bea1e83b99a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 01/10] [clang][DebugInfo] Expand detection of structured bindin

[clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-09-04 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From a9e13ad8d2a7a95d431dddcced611bea1e83b99a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 01/11] [clang][DebugInfo] Expand detection of structured bindin

[clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-09-04 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From a9e13ad8d2a7a95d431dddcced611bea1e83b99a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 01/13] [clang][DebugInfo] Expand detection of structured bindin

[clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-09-04 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From a9e13ad8d2a7a95d431dddcced611bea1e83b99a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 01/12] [clang][DebugInfo] Expand detection of structured bindin

[clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-09-04 Thread Michael Buch via cfe-commits
Michael137 wrote: Latest commit narrows the heuristics so it specifically applies to `CallExpr`s generated for structured bindings. Here's what the AST looks like when stopped in `IgnoreImplicitCallSingleStep` for a structured binding: ``` (lldb) p E->dump()

[clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-09-03 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From a9e13ad8d2a7a95d431dddcced611bea1e83b99a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 1/9] [clang][DebugInfo] Expand detection of structured bindings

[clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-09-03 Thread Michael Buch via cfe-commits
Michael137 wrote: > I'm still happy with this. I did not notice it was not merged Yea I was just clearing out my open PRs and noticed this was still open. There is still that clang-tidy failure I haven't figured out. Might need a more targeted heuristic for expressions coming from binding decl

[clang] [libcxxabi] [lldb] [llvm] [WIP][lldb] Alternative implementation of more reliable function call infrastructure (PR #115245)

2025-09-03 Thread Michael Buch via cfe-commits
Michael137 wrote: Landed in https://github.com/llvm/llvm-project/pull/148877 https://github.com/llvm/llvm-project/pull/115245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxxabi] [lldb] [llvm] [WIP][lldb] Alternative implementation of more reliable function call infrastructure (PR #115245)

2025-09-03 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/115245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [WIP][lldb][Expression] More reliable function call resolution (PR #114529)

2025-09-03 Thread Michael Buch via cfe-commits
Michael137 wrote: Landed in https://github.com/llvm/llvm-project/pull/148877 https://github.com/llvm/llvm-project/pull/114529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [WIP][lldb][Expression] More reliable function call resolution (PR #114529)

2025-09-03 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/114529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [clang][RecordLayoutBuilder] Be stricter about inferring packed-ness in ExternalLayouts (PR #97443)

2025-09-03 Thread Michael Buch via cfe-commits
Michael137 wrote: @efriedma-quic @rjmccall ping Remembered about this while clearing out open PRs https://github.com/llvm/llvm-project/pull/97443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [lldb] [clang][RecordLayoutBuilder] Be stricter about inferring packed-ness in ExternalLayouts (PR #97443)

2025-09-03 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/97443 >From 38b7837bcc5da9e89778191654f9552ebccacbd5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 2 Jul 2024 18:43:34 +0200 Subject: [PATCH 1/3] [clang][RecordLayoutBuilder] Be stricter about inferring pa

[clang] [clang][DebugInfo] Attach DW_AT_const_value to static data-member definitions if available (PR #72730)

2025-09-03 Thread Michael Buch via cfe-commits
Michael137 wrote: Since reverted https://github.com/llvm/llvm-project/pull/71780 (reasons described in https://github.com/llvm/llvm-project/pull/74580), don't think there's any point in keeping this open. https://github.com/llvm/llvm-project/pull/72730

[clang] [clang][DebugInfo] Attach DW_AT_const_value to static data-member definitions if available (PR #72730)

2025-09-03 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/72730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-09-03 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From a9e13ad8d2a7a95d431dddcced611bea1e83b99a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 1/8] [clang][DebugInfo] Expand detection of structured bindings

[clang] [DebugInfo] When referencing structured bindings use the reference's location, not the binding's declaration's location (PR #153637)

2025-09-03 Thread Michael Buch via cfe-commits
https://github.com/Michael137 milestoned https://github.com/llvm/llvm-project/pull/153637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DebugInfo] When referencing structured bindings use the reference's location, not the binding's declaration's location (PR #153637)

2025-09-03 Thread Michael Buch via cfe-commits
Michael137 wrote: /cherry-pick 665e875f1a86be650e044bb20744bb272d03e11d https://github.com/llvm/llvm-project/pull/153637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DebugInfo] When referencing structured bindings use the reference's location, not the binding's declaration's location (PR #153637)

2025-09-03 Thread Michael Buch via cfe-commits
Michael137 wrote: Can we cherry-pick this to `release/21.x`? I'm planning to pull this into the Apple LLVM fork for the 21.x release https://github.com/llvm/llvm-project/pull/153637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [DebugInfo] When referencing structured bindings use the reference's location, not the binding's declaration's location (PR #153637)

2025-09-03 Thread Michael Buch via cfe-commits
@@ -3387,7 +3387,14 @@ LValue CodeGenFunction::EmitDeclRefLValue(const DeclRefExpr *E) { auto *FD = LambdaCaptureFields.lookup(BD); return EmitCapturedFieldLValue(*this, FD, CXXABIThisValue); } -return EmitLValue(BD->getBinding()); +// Suppress debug lo

[clang] [lldb] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-09-02 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-09-01 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From bb71b69ea69fe4046a3f93e30f82dfb1d4d59b69 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:14:40 +0100 Subject: [PATCH 1/3] [clang][DebugInfo] Emit unified (Itanium) mangled name to

[clang] [lldb] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-09-01 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From bb71b69ea69fe4046a3f93e30f82dfb1d4d59b69 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:14:40 +0100 Subject: [PATCH 1/3] [clang][DebugInfo] Emit unified (Itanium) mangled name to

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-09-01 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From a4ec01a37825ac1a2fd910ad1357b7bbe403046e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 01/12] [llvm][DebugInfo] Support DW_AT_linkage_names that are

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-09-01 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From a4ec01a37825ac1a2fd910ad1357b7bbe403046e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 01/12] [llvm][DebugInfo] Support DW_AT_linkage_names that are

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-09-01 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From 5d75d1679d492df1a72c4013afde052f7b6195dd Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/6] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [lldb] [clang][Mangle] Inject structor type into mangled name when mangling for LLDB JIT expressions (PR #155485)

2025-09-01 Thread Michael Buch via cfe-commits
Michael137 wrote: LLDB doesn't currently support inheriting ctors in the expression evaluator but I added this capability here for completeness. https://github.com/llvm/llvm-project/pull/155485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [lldb] [clang][Mangle] Inject structor type into mangled name when mangling for LLDB JIT expressions (PR #155485)

2025-09-01 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/155485 >From 4d47b8bdf579de65eb69c69381c98c85e7f5a8e5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 4 Aug 2025 14:20:45 +0100 Subject: [PATCH 1/4] [clang][Mangle] Inject structor type into mangled name whe

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-27 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From 5d75d1679d492df1a72c4013afde052f7b6195dd Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/5] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [lldb] [clang][Mangle] Inject structor type into mangled name when mangling for LLDB JIT expressions (PR #155485)

2025-08-27 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/155485 >From 4d47b8bdf579de65eb69c69381c98c85e7f5a8e5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 4 Aug 2025 14:20:45 +0100 Subject: [PATCH 1/3] [clang][Mangle] Inject structor type into mangled name whe

[clang] [lldb] [clang][Mangle] Inject structor type into mangled name when mangling for LLDB JIT expressions (PR #155485)

2025-08-27 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/155485 >From 4d47b8bdf579de65eb69c69381c98c85e7f5a8e5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 4 Aug 2025 14:20:45 +0100 Subject: [PATCH 1/2] [clang][Mangle] Inject structor type into mangled name whe

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-27 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-26 Thread Michael Buch via cfe-commits
Michael137 wrote: > > We didn't expect the debug info to increase that much based on the [#145967 > > (comment)](https://github.com/llvm/llvm-project/pull/145967#issuecomment-3099264478). > > Are they using some variant of -fno-sanitize-merge by any chance? > > Typically in optimized builds th

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-26 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Mangle] Inject structor type into mangled name when mangling for LLDB JIT expressions (PR #155485)

2025-08-26 Thread Michael Buch via cfe-commits
Michael137 wrote: @AaronBallman I *think* you looked at this already in https://github.com/llvm/llvm-project/pull/149827, but thought it's best I split this out since it's sufficiently strange behaviour to warrant its own commit. https://github.com/llvm/llvm-project/pull/155485 ___

[clang] [clang][Mangle] Inject structor type into mangled name when mangling for LLDB JIT expressions (PR #155485)

2025-08-26 Thread Michael Buch via cfe-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/155485 Part of https://github.com/llvm/llvm-project/pull/149827 This patch adds special handling for `AsmLabel`s created by LLDB. LLDB uses `AsmLabel`s to encode information about a function declaration to make it

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-26 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-26 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From 5d75d1679d492df1a72c4013afde052f7b6195dd Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/5] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-26 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From a4ec01a37825ac1a2fd910ad1357b7bbe403046e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 01/10] [llvm][DebugInfo] Support DW_AT_linkage_names that are

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-26 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From 5d75d1679d492df1a72c4013afde052f7b6195dd Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/5] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Michael Buch via cfe-commits
Michael137 wrote: uhm i'll have a more detailed look at the motivation for this but i added this specifically for better debugging experience. I'd be surprised if this didnt regress anything in LLDB https://github.com/llvm/llvm-project/pull/155120 __

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-22 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From d55e41fa03d09b2ddfc9484c4a70a7d21ed9a994 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/5] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-22 Thread Michael Buch via cfe-commits
Michael137 wrote: Rebased the PR on top of the LLVM/Clang changes that are in-review in separate PRs. Cleaned up the commits. The LLDB changes are all in the latest one https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe

[clang] [clang][DebugInfo][test] Move debug-info tests from CodeGenObjCXX to DebugInfo directory (PR #154912)

2025-08-22 Thread Michael Buch via cfe-commits
Michael137 wrote: This would conclude moving all the debug-info tests. Might've missed a couple here and there, but the vast majority should be in `clang/test/DebugInfo` now. https://github.com/llvm/llvm-project/pull/154912 ___ cfe-commits mailing lis

[clang] [clang][DebugInfo][test] Move debug-info tests from CodeGenObjCXX to DebugInfo directory (PR #154912)

2025-08-22 Thread Michael Buch via cfe-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/154912 This patch works towards consolidating all Clang debug-info into the `clang/test/DebugInfo` directory (https://discourse.llvm.org/t/clang-test-location-of-clang-debug-info-tests/87958). Here we move only the

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From d55e41fa03d09b2ddfc9484c4a70a7d21ed9a994 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 01/10] [llvm][DebugInfo] Support DW_AT_linkage_names that are

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From d55e41fa03d09b2ddfc9484c4a70a7d21ed9a994 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 01/11] [llvm][DebugInfo] Support DW_AT_linkage_names that are

[clang] [clang][DebugInfo][test] Move debug-info tests from CodeGenObjC to DebugInfo directory (PR #154781)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/154781 This patch works towards consolidating all Clang debug-info into the `clang/test/DebugInfo` directory (https://discourse.llvm.org/t/clang-test-location-of-clang-debug-info-tests/87958). Here we move only th

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From d55e41fa03d09b2ddfc9484c4a70a7d21ed9a994 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 01/11] [llvm][DebugInfo] Support DW_AT_linkage_names that are

[clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From d55e41fa03d09b2ddfc9484c4a70a7d21ed9a994 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 01/10] [llvm][DebugInfo] Support DW_AT_linkage_names that are

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From d55e41fa03d09b2ddfc9484c4a70a7d21ed9a994 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/9] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] Fix scope of typedefs present inside a template class (PR #146729)

2025-08-21 Thread Michael Buch via cfe-commits
@@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm -debug-info-kind=standalone -o - %s | FileCheck %s Michael137 wrote: You'll have to rebase the PR to get the directory https://github.com/llvm/llvm-project/pull/146729 ___

[clang] Fix scope of typedefs present inside a template class (PR #146729)

2025-08-21 Thread Michael Buch via cfe-commits
@@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm -debug-info-kind=standalone -o - %s | FileCheck %s Michael137 wrote: Could you move this test into the recently added `clang/test/DebugInfo/CXX` directory? https://github.com/llv

[clang] [clang][DebugInfo][test] Move debug-info tests from CodeGenCXX to DebugInfo directory (PR #154538)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/154538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From ff0b6ac2d035ea3abb8506c02b92e07a17788142 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/8] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-21 Thread Michael Buch via cfe-commits
@@ -125,8 +125,11 @@ DEBUGOPT(DebugNameTable, 2, 0, Compatible) /// Whether to use DWARF base address specifiers in .debug_ranges. DEBUGOPT(DebugRangesBaseAddress, 1, 0, Compatible) +/// Whether to add linkage names to constructor/destructor declarations. +DEBUGOPT(DebugStruct

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-21 Thread Michael Buch via cfe-commits
@@ -4753,6 +4753,15 @@ def gembed_source : Flag<["-"], "gembed-source">, Group, def gno_embed_source : Flag<["-"], "gno-embed-source">, Group, Flags<[NoXarchOption]>, HelpText<"Restore the default behavior of not embedding source text in DWARF debug sections">; +defm

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From 14337d42811a9a9dd9285669109dff2524ca357a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/7] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-20 Thread Michael Buch via cfe-commits
@@ -125,8 +125,11 @@ DEBUGOPT(DebugNameTable, 2, 0, Compatible) /// Whether to use DWARF base address specifiers in .debug_ranges. DEBUGOPT(DebugRangesBaseAddress, 1, 0, Compatible) +/// Whether to add linkage names to constructor/destructor declarations. +DEBUGOPT(DebugStruct

[clang] [clang][DebugInfo][test] Move debug-info tests from CodeGenCXX to DebugInfo directory (PR #154538)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154538 >From af6ed337ad9bcbe80a7b50d724a5bca37faf7022 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 20 Aug 2025 14:26:44 +0100 Subject: [PATCH 1/4] [clang][DebugInfo][test] Move debug-info tests from CodeG

[clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-20 Thread Michael Buch via cfe-commits
Michael137 wrote: > Even a 3-4% increase in binary size is going to cause serious problems for us > at Google. Is there any way that this work could be guarded by a flag, so > that we can turn it off until we find a way to work around the problems it > will cause for us? Yup I put this behind

[clang] [llvm] [DO-NOT-MERGE] Add unified mangled name to structor declarations in DWARF (PR #153369)

2025-08-20 Thread Michael Buch via cfe-commits
Michael137 wrote: Closing in favour of https://github.com/llvm/llvm-project/pull/154538 https://github.com/llvm/llvm-project/pull/153369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DO-NOT-MERGE] Add unified mangled name to structor declarations in DWARF (PR #153369)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/153369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DebugInfo][test] Move debug-info tests from CodeGenCXX to DebugInfo directory (PR #154538)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154538 >From af6ed337ad9bcbe80a7b50d724a5bca37faf7022 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 20 Aug 2025 14:26:44 +0100 Subject: [PATCH 1/3] [clang][DebugInfo][test] Move debug-info tests from CodeG

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-20 Thread Michael Buch via cfe-commits
Michael137 wrote: Test failure is an XPASS in `TestExprDefinitionInDylib` because the LLDB `AsmLabel` now has a mangled name in it and the lookup by mangled name succeeds. Though it's technically not correct because we're not guaranteed to pick the right constructor variant (we probably just p

[clang] [clang][DebugInfo][test] Move debug-info tests from CodeGenCXX to DebugInfo directory (PR #154538)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154538 >From af6ed337ad9bcbe80a7b50d724a5bca37faf7022 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 20 Aug 2025 14:26:44 +0100 Subject: [PATCH 1/2] [clang][DebugInfo][test] Move debug-info tests from CodeG

[clang] [clang][DebugInfo][test] Move debug-info tests from CodeGenCXX to DebugInfo directory (PR #154538)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/154538 This patch works towards consolidating all Clang debug-info into the `clang/test/DebugInfo` directory (https://discourse.llvm.org/t/clang-test-location-of-clang-debug-info-tests/87958). Here we move only th

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-20 Thread Michael Buch via cfe-commits
Michael137 wrote: Here is the debug-info increase when I run bloaty on all the Clang/LLDB/LLVM object files: ``` $ bloaty `find builds-lldb/with-patch/ -name '*.o'` -- `find builds-lldb/no-patch/ -name '*.o'` FILE SIZEVM SIZE -- -- +15% +207Mi [ =

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From 14337d42811a9a9dd9285669109dff2524ca357a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/6] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From 14337d42811a9a9dd9285669109dff2524ca357a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/5] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From 14337d42811a9a9dd9285669109dff2524ca357a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/6] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154142 >From 14337d42811a9a9dd9285669109dff2524ca357a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/4] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[clang] [clang][test][DebugInfo] Move debug-info tests from CodeGen to DebugInfo directory (PR #154311)

2025-08-19 Thread Michael Buch via cfe-commits
Michael137 wrote: Removed the `debug-*` prefix from the tests where it made sense https://github.com/llvm/llvm-project/pull/154311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][test][DebugInfo] Move debug-info tests from CodeGen to DebugInfo directory (PR #154311)

2025-08-19 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154311 >From 0831825c1e1708926fcb803fa0c3e14db7943859 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 19 Aug 2025 11:37:58 +0100 Subject: [PATCH 1/4] [clang][test][DebugInfo] Move debug-info tests from CodeG

[clang] [clang][test][DebugInfo] Move debug-info tests from CodeGen to DebugInfo directory (PR #154311)

2025-08-19 Thread Michael Buch via cfe-commits
Michael137 wrote: > Any chance of stripping the debug/debug-info prefixes from the file names, > now that they'll b ein a DebugInfo directory? I did for most of them :) Let me check if there are any left https://github.com/llvm/llvm-project/pull/154311

[clang] [clang][test][DebugInfo] Move debug-info tests from CodeGen to DebugInfo directory (PR #154311)

2025-08-19 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/154311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][test][DebugInfo] Move debug-info tests from CodeGen to DebugInfo directory (PR #154311)

2025-08-19 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154311 >From 0831825c1e1708926fcb803fa0c3e14db7943859 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 19 Aug 2025 11:37:58 +0100 Subject: [PATCH 1/3] [clang][test][DebugInfo] Move debug-info tests from CodeG

[clang] [clang][test][DebugInfo] Move debug-info tests from CodeGen to DebugInfo directory (PR #154311)

2025-08-19 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/154311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   6   7   8   >