@@ -2518,6 +2518,57 @@ StringRef CGDebugInfo::getVTableName(const CXXRecordDecl
*RD) {
return internString("_vptr$", RD->getNameAsString());
}
+// Emit symbol for the debugger that points to the vtable address for
+// the given class. The symbol is named as '_vtable$'.
+//
@@ -2518,6 +2518,59 @@ StringRef CGDebugInfo::getVTableName(const CXXRecordDecl
*RD) {
return internString("_vptr$", RD->getNameAsString());
}
+// Emit symbol for the debugger that points to the vtable address for
+// the given class. The symbol is named as '_vtable$'.
+//
https://github.com/Michael137 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/130255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/130255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
Reverted in https://github.com/llvm/llvm-project/pull/135974 since it's
breaking the LLDB build. Let me know if you need help reproducing
https://github.com/llvm/llvm-project/pull/135808
___
cfe-commits mailing list
cfe-commits@lists
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/135974
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/133448
>From 732a9b611bb4b6c49a0b4bf1d616870ffa051d8f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 28 Mar 2025 13:29:27 +
Subject: [PATCH 1/4] [clang][Sema] Fix typo in 'offsetof' diagnostics
Before:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/133448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115245
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/115245
>From 63ca211312cd9dcbf28d30866a429262b504bdb3 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 5 Nov 2024 00:22:07 +
Subject: [PATCH] Init
---
clang/include/clang/Basic/Attr.td | 7
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/133448
>From 732a9b611bb4b6c49a0b4bf1d616870ffa051d8f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 28 Mar 2025 13:29:27 +
Subject: [PATCH 1/2] [clang][Sema] Fix typo in 'offsetof' diagnostics
Before:
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/133448
>From 732a9b611bb4b6c49a0b4bf1d616870ffa051d8f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 28 Mar 2025 13:29:27 +
Subject: [PATCH 1/3] [clang][Sema] Fix typo in 'offsetof' diagnostics
Before:
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/133448
Before:
```
offset of on non-POD type
```
After:
```
offsetof on non-POD type
```
>From 732a9b611bb4b6c49a0b4bf1d616870ffa051d8f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 28 Mar 2025 13:29:27 +0
https://github.com/Michael137 commented:
LLDB changes LGTM
https://github.com/llvm/llvm-project/pull/132401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
FYI, this is causing the LLDB `image dump ast` command to infinitely recurse
when we have template functions in the AST. Not really super urgent because
it's not a command most people use, and the root cause is probably due to the
way LLDB constructs its AST. But thought I'd
@@ -2518,6 +2518,59 @@ StringRef CGDebugInfo::getVTableName(const CXXRecordDecl
*RD) {
return internString("_vptr$", RD->getNameAsString());
}
+// Emit symbol for the debugger that points to the vtable address for
+// the given class. The symbol is named as '_vtable$'.
+//
@@ -2518,6 +2518,59 @@ StringRef CGDebugInfo::getVTableName(const CXXRecordDecl
*RD) {
return internString("_vptr$", RD->getNameAsString());
}
+// Emit symbol for the debugger that points to the vtable address for
+// the given class. The symbol is named as '_vtable$'.
+//
@@ -2518,6 +2518,59 @@ StringRef CGDebugInfo::getVTableName(const CXXRecordDecl
*RD) {
return internString("_vptr$", RD->getNameAsString());
}
+// Emit symbol for the debugger that points to the vtable address for
+// the given class. The symbol is named as '_vtable$'.
+//
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/130255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/130255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 commented:
Would be great to have a simpler of getting to the vtable info! I left some nits
Don't see an issue with the the general approach, but i'll let others chime in
https://github.com/llvm/llvm-project/pull/130255
_
@@ -2518,6 +2518,59 @@ StringRef CGDebugInfo::getVTableName(const CXXRecordDecl
*RD) {
return internString("_vptr$", RD->getNameAsString());
}
+// Emit symbol for the debugger that points to the vtable address for
+// the given class. The symbol is named as '_vtable$'.
+//
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/130255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2518,6 +2518,59 @@ StringRef CGDebugInfo::getVTableName(const CXXRecordDecl
*RD) {
return internString("_vptr$", RD->getNameAsString());
}
+// Emit symbol for the debugger that points to the vtable address for
+// the given class. The symbol is named as '_vtable$'.
+//
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/130255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/130255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2518,6 +2518,59 @@ StringRef CGDebugInfo::getVTableName(const CXXRecordDecl
*RD) {
return internString("_vptr$", RD->getNameAsString());
}
+// Emit symbol for the debugger that points to the vtable address for
+// the given class. The symbol is named as '_vtable$'.
+//
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/127056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
Fixed in `0feb00f17cbaac7428dcb7aed13d903b65974978`
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
FYI on macOS CI this is failing with:
```
FAIL: test_dsym (TestCPPEnumPromotion.TestCPPEnumPromotion)
--
Traceback (most recent call last):
File
"/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/llvm-
Michael137 wrote:
let me know if you need me to merge this for you
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/127056
>From b84ebf9c696ffc3867a52ed1540d59d18d2e5ece Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 13 Feb 2025 13:00:28 +
Subject: [PATCH 1/2] [clang][DebugInfo][test] Add tests for C++20 non-type
tem
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/127056
This exercises the codepath where we create `DITemplateValueParameter`s whose
`TemplateArgument::ArgKind` is `StructuralValue`, which was added in
(https://github.com/llvm/llvm-project/pull/78041). Previousl
@@ -8476,27 +8476,20 @@ bool TypeSystemClang::CompleteTagDeclarationDefinition(
clang::ASTContext &ast = lldb_ast->getASTContext();
- /// TODO This really needs to be fixed.
+ unsigned NumNegativeBits = 0;
Michael137 wrote:
Can we move this block back in
https://github.com/Michael137 approved this pull request.
Looks great! Thank you for moving all this functionality into Clang
LGTM (just one minor comment left)
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@
Michael137 wrote:
ah fair enough
lets get that one merged then
https://github.com/llvm/llvm-project/pull/126937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/126937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
> > > > This is just moving stuff around so that seems fine. Though, I wonder,
> > > > could we just pass e.g. an `ArrayRef` to `computeEnumBits()`?
> > > > The LLDB pr you linked seems to have an
> > > > `SmallVector`, so that should be possible (I think
> > > > it does req
Michael137 wrote:
> @Michael137 Changed the first argument of `computeEnumBits` to an `ArrayRef`
> to avoid the template and so it can be still seamlessly used from Sema. On
> LLDB side, I had to create a `SmallVector` and put enum constants there at
> the point of their creation (`AddEnumerat
@@ -2367,11 +2370,27 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/126215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
Put up https://github.com/llvm/llvm-project/pull/126215
Should address the failure @hokein observed
https://github.com/llvm/llvm-project/pull/125791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/126215
This addresses the MSAN failure reported
in https://github.com/llvm/llvm-project/pull/125791#issuecomment-2639183154:
```
==5633==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 in
clang::ASTNodeI
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/126045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
The one test failure unrelated:
```
FAIL: Clang :: Tooling/clang-linker-wrapper-spirv-elf.cpp (20542 of 21851)
TEST 'Clang :: Tooling/clang-linker-wrapper-spirv-elf.cpp'
FAILED
Exit Code: 1
Command Output (stderr):
--
RUN: at line 4: mk
Michael137 wrote:
> > > > Actually, @mizvekov, can we make the
> > > > `ClassTemplateSpecializationDecl::ClassTemplateSpecializationDecl(ASTContext
> > > > &C, Kind DK)` constructor default initialize the `StrictPackMatch`
> > > > member to false? In that case users of `CreateDeserialized` wou
Michael137 wrote:
> > Actually, @mizvekov, can we make the
> > `ClassTemplateSpecializationDecl::ClassTemplateSpecializationDecl(ASTContext
> > &C, Kind DK)` constructor default initialize the `StrictPackMatch` member
> > to false? In that case users of `CreateDeserialized` wouldn't need to wo
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/126045
>From 10d37ec7e406d3b6ff5034003087a4b6cbb76fe0 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 5 Feb 2025 12:02:50 +
Subject: [PATCH] [clang][DebugInfo] Set EnumKind based on enum_extensibility
at
Michael137 wrote:
> This is just moving stuff around so that seems fine. Though, I wonder, could
> we just pass e.g. an `ArrayRef` to `computeEnumBits()`? The LLDB pr
> you linked seems to have an `SmallVector`, so that should
> be possible (I think it does require a `reinterpret_cast` from a
Michael137 wrote:
Actually, @mizvekov, can we make
`ClassTemplatePartialSpecializationDecl(ASTContext&)` default initialize the
`StrictPackMatch` member to false? In that case users of `CreateDeserialized`
wouldn't need to worry about it being potentially uninitialized? Otherwise
we'll have t
@@ -280,7 +280,8 @@ std::optional
CxxModuleHandler::tryInstantiateStdTemplate(Decl *d) {
new_class_template->getDeclContext(),
new_class_template->getTemplatedDecl()->getLocation(),
new_class_template->getLocation(), new_class_template, imported_args,
-
Michael137 wrote:
I've only included the LLVM changes here now (anything metadata and DWARF
attribute related). Will do the plumbing from the frontend in a separate patch
https://github.com/llvm/llvm-project/pull/124752
___
cfe-commits mailing list
cf
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/124752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
> Is my thing about the ctor understanding correct, and it's that the ctor
> exists theoretically/abstractly, but not in the AST or in the generated
> IR/DWARF? Could it be added/would that be sufficient?
>
> But, yeah, probably fine to just add the attribute, since that's th
Michael137 wrote:
> Might be as simple as a constant true or false, but I'm nearing the end of my
> work day so I've reverted it for now.
>
> In the meantime, @Michael137 might know if this is something LLDB should
> actually be tracking. Or in other words, is #125290 something that can happen
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
Michael137 wrote:
Feel fr
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
Michael137 wrote:
Ah true
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
Michael137 wrote:
That's
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
Michael137 wrote:
Unless
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
Michael137 wrote:
Apologi
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
Michael137 wrote:
> Mostl
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,37 @@
+"""
+Test LLDB type promotion of unscoped enums.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class TestCPPEnumPromotion(TestBase):
+@skipIf(debug_info=no_match([
@@ -0,0 +1,37 @@
+"""
+Test LLDB type promotion of unscoped enums.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class TestCPPEnumPromotion(TestBase):
+@skipIf(debug_info=no_match([
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
Michael137 wrote:
I do th
Michael137 wrote:
> (hmm, can't use the foundation library on godbolt/compiler explorer) Can you
> show a small example of the code you're interested in and the DWARF it
> produces? The documentation I can find seems to suggest that the extensible
> enums have ctors that take the underlying in
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/124752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/124752
When creating `EnumDecl`s from DWARF for Objective-C `NS_ENUM`s, the Swift
compiler tries to figure out if it should perform "swiftification" of that enum
(which involves renaming the enumerator cases, etc.)
@@ -0,0 +1,37 @@
+"""
+Test LLDB type promotion of unscoped enums.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class TestCPPEnumPromotion(TestBase):
+@skipIf(debug_info=no_match([
@@ -3903,6 +3903,7 @@ class EnumDecl : public TagDecl {
void setInstantiationOfMemberEnum(ASTContext &C, EnumDecl *ED,
TemplateSpecializationKind TSK);
+public:
Michael137 wrote:
I see why you moved it. It's because we're
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
@@ -3903,6 +3903,7 @@ class EnumDecl : public TagDecl {
void setInstantiationOfMemberEnum(ASTContext &C, EnumDecl *ED,
TemplateSpecializationKind TSK);
+public:
Michael137 wrote:
Can we not just leave this whole block in
https://github.com/Michael137 deleted
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 commented:
Looks much better
Left some more clarification comments
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
@@ -3903,6 +3903,7 @@ class EnumDecl : public TagDecl {
void setInstantiationOfMemberEnum(ASTContext &C, EnumDecl *ED,
TemplateSpecializationKind TSK);
+public:
Michael137 wrote:
Don't need this change anymore
https://gi
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/124305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Balázs_Kéri?=
Message-ID:
In-Reply-To:
Michael137 wrote:
> If this case is not handled, the following `setDescribedFunctionTemplate`
> will run into an assertion. The case happens in the test code. What exactly
> happens is that because of the `__get_first_arg` mismatch a field
>
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/124305
>From 2fbabc9802e09a175bd71624b2ff89a2d9b7f3a1 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 24 Jan 2025 11:59:42 +
Subject: [PATCH 1/4] [clang][ASTImporter][test] Add test for importing
explici
@@ -3441,13 +3441,33 @@ TEST_P(ASTImporterOptionSpecificTestBase,
ImportParmVarDecl) {
ASSERT_TRUE(FromVar);
ASSERT_TRUE(FromVar->hasUninstantiatedDefaultArg());
ASSERT_TRUE(FromVar->getUninstantiatedDefaultArg());
+ ASSERT_FALSE(FromVar->isExplicitObjectParameter());
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/124305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/124305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?=
Message-ID:
In-Reply-To:
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/124273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/124305
>From 2fbabc9802e09a175bd71624b2ff89a2d9b7f3a1 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 24 Jan 2025 11:59:42 +
Subject: [PATCH 1/3] [clang][ASTImporter][test] Add test for importing
explici
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/124305
>From 2fbabc9802e09a175bd71624b2ff89a2d9b7f3a1 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 24 Jan 2025 11:59:42 +
Subject: [PATCH 1/2] [clang][ASTImporter][test] Add test for importing
explici
@@ -3441,13 +3441,33 @@ TEST_P(ASTImporterOptionSpecificTestBase,
ImportParmVarDecl) {
ASSERT_TRUE(FromVar);
ASSERT_TRUE(FromVar->hasUninstantiatedDefaultArg());
ASSERT_TRUE(FromVar->getUninstantiatedDefaultArg());
+ ASSERT_FALSE(FromVar->isExplicitObjectParameter());
=?utf-8?q?Balázs_Kéri?=
Message-ID:
In-Reply-To:
https://github.com/Michael137 commented:
So in spirit this is kind of like an ODR violation right? Which the ASTImporter
does try to handle, so this seems reasonable to me. For my own understanding,
where did the crash end up happening?
Also,
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/124305
>From 2fbabc9802e09a175bd71624b2ff89a2d9b7f3a1 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 24 Jan 2025 11:59:42 +
Subject: [PATCH] [clang][ASTImporter][test] Add test for importing explicit
ob
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/124305
Adds test that confirms that we import the explicit object parameter location
for `ParmVarDecl`s. This is how Clang determines whether a parameter
`isExplicitObjectParamater`. The LLDB expression evaluator r
1 - 100 of 517 matches
Mail list logo
