[clang] [flang] [llvm] [flang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139131)

2025-05-10 Thread Michał Górny via cfe-commits
mgorny wrote: Filed https://github.com/llvm/llvm-project/pull/139371 https://github.com/llvm/llvm-project/pull/139131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [flang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139131)

2025-05-10 Thread Michał Górny via cfe-commits
mgorny wrote: …or I'll try fixing it first, it seems to be a trivial case of missing include. https://github.com/llvm/llvm-project/pull/139131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [flang] [llvm] [flang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139131)

2025-05-10 Thread Michał Górny via cfe-commits
mgorny wrote: I'm also seeing this failure, so I'm going to revert. https://github.com/llvm/llvm-project/pull/139131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CMake] respect LLVMConfig.cmake's LLVM_DEFINITIONS (PR #138587)

2025-05-07 Thread Michał Górny via cfe-commits
mgorny wrote: Yeah, I think it's a good idea. Thanks for doing that! https://github.com/llvm/llvm-project/pull/138587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [openmp] [OpenMP] Change build of OpenMP device runtime to be a separate runtime (PR #136729)

2025-04-23 Thread Michał Górny via cfe-commits
mgorny wrote: Honestly, I am thoroughly confused about all that openmp ↔ offload moving. But if these don't share much code with the current `openmp`, perhaps the cleanest approach would be to make it entirely separate? https://github.com/llvm/llvm-project/pull/136729

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-04-19 Thread Michał Górny via cfe-commits
mgorny wrote: https://github.com/llvm/llvm-project/pull/136442 https://github.com/llvm/llvm-project/pull/126143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-04-19 Thread Michał Górny via cfe-commits
mgorny wrote: Yeah, I can do that. I suppose a separate build would be cleaner in the long run — and hopefully it will let us build the CPU part cleanly with GCC xP. https://github.com/llvm/llvm-project/pull/126143 ___ cfe-commits mailing list cfe-com

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-04-19 Thread Michał Górny via cfe-commits
mgorny wrote: No, I'm afraid that didn't change anything. However, it did if I added it to `target_link_options` too. That said, you want to instead: ```diff --- a/offload/DeviceRTL/CMakeLists.txt +++ b/offload/DeviceRTL/CMakeLists.txt @@ -132,7 +132,7 @@ function(compileDeviceRTLLibrary targe

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-04-19 Thread Michał Górny via cfe-commits
mgorny wrote: Yeah, appending `-march=` seems to work. https://github.com/llvm/llvm-project/pull/126143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-04-19 Thread Michał Górny via cfe-commits
mgorny wrote: > It should only be invoking `nvptx-arch` if the user passed `-march=native`. Sorry, didn't notice this sentence. Well, *I am* building with `-march=native` here — after all, other files are built for a CPU. If I change it to, say, `-march=zen2`, then it indeed compiles, with a l

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-04-19 Thread Michał Górny via cfe-commits
mgorny wrote: I'm sorry, I've unmerged these packages already after trying an older commit. Lemme build them again. https://github.com/llvm/llvm-project/pull/126143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-04-19 Thread Michał Górny via cfe-commits
mgorny wrote: How did you disable it? Perhaps it's failing because of the specific error: ``` $ nvptx-arch Failed to 'dlopen' libcuda.so.1 ``` For comparison, `amdgpu-arch` doesn't print

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-04-19 Thread Michał Górny via cfe-commits
mgorny wrote: Clang was built from the same commit id (ee4c8b556c5cf42c55ce9540bbb0e29c11894a71). https://github.com/llvm/llvm-project/pull/126143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-04-19 Thread Michał Górny via cfe-commits
mgorny wrote: Nah, building standalone directly. And separately from OpenMP. https://github.com/llvm/llvm-project/pull/126143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-04-19 Thread Michał Górny via cfe-commits
mgorny wrote: And after switching to clang, it fails anyway: ``` $ /usr/lib/ccache/bin/x86_64-pc-linux-gnu-clang++ -O2 -pipe -march=native -Wl,-O1 -Wl,--as-needed -Wl,-z,pack-relative-relocs --target=nvptx64-nvidia-cuda -r -nostdlib -flto -Wl,--lto-emit-llvm DeviceRTL/Allocator.cpp-nvptx.o

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-04-19 Thread Michał Górny via cfe-commits
mgorny wrote: This change broke building with GCC set as the C++ compiler: ``` FAILED: libomptarget-nvptx.bc : && /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -O2 -pipe -march=native -Wl,-O1 -Wl,--as-needed -Wl,-z,pack-relative-relocs --target=nvptx64-nvidia-cuda -r -nostdlib -flto -Wl,--lt

[clang] [clang] [Driver] Fix respecting libdir when locating flang runtime (PR #127345)

2025-04-14 Thread Michał Górny via cfe-commits
https://github.com/mgorny closed https://github.com/llvm/llvm-project/pull/127345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [Driver] Fix respecting libdir when locating flang runtime (PR #127345)

2025-04-14 Thread Michał Górny via cfe-commits
mgorny wrote: Closed in favor of #134362. https://github.com/llvm/llvm-project/pull/127345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [driver] Generalize the code that adds the path of libflang_rt.runtime.a. (PR #134362)

2025-04-12 Thread Michał Górny via cfe-commits
mgorny wrote: > I find this change quite confusing. It seems that `-static-libflangrt` now > expects entirely different install location than `-shared-libflangrt`. Ah, sorry, now I see that `-L/usr/lib/llvm/21/bin/../../../../lib/clang/21/lib/x86_64-pc-linux-gnu` is also added, so the "resour

[clang] [flang] [driver] Generalize the code that adds the path of libflang_rt.runtime.a. (PR #134362)

2025-04-12 Thread Michał Górny via cfe-commits
mgorny wrote: I find this change quite confusing. It seems that `-static-libflangrt` now expects entirely different install location than `-shared-libflangrt`. Furthermore, the location used seems inconsistent with clang, i.e.: /usr/lib/llvm/21/bin/../../../../lib/clang/21/lib/x86_64-pc-l

[libclc] [libclc] Move log1p/asinh/acosh/atanh to the CLC library (PR #132956)

2025-03-29 Thread Michał Górny via cfe-commits
mgorny wrote: This change seems to have broken the test suite: ``` ctest -j 32 --test-load 32 Test project /var/tmp/portage/llvm-core/libclc-21.0.0./work/libclc_build Start 1: external-calls-tahiti-amdgcn--.bc Start 2: external-calls-amdgcn--amdhsa.bc Start 3: external-calls-tahi

[libclc] [libclc] Disable external-calls testing for clspv targets (PR #127529)

2025-02-17 Thread Michał Górny via cfe-commits
https://github.com/mgorny approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/127529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Fix dependencies on generated convert builtins (PR #127515)

2025-02-17 Thread Michał Górny via cfe-commits
https://github.com/mgorny approved this pull request. Thanks for looking into it. https://github.com/llvm/llvm-project/pull/127515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [Driver] Fix respecting libdir when locating flang runtime (PR #127345)

2025-02-16 Thread Michał Górny via cfe-commits
mgorny wrote: Sigh, looks like clang's driver is a mess around `lib`/`lib64` after all. So a proper solution would probably involve adding arch to the library name, and moving it into clang's resource directory. https://github.com/llvm/llvm-project/pull/127345 _

[clang] [clang] [Driver] Fix respecting libdir when locating flang runtime (PR #127345)

2025-02-16 Thread Michał Górny via cfe-commits
mgorny wrote: Hmm, but thinking about it, it should probably grab the right libdir from some multilib config rather than the hardwired build-time value. https://github.com/llvm/llvm-project/pull/127345 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [clang] [Driver] Fix respecting libdir when locating flang runtime (PR #127345)

2025-02-15 Thread Michał Górny via cfe-commits
mgorny wrote: > But `lib` is used for 32-bit libraries, and `lib64` for 64-bit libraries. …and just to be clear, Flang runtimes are installed into plain system `CMAKE_INSTALL_LIBDIR` rather than `clang/lib/...` path (along with the "host" Flang libraries), and they don't have any arch-suffix,

[clang] [clang] [Driver] Fix respecting libdir when locating flang runtime (PR #127345)

2025-02-15 Thread Michał Górny via cfe-commits
mgorny wrote: But `lib` is used for 32-bit libraries, and `lib64` for 64-bit libraries. https://github.com/llvm/llvm-project/pull/127345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [Driver] Fix respecting libdir when locating flang runtime (PR #127345)

2025-02-15 Thread Michał Górny via cfe-commits
https://github.com/mgorny created https://github.com/llvm/llvm-project/pull/127345 Fix `tools::addFortranRuntimeLibraryPath` to use `CLANG_INSTALL_LIBDIR_BASENAME` rather than hardwired `lib` directory. This fixes flang being unable to find its runtime when installed into nonstandard directory

[libclc] [libclc] [cmake] Fix per-target *_convert.cl dependencies (PR #127315)

2025-02-15 Thread Michał Górny via cfe-commits
https://github.com/mgorny edited https://github.com/llvm/llvm-project/pull/127315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] [cmake] Fix per-target *_convert.cl dependencies (PR #127315)

2025-02-15 Thread Michał Górny via cfe-commits
https://github.com/mgorny created https://github.com/llvm/llvm-project/pull/127315 Fix `add_libclc_builtin_set` to add an appropriate dependency to either `clspv-generate_convert.cl` or `generate_convert.cl` based on the `ARCH` argument, rather than to both unconditionally. This fixes build f

[libclc] [libclc] Move conversion builtins to the CLC library (PR #124727)

2025-02-15 Thread Michał Górny via cfe-commits
mgorny wrote: Ah, it's just incorrect dependency. Filed #127315 to fix it. https://github.com/llvm/llvm-project/pull/124727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Move conversion builtins to the CLC library (PR #124727)

2025-02-15 Thread Michał Górny via cfe-commits
mgorny wrote: I'm guessing that both `amdgcn` and `nvptx` targets now require `clspv-generate_convert.cl`, but the targets for them are defined only when `clspv` targets are enabled. No clue whether it means that the targets need to be defined unconditionally, or `clc-convert.cl` skipped when

[libclc] [libclc] Move conversion builtins to the CLC library (PR #124727)

2025-02-15 Thread Michał Górny via cfe-commits
mgorny wrote: The same failure also happens when SPIRV targets are disabled. https://github.com/llvm/llvm-project/pull/124727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Move conversion builtins to the CLC library (PR #124727)

2025-02-15 Thread Michał Górny via cfe-commits
mgorny wrote: This change broke standalone libclc builds on Gentoo: ``` make -C /tmp/portage/llvm-core/libclc-21.0.0_pre20250215/work/libclc_build/gentoo_common_config.cmake -G Ninja -DCMAKE_INSTALL_PREFIX=/usr -DLIBCLC_TARGETS_TO_BUILD=spirv-mesa3d-;spirv64-mesa3d-;r600--;amdgcn--;amdgcn-mes

[clang] [llvm] [clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this` (PR #122928)

2025-01-18 Thread Michał Górny via cfe-commits
mgorny wrote: Thanks! https://github.com/llvm/llvm-project/pull/122928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this` (PR #122928)

2025-01-18 Thread Michał Górny via cfe-commits
mgorny wrote: Thanks! https://github.com/llvm/llvm-project/pull/122928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "[clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this`" (PR #123455)

2025-01-17 Thread Michał Górny via cfe-commits
https://github.com/mgorny closed https://github.com/llvm/llvm-project/pull/123455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "[clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this`" (PR #123455)

2025-01-17 Thread Michał Górny via cfe-commits
https://github.com/mgorny created https://github.com/llvm/llvm-project/pull/123455 Reverts llvm/llvm-project#122928 From ce83c9470ba1a9860c107d39e60d9148ac009e91 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Date: Sat, 18 Jan 2025 07:59:09 + Subject: [PATCH] =?UTF-8?q

[clang] [llvm] [clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this` (PR #122928)

2025-01-17 Thread Michał Górny via cfe-commits
mgorny wrote: I'm going to revert because of the buildbot failures. https://github.com/llvm/llvm-project/pull/122928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [openmp] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-23 Thread Michał Górny via cfe-commits
mgorny wrote: @jhuber6, since I think this PR makes #119006 obsolete, should I merge that one while this one's still in the works, or close it? https://github.com/llvm/llvm-project/pull/119091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [clang-cl] Don't add implicit NoBuiltinAttr to deleted or defaulted functions (PR #119719)

2024-12-14 Thread Michał Górny via cfe-commits
mgorny wrote: This test is failing on x86: #119979 https://github.com/llvm/llvm-project/pull/119719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [openmp] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-08 Thread Michał Górny via cfe-commits
@@ -288,18 +258,11 @@ function(compileDeviceRTLLibrary target_cpu target_name target_triple) endif() endfunction() -# Generate a Bitcode library for all the gpu architectures the user requested. -add_custom_target(omptarget.devicertl.nvptx) add_custom_target(omptarget.devi

[clang] [llvm] [openmp] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-08 Thread Michał Górny via cfe-commits
@@ -288,18 +258,11 @@ function(compileDeviceRTLLibrary target_cpu target_name target_triple) endif() endfunction() -# Generate a Bitcode library for all the gpu architectures the user requested. -add_custom_target(omptarget.devicertl.nvptx) add_custom_target(omptarget.devi

[clang] [llvm] [openmp] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-08 Thread Michał Górny via cfe-commits
@@ -288,18 +258,11 @@ function(compileDeviceRTLLibrary target_cpu target_name target_triple) endif() endfunction() -# Generate a Bitcode library for all the gpu architectures the user requested. -add_custom_target(omptarget.devicertl.nvptx) add_custom_target(omptarget.devi

[clang] [llvm] [openmp] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-08 Thread Michał Górny via cfe-commits
@@ -288,18 +258,11 @@ function(compileDeviceRTLLibrary target_cpu target_name target_triple) endif() endfunction() -# Generate a Bitcode library for all the gpu architectures the user requested. -add_custom_target(omptarget.devicertl.nvptx) add_custom_target(omptarget.devi

[clang] [clang][Driver] Support simplified triple versions for config files (PR #111387)

2024-12-06 Thread Michał Górny via cfe-commits
https://github.com/mgorny approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/111387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [clang][driver] Special care for -l flags in config files (PR #117573)

2024-11-27 Thread Michał Górny via cfe-commits
https://github.com/mgorny approved this pull request. I don't see anything wrong but I don't consider myself an expert either. https://github.com/llvm/llvm-project/pull/117573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [flang] [clang][driver] Special care for -l flags in config files (PR #117573)

2024-11-25 Thread Michał Górny via cfe-commits
@@ -0,0 +1 @@ +-ffast-math -lm -lhappy mgorny wrote: Could you also include some "positional" `-Wl` flags, like `-Wl,-Bstatic` and `-Wl,-Bdynamic`? https://github.com/llvm/llvm-project/pull/117573 ___ cfe-commits mail

[libclc] [libclc] Create aliases with custom_command (PR #115885)

2024-11-13 Thread Michał Górny via cfe-commits
mgorny wrote: This change broke installing for us, see bug #115942. https://github.com/llvm/llvm-project/pull/115885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] Reland "[libclc] Create aliases with custom_command (#115885)" (PR #116025)

2024-11-13 Thread Michał Górny via cfe-commits
https://github.com/mgorny approved this pull request. I can confirm that libclc builds fine for me, with this patch applied. https://github.com/llvm/llvm-project/pull/116025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[libclc] [libclc] Create aliases with custom_command (PR #115885)

2024-11-12 Thread Michał Górny via cfe-commits
@@ -355,11 +355,13 @@ function(add_libclc_builtin_set) install( FILES ${CMAKE_CURRENT_BINARY_DIR}/${obj_suffix} DESTINATION "${CMAKE_INSTALL_DATADIR}/clc" ) foreach( a ${ARG_ALIASES} ) set( alias_suffix "${a}-${ARG_TRIPLE}.bc" ) -add_custom_target( ${alias_suffix}

[clang] [clang] Make LazyOffsetPtr more portable (PR #112927)

2024-10-19 Thread Michał Górny via cfe-commits
mgorny wrote: Doesn't it change ABI, though? https://github.com/llvm/llvm-project/pull/112927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] [Clang] Support for Gentoo `*t64` triples (64-bit time_t ABIs) (PR #111302)

2024-10-14 Thread Michał Górny via cfe-commits
https://github.com/mgorny closed https://github.com/llvm/llvm-project/pull/111302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] [Clang] Support for Gentoo `*t64` triples (64-bit time_t ABIs) (PR #111302)

2024-10-06 Thread Michał Górny via cfe-commits
https://github.com/mgorny updated https://github.com/llvm/llvm-project/pull/111302 From 3e057361eee9fa22f1a666857ce98019aba44ea2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Date: Sat, 5 Oct 2024 18:31:35 +0200 Subject: [PATCH 1/3] [llvm] [Triple] Support *t64 environment

[clang] [llvm] [LLVM] [Clang] Support for Gentoo `*t64` triples (64-bit time_t ABIs) (PR #111302)

2024-10-06 Thread Michał Górny via cfe-commits
@@ -177,6 +177,7 @@ createTargetCodeGenInfo(CodeGenModule &CGM) { else if (CodeGenOpts.FloatABI == "hard" || (CodeGenOpts.FloatABI != "soft" && (Triple.getEnvironment() == llvm::Triple::GNUEABIHF || mgorny wrote: Are you asking i

[clang] [llvm] [LLVM] [Clang] Support for Gentoo `*t64` triples (64-bit time_t ABIs) (PR #111302)

2024-10-06 Thread Michał Górny via cfe-commits
@@ -177,6 +177,7 @@ createTargetCodeGenInfo(CodeGenModule &CGM) { else if (CodeGenOpts.FloatABI == "hard" || (CodeGenOpts.FloatABI != "soft" && (Triple.getEnvironment() == llvm::Triple::GNUEABIHF || mgorny wrote: I'm wondering if

[clang] [llvm] [LLVM] [Clang] Support for Gentoo `*t64` triples (64-bit time_t ABIs) (PR #111302)

2024-10-06 Thread Michał Górny via cfe-commits
@@ -610,7 +610,8 @@ static llvm::Triple computeTargetTriple(const Driver &D, if (A->getOption().matches(options::OPT_m64) || A->getOption().matches(options::OPT_maix64)) { AT = Target.get64BitArchVariant().getArch(); - if (Target.getEnvironment() == llvm:

[clang] [llvm] [LLVM] [Clang] Support for Gentoo `*t64` triples (64-bit time_t ABIs) (PR #111302)

2024-10-06 Thread Michał Górny via cfe-commits
@@ -1283,6 +1283,28 @@ TEST(TripleTest, ParsedIDs) { EXPECT_EQ(Triple::Linux, T.getOS()); EXPECT_EQ(Triple::PAuthTest, T.getEnvironment()); + // Gentoo time64 triples + T = Triple("i686-pc-linux-gnut64"); + EXPECT_EQ(Triple::x86, T.getArch()); + EXPECT_EQ(Triple::PC, T

[clang] [llvm] [LLVM] [Clang] Support for Gentoo `*t64` triples (64-bit time_t ABIs) (PR #111302)

2024-10-06 Thread Michał Górny via cfe-commits
https://github.com/mgorny updated https://github.com/llvm/llvm-project/pull/111302 From 3e057361eee9fa22f1a666857ce98019aba44ea2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Date: Sat, 5 Oct 2024 18:31:35 +0200 Subject: [PATCH 1/2] [llvm] [Triple] Support *t64 environment

[clang] [llvm] [LLVM] [Clang] Support for Gentoo `*t64` triples (64-bit time_t ABIs) (PR #111302)

2024-10-06 Thread Michał Górny via cfe-commits
https://github.com/mgorny updated https://github.com/llvm/llvm-project/pull/111302 From df75eaa8e0f399a43bde9e60af326f0c91aa7ad4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Date: Sat, 5 Oct 2024 18:31:35 +0200 Subject: [PATCH 1/2] [llvm] [Triple] Support *t64 environment

[clang] [llvm] [LLVM] [Clang] Support for Gentoo `*t64` triples (64-bit time_t ABIs) (PR #111302)

2024-10-06 Thread Michał Górny via cfe-commits
@@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -E -dM -triple=i686-pc-linux-gnu < /dev/null | FileCheck -match-full-lines -check-prefix TIME32 %s mgorny wrote: Yeah, I was wondering if it's in the `init.c` tests for a reason. https://github.com/llvm/llvm-project/pull/111

[clang] [llvm] [LLVM] [Clang] Support for Gentoo `*t64` triples (64-bit time_t ABIs) (PR #111302)

2024-10-06 Thread Michał Górny via cfe-commits
https://github.com/mgorny created https://github.com/llvm/llvm-project/pull/111302 Gentoo is planning to introduce a `*t64` suffix for triples that will be used by 32-bit platforms that use 64-bit `time_t`. Add support for parsing and accepting these triples, and while at it make clang automat

[clang] [Clang] Replace vt_gen with LLVMCodeGenTypes (PR #109601)

2024-09-24 Thread Michał Górny via cfe-commits
https://github.com/mgorny approved this pull request. Thanks! This fixes the problem with standalone builds for me. https://github.com/llvm/llvm-project/pull/109601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] Add missing deps edge: CodeGenAction.cpp.o -> GenVT.inc (PR #109306)

2024-09-24 Thread Michał Górny via cfe-commits
mgorny wrote: This broke standalone clang builds: ``` -- Configuring done (6.4s) CMake Error at /usr/lib/llvm/20/lib/cmake/llvm/AddLLVM.cmake:587 (add_dependencies): The dependency target "vt_gen" of target "obj.clangCodeGen" does not exist. Call Stack (most recent call first): cmake/module

[clang] The real option name and not the alias used is displayed in msgs when using a config file (PR #107613)

2024-09-16 Thread Michał Górny via cfe-commits
https://github.com/mgorny approved this pull request. Seems to make sense and is roughly consistent with the code above. https://github.com/llvm/llvm-project/pull/107613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] scan-build-py: respect LLVM_LIBDIR_SUFFIX like other tools do (PR #108549)

2024-09-14 Thread Michał Górny via cfe-commits
mgorny wrote: Sounds like a bug in OpenEmbedded then. CPython installs Python modules in `/usr/lib`, unconditionally. https://github.com/llvm/llvm-project/pull/108549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [clang] Install scan-build-py into plain "lib" directory (#106608) (PR #106612)

2024-08-30 Thread Michał Górny via cfe-commits
https://github.com/mgorny closed https://github.com/llvm/llvm-project/pull/106612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0c4cf79 - [clang] Install scan-build-py into plain "lib" directory (#106612)

2024-08-30 Thread Michał Górny via cfe-commits
Author: Michał Górny Date: 2024-08-30T16:30:19+02:00 New Revision: 0c4cf79defe30d43279bf4526cdf32b6c7f8a197 URL: https://github.com/llvm/llvm-project/commit/0c4cf79defe30d43279bf4526cdf32b6c7f8a197 DIFF: https://github.com/llvm/llvm-project/commit/0c4cf79defe30d43279bf4526cdf32b6c7f8a197.diff

[clang] [clang] Install scan-build-py into plain "lib" directory (#106608) (PR #106612)

2024-08-29 Thread Michał Górny via cfe-commits
https://github.com/mgorny created https://github.com/llvm/llvm-project/pull/106612 Install scan-build-py modules into the plain `lib` directory, without LLVM_LIBDIR_SUFFIX appended, to match the path expected by `intercept-build` executable. This fixes the program being unable to find its mod

[libclc] libclc: add half version of 'sign' (PR #99841)

2024-07-22 Thread Michał Górny via cfe-commits
mgorny wrote: Thanks. I can confirm that the tests pass for me with this change applied. https://github.com/llvm/llvm-project/pull/99841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] libclc: increase fp16 support (PR #98149)

2024-07-20 Thread Michał Górny via cfe-commits
mgorny wrote: This change seems to have caused test regression. This is Gentoo Linux amd64, tried LLVM 72d8c2737bb557af9d0c735b9fa30b1b03485627 and 18.1.8. To reproduce, I've done: ``` cmake -G Ninja "${llvm_project}"/libclc -DLIBCLC_TARGETS_TO_BUILD="spirv-mesa3d-;spirv64-mesa3d-;r600--;amdg

[clang] [C2y] Claim partial conformance to WG14 N3244 (PR #98525)

2024-07-15 Thread Michał Górny via cfe-commits
mgorny wrote: Thanks. I can confirm that the tests pass for me with the patch applied. https://github.com/llvm/llvm-project/pull/98525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C2y] Claim partial conformance to WG14 N3244 (PR #98525)

2024-07-13 Thread Michał Górny via cfe-commits
mgorny wrote: The added test fails on 32-bit x86: ``` FAIL: Clang :: C/C2y/n3244.c (1461 of 20066) TEST 'Clang :: C/C2y/n3244.c' FAILED Exit Code: 1 Command Output (stderr): -- RUN: at line 1: /var/tmp/portage/sys-devel/clang-19.0.0_pre20240713/work/x/

[clang-tools-extra] [llvm] [clang-doc] fix bug introduced by asset test (PR #97540)

2024-07-09 Thread Michał Górny via cfe-commits
mgorny wrote: Thank you. https://github.com/llvm/llvm-project/pull/97540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clang-doc] fix bug introduced by asset test (PR #97540)

2024-07-06 Thread Michał Górny via cfe-commits
mgorny wrote: This change broke standalone clang builds against installed LLVM, since `LLVM_SHARE_OUTPUT_INTDIR` is not exported by LLVM and therefore resolves to an empty path: ``` ninja: error: mkdir(/clang-doc): Permission denied ninja: build stopped: . ``` Why are you even declaring the d

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

2024-06-22 Thread Michał Górny via cfe-commits
mgorny wrote: Thanks! https://github.com/llvm/llvm-project/pull/96136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

2024-06-22 Thread Michał Górny via cfe-commits
mgorny wrote: Also hit it on 32-bit x86; filed #96379 before I managed to bisect it. https://github.com/llvm/llvm-project/pull/96136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [llvm] [libclc] Refactor build system to allow in-tree builds (PR #87622)

2024-04-10 Thread Michał Górny via cfe-commits
mgorny wrote: Yeah, things seem to build and install fine for me too, with this patch applied. https://github.com/llvm/llvm-project/pull/87622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

2024-04-08 Thread Michał Górny via cfe-commits
mgorny wrote: Yeah, it built this time for me too. Thanks, again! https://github.com/llvm/llvm-project/pull/87505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

2024-04-08 Thread Michał Górny via cfe-commits
mgorny wrote: Thanks. Unfortunately, I'm still getting a build failure: ``` [1792/1922] cd /tmp/portage/dev-libs/libclc-19.0.0./work/libclc_build && /usr/lib/llvm/17/bin/llvm-spirv --spirv-max-version=1.1 -o spirv-mesa3d-.spv builtins.link.spirv-mesa3d- FAILED: spirv-mesa3d-.spv /tmp/port

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

2024-04-08 Thread Michał Górny via cfe-commits
mgorny wrote: ``` set( spv_suffix ${arch_suffix}.spv ) add_custom_command( OUTPUT "${spv_suffix}" COMMAND ${LLVM_SPIRV} ${spvflags} -o "${spv_suffix}" ${builtins_opt_lib_tgt} DEPENDS ${builtins_link_lib_tgt} ) ``` I think that ought to be `DEPENDS ${builtins_opt_lib_

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

2024-04-08 Thread Michał Górny via cfe-commits
mgorny wrote: Thanks. This seems to fix that problem. However, now I'm seeing missing dep in build ordering: ``` [1793/1922] cd /tmp/portage/dev-libs/libclc-19.0.0./work/libclc_build && /usr/lib/llvm/17/bin/llvm-spirv --spirv-max-version=1.1 -o spirv-mesa3d-.spv builtins.opt.spirv-mesa3d-

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

2024-04-06 Thread Michał Górny via cfe-commits
mgorny wrote: This change broke standalone build against LLVM dylib — it now insists on linking to non-existing static libraries: ``` FAILED: prepare_builtins : && /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -march=znver2 --param=l1-cache-size=32 --param=l1-cache-line-size=64 -O2 -pipe -frec

[clang] [clang] [cmake] Add cmake module dir before using GetDarwinLinkerVersion (PR #86386)

2024-03-23 Thread Michał Górny via cfe-commits
https://github.com/mgorny closed https://github.com/llvm/llvm-project/pull/86386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [cmake] Add cmake module dir before using GetDarwinLinkerVersion (PR #86386)

2024-03-23 Thread Michał Górny via cfe-commits
mgorny wrote: Thanks! https://github.com/llvm/llvm-project/pull/86386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [cmake] Add cmake module dir before using GetDarwinLinkerVersion (PR #86386)

2024-03-23 Thread Michał Górny via cfe-commits
https://github.com/mgorny created https://github.com/llvm/llvm-project/pull/86386 Move the code adding top-level cmake/Modules directory to CMAKE_MODULE_PATH prior to including `GetDarwinLinkerVersion`, in order to fix standalone builds. Fixes a regression introduced by 3bc71c2abfa00413fd15cf0

[clang] [flang] [llvm] [Docs] Allow building man pages without myst_parser (PR #82402)

2024-02-23 Thread Michał Górny via cfe-commits
@@ -35,8 +35,16 @@ import sphinx -if sphinx.version_info >= (3, 0): -extensions.append("myst_parser") +# When building man pages, we do not use the markdown pages, +# So, we can continue without the myst_parser dependencies. +# Doing so reduces dependencies of some packag

[clang] [flang] [llvm] [Docs] Allow building man pages without myst_parser (PR #82402)

2024-02-23 Thread Michał Górny via cfe-commits
https://github.com/mgorny approved this pull request. Thank you. From a quick test run with and without `myst-parser`, this seems to work as intended. https://github.com/llvm/llvm-project/pull/82402 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [flang] [llvm] [Docs] Allow building man pages without myst_parser (PR #82402)

2024-02-23 Thread Michał Górny via cfe-commits
https://github.com/mgorny edited https://github.com/llvm/llvm-project/pull/82402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [Documentation] Replace recommonmark by myst-parser (PR #65664)

2024-02-20 Thread Michał Górny via cfe-commits
mgorny wrote: I've adjusted the Gentoo packages, and can live with it. I just find it sad that even though there was an explicit comment on why the `ImportError` fallback was added, it was just removed without a second thought or even an attempt to communicate with me (given `git blame` would

[clang] [flang] [llvm] [Documentation] Replace recommonmark by myst-parser (PR #65664)

2024-02-20 Thread Michał Górny via cfe-commits
mgorny wrote: What used to work is that you could build manpages (that don't use any `.md` files) without installing additional dependencies. Now Sphinx requires myst-parser even when no `.md` files are used. *I* don't really care. However, Gentoo users do tend to complain whenever any single

[clang] [flang] [llvm] [Documentation] Replace recommonmark by myst-parser (PR #65664)

2024-02-17 Thread Michał Górny via cfe-commits
mgorny wrote: I'm sorry for being late to the party but what's the rationale for removing support for building manpages without myst-parser, that FWICS isn't used for manpages at all? I don't see any answer neither in the commit message, nor in this thread. It really feels like you've just *sh

[openmp] [libcxx] [llvm] [compiler-rt] [libcxxabi] [clang] [mlir] [lld] [runtimes] Use LLVM libunwind from libc++abi by default (PR #77687)

2024-01-13 Thread Michał Górny via cfe-commits
mgorny wrote: FTR, this breaks standalone builds against installed LLVM's libunwind since `unwind_shared` target doesn't exist. However, as long as I can pass `-DLIBCXXABI_USE_LLVM_UNWINDER=OFF` that just does the right thing, it's fine with me. https://github.com/llvm/llvm-project/pull/77687

[clang] [Clang] Remove NetBSD/i386 workaround for FP eval method with older versions (PR #74025)

2023-12-02 Thread Michał Górny via cfe-commits
https://github.com/mgorny approved this pull request. Code LGTM but please add a note to the release notes, as was requested. https://github.com/llvm/llvm-project/pull/74025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang-tools-extra] 3bff90e - [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp

2023-03-24 Thread Michał Górny via cfe-commits
Author: Michał Górny Date: 2023-03-24T20:25:31+01:00 New Revision: 3bff90e7e84aad6f0fddaf1d17a7db011052b95d URL: https://github.com/llvm/llvm-project/commit/3bff90e7e84aad6f0fddaf1d17a7db011052b95d DIFF: https://github.com/llvm/llvm-project/commit/3bff90e7e84aad6f0fddaf1d17a7db011052b95d.diff

[clang] 0f8b995 - [clang] Fix linking to LLVMTestingAnnotations in standalone build

2023-01-24 Thread Michał Górny via cfe-commits
Author: Michał Górny Date: 2023-01-24T13:21:24+01:00 New Revision: 0f8b995b63620c3eb57610f958f66691d38d7185 URL: https://github.com/llvm/llvm-project/commit/0f8b995b63620c3eb57610f958f66691d38d7185 DIFF: https://github.com/llvm/llvm-project/commit/0f8b995b63620c3eb57610f958f66691d38d7185.diff

[clang] dab67c6 - [clang] [OpenMP] Test amdgcn_openmp_device_math_c.c test on 32-bit platforms

2022-12-26 Thread Michał Górny via cfe-commits
Author: Michał Górny Date: 2022-12-26T10:38:40+01:00 New Revision: dab67c66932b9149842f7c8431e951f952125fc0 URL: https://github.com/llvm/llvm-project/commit/dab67c66932b9149842f7c8431e951f952125fc0 DIFF: https://github.com/llvm/llvm-project/commit/dab67c66932b9149842f7c8431e951f952125fc0.diff

[clang] b3f94fe - [clang][Driver] allow tilde in user config dir

2022-11-16 Thread Michał Górny via cfe-commits
Author: Michał Górny Date: 2022-11-16T13:23:25+01:00 New Revision: b3f94fe1c3c4f4fd7a937288b5543c4067b3e2f2 URL: https://github.com/llvm/llvm-project/commit/b3f94fe1c3c4f4fd7a937288b5543c4067b3e2f2 DIFF: https://github.com/llvm/llvm-project/commit/b3f94fe1c3c4f4fd7a937288b5543c4067b3e2f2.diff

[clang] 20132d8 - Link libclangBasic against libatomic when necessary.

2022-11-03 Thread Michał Górny via cfe-commits
Author: Sam James Date: 2022-11-03T21:07:44+01:00 New Revision: 20132d8eaa68a6c53e152718beda1dc0f4c9ff6c URL: https://github.com/llvm/llvm-project/commit/20132d8eaa68a6c53e152718beda1dc0f4c9ff6c DIFF: https://github.com/llvm/llvm-project/commit/20132d8eaa68a6c53e152718beda1dc0f4c9ff6c.diff LOG

[clang] 9dd01a5 - Harmonize cmake_policy() across standalone builds of all projects

2022-10-27 Thread Michał Górny via cfe-commits
Author: Michał Górny Date: 2022-10-28T08:46:48+02:00 New Revision: 9dd01a5241dc5b46e92485e05bc345221df8938c URL: https://github.com/llvm/llvm-project/commit/9dd01a5241dc5b46e92485e05bc345221df8938c DIFF: https://github.com/llvm/llvm-project/commit/9dd01a5241dc5b46e92485e05bc345221df8938c.diff

  1   2   3   4   >