Author: Matthias Gehre
Date: 2022-06-09T07:15:03+01:00
New Revision: 7e17e15c9f01a04283524c6a6735d639aac39fe6
URL:
https://github.com/llvm/llvm-project/commit/7e17e15c9f01a04283524c6a6735d639aac39fe6
DIFF:
https://github.com/llvm/llvm-project/commit/7e17e15c9f01a04283524c6a6735d639aac39fe6.diff
Author: Matthias Gehre
Date: 2020-06-03T12:19:06+02:00
New Revision: add51e152aa6dc3aa7a51901a099b2ebe8cfe377
URL:
https://github.com/llvm/llvm-project/commit/add51e152aa6dc3aa7a51901a099b2ebe8cfe377
DIFF:
https://github.com/llvm/llvm-project/commit/add51e152aa6dc3aa7a51901a099b2ebe8cfe377.diff
Author: Matthias Gehre
Date: 2020-04-27T14:23:23+02:00
New Revision: 145dcef8bdf9da9684c9c4e34a8e6c45baafab74
URL:
https://github.com/llvm/llvm-project/commit/145dcef8bdf9da9684c9c4e34a8e6c45baafab74
DIFF:
https://github.com/llvm/llvm-project/commit/145dcef8bdf9da9684c9c4e34a8e6c45baafab74.diff
Author: Matthias Gehre
Date: 2020-04-17T10:37:24+02:00
New Revision: 0642e5e7a7e54a11120262cfafea0193e3a75faf
URL:
https://github.com/llvm/llvm-project/commit/0642e5e7a7e54a11120262cfafea0193e3a75faf
DIFF:
https://github.com/llvm/llvm-project/commit/0642e5e7a7e54a11120262cfafea0193e3a75faf.diff
Author: Matthias Gehre
Date: 2020-04-09T19:26:41+02:00
New Revision: eaa55590945a130131a47a4d2b89e3bbdfced79e
URL:
https://github.com/llvm/llvm-project/commit/eaa55590945a130131a47a4d2b89e3bbdfced79e
DIFF:
https://github.com/llvm/llvm-project/commit/eaa55590945a130131a47a4d2b89e3bbdfced79e.diff
Author: Matthias Gehre
Date: 2019-11-06T09:27:02+01:00
New Revision: 24130d661ed42c30f009b695d3c9ce57d2208b5e
URL:
https://github.com/llvm/llvm-project/commit/24130d661ed42c30f009b695d3c9ce57d2208b5e
DIFF:
https://github.com/llvm/llvm-project/commit/24130d661ed42c30f009b695d3c9ce57d2208b5e.diff
s/stdio
>
> Thanks,
> Yvan
>
> On Fri, 6 Sep 2019 at 10:54, Matthias Gehre via cfe-commits
> wrote:
> >
> > Author: mgehre
> > Date: Fri Sep 6 01:56:30 2019
> > New Revision: 371182
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=371182&view=
Author: mgehre
Date: Fri Sep 6 12:15:02 2019
New Revision: 371241
URL: http://llvm.org/viewvc/llvm-project?rev=371241&view=rev
Log:
[LifetimeAnalysis] don't use raw string literals in macros
They broke the AArch64 bots (gcc does not support it)
Modified:
cfe/trunk/unittests/Sema/GslOwnerPoi
Author: mgehre
Date: Fri Sep 6 01:56:30 2019
New Revision: 371182
URL: http://llvm.org/viewvc/llvm-project?rev=371182&view=rev
Log:
Reland [LifetimeAnalysis] Support more STL idioms (template forward declaration
and DependentNameType)
Reland after https://reviews.llvm.org/D66806 fixed the false
t;
>> If we can make the gsl::Pointer diagnostics false-positive-free, that's
>> great, but otherwise we should use a different warning flag for the
>> warnings that involve these annotations and use -Wreturn-stack-address for
>> only the zero-false-positive cases
Author: mgehre
Date: Wed Aug 21 15:08:59 2019
New Revision: 369591
URL: http://llvm.org/viewvc/llvm-project?rev=369591&view=rev
Log:
[LifetimeAnalysis] Support more STL idioms (template forward declaration and
DependentNameType)
Summary:
This fixes inference of gsl::Pointer on std::set::iterator
Author: mgehre
Date: Wed Aug 14 14:55:57 2019
New Revision: 368929
URL: http://llvm.org/viewvc/llvm-project?rev=368929&view=rev
Log:
[LifetimeAnalysis] Support std::stack::top() and std::optional::value()
Summary: Diagnose dangling pointers that come from std::stack::top() and
std::optional::val
Author: mgehre
Date: Wed Aug 7 03:45:36 2019
New Revision: 368147
URL: http://llvm.org/viewvc/llvm-project?rev=368147&view=rev
Log:
gsl::Owner/gsl::Pointer: Add implicit annotations for some std types
Summary:
Hard code gsl::Owner/gsl::Pointer for std types. The paper mentions
some types explici
Author: mgehre
Date: Thu Jul 25 10:50:51 2019
New Revision: 367040
URL: http://llvm.org/viewvc/llvm-project?rev=367040&view=rev
Log:
Add lifetime categories attributes
Summary:
This is the first part of work announced in
"[RFC] Adding lifetime analysis to clang" [0],
i.e. the addition of the [[gs
Author: mgehre
Date: Tue Jul 16 14:19:00 2019
New Revision: 366265
URL: http://llvm.org/viewvc/llvm-project?rev=366265&view=rev
Log:
[clang-tidy] initial version of readability-convert-member-functions-to-static
Summary:
Finds non-static member functions that can be made ``static``.
I have run t
Author: mgehre
Date: Fri Jun 21 14:30:25 2019
New Revision: 364106
URL: http://llvm.org/viewvc/llvm-project?rev=364106&view=rev
Log:
[clang-tidy] misc-unused-parameters: don't comment out parameter name for C code
Summary: The fixit `int square(int /*num*/)` yields `error: parameter name
omitted
Author: mgehre
Date: Thu May 23 22:46:57 2019
New Revision: 361601
URL: http://llvm.org/viewvc/llvm-project?rev=361601&view=rev
Log:
[clang-tidy] Add option "LiteralInitializers" to
cppcoreguidelines-pro-type-member-init
Differential Revision: D24892
Added:
clang-tools-extra/trunk/test/cla
Author: mgehre
Date: Tue May 14 11:23:10 2019
New Revision: 360698
URL: http://llvm.org/viewvc/llvm-project?rev=360698&view=rev
Log:
[clang-tidy] Fix invalid fixit for readability-static-accessed-through-instance
(bug 40544)
Summary:
Fixed https://bugs.llvm.org/show_bug.cgi?id=40544
Before, we w
Author: mgehre
Date: Mon May 13 12:21:57 2019
New Revision: 360613
URL: http://llvm.org/viewvc/llvm-project?rev=360613&view=rev
Log:
[clang-tidy] readability-redundant-declaration: fix false positive with C
"extern inline"
Summary:
readability-redundant-declaration was diagnosing a redundant dec
Author: mgehre
Date: Wed Jul 12 00:04:19 2017
New Revision: 307759
URL: http://llvm.org/viewvc/llvm-project?rev=307759&view=rev
Log:
CFG: Add CFGElement for automatic variables that leave the scope
Summary:
This mimics the implementation for the implicit destructors. The
generation of this scope
Author: mgehre
Date: Tue Apr 4 15:11:13 2017
New Revision: 299465
URL: http://llvm.org/viewvc/llvm-project?rev=299465&view=rev
Log:
[clang-format] fix crash in NamespaceEndCommentsFixer (PR32438)
Summary:
The new test case was crashing before. Now it passes
as expected.
Reviewers: djasper
Subs
Author: mgehre
Date: Mon Mar 27 14:45:24 2017
New Revision: 298880
URL: http://llvm.org/viewvc/llvm-project?rev=298880&view=rev
Log:
Add [[clang::suppress(rule, ...)]] attribute
Summary:
This patch implements parsing of [[clang::suppress(rule, ...)]]
and [[gsl::suppress(rule, ...)]] attributes.
Author: mgehre
Date: Fri Mar 17 16:41:20 2017
New Revision: 298126
URL: http://llvm.org/viewvc/llvm-project?rev=298126&view=rev
Log:
Implement DR 373 "Lookup on namespace qualified name in using-directive"
Summary:
3.4.6 [basic.lookup.udir] paragraph 1:
In a using-directive or namespace-alias-def
mgehre added a comment.
With this fix, is there still a warning on the following code?
if(b) {
...
if(c)
return;
else
doSomething()
...
}
I would expect that the check still warns on it.
https://reviews.llvm.org/D26125
mgehre added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2509
+to suppress specific clang-tidy warnings. They can be attached to a scope,
+statement or type. The ``[[gsl::suppress]]`` is an alias of
``[[clang::suppress]]``
+which is intended to be used for suppr
mgehre added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.cpp:25
- Finder->addMatcher(cxxReinterpretCastExpr().bind("cast"), this);
+ std::vector Rules{"type", "type.1",
"cppcoreguidelines-pro-type-reinterpret-cast"};
+
Finder->addM
mgehre updated this revision to Diff 72981.mgehre added a comment.
View RevisionAdd additional gsl::suppress spelling, add test, add documentationhttps://reviews.llvm.org/D24886Files:include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/Sema/SemaDeclAttr.cpp
lib/Sema/SemaStmtAttr.cpp
test
mgehre added a comment.
My main goal is to be able to suppress any clang-tidy warning through an
attribute. Initially, I though we could reuse the C++ Core Guidelines attribute
for that,
(because I though it was plain [[suppress]]). As a bonus (not more), we would
have interoperability with oth
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282625: [clang-tidy] fix false-positive for
cppcoreguidelines-pro-type-member-init… (authored by mgehre).
Changed prior to commit:
https://reviews.llvm.org/D24848?vs=72677&id=72885#toc
Repository:
rL
Author: mgehre
Date: Wed Sep 28 15:06:18 2016
New Revision: 282625
URL: http://llvm.org/viewvc/llvm-project?rev=282625&view=rev
Log:
[clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init with
in-class initializers
Summary:
This fixes https://llvm.org/bugs/show_bug.cgi?id=304
mgehre added a comment.
In the C++ Core Guidelines issue on namespaceing of the [[suppress]], it was
state that Microsoft uses
[[gsl::suppress]] and it is the intent to update the C++ Core Guidelines to
[[gsl::suppress]].
https://reviews.llvm.org/D24886
_
mgehre added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.cpp:25
@@ -23,2 +24,3 @@
- Finder->addMatcher(cxxReinterpretCastExpr().bind("cast"), this);
+ std::vector Rules{"type", "type.1",
"cppcoreguidelines-pro-type-reinterpret-cast"};
mgehre added a comment.
I would like to close that particular bug report, and thus I would like to have
the reproducer of that bug as part of the test case.
The PositivePartiallyInClassInitialized is also a good test, but I fail to see
how it is proves that that particular bug is solved.
Are yo
mgehre updated this revision to Diff 72677.
mgehre added a comment.
Rename the struct that was introduced in the test. Note that I need to keep the
function Bug30487,
because that is where the false-positive warning was emitted.
https://reviews.llvm.org/D24848
Files:
clang-tidy/utils/TypeTra
mgehre added a comment.
Thank your very much for your comments!
Let me try to give me reasoning for those points:
1. But it's missing some pieces, like test cases
I though about how to test this, having no semantic meaning itself.
I could look at the AST dump, but it does not even show the
rules
mgehre updated this revision to Diff 72394.
mgehre added a comment.
Extend test to negative case
https://reviews.llvm.org/D24892
Files:
clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h
docs/clang-tidy/checks/cppcoreguidelines-pr
mgehre created this revision.
mgehre added reviewers: alexfh, aaron.ballman, hokein.
mgehre added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
Adds the option "LiteralInitializers" to
cppcoreguidelines-pro-type-member-init.
If set to non-zero, the check will provide fix-its with
mgehre added a comment.
I'm sorry if this sounds dumb, but is there a way for me to follow that
particular discussion?
https://reviews.llvm.org/D22587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282330: [clang-tidy] fix for NOLINT after macro expansion
(authored by mgehre).
Changed prior to commit:
https://reviews.llvm.org/D24845?vs=72214&id=72391#toc
Repository:
rL LLVM
https://reviews.llv
Author: mgehre
Date: Sat Sep 24 11:06:53 2016
New Revision: 282330
URL: http://llvm.org/viewvc/llvm-project?rev=282330&view=rev
Log:
[clang-tidy] fix for NOLINT after macro expansion
Summary:
When having
``` c++
#define MACRO code-with-warning
MACRO; // NOLINT
```
clang-tidy would still s
mgehre updated this revision to Diff 72366.
mgehre added a comment.
Include link to corresponding clang-tidy patch
https://reviews.llvm.org/D24886
Files:
include/clang/Basic/Attr.td
lib/Sema/SemaDeclAttr.cpp
lib/Sema/SemaStmtAttr.cpp
Index: lib/Sema/SemaStmtAttr.cpp
=
mgehre updated this revision to Diff 72365.
mgehre added a comment.
Minor fix
https://reviews.llvm.org/D24888
Files:
clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.cpp
clang-tidy/cppcoreguidelines/Suppression.h
docs/clang-tidy/checks/cppcoreguidelines-pro-type-reinterpret-cast.r
mgehre created this revision.
mgehre added reviewers: alexfh, aaron.ballman.
mgehre added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
This is a proof-of-concept how the [[clang::suppress(tags,...)]] attribute can
work with suppressing clang-tidy warnings.
The list of tags that
mgehre created this revision.
mgehre added reviewers: alexfh, aaron.ballman, rsmith.
mgehre added a subscriber: cfe-commits.
This patch implements parsing of [[clang::suppress(rule, ...)]]
attributes.
C++ Core Guidelines depend heavily on tool support for
rule enforcement. They also propose a way
mgehre created this revision.
mgehre added reviewers: alexfh, aaron.ballman.
mgehre added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
This fixes https://llvm.org/bugs/show_bug.cgi?id=30487 where
```
warning: uninitialized record type: 's' [cppcoreguidelines-pro-type-member-init
mgehre created this revision.
mgehre added reviewers: alexfh, aaron.ballman, hokein.
mgehre added a subscriber: cfe-commits.
When having
``` c++
#define MACRO code-with-warning
MACRO; // NOLINT
```
clang-tidy would still show the warning, because
it searched for "NOLINT" only in the first
mgehre added a comment.
ping
https://reviews.llvm.org/D22587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgehre added a comment.
ping
https://reviews.llvm.org/D22476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgehre added a comment.
Friendly ping
https://reviews.llvm.org/D15031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgehre added inline comments.
Comment at: lib/AST/ASTContext.cpp:4456
@@ +4455,3 @@
+ // the template parameter and not an expression involving the template
parameter.
+ auto *E = Arg.getAsExpr()->IgnoreImpCasts();
+ while(auto *DeclRef = dyn_cast_or_null(E)) {
---
mgehre updated this revision to Diff 64777.
mgehre added a comment.
- Properly check for being member of current instantiation.
- Add new testcase test/CXX/temp/temp.res/temp.dep/temp.dep.expr/p5.cpp
- Added assert() according to review comment
https://reviews.llvm.org/D22476
Files:
lib/AST/E
mgehre created this revision.
mgehre added reviewers: klimek, aaron.ballman, rsmith.
mgehre added a subscriber: cfe-commits.
Look through expressions to determine if a nontype template argument has been
given the value of the template parameter.
https://reviews.llvm.org/D22587
Files:
lib/AST/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276111: clang-tidy modernize-loop-convert: preserve type of
alias declaration (bug… (authored by mgehre).
Changed prior to commit:
https://reviews.llvm.org/D22069?vs=63400&id=64672#toc
Repository:
rL
Author: mgehre
Date: Wed Jul 20 07:32:06 2016
New Revision: 276111
URL: http://llvm.org/viewvc/llvm-project?rev=276111&view=rev
Log:
clang-tidy modernize-loop-convert: preserve type of alias declaration (bug
28341)
Summary:
Previoly, the added test failed with the fillowing fixit:
char v[5
Author: mgehre
Date: Tue Jul 19 12:02:54 2016
New Revision: 275993
URL: http://llvm.org/viewvc/llvm-project?rev=275993&view=rev
Log:
cppcoreguidelines-pro-bounds-constant-array-index: ignore implicit constructor
Summary:
The code
struct A {
int x[3];
};
gets an compiler-generated copy c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275993: cppcoreguidelines-pro-bounds-constant-array-index:
ignore implicit constructor (authored by mgehre).
Changed prior to commit:
https://reviews.llvm.org/D22381?vs=64035&id=64515#toc
Repository:
mgehre created this revision.
mgehre added reviewers: klimek, aaron.ballman, rsmith.
mgehre added a subscriber: cfe-commits.
A MemberExpr is non-dependent if
1) it is a member of the current instantiation
2) the member is non-dependent
We check 1) by asserting that the base of the
MemberExpr is a
mgehre added a comment.
Friendly ping
https://reviews.llvm.org/D22069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgehre added a comment.
I additionally have run the check on blender and ITK and the assert did not
fire.
https://reviews.llvm.org/D22069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
mgehre created this revision.
mgehre added reviewers: alexfh, aaron.ballman.
mgehre added a subscriber: cfe-commits.
Herald added subscribers: nemanjai, aemerson.
The code
struct A {
int x[3];
};
gets an compiler-generated copy constructor that uses ArraySubscriptExpr (see
below).
Previ
Author: mgehre
Date: Thu Jul 14 15:00:48 2016
New Revision: 275461
URL: http://llvm.org/viewvc/llvm-project?rev=275461&view=rev
Log:
cppcoreguidelines-pro-bounds-constant-array-index: crash for value dependent
index in c++03 mode
Summary:
When the expression is value dependent,
isIntegerConstant
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275461: cppcoreguidelines-pro-bounds-constant-array-index:
crash for value dependent… (authored by mgehre).
Changed prior to commit:
https://reviews.llvm.org/D22190?vs=63795&id=64030#toc
Repository:
mgehre updated this revision to Diff 63795.
mgehre added a comment.
Suppress diagnostics if index is value-dependent. Emit them in specializations.
http://reviews.llvm.org/D22190
Files:
clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp
test/clang-tidy/cppcoreguidelines-pro-b
mgehre added a subscriber: mgehre.
mgehre added a comment.
Nice check. This should be mentioned in docs/ReleaseNotes.rst
http://reviews.llvm.org/D0
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
mgehre added a comment.
Even if we change isIntegerConstantExpr() to return true instead of asserting,
we still need this fix to the check. Because
we call isIntegerConstantExpr() to find out if we can possibly calculate the
(constant) value of the index expression.
If it is value dependent, we
mgehre created this revision.
mgehre added reviewers: alexfh, aaron.ballman.
mgehre added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
When the expression is value dependent,
isIntegerConstantExpr() crashes in C++03 mode with
../tools/clang/lib/AST/ExprConstant.cpp:9330: (anony
mgehre updated this revision to Diff 63400.
mgehre added a comment.
Added assert.
Runs on llvm code-base without triggering the assert.
http://reviews.llvm.org/D22069
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
test/clang-tidy/modernize-loop-convert-extra.cpp
Index: test/clang-tidy/mo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274985: clang-tidy/readability-identifier-naming: crash on…
(authored by mgehre).
Changed prior to commit:
http://reviews.llvm.org/D22188?vs=63397&id=63398#toc
Repository:
rL LLVM
http://reviews.llv
Author: mgehre
Date: Sat Jul 9 15:09:28 2016
New Revision: 274985
URL: http://llvm.org/viewvc/llvm-project?rev=274985&view=rev
Log:
clang-tidy/readability-identifier-naming: crash on
DependentTemplateSpecializationType
Summary:
Previously, the added test cases crashed because the passed a null
mgehre added a comment.
I didn't see that bug before, but with my patch, I cannot reproduce the
reported crash.
So I guess that fixed it.
http://reviews.llvm.org/D22188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
mgehre updated this revision to Diff 63397.
mgehre added a comment.
Add a second test case and fix
http://reviews.llvm.org/D22188
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readability-identifier-naming.cpp
Index: test/clang-tidy/readability-identifier-naming.c
mgehre created this revision.
mgehre added a reviewer: alexfh.
mgehre added a subscriber: cfe-commits.
Previously, the added test cases crashed because
Ref.getTypePtr()->getAsTagDecl()
is nullptr.
http://reviews.llvm.org/D22188
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/cl
mgehre added inline comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:525
@@ +524,3 @@
+ DeclarationType = DeclarationType.getNonReferenceType();
+if (Descriptor.ElemType.isNull() || DeclarationType.isNull() ||
+!Context->hasSameUnqualifiedType(Decla
mgehre created this revision.
mgehre added reviewers: alexfh, klimek.
mgehre added a subscriber: cfe-commits.
Previoly, the added test failed with the fillowing fixit:
char v[5];
-for(size_t i = 0; i < 5; ++i)
+for(char value : v)
{
-unsigned char value = v[i];
mgehre updated this revision to Diff 56800.
mgehre added a comment.
Update for review comment:
- Return Optional when looking for 'inline'
- Add test that hides 'inline' in a macro
http://reviews.llvm.org/D18914
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/Readabilit
mgehre added a comment.
Ping
http://reviews.llvm.org/D15031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mgehre
Date: Tue Apr 12 00:45:13 2016
New Revision: 266044
URL: http://llvm.org/viewvc/llvm-project?rev=266044&view=rev
Log:
[clang-tidy] fix readability-avoid-const-params-in-decls creating invalid code
in fix-its
Summary:
The Fix-Its for the added test cases were before:
-void F11(cons
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266044: [clang-tidy] fix
readability-avoid-const-params-in-decls creating invalid… (authored by mgehre).
Changed prior to commit:
http://reviews.llvm.org/D18993?vs=53322&id=53368#toc
Repository:
rL L
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266043: [ASTMatchers]: fix crash in hasReturnValue (authored
by mgehre).
Changed prior to commit:
http://reviews.llvm.org/D18991?vs=53311&id=53367#toc
Repository:
rL LLVM
http://reviews.llvm.org/D18
Author: mgehre
Date: Tue Apr 12 00:43:18 2016
New Revision: 266043
URL: http://llvm.org/viewvc/llvm-project?rev=266043&view=rev
Log:
[ASTMatchers]: fix crash in hasReturnValue
Summary:
The crash was reproduced by the included test case. It was initially
found through a crash of clang-tidy's misc-
mgehre added inline comments.
Comment at: test/clang-tidy/readability-redundant-inline.cpp:6
@@ +5,3 @@
+// CHECK-MESSAGES: :[[@LINE-1]]:14: warning: 'inline' is redundant because
method body is defined inside class [readability-redundant-inline]
+// CHECK-FIXES: {{^}} int f1()
mgehre created this revision.
mgehre added reviewers: fowles, hokein, sbenza, alexfh.
mgehre added a subscriber: cfe-commits.
The Fix-Its for the added test cases were before:
-void F11(const unsigned int /*version*/);
+void F11(unsigned int int /*version*/);
-void F12(const bool b = true);
+void
mgehre updated this revision to Diff 53317.
mgehre added a comment.
Removed debug output
http://reviews.llvm.org/D18914
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readability/RedundantInlineCheck.cpp
clang-tidy/readability/Re
mgehre updated this revision to Diff 53315.
mgehre added a comment.
Update for review comments; simplified lexing, added proposed test case
http://reviews.llvm.org/D18914
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readability/R
mgehre created this revision.
mgehre added reviewers: klimek, alexfh.
mgehre added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
The crash was reproduced by the included test case. It was initially
found through a crash of clang-tidy's misc-misplaced-widening-cast
check.
http://re
mgehre updated this revision to Diff 53261.
mgehre added a comment.
Remove unused CFGBuilder::prependLifetimeEndsWithTerminator
http://reviews.llvm.org/D15031
Files:
include/clang/Analysis/AnalysisContext.h
include/clang/Analysis/CFG.h
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
mgehre added a comment.
I'm thinking about extending the check to the following issue and would like to
hear your opinion.
In C++, the following three code snippets all have identical meaning
1:
struct S {
int f();
};
inline int S::f() {
return 0;
}
2:
struct S {
inline
mgehre updated this revision to Diff 53118.
mgehre added a comment.
Update for review comments
http://reviews.llvm.org/D18914
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readability/RedundantInlineCheck.cpp
clang-tidy/readabil
mgehre created this revision.
mgehre added reviewers: sbenza, bkramer, aaron.ballman, alexfh.
mgehre added a subscriber: cfe-commits.
This check flags redundant 'inline' specifiers.
It flags 'inline' on member functions defined inside a class definition
like
.. code-block:: c++
struct S {
i
mgehre updated this revision to Diff 53097.
mgehre added a comment.
Update for renaming in http://reviews.llvm.org/D15031
http://reviews.llvm.org/D15032
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguidel
mgehre updated this revision to Diff 53092.
mgehre added a comment.
Fix assert in LocalScope::const_iterator::distance when using goto to jump over
trivially constructable variable declarations
Added two test cases for this
http://reviews.llvm.org/D15031
Files:
include/clang/Analysis/Analysi
mgehre updated this revision to Diff 52959.
mgehre added a comment.
Update for review comments
- Change name from ObjLeavesScope to LifetimeEnds
- Make sure that trivially destructible objects end their lifetime after
non-trivial destructible objects
- Add test
- Add analyzer option to enable Li
mgehre added a comment.
By the way, is there a tool to generate parts of the test based on clang
output, i.e.
something that will prefix the output of clang with "CHECK: " and "CHECK-NEXT:"
so I can copy-and-paste
it into my test file?
http://reviews.llvm.org/D15031
mgehre added inline comments.
Comment at: include/clang/Analysis/CFG.h:170
@@ -168,1 +169,3 @@
+class CFGAutomaticObjLeavesScope : public CFGElement {
+public:
rsmith wrote:
> What is this intended to model? There seem to be a few options here:
>
> 1) The poin
mgehre added a comment.
Thank you very much for your review. I'm sorry that I'm currently quite busy,
but I will find some time to answer at the end of this week.
http://reviews.llvm.org/D15031
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255470: [clang-tidy] add check
cppcoreguidelines-pro-bounds-constant-array-index (authored by mgehre).
Changed prior to commit:
http://reviews.llvm.org/D15030?vs=42338&id=42671#toc
Repository:
rL LLV
Author: mgehre
Date: Sun Dec 13 16:08:26 2015
New Revision: 255470
URL: http://llvm.org/viewvc/llvm-project?rev=255470&view=rev
Log:
[clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index
Summary:
This is http://reviews.llvm.org/D13746 but instead of including ,
a stub is provid
mgehre updated this revision to Diff 42338.
mgehre added a comment.
Thanks for the comments!
http://reviews.llvm.org/D15030
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIn
mgehre added a comment.
The lifetime checker that needs this is at http://reviews.llvm.org/D15032
http://reviews.llvm.org/D15031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgehre created this revision.
mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman.
mgehre added a subscriber: cfe-commits.
mgehre added a dependency: D15031: CFG: Add CFGElement for automatic variables
that leave the scope.
This checker implements the lifetime rules presented in the pa
1 - 100 of 207 matches
Mail list logo
