Re: [PATCH] D15797: [clang-tidy] Fix readability-braces-around-statements assert failure

mattsta added a comment. Yeah, I fully understand the need to make sure it doesn't break again (or that this actually fixes it properly), but these changes are about the limit of my LLVM+Tidy internals understanding. (What's missing from this diff is the 20 hours across 4-6 months where I trie

Re: [PATCH] D15797: [clang-tidy] Fix readability-braces-around-statements assert failure

mattsta updated this revision to Diff 43748. mattsta added a comment. Updated to include fix for: Assertion failed: (InitialLoc.isValid()), function checkStmt, file ../llvm/tools/clang/tools/extra/clang-tidy/readability/BracesAroundStatementsCheck.cpp, line 226. Repository: rL LLVM http:

Re: [PATCH] D15797: [clang-tidy] Fix readability-braces-around-statements assert failure

mattsta added a comment. It's difficult to track down *why* the invalid locations are happening because by the time we get to an invalid location, all source location information is lost. The best I've been able to come up with is fixing the early return conditions (which were previously impos