[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

https://github.com/majaha updated https://github.com/llvm/llvm-project/pull/65876 >From 7c43c803764bf9e0256d4e3e9f497d2622bb8f69 Mon Sep 17 00:00:00 2001 From: Matt Harding Date: Fri, 25 Aug 2023 06:19:14 +0100 Subject: [PATCH 01/13] Add no-trap-after-noreturn flag and wasm tests Add the comma

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

https://github.com/majaha updated https://github.com/llvm/llvm-project/pull/65876 >From 7c43c803764bf9e0256d4e3e9f497d2622bb8f69 Mon Sep 17 00:00:00 2001 From: Matt Harding Date: Fri, 25 Aug 2023 06:19:14 +0100 Subject: [PATCH 01/13] Add no-trap-after-noreturn flag and wasm tests Add the comma

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

https://github.com/majaha updated https://github.com/llvm/llvm-project/pull/65876 >From 7c43c803764bf9e0256d4e3e9f497d2622bb8f69 Mon Sep 17 00:00:00 2001 From: Matt Harding Date: Fri, 25 Aug 2023 06:19:14 +0100 Subject: [PATCH 01/12] Add no-trap-after-noreturn flag and wasm tests Add the comma

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

https://github.com/majaha updated https://github.com/llvm/llvm-project/pull/65876 >From 7c43c803764bf9e0256d4e3e9f497d2622bb8f69 Mon Sep 17 00:00:00 2001 From: Matt Harding Date: Fri, 25 Aug 2023 06:19:14 +0100 Subject: [PATCH 01/12] Add no-trap-after-noreturn flag and wasm tests Add the comma

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

https://github.com/majaha updated https://github.com/llvm/llvm-project/pull/65876 >From 7c43c803764bf9e0256d4e3e9f497d2622bb8f69 Mon Sep 17 00:00:00 2001 From: Matt Harding Date: Fri, 25 Aug 2023 06:19:14 +0100 Subject: [PATCH 01/10] Add no-trap-after-noreturn flag and wasm tests Add the comma

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

https://github.com/majaha updated https://github.com/llvm/llvm-project/pull/65876 >From 7c43c803764bf9e0256d4e3e9f497d2622bb8f69 Mon Sep 17 00:00:00 2001 From: Matt Harding Date: Fri, 25 Aug 2023 06:19:14 +0100 Subject: [PATCH 01/10] Add no-trap-after-noreturn flag and wasm tests Add the comma

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

https://github.com/majaha edited https://github.com/llvm/llvm-project/pull/65876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

@@ -1,33 +1,133 @@ -; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck %s -; RUN: llc < %s -asm-verbose=false -fast-isel -fast-isel-abort=1 -verify-machineinstrs | FileCheck %s - -; Test that LLVM unreachable instruction and trap intrinsic are lowered to -; wasm

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

@@ -1,33 +1,133 @@ -; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck %s -; RUN: llc < %s -asm-verbose=false -fast-isel -fast-isel-abort=1 -verify-machineinstrs | FileCheck %s - -; Test that LLVM unreachable instruction and trap intrinsic are lowered to -; wasm

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

@@ -1,33 +1,133 @@ -; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck %s -; RUN: llc < %s -asm-verbose=false -fast-isel -fast-isel-abort=1 -verify-machineinstrs | FileCheck %s - -; Test that LLVM unreachable instruction and trap intrinsic are lowered to -; wasm

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

@@ -1,33 +1,133 @@ -; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck %s -; RUN: llc < %s -asm-verbose=false -fast-isel -fast-isel-abort=1 -verify-machineinstrs | FileCheck %s - -; Test that LLVM unreachable instruction and trap intrinsic are lowered to -; wasm

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

majaha wrote: Yeah you've got it, that's the main point. It can be set via the C++ API, and when I tried doing so in the Rust compiler I found it broke the WebAssembly backend. Sorry if I didn't make that clear enough earlier, I'm glad we're on the same page now. https://github.com/llvm/llvm-

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

majaha wrote: > These are just non-wasm options, so they mean nothing to wasm. Yes, and using them gives no warning. > Wasm simply doesn't do anything with respect to these options and wasm is not > overriding them. --trap-unreachable is absolutely overridden, in exactly the same place as -

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

https://github.com/majaha updated https://github.com/llvm/llvm-project/pull/65876 >From 7c43c803764bf9e0256d4e3e9f497d2622bb8f69 Mon Sep 17 00:00:00 2001 From: Matt Harding Date: Fri, 25 Aug 2023 06:19:14 +0100 Subject: [PATCH 1/8] Add no-trap-after-noreturn flag and wasm tests Add the command

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

https://github.com/majaha updated https://github.com/llvm/llvm-project/pull/65876 >From 7c43c803764bf9e0256d4e3e9f497d2622bb8f69 Mon Sep 17 00:00:00 2001 From: Matt Harding Date: Fri, 25 Aug 2023 06:19:14 +0100 Subject: [PATCH 1/8] Add no-trap-after-noreturn flag and wasm tests Add the command