[PATCH] D157517: [AArch64][SVE] Add asm predicate constraint Uph

2023-08-11 Thread Matt Devereau via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc52d9509d40d: [AArch64][SVE] Add asm predicate constraint Uph (authored by MattDevereau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157517/new/ https://

[PATCH] D157517: [AArch64][SVE] Add asm predicate constraint Uph

2023-08-10 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau updated this revision to Diff 548965. MattDevereau added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. @sdesmalen I had to make an additional changes to `clang/lib/Basic/Targets/AArch64.cpp` and `clang/test/CodeGen/aarch64-sve-inline-asm-datatypes

[PATCH] D156115: [Clang][SVE] Permit specific predicate-as-counter registers in inline assembly

2023-07-24 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-inline-asm.c:17 + +void test_sve2p1_asm(void) { + register __SVCount_t x2 asm("pn0"); I think it would be better to keep this test similar to `test_sve_asm` in that it tests both end

[PATCH] D145505: [AArch64][SVE] Add svboolx2_t and svboolx4_t tuple types

2023-03-14 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau closed this revision. MattDevereau added a comment. a1fae98ba95c18ea6b673fc3c177b917e0f5aa56 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145505/new/ https://revie

[PATCH] D145505: [AArch64][SVE] Add svboolx2_t and svboolx4_t tuple types

2023-03-13 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau updated this revision to Diff 504588. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145505/new/ https://reviews.llvm.org/D145505 Files: clang/include/clang/Basic/AArch64SVEACLETypes.def clang/lib/AST/ASTContext.cpp clang/lib/AST/T

[PATCH] D145505: [AArch64][SVE] Add svboolx2_t and svboolx4_t tuple types

2023-03-07 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau created this revision. MattDevereau added reviewers: sdesmalen, CarolineConcatto, peterwaller-arm. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. MattDevereau requested review of this revision. Herald added a p

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

2022-05-11 Thread Matt Devereau via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG75bb815231f6: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang (authored by MattDevereau). Changed prior to commit: https://reviews.llvm.org/D124998?vs=427335&id=428644#toc Repository: rG LLVM G

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

2022-05-05 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau updated this revision to Diff 427335. MattDevereau added a comment. set `CXCallingConv_AArch64SVEPcs= 17` to 18 to resolve ABI break renamed CC_AArch64SVEPcs to CC_AArch64SVEPCS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124998/new/

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

2022-05-05 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau created this revision. MattDevereau added reviewers: paulwalker-arm, peterwaller-arm, bsmith, DavidTruby, dtemirbulatov. Herald added subscribers: ctetreau, psnobl, arphaman, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a reviewer: aaron.ballman. Herald add

[PATCH] D121792: [AArch64][SVE] InstCombine llvm.aarch64.sve.sel to select

2022-03-17 Thread Matt Devereau via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa9e08bc7c1e5: [AArch64][SVE] InstCombine llvm.aarch64.sve.sel to select (authored by MattDevereau). Changed prior to commit: https://reviews.llvm.

[PATCH] D121792: [AArch64][SVE] InstCombine llvm.aarch64.sve.sel to select

2022-03-16 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau created this revision. MattDevereau added reviewers: peterwaller-arm, paulwalker-arm, DavidTruby, bsmith. Herald added subscribers: ctetreau, psnobl, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. MattDevereau requested review of th

[PATCH] D121294: [AArch64][SVE][Clang] Fix crash for incorrect svptrue and svcnt parameters

2022-03-11 Thread Matt Devereau via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6c5da880e03c: [AArch64][SVE][Clang] Fix crash for incorrect svptrue and svcnt parameters (authored by MattDevereau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D121294: [AArch64][SVE][Clang] Fix crash for incorrect svptrue and svcnt parameters

2022-03-09 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau added a comment. In D121294#3370085 , @sdesmalen wrote: > This is missing tests for svundef, svrdffr, svsetffr and svpfalse? @sdesmalen Only svcnt and svptrue cause the crash. This might be because of extra values added by the `[IsAppendSVA

[PATCH] D121294: [AArch64][SVE][Clang] Fix crash for incorrect svptrue and svcnt parameters

2022-03-09 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau created this revision. MattDevereau added reviewers: peterwaller-arm, paulwalker-arm, DavidTruby. Herald added subscribers: ctetreau, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. MattDevereau requested review of this revision. Herald

[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

2022-02-28 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau abandoned this revision. MattDevereau added a comment. Abandoning this patch as it is redundant due to changes in D105331 . This patch also drew attention to unused code removed in 841355c1e4e35fc02b5b171419979f5f9af0ebc8

[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

2022-02-16 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau updated this revision to Diff 409236. MattDevereau added a comment. Removed -O1 and -ffast-math flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119926/new/ https://reviews.llvm.org/D119926 Files: clang/lib/AST/ASTContext.cpp c

[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

2022-02-16 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau created this revision. MattDevereau added reviewers: georges, peterwaller-arm, paulwalker-arm, DavidTruby, bsmith, teemperor, rjmccall, qiucf. Herald added a subscriber: kristof.beyls. MattDevereau requested review of this revision. Herald added a project: clang. Herald added a subscr

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

2021-12-13 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau closed this revision. MattDevereau added a comment. 41def32040787e917b52279cc30231b27f2f02f7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ https://revie

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

2021-12-06 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau marked an inline comment as done. MattDevereau added a comment. clang-format is upset about this ordering: #include "clang/Basic/arm_sve_builtin_cg.inc" #include "clang/Basic/BuiltinsAArch64NeonSVEBridge_cg.def" but swapping the order causes all SVE tests to fail. I'm ignoring the

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

2021-12-06 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau updated this revision to Diff 392015. MattDevereau added a comment. replace numbers in BuiltinsAArch64NeonSVEBridge_cg.def with SVETypeFlags enum values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ https://reviews.llvm.or

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

2021-12-03 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau updated this revision to Diff 391616. MattDevereau added a comment. run clang format to fix test macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ https://reviews.llvm.org/D114713 Files: clang/include/clang/Basic/Built

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

2021-12-03 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau updated this revision to Diff 391595. MattDevereau added a comment. updated SVEMAP2 types added overloadable intrinsics updated BUILTIN function signatures CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ https://reviews.llvm.org/D114713 Files: clang/include/cla

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

2021-12-02 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau marked an inline comment as done. MattDevereau added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1325 setOperationAction(ISD::MLOAD, VT, Custom); + setOperationAction(ISD::INSERT_SUBVECTOR, VT, Custom); }

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

2021-11-30 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau updated this revision to Diff 390731. MattDevereau added a comment. updated builtin signatures in `clang/include/clang/Basic/BuiltinsAArch64NeonSVEBridge.def` removed irrelevant change in `llvm/lib/Target/AArch64/AArch64ISelLowering.cpp` ran clang-format CHANGES SINCE LAST ACTION

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

2021-11-30 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1325 setOperationAction(ISD::MLOAD, VT, Custom); + setOperationAction(ISD::INSERT_SUBVECTOR, VT, Custom); } paulwalker-arm wrote: > Can you extract th

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

2021-11-29 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau created this revision. MattDevereau added reviewers: bsmith, peterwaller-arm, DavidTruby, paulwalker-arm. Herald added subscribers: psnobl, hiraditya, kristof.beyls, tschuett, mgorny. Herald added a reviewer: efriedma. MattDevereau requested review of this revision. Herald added proje

[PATCH] D113489: [AArch64][SVE] Instcombine SVE LD1/ST1 to stock LLVM IR

2021-11-16 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau added a comment. This caused buildbot failures which failed on the bfloat tests. Pushed commit 83727f27719d3f319f746b473ce09be7e1d99b32 to fix the issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D113489: [AArch64][SVE] Instcombine SVE LD1/ST1 to stock LLVM IR

2021-11-12 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau marked 9 inline comments as done. MattDevereau added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:732 + Type *VecTyPtr = II.getType()->getPointerTo(); + IRBuilder<> Builder(II.getContext()); + Builder.SetInsertPoint(&II); ---