This revision was automatically updated to reflect the committed changes.
Closed by commit rL308965: This patch enables the usage of constant Enum
identifiers within Microsoft… (authored by mharoush).
Changed prior to commit:
https://reviews.llvm.org/D33277?vs=104390&id=108044#toc
Repository:
mharoush added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D33277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mharoush added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D33278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mharoush marked 4 inline comments as done.
mharoush added inline comments.
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:1382
+if (const MCConstantExpr *CE =
+dyn_cast_or_null(Val)) {
+ StringRef ErrMsg;
rnk wrote:
> rnk wrot
mharoush updated this revision to Diff 104391.
mharoush marked an inline comment as done.
mharoush added a comment.
simplified the rewrite condition of complex expressions and eliminated the need
to use the ReplaceEnumIdentifier flag. This requires making small adjustments
to some of the older t
mharoush updated this revision to Diff 104390.
mharoush added a comment.
Updated inline asm tests to look for decimal immediate value instead of looking
for the original string e.g. 10 vs 0xA and other variations.
Also updated the test cases to use check-same etc.
Repository:
rL LLVM
https:/
mharoush added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D33278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mharoush marked 3 inline comments as done.
mharoush added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D33278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mharoush updated this revision to Diff 102172.
mharoush marked 6 inline comments as done.
mharoush added a comment.
Restored old test case for constant int folding and added check-label
directives for each tester function.
Repository:
rL LLVM
https://reviews.llvm.org/D33277
Files:
lib/Sem
mharoush updated this revision to Diff 101693.
mharoush added a comment.
added struct case to the test
Repository:
rL LLVM
https://reviews.llvm.org/D33277
Files:
lib/Sema/SemaStmtAsm.cpp
test/CodeGen/x86-ms-inline-asm-enum_feature.cpp
Index: lib/Sema/SemaStmtAsm.cpp
mharoush updated this revision to Diff 101689.
Repository:
rL LLVM
https://reviews.llvm.org/D33277
Files:
lib/Sema/SemaStmtAsm.cpp
test/CodeGen/x86-ms-inline-asm-enum_feature.cpp
Index: lib/Sema/SemaStmtAsm.cpp
===
--- lib/Se
mharoush marked an inline comment as done.
mharoush added inline comments.
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:722
+ bool ParseIntelExpression(IntelExprStateMachine &SM, SMLoc &End,
+bool &ReplaceEnumIdentifier);
std::unique_ptr
mharoush updated this revision to Diff 101688.
mharoush marked an inline comment as done.
mharoush added a comment.
Simplified the AsmRewrite condition in x86AsmParser. Some fixes to simplify the
Intel State Machine immediate value rewrite treatment divergence.
Repository:
rL LLVM
https://re
mharoush marked an inline comment as done.
mharoush added inline comments.
Comment at: lib/Parse/ParseStmtAsm.cpp:100
+ // result of a call to LookupInlineAsmIdentifier.
+ bool EvaluateLookupAsEnum(void *LookupResult, int64_t &Result) {
+if (!LookupResult) return false;
---
mharoush updated this revision to Diff 99780.
mharoush added a comment.
removed functions and dropped an irrelevant test case.
Repository:
rL LLVM
https://reviews.llvm.org/D33277
Files:
lib/Sema/SemaStmtAsm.cpp
test/CodeGen/x86-ms-inline-asm-enum_feature.cpp
Index: lib/Sema/SemaStmtAsm
mharoush updated this revision to Diff 99778.
mharoush added a comment.
Using identifier info to pass enum information.
Repository:
rL LLVM
https://reviews.llvm.org/D33278
Files:
include/llvm/MC/MCParser/MCAsmParser.h
lib/Target/X86/AsmParser/X86AsmParser.cpp
Index: lib/Target/X86/AsmPa
mharoush marked an inline comment as done.
mharoush added inline comments.
Comment at: include/llvm/MC/MCParser/MCAsmParser.h:64
unsigned &Offset) = 0;
+ virtual bool EvaluateLookupAsEnum(void *LookupResult,int64_t &Result) = 0;
};
-
mharoush created this revision.
This patch enables the usage of constant Enum identifiers within Microsoft
style inline assembly statements.
part 2 out of 2.
[https://reviews.llvm.org/D33277]
Repository:
rL LLVM
https://reviews.llvm.org/D33278
Files:
include/llvm/MC/MCParser/MCAsmParser.
mharoush created this revision.
mharoush added a project: clang-c.
Herald added a subscriber: eraman.
This patch enables the usage of constant Enum identifiers within Microsoft
style inline assembly statements.
part 1 out of 2.
Repository:
rL LLVM
https://reviews.llvm.org/D33277
Files:
l
19 matches
Mail list logo
