[clang-tools-extra] r351303 - [clang-tidy] Treat references to smart pointers correctly in use-after-move.

2019-01-15 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Tue Jan 15 23:53:25 2019 New Revision: 351303 URL: http://llvm.org/viewvc/llvm-project?rev=351303&view=rev Log: [clang-tidy] Treat references to smart pointers correctly in use-after-move. Summary: Previously, we weren't recognizing these as smart pointers and thus weren't a

[clang-tools-extra] r343768 - [clang-tidy] Sequence statements with multiple parents correctly (PR39149)

2018-10-04 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Thu Oct 4 04:36:39 2018 New Revision: 343768 URL: http://llvm.org/viewvc/llvm-project?rev=343768&view=rev Log: [clang-tidy] Sequence statements with multiple parents correctly (PR39149) Summary: Before this fix, the bugprone-use-after-move check could incorrectly conclude t

[clang-tools-extra] r339571 - [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move

2018-08-13 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Mon Aug 13 07:24:52 2018 New Revision: 339571 URL: http://llvm.org/viewvc/llvm-project?rev=339571&view=rev Log: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move Summary: This allows member functions to be marked as reinitializing the obje

r339569 - Summary:Add clang::reinitializes attribute

2018-08-13 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Mon Aug 13 07:11:03 2018 New Revision: 339569 URL: http://llvm.org/viewvc/llvm-project?rev=339569&view=rev Log: Summary:Add clang::reinitializes attribute Summary: This is for use by clang-tidy's bugprone-use-after-move check -- see corresponding clang-tidy patch at https://

[clang-tools-extra] r338932 - [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while

2018-08-03 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Fri Aug 3 15:20:04 2018 New Revision: 338932 URL: http://llvm.org/viewvc/llvm-project?rev=338932&view=rev Log: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while Summary: Fixes https://bugs.llvm.org/show_bug.cgi?id=36516.

r325236 - Add -no-canonical-prefixes to allow different build modes.

2018-02-15 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Thu Feb 15 05:50:07 2018 New Revision: 325236 URL: http://llvm.org/viewvc/llvm-project?rev=325236&view=rev Log: Add -no-canonical-prefixes to allow different build modes. Modified: cfe/trunk/test/Driver/amdgcn-toolchain-pic.cl Modified: cfe/trunk/test/Driver/amdgcn-tool

[clang-tools-extra] r321156 - [clangd] Add "../" to Logger.h included from parent directory.

2017-12-20 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Wed Dec 20 01:17:31 2017 New Revision: 321156 URL: http://llvm.org/viewvc/llvm-project?rev=321156&view=rev Log: [clangd] Add "../" to Logger.h included from parent directory. Modified: clang-tools-extra/trunk/clangd/index/MemIndex.cpp Modified: clang-tools-extra/trunk/c

r320971 - [X86] Use {{.*}} instead of hardcoded %1 in knot test.

2017-12-18 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Mon Dec 18 03:29:21 2017 New Revision: 320971 URL: http://llvm.org/viewvc/llvm-project?rev=320971&view=rev Log: [X86] Use {{.*}} instead of hardcoded %1 in knot test. This makes the test more resilient and consistent with the other tests introduced in r320919. Modified:

r312109 - Add test case that was broken by r311970.

2017-08-30 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Wed Aug 30 03:44:51 2017 New Revision: 312109 URL: http://llvm.org/viewvc/llvm-project?rev=312109&view=rev Log: Add test case that was broken by r311970. See also discussion here: https://reviews.llvm.org/rL301963 As far as I can tell, this discussion was never resolved. M

r312108 - Revert "Improve constant expression evaluation of arrays of unknown bound."

2017-08-30 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Wed Aug 30 03:44:46 2017 New Revision: 312108 URL: http://llvm.org/viewvc/llvm-project?rev=312108&view=rev Log: Revert "Improve constant expression evaluation of arrays of unknown bound." This reverts commit r311970. Breaks internal tests. Modified: cfe/trunk/include/c

r298504 - Revert "Correct class-template deprecation behavior"

2017-03-22 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Wed Mar 22 08:34:37 2017 New Revision: 298504 URL: http://llvm.org/viewvc/llvm-project?rev=298504&view=rev Log: Revert "Correct class-template deprecation behavior" This reverts commit r298410 (which produces incorrect warnings, see comments on https://reviews.llvm.org/rL298

r298503 - Revert "iFix Test deprecation behavior in C89 mode as a result of r298410"

2017-03-22 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Wed Mar 22 08:33:03 2017 New Revision: 298503 URL: http://llvm.org/viewvc/llvm-project?rev=298503&view=rev Log: Revert "iFix Test deprecation behavior in C89 mode as a result of r298410" This reverts commit r298433. (Required to revert r298410, see comments there.) Modified

[clang-tools-extra] r297272 - [clang-tidy] misc-use-after-move: Fix failing assertion

2017-03-08 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Wed Mar 8 06:34:51 2017 New Revision: 297272 URL: http://llvm.org/viewvc/llvm-project?rev=297272&view=rev Log: [clang-tidy] misc-use-after-move: Fix failing assertion Summary: I've added a test case that (without the fix) triggers the assertion, which happens when a move ha

r297129 - [analyzer] Fix crash when building CFG with variable of incomplete type

2017-03-07 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Tue Mar 7 02:42:37 2017 New Revision: 297129 URL: http://llvm.org/viewvc/llvm-project?rev=297129&view=rev Log: [analyzer] Fix crash when building CFG with variable of incomplete type Summary: I've included a unit test with a function template containing a variable of incomp

[clang-tools-extra] r297006 - Revert "[clang-tidy] misc-use-after-move: Fix failing assertion"

2017-03-06 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Mon Mar 6 03:46:27 2017 New Revision: 297006 URL: http://llvm.org/viewvc/llvm-project?rev=297006&view=rev Log: Revert "[clang-tidy] misc-use-after-move: Fix failing assertion" This reverts commit r297004; it was causing buildbots to fail. Modified: clang-tools-extra/tr

[clang-tools-extra] r297004 - [clang-tidy] misc-use-after-move: Fix failing assertion

2017-03-06 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Mon Mar 6 02:55:42 2017 New Revision: 297004 URL: http://llvm.org/viewvc/llvm-project?rev=297004&view=rev Log: [clang-tidy] misc-use-after-move: Fix failing assertion Summary: I've added a test case that (without the fix) triggers the assertion, which happens when a move ha

r293051 - [Driver] Prevent no-arc-exception-silence.m test from writing output.

2017-01-25 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Wed Jan 25 06:55:53 2017 New Revision: 293051 URL: http://llvm.org/viewvc/llvm-project?rev=293051&view=rev Log: [Driver] Prevent no-arc-exception-silence.m test from writing output. Summary: This enables the test to run on systems where output cannot be written. Reviewers:

r292791 - Revert "IRGen: Start using the WriteThinLTOBitcode pass."

2017-01-23 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Mon Jan 23 08:33:42 2017 New Revision: 292791 URL: http://llvm.org/viewvc/llvm-project?rev=292791&view=rev Log: Revert "IRGen: Start using the WriteThinLTOBitcode pass." Summary: This reverts commit r292662. This change broke internal builds. Will provide a reproducer inter

r288665 - CFGBuilder: Fix crash when visiting delete expression on dependent type

2016-12-05 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Mon Dec 5 05:33:19 2016 New Revision: 288665 URL: http://llvm.org/viewvc/llvm-project?rev=288665&view=rev Log: CFGBuilder: Fix crash when visiting delete expression on dependent type Summary: CXXDeleteExpr::getDestroyedType() can return a null QualType if the destroyed type

[clang-tools-extra] r285842 - [clang-tidy] Extend misc-use-after-move to support unique_ptr and shared_ptr.

2016-11-02 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Wed Nov 2 12:34:47 2016 New Revision: 285842 URL: http://llvm.org/viewvc/llvm-project?rev=285842&view=rev Log: [clang-tidy] Extend misc-use-after-move to support unique_ptr and shared_ptr. Summary: As a unique_ptr or shared_ptr that has been moved from is guaranteed to be n

[clang-tools-extra] r284235 - [clang-tidy] Add additional diagnostic to misc-use-after-move

2016-10-14 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Fri Oct 14 08:23:39 2016 New Revision: 284235 URL: http://llvm.org/viewvc/llvm-project?rev=284235&view=rev Log: [clang-tidy] Add additional diagnostic to misc-use-after-move Summary: This adds a diagnostic to the misc-use-after-move check that is output when the use happens

[clang-tools-extra] r281460 - [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule

2016-09-14 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Wed Sep 14 08:33:11 2016 New Revision: 281460 URL: http://llvm.org/viewvc/llvm-project?rev=281460&view=rev Log: [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule Summary: This is needed for the recently submitted misc-use-after-move check (rL281453). For so

[clang-tools-extra] r281455 - [clang-tidy] Make test for misc-use-after-move pass under Windows

2016-09-14 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Wed Sep 14 07:22:35 2016 New Revision: 281455 URL: http://llvm.org/viewvc/llvm-project?rev=281455&view=rev Log: [clang-tidy] Make test for misc-use-after-move pass under Windows Summary: Adds -fno-delayed-template-parsing Reviewers: alexfh Subscribers: cfe-commits Differe

[clang-tools-extra] r281453 - [clang-tidy] Add check 'misc-use-after-move'

2016-09-14 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Wed Sep 14 05:29:32 2016 New Revision: 281453 URL: http://llvm.org/viewvc/llvm-project?rev=281453&view=rev Log: [clang-tidy] Add check 'misc-use-after-move' Summary: The check warns if an object is used after it has been moved, without an intervening reinitialization. See u

r281200 - [CFG] Add iterator_ranges to CFG and CFGBlock.

2016-09-12 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Mon Sep 12 03:28:21 2016 New Revision: 281200 URL: http://llvm.org/viewvc/llvm-project?rev=281200&view=rev Log: [CFG] Add iterator_ranges to CFG and CFGBlock. Summary: (Needed for D23353.) Reviewers: alexfh Subscribers: cfe-commits Differential Revision: https://reviews.l

[clang-tools-extra] r280077 - [clang-tidy] Add check 'misc-move-forwarding-reference'

2016-08-30 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Tue Aug 30 07:11:12 2016 New Revision: 280077 URL: http://llvm.org/viewvc/llvm-project?rev=280077&view=rev Log: [clang-tidy] Add check 'misc-move-forwarding-reference' Summary: The check emits a warning if std::move() is applied to a forwarding reference, i.e. an rvalue ref

[clang-tools-extra] r278934 - Adapt to TraverseLambdaCapture interface change from D23204

2016-08-17 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Wed Aug 17 10:00:22 2016 New Revision: 278934 URL: http://llvm.org/viewvc/llvm-project?rev=278934&view=rev Log: Adapt to TraverseLambdaCapture interface change from D23204 Summary: Depends on D23204. This is intended to be submitted immediately after D23204 lands. Reviewer

r278933 - Visit lambda capture inits from RecursiveASTVisitor::TraverseLambdaCapture().

2016-08-17 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Wed Aug 17 09:59:53 2016 New Revision: 278933 URL: http://llvm.org/viewvc/llvm-project?rev=278933&view=rev Log: Visit lambda capture inits from RecursiveASTVisitor::TraverseLambdaCapture(). Summary: rL277342 made RecursiveASTVisitor visit lambda capture initialization expres

r278507 - [ASTMatchers] Add templateTypeParmDecl() to Registry.cpp

2016-08-12 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Fri Aug 12 08:51:00 2016 New Revision: 278507 URL: http://llvm.org/viewvc/llvm-project?rev=278507&view=rev Log: [ASTMatchers] Add templateTypeParmDecl() to Registry.cpp Summary: This appears to have been forgotten when templateTypeParmDecl() was initially added. Reviewers:

r278213 - [ASTMatchers] Extend documentation for match()

2016-08-10 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Wed Aug 10 06:22:57 2016 New Revision: 278213 URL: http://llvm.org/viewvc/llvm-project?rev=278213&view=rev Log: [ASTMatchers] Extend documentation for match() Summary: Adds an explanation of how to use findAll() to find all matches in a subtree. Modified: cfe/trunk/incl

r278123 - [ASTMatchers] Add matchers canReferToDecl() and hasUnderlyingDecl()

2016-08-09 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Tue Aug 9 10:07:52 2016 New Revision: 278123 URL: http://llvm.org/viewvc/llvm-project?rev=278123&view=rev Log: [ASTMatchers] Add matchers canReferToDecl() and hasUnderlyingDecl() Summary: Required for D0 Reviewers: sbenza, klimek, aaron.ballman, alexfh Subscribers: al

r277342 - Make RecursiveASTVisitor visit lambda capture initialization expressions

2016-08-01 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Mon Aug 1 07:15:46 2016 New Revision: 277342 URL: http://llvm.org/viewvc/llvm-project?rev=277342&view=rev Log: Make RecursiveASTVisitor visit lambda capture initialization expressions Summary: Lambda capture initializations are part of the explicit source code and therefore

[clang-tools-extra] r277339 - [clang-tidy] Prepare modernize-loop-convert for upcoming changes in D22566

2016-08-01 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Mon Aug 1 06:29:17 2016 New Revision: 277339 URL: http://llvm.org/viewvc/llvm-project?rev=277339&view=rev Log: [clang-tidy] Prepare modernize-loop-convert for upcoming changes in D22566 Summary: D22566 will change RecursiveASTVisitor so that it descends into the initializa

r276759 - Revert "Make RecursiveASTVisitor visit lambda capture initialization expressions"

2016-07-26 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Tue Jul 26 11:01:55 2016 New Revision: 276759 URL: http://llvm.org/viewvc/llvm-project?rev=276759&view=rev Log: Revert "Make RecursiveASTVisitor visit lambda capture initialization expressions" This reverts commit r276755. (Broke clang-tidy check modernize-loop-convert.)

r276755 - Make RecursiveASTVisitor visit lambda capture initialization expressions

2016-07-26 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Tue Jul 26 10:19:10 2016 New Revision: 276755 URL: http://llvm.org/viewvc/llvm-project?rev=276755&view=rev Log: Make RecursiveASTVisitor visit lambda capture initialization expressions Summary: Lambda capture initializations are part of the explicit source code and therefor

[clang-tools-extra] r276752 - Revert test commit

2016-07-26 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Tue Jul 26 09:37:39 2016 New Revision: 276752 URL: http://llvm.org/viewvc/llvm-project?rev=276752&view=rev Log: Revert test commit This reverts rL276746. Modified: clang-tools-extra/trunk/clang-tidy/misc/MoveConstantArgumentCheck.cpp Modified: clang-tools-extra/trunk/c

[clang-tools-extra] r276746 - Test commit -- adding a newline

2016-07-26 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Tue Jul 26 09:01:48 2016 New Revision: 276746 URL: http://llvm.org/viewvc/llvm-project?rev=276746&view=rev Log: Test commit -- adding a newline Modified: clang-tools-extra/trunk/clang-tidy/misc/MoveConstantArgumentCheck.cpp Modified: clang-tools-extra/trunk/clang-tidy/m