[PATCH] D139122: Generalize clang-tidy modernize-pass-by-value

2022-12-01 Thread Martin Bidlingmaier via Phabricator via cfe-commits
mbid created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. mbid added a comment. mbid published this revision for review. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Hi Nathan, Could

[PATCH] D138031: Add clang-tidy check for missing move constructors

2022-11-17 Thread Martin Bidlingmaier via Phabricator via cfe-commits
mbid added a comment. Hi Nathan, thanks for looking into this. I did indeed not know about the existing check in cppcoreguidelines -- maybe I should've been more suspicious about assuming something so obvious supposedly doesn't exist yet :) But perhaps the replacements could still be integrated

[PATCH] D138035: Fix clang-tidy util findNextTokenSkippingComments

2022-11-15 Thread Martin Bidlingmaier via Phabricator via cfe-commits
mbid created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. mbid requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The function did not update the Start sou

[PATCH] D138031: Add clang-tidy check for missing move constructors

2022-11-15 Thread Martin Bidlingmaier via Phabricator via cfe-commits
mbid added inline comments. Comment at: clang/include/clang/Lex/Token.h:101 -return is(K1) || is(K2); - } template bool isOneOf(tok::TokenKind K1, Ts... Ks) const { This change is necessary to make `isOneOf` work with a single argument (and also no argu

[PATCH] D138031: Add clang-tidy check for missing move constructors

2022-11-15 Thread Martin Bidlingmaier via Phabricator via cfe-commits
mbid created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. mbid requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monore