Thanks for the quick response and your suggestions!
I believe the workaround you suggest in 1) will work for us, so there's no
need for an urgent change. Thanks again!
On 21 December 2017 at 20:11, Alex L wrote:
> Thanks for raising your concerns.
>
> We decided to avoid -m-version-min flag in
This is causing problems in some internal builds that specify both
-mios-simulator-version-min=9.0 and --target=x86_64-apple-ios
My expectation would be for the code to take the minimum OS version number
from the -mios-simulator-version-min flag. In fact, however, the code seems
to be completely i
This revision was automatically updated to reflect the committed changes.
mboehme marked 2 inline comments as done.
Closed by commit rL285842: [clang-tidy] Extend misc-use-after-move to support
unique_ptr and shared_ptr. (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D
mboehme marked 4 inline comments as done.
mboehme added a comment.
Please take another look.
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:467
+StringRef getName(const NamedDecl *ND) {
+ if (!ND->getIdentifier())
+return StringRef();
aaron.ballman wrot
mboehme updated this revision to Diff 76655.
mboehme added a comment.
- Responses to reviewer comments
https://reviews.llvm.org/D26041
Files:
clang-tidy/misc/UseAfterMoveCheck.cpp
docs/clang-tidy/checks/misc-use-after-move.rst
test/clang-tidy/misc-use-after-move.cpp
Index: test/clang-tid
mboehme created this revision.
mboehme added a reviewer: alexfh.
mboehme added a subscriber: cfe-commits.
As a unique_ptr or shared_ptr that has been moved from is guaranteed to be null,
we only warn if the pointer is dereferenced.
https://reviews.llvm.org/D26041
Files:
clang-tidy/misc/UseAft
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284235: [clang-tidy] Add additional diagnostic to
misc-use-after-move (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D25612?vs=74671&id=74673#toc
Repository:
rL LLVM
https:
mboehme updated this revision to Diff 74671.
mboehme added a comment.
- Responses to reviewer comments
https://reviews.llvm.org/D25612
Files:
clang-tidy/misc/UseAfterMoveCheck.cpp
test/clang-tidy/misc-use-after-move.cpp
Index: test/clang-tidy/misc-use-after-move.cpp
==
mboehme created this revision.
mboehme added a reviewer: hokein.
mboehme added a subscriber: cfe-commits.
This adds a diagnostic to the misc-use-after-move check that is output when the
use happens on a later loop iteration than the move, for example:
A a;
for (int i = 0; i < 10; ++i) {
a
mboehme abandoned this revision.
mboehme added a comment.
Abandoning after discussion with klimek.
https://reviews.llvm.org/D24962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mboehme created this revision.
mboehme added a reviewer: klimek.
mboehme added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
r282433 added LLVM_ATTRIBUTE_ALWAYS_INLINE to the StringRef(const char *)
constructor. This causes the size of the stack frame for
RegistryMaps::RegistryMaps
mboehme added a comment.
Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D24561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281460: [clang-tidy] Add dependency on clangAnalysis to
clangTidyMiscModule (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D24561?vs=71345&id=71346#toc
Repository:
rL LLVM
mboehme added a comment.
Trivial build fix, will submit without review.
https://reviews.llvm.org/D24561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mboehme created this revision.
mboehme added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
This is needed for the recently submitted misc-use-after-move check (rL281453).
For some reason, this still built under Linux, but it caused the PPC build bot
to fail.
https://reviews.
>
> While I'm excited to see this go in anywhere, I have to say I'm a bit sad
> it isn't going in as a warning and instead inside clang-tidy. This has been
> a much requested warning from Clang for many years.
>
> Is there a concise description of why this design was chosen? Are there
> specific pr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281455: [clang-tidy] Make test for misc-use-after-move pass
under Windows (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D24550?vs=71318&id=71319#toc
Repository:
rL LLVM
ht
mboehme added a comment.
Single-line trivial change, will submit without review. Please let me know if
you have any objections.
https://reviews.llvm.org/D24550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
mboehme created this revision.
mboehme added a reviewer: alexfh.
mboehme added a subscriber: cfe-commits.
Adds -fno-delayed-template-parsing
https://reviews.llvm.org/D24550
Files:
test/clang-tidy/misc-use-after-move.cpp
Index: test/clang-tidy/misc-use-after-move.cpp
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281453: [clang-tidy] Add check 'misc-use-after-move'
(authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D23353?vs=71312&id=71313#toc
Repository:
rL LLVM
https://reviews.llvm.or
mboehme marked an inline comment as done.
mboehme added a comment.
https://reviews.llvm.org/D23353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mboehme updated this revision to Diff 71312.
mboehme marked 6 inline comments as done.
mboehme added a comment.
Herald added subscribers: mgorny, beanz.
Responses to reviewer comments.
https://reviews.llvm.org/D23353
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
This revision was automatically updated to reflect the committed changes.
mboehme marked an inline comment as done.
Closed by commit rL281200: [CFG] Add iterator_ranges to CFG and CFGBlock.
(authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D23842?vs=69129&id=70981#toc
Re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280077: [clang-tidy] Add check
'misc-move-forwarding-reference' (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D0?vs=69665&id=69666#toc
Repository:
rL LLVM
https://revi
mboehme updated this revision to Diff 69665.
mboehme added a comment.
Update to current head
https://reviews.llvm.org/D0
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveForwardingReferenceCheck.cpp
clang-tidy/misc/MoveForwardingReferenceC
mboehme marked an inline comment as done.
mboehme added a comment.
https://reviews.llvm.org/D0
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mboehme updated this revision to Diff 69662.
mboehme added a comment.
Fix typo
https://reviews.llvm.org/D0
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveForwardingReferenceCheck.cpp
clang-tidy/misc/MoveForwardingReferenceCheck.h
docs/
mboehme marked an inline comment as done.
mboehme added a comment.
Any more comments here?
https://reviews.llvm.org/D0
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mboehme marked an inline comment as done.
Comment at: include/clang/Analysis/CFG.h:526
@@ -524,1 +525,3 @@
typedef AdjacentBlocks::const_reverse_iterator const_pred_reverse_iterator;
+ typedef llvm::iterator_range pred_range;
+ typedef llvm::iterator_ran
mboehme marked 9 inline comments as done.
mboehme added a comment.
> > > 2. Also it would be good to make link in cppcoreguidelines.
>
> >
>
> >
>
> > How exactly would I create such a "link"? Are you just thinking of a link
> > in the documentation, or is there a way to have one clang
mboehme updated this revision to Diff 69206.
mboehme added a comment.
Responses to reviewer comments.
https://reviews.llvm.org/D23353
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/UseAfterMoveCheck.cpp
clang-tidy/misc/UseAfterMoveCheck.h
docs
mboehme updated this revision to Diff 69129.
mboehme added a comment.
Re-add inadvertently deleted blank line
https://reviews.llvm.org/D23842
Files:
include/clang/Analysis/CFG.h
Index: include/clang/Analysis/CFG.h
===
--- includ
mboehme created this revision.
mboehme added a reviewer: alexfh.
mboehme added a subscriber: cfe-commits.
(Needed for D23353.)
https://reviews.llvm.org/D23842
Files:
include/clang/Analysis/CFG.h
Index: include/clang/Analysis/CFG.h
==
mboehme marked 2 inline comments as done.
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:659
@@ +658,3 @@
+ UseAfterMove Use;
+ if (finder.find(FunctionBody, MovingCall, MovedVariable, &Use)) {
+emitDiagnostic(MovingCall, MovedVariable, Use, this, Result.Context);
---
mboehme updated this revision to Diff 68366.
mboehme added a comment.
Remove braces around another single-line if statement block
https://reviews.llvm.org/D23353
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/UseAfterMoveCheck.cpp
clang-tidy/mis
mboehme updated this revision to Diff 68365.
mboehme added a comment.
Remove braces around single-line bodies of if statements
https://reviews.llvm.org/D23353
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/UseAfterMoveCheck.cpp
clang-tidy/misc/U
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278934: Adapt to TraverseLambdaCapture interface change from
D23204 (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D23543?vs=68138&id=68358#toc
Repository:
rL LLVM
https://
This revision was automatically updated to reflect the committed changes.
mboehme marked an inline comment as done.
Closed by commit rL278933: Visit lambda capture inits from
RecursiveASTVisitor::TraverseLambdaCapture(). (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D
mboehme marked 3 inline comments as done.
Comment at: unittests/Tooling/RecursiveASTVisitorTestExprVisitor.cpp:239
@@ +238,3 @@
+ EXPECT_TRUE(Visitor.runOver(
+"void f() { int i; [a = i + 1]{}; }",
+DeclRefExprVisitor::Lang_CXX14));
alexfh wrote:
> So, C+
mboehme updated this revision to Diff 68352.
mboehme marked an inline comment as done.
mboehme added a comment.
Changes in response to reviewer comments
https://reviews.llvm.org/D23204
Files:
include/clang/AST/RecursiveASTVisitor.h
lib/Index/IndexBody.cpp
unittests/Tooling/RecursiveASTVis
mboehme marked 2 inline comments as done.
Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:46-56
@@ +45,13 @@
+// std::move(). This will hopefully prevent erroneous replacements if the
+// code does unusual things (e.g. create an alias for std::move() in
+/
mboehme updated this revision to Diff 68322.
mboehme added a comment.
Reponses to reviewer comments
https://reviews.llvm.org/D0
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveForwardingReferenceCheck.cpp
clang-tidy/misc/MoveForwardingRef
mboehme marked 4 inline comments as done.
mboehme added a comment.
In https://reviews.llvm.org/D23353#511362, @Prazek wrote:
> I will review it later, but my first thoughts:
>
> 1. I think we should make some other group, because misc seems to be
> overloaded. I discussed it with Alex months ago
mboehme marked 9 inline comments as done.
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:493
@@ +492,3 @@
+if (!S)
+ continue;
+
For some reason, I thought I had read that they weren't compatible with CFG /
CFGBlock -- but obviously I must have been i
mboehme updated this revision to Diff 68147.
mboehme added a comment.
Responses to reviewer comments.
https://reviews.llvm.org/D23353
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/UseAfterMoveCheck.cpp
clang-tidy/misc/UseAfterMoveCheck.h
docs
mboehme marked 2 inline comments as done.
Comment at: include/clang/AST/RecursiveASTVisitor.h:892
@@ -891,1 +891,3 @@
+ else
+TRY_TO(TraverseStmt(LE->capture_init_begin()[C - LE->capture_begin()]));
return true;
klimek wrote:
> I'd rather pass in the offse
mboehme updated this revision to Diff 68139.
mboehme added a comment.
Update to a clean diff.
(Sorry, the last diff included a large number of extraneous changes by others.)
https://reviews.llvm.org/D23204
Files:
include/clang/AST/RecursiveASTVisitor.h
lib/Index/IndexBody.cpp
unittests/T
mboehme created this revision.
mboehme added a reviewer: alexfh.
mboehme added a subscriber: cfe-commits.
mboehme added a dependency: D23204: Visit lambda capture inits from
RecursiveASTVisitor::TraverseLambdaCapture()..
Depends on D23204.
This is intended to be submitted immediately after D2320
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278507: [ASTMatchers] Add templateTypeParmDecl() to
Registry.cpp (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D23448?vs=67831&id=67832#toc
Repository:
rL LLVM
https://rev
mboehme created this revision.
mboehme added a reviewer: alexfh.
mboehme added a subscriber: cfe-commits.
Herald added subscribers: samparker, rengolin, aemerson, klimek.
This appears to have been forgotten when templateTypeParmDecl() was initially
added.
https://reviews.llvm.org/D23448
Files:
mboehme updated this revision to Diff 67829.
mboehme marked 2 inline comments as done.
mboehme added a comment.
Fix typo in comment
https://reviews.llvm.org/D0
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveForwardingReferenceCheck.cpp
c
mboehme added inline comments.
Comment at: test/clang-tidy/misc-move-forwarding-reference.cpp:50
@@ +49,3 @@
+// operator.
+template void f5(U &&SomeU) {
+ {
Sorry, that should have been "scope resolution operator". Comment changed.
What this is trying to test
mboehme updated this revision to Diff 67830.
mboehme added a comment.
Restore spaces around scope resolution operator in test case
https://reviews.llvm.org/D0
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveForwardingReferenceCheck.cpp
cl
mboehme updated this revision to Diff 67828.
mboehme added a comment.
Handle case where the forwarding reference is a parameter of a generic lambda.
https://reviews.llvm.org/D0
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveForwardingRefer
mboehme added a comment.
Apologies for the size of this patch. alexfh@ said he was willing to review it
as-is -- however, I'm happy to resubmit in smaller pieces if necessary.
https://reviews.llvm.org/D23353
___
cfe-commits mailing list
cfe-commits
mboehme created this revision.
mboehme added a reviewer: alexfh.
mboehme added a subscriber: cfe-commits.
The check warns if an object is used after it has been moved, without an
intervening reinitialization.
See user-facing documentation for details.
https://reviews.llvm.org/D23353
Files:
cl
mboehme added a comment.
Now that https://reviews.llvm.org/D23004 is submitted, can you take another
look?
https://reviews.llvm.org/D0
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278123: [ASTMatchers] Add matchers canReferToDecl() and
hasUnderlyingDecl() (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D23004?vs=66912&id=67353#toc
Repository:
rL LLVM
mboehme updated this revision to Diff 66914.
mboehme marked 2 inline comments as done.
mboehme added a comment.
Renamed canReferToDecl to hasAnyDeclaration.
This is for consistency with the corresponding change in
https://reviews.llvm.org/D23004.
https://reviews.llvm.org/D0
Files:
mboehme marked 5 inline comments as done.
mboehme added a comment.
https://reviews.llvm.org/D23004
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mboehme updated this revision to Diff 66912.
mboehme added a comment.
- Rename canReferToDecl to hasAnyDeclaration
https://reviews.llvm.org/D23004
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/
mboehme updated this revision to Diff 66815.
mboehme added a comment.
Removed superfluous parentheses
https://reviews.llvm.org/D23004
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersTr
mboehme marked 3 inline comments as done.
mboehme added a comment.
https://reviews.llvm.org/D23004
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mboehme marked an inline comment as done.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2486
@@ +2485,3 @@
+
+ return (UnderlyingDecl != nullptr &&
+ InnerMatcher.matches(*UnderlyingDecl, Finder, Builder));
I was trying to match the style of the ne
mboehme added a comment.
I've rebased the patch to a newer head revision, which seems to confuse
Phabricator when diffing against earlier versions of the patch. Apologies. I
assume this means I should avoid doing this (rebasing to a newer revision)?
https://reviews.llvm.org/D23004
_
mboehme updated this revision to Diff 66808.
https://reviews.llvm.org/D23004
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersTraversalTest.cpp
Index: unittests/ASTMatchers/ASTMatchersTr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277339: [clang-tidy] Prepare modernize-loop-convert for
upcoming changes in D22566 (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D22903?vs=65877&id=66303#toc
Repository:
rL
mboehme added reviewers: sbenza, aaron.ballman.
mboehme updated this revision to Diff 66291.
mboehme added a comment.
Updated test and documentation for hasUnderlyingDecl() to use using
declarations instead of typedefs. (I made the mistaken assumption that
getUnderlyingDecl() would also work on
mboehme added a comment.
Retracting from review for the moment. Tests fail to compile (embarrasingly
enough, I ran the wrong test suite -- apologies).
https://reviews.llvm.org/D23004
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
mboehme marked 7 inline comments as done.
Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:93
@@ +92,3 @@
+ hasArgument(0, ignoringParenImpCasts(declRefExpr(
+ to(ForwardingReferenceParmMatcher)
+ .bind("call-
mboehme updated this revision to Diff 66284.
mboehme marked 3 inline comments as done.
https://reviews.llvm.org/D0
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveForwardingReferenceCheck.cpp
clang-tidy/misc/MoveForwardingReferenceCheck.h
mboehme created this revision.
mboehme added reviewers: aaron.ballman, sbenza.
mboehme added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Required for D0
https://reviews.llvm.org/D23004
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
li
mboehme added a comment.
This was reverted in https://reviews.llvm.org/rL276759 because it broke
modernize-loop-convert.
https://reviews.llvm.org/D22903 contains a fix for the modernize-loop-convert
issue. Will re-submit this patch once https://reviews.llvm.org/D22903 has
landed.
Repository:
mboehme created this revision.
mboehme added a reviewer: klimek.
mboehme added a subscriber: cfe-commits.
D22566 will change RecursiveASTVisitor so that it descends into the
initialization expressions for lambda captures.
modernize-loop-convert needs to be prepared for this so that it does not
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276755: Make RecursiveASTVisitor visit lambda capture
initialization expressions (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D22566?vs=64665&id=65526#toc
Repository:
rL L
mboehme marked 13 inline comments as done.
Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:20
@@ +19,3 @@
+
+static void ReplaceMoveWithForward(const UnresolvedLookupExpr *Callee,
+ const TemplateTypeParmType *TypeParmType,
--
mboehme updated this revision to Diff 65484.
mboehme marked an inline comment as done.
mboehme added a comment.
Changes in response to reviewer comments
https://reviews.llvm.org/D0
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveForwardingR
mboehme created this revision.
mboehme added a reviewer: klimek.
mboehme added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Lambda capture initializations are part of the explicit source code and
therefore should be visited by default but, so far, RecursiveASTVisitor does
not vi
mboehme created this revision.
mboehme added a reviewer: bkramer.
mboehme added a subscriber: cfe-commits.
The test currently fails if the name of the Clang binary doesn't contain
"clang".
This patch removes that requirement, as some environments may choose to run the
test with a differently na
mboehme added a comment.
Fix submitted
Repository:
rL LLVM
https://reviews.llvm.org/D22170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mboehme added a comment.
Fix in review at https://reviews.llvm.org/D22349
Repository:
rL LLVM
https://reviews.llvm.org/D22170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mboehme created this revision.
mboehme added a reviewer: bkramer.
mboehme added subscribers: cfe-commits, ashi1.
rL275318 added the test Frontend/opencl.cl test, but that test was never
actually run because Frontend/lit.local.cfg doesn't contain the '.cl' file
suffix.
Once the test is activated
The test cfe/trunk/test/Frontend/opencl.cl that was added here appears to
fail.
Running "ninja check-clang" doesn't pick this up because
cfe/trunk/test/Frontend/lit.local.cfg doesn't contain '.cl' as a file
suffix:
config.suffixes = ['.c', '.cpp', '.m', '.mm', '.ll']
As soon as I add the suffix:
mboehme added a subscriber: mboehme.
mboehme added a comment.
The test cfe/trunk/test/Frontend/opencl.cl that was added here appears to
fail.
Running "ninja check-clang" doesn't pick this up because
cfe/trunk/test/Frontend/lit.local.cfg doesn't contain '.cl' as a file
suffix:
config.suffixes = [
mboehme abandoned this revision.
mboehme added a comment.
Good to hear -- abandoning this patch then.
http://reviews.llvm.org/D22263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mboehme marked 5 inline comments as done.
mboehme added a comment.
In http://reviews.llvm.org/D0#480415, @mgehre wrote:
> Nice check. This should be mentioned in docs/ReleaseNotes.rst
Done.
Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:34
@@ +33,3 @@
+ if
mboehme updated this revision to Diff 63663.
mboehme added a comment.
Addressed Prazek's review comments.
http://reviews.llvm.org/D0
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveForwardingReferenceCheck.cpp
clang-tidy/misc/MoveForwardi
mboehme created this revision.
mboehme added a reviewer: alexfh.
mboehme added a subscriber: cfe-commits.
The missing newline after the ".. code:: c++" was causing a compile error when
producing the documentation
http://reviews.llvm.org/D22263
Files:
docs/clang-tidy/checks/modernize-use-empla
mboehme created this revision.
mboehme added a reviewer: sbenza.
mboehme added a subscriber: cfe-commits.
The check emits a warning if std::move() is applied to a forwarding reference,
i.e. an rvalue reference of a function template argument type.
If a developer is unaware of the special rules f
mboehme marked an inline comment as done.
mboehme added a comment.
http://reviews.llvm.org/D21895
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mboehme updated this revision to Diff 62374.
http://reviews.llvm.org/D21895
Files:
lib/Analysis/CFG.cpp
unittests/Analysis/CFGTest.cpp
unittests/Analysis/CMakeLists.txt
unittests/CMakeLists.txt
Index: unittests/CMakeLists.txt
==
mboehme created this revision.
mboehme added a reviewer: klimek.
mboehme added a subscriber: cfe-commits.
CFG generation is expected to fail in this case, but it should not crash.
Also added a test that reproduces the crash.
http://reviews.llvm.org/D21895
Files:
lib/Analysis/CFG.cpp
unittes
mboehme created this revision.
mboehme added a reviewer: klimek.
mboehme added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
http://reviews.llvm.org/D21799
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index: include/clang/ASTMatchers/ASTMatchers.h
mboehme created this revision.
mboehme added a reviewer: alexfh.
mboehme added a subscriber: cfe-commits.
http://reviews.llvm.org/D21366
Files:
clang-tidy/misc/MoveConstantArgumentCheck.cpp
clang-tidy/misc/MoveConstantArgumentCheck.h
Index: clang-tidy/misc/MoveConstantArgumentCheck.h
===
mboehme added inline comments.
Comment at: test/clang-tidy/misc-move-const-arg.cpp:75-76
@@ +74,4 @@
+
+class NonMoveable {
+ public:
+ NonMoveable();
aaron.ballman wrote:
> > Can you expand on this?
> >
> > The standard says: "If the definition of a class X does
mboehme updated this revision to Diff 60686.
http://reviews.llvm.org/D21223
Files:
clang-tidy/misc/MoveConstantArgumentCheck.cpp
docs/clang-tidy/checks/misc-move-const-arg.rst
test/clang-tidy/misc-move-const-arg.cpp
Index: test/clang-tidy/misc-move-const-arg.cpp
===
mboehme added inline comments.
Comment at: test/clang-tidy/misc-move-const-arg.cpp:75-76
@@ +74,4 @@
+
+struct NonMoveable {
+ public:
+ NonMoveable();
aaron.ballman wrote:
> This type isn't non-moveable. For that, you need to explicitly delete the
> move constr
mboehme updated this revision to Diff 60671.
http://reviews.llvm.org/D21223
Files:
clang-tidy/misc/MoveConstantArgumentCheck.cpp
docs/clang-tidy/checks/misc-move-const-arg.rst
test/clang-tidy/misc-move-const-arg.cpp
Index: test/clang-tidy/misc-move-const-arg.cpp
===
mboehme added inline comments.
Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:37
@@ +36,3 @@
+ if (BeforeArgumentsRange.isValid() && AfterArgumentsRange.isValid()) {
+(*Diag) << FixItHint::CreateRemoval(BeforeArgumentsRange)
+<< FixItHint::CreateRemoval
mboehme updated this revision to Diff 60523.
mboehme marked 4 inline comments as done.
http://reviews.llvm.org/D21223
Files:
clang-tidy/misc/MoveConstantArgumentCheck.cpp
docs/clang-tidy/checks/misc-move-const-arg.rst
test/clang-tidy/misc-move-const-arg.cpp
Index: test/clang-tidy/misc-move
1 - 100 of 103 matches
Mail list logo
