[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6403287eff71: [Flang] [FlangRT] Introduce FlangRT project as solut

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

madanial added a comment. In D154869#4628847 , @efriedma wrote: > Maybe split the changes to reformat the unittests into a separate patch? > > Otherwise, I'm happy with the current state of this patch, but probably > someone more active in flang should a

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

madanial added inline comments. Comment at: runtimes/CMakeLists.txt:20 +set(RUNTIMES_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) + ldionne wrote: > This shouldn't be necessary, CMake already creates a `Project_SOURCE_DIR` > variable for each declared `project()` I

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

madanial added a comment. Pinging for review. I will be taking over this patch from Paul, but Paul will still be around to answer any questions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.llvm.org/D154869 __

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

madanial added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

This revision was automatically updated to reflect the committed changes. Closed by commit rG1360bfb05b31: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing… (authored by madanial). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D144516: [Flang] Add user option -funderscoring/-fnounderscoring

madanial created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: mehdi_amini. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. madanial requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald added a p

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

madanial updated this revision to Diff 497931. madanial added a comment. addressing style mismatch in > flang/include/flang/Tools/CLOptions.inc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 Files: clang/include/clang/Driver/Options.td cl

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

madanial updated this revision to Diff 497928. madanial added a comment. Bug Fix for failing test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp fl

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

madanial updated this revision to Diff 497392. madanial added a comment. clang-format issue in ExternalNameConversion.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/To

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

madanial updated this revision to Diff 497024. madanial added a comment. Addressing the review comments relating to the test case. Thanks for the catch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 Files: clang/include/clang/Driver/Option

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

madanial updated this revision to Diff 496027. madanial added a comment. Rebase, as well as bug fix relating to the ExternalNameConversion pass option that was exposed by the requested fir-opt test case. The pass option was being overwritten by default value whenever it was called through fir-op

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

madanial updated this revision to Diff 492463. madanial added a comment. Addressing review comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp flang/i

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

madanial updated this revision to Diff 492312. madanial retitled this revision from "[Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass" to "[Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external

[PATCH] D106815: Update: clang/test/Profile/gcc-flag-compatibility.c to have -flto on AIX

madanial marked an inline comment as done. madanial added a comment. I need some help to commit this change as I do not have commit access as of now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106815/new/ https://reviews.llvm.org/D106815 __

[PATCH] D106815: Update: clang/test/Profile/gcc-flag-compatibility.c to have -flto on AIX

madanial updated this revision to Diff 362829. madanial added a comment. Adding comment in gcc-flag-compatibility.c indicating that testing for AIX is done in gcc-flag-compatibility-aix.c as suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D106815: Update: clang/test/Profile/gcc-flag-compatibility.c upstream to have -flto on AIX

madanial created this revision. madanial added reviewers: Whitney, dnovillo, xur. madanial added a project: LLVM. Herald added a subscriber: inglorion. madanial requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commit: https://reviews.llvm.or