Fznamznon wrote:
ping @tahonermann
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
Oops new tests are failing.
https://github.com/llvm/llvm-project/pull/140282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -25,20 +40,29 @@ int main() {
auto lambda2 = [](int){};
auto lambda3 = [](double){};
- kernel(lambda1);
- kernel2(lambda2);
- kernel3(lambda3);
+ kernel_wrapper(lambda1);
+ kernel2_wrapper(lambda2);
+ kernel3_wrapper(lambda3);
// Ensure the kernels are named
@@ -25,20 +40,29 @@ int main() {
auto lambda2 = [](int){};
auto lambda3 = [](double){};
- kernel(lambda1);
- kernel2(lambda2);
- kernel3(lambda3);
+ kernel_wrapper(lambda1);
+ kernel2_wrapper(lambda2);
+ kernel3_wrapper(lambda3);
// Ensure the kernels are named
@@ -25,20 +40,29 @@ int main() {
auto lambda2 = [](int){};
auto lambda3 = [](double){};
- kernel(lambda1);
- kernel2(lambda2);
- kernel3(lambda3);
+ kernel_wrapper(lambda1);
+ kernel2_wrapper(lambda2);
+ kernel3_wrapper(lambda3);
// Ensure the kernels are named
@@ -25,20 +40,29 @@ int main() {
auto lambda2 = [](int){};
auto lambda3 = [](double){};
- kernel(lambda1);
- kernel2(lambda2);
- kernel3(lambda3);
+ kernel_wrapper(lambda1);
+ kernel2_wrapper(lambda2);
+ kernel3_wrapper(lambda3);
// Ensure the kernels are named
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/147030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/146854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/146854
>From 9a640eefb5d27a65f236b5f7df1398bdf1bcc017 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Thu, 3 Jul 2025 03:46:41 -0700
Subject: [PATCH 1/4] [NFC][clang] Fix
CodeGenSYCL::unique_stable_nam
@@ -747,6 +747,10 @@ Bug Fixes in This Version
- Fixed an infinite recursion when checking constexpr destructors. (#GH141789)
- Fixed a crash when a malformed using declaration appears in a ``constexpr``
function. (#GH144264)
- Fixed a bug when use unicode character name in ma
@@ -25,20 +40,29 @@ int main() {
auto lambda2 = [](int){};
auto lambda3 = [](double){};
- kernel(lambda1);
- kernel2(lambda2);
- kernel3(lambda3);
+ kernel_wrapper(lambda1);
+ kernel2_wrapper(lambda2);
+ kernel3_wrapper(lambda3);
// Ensure the kernels are named
Fznamznon wrote:
> I noticed there is a problem with __builtin_sycl_unique_stable_name and
> sycl_kernel_etnry_point attribute. If I add this wrapping of
> __builtin_sycl_unique_stable_name calls AND sycl_kernel_entry_point
> attribute, the strings disappear from the IR. They are in here
> ht
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/146854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon ready_for_review
https://github.com/llvm/llvm-project/pull/146854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/146854
>From 9a640eefb5d27a65f236b5f7df1398bdf1bcc017 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Thu, 3 Jul 2025 03:46:41 -0700
Subject: [PATCH 1/3] [NFC][clang] Fix
CodeGenSYCL::unique_stable_nam
@@ -46,6 +46,22 @@ Potentially Breaking Changes
``endbr64`` instruction at the labels named as possible branch
destinations, so it is not safe to use a register-controlled branch
instruction to branch to one. (In line with gcc.)
+- Scalar deleting destructor support has b
Fznamznon wrote:
Ping @tahonermann
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1450,7 +1450,6 @@ def MicrosoftAnonTag : DiagGroup<"microsoft-anon-tag">;
def MicrosoftCommentPaste : DiagGroup<"microsoft-comment-paste">;
def MicrosoftEndOfFile : DiagGroup<"microsoft-end-of-file">;
def MicrosoftInaccessibleBase : DiagGroup<"microsoft-inaccessible-base">;
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/147030
>From 3060e6f416ea62bdf62470e6636278d736cc49d0 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Fri, 4 Jul 2025 02:50:38 -0700
Subject: [PATCH 1/4] [win][clang] Do not inject static_assert macro d
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 01/17] [win][clang] Align scalar deleting destructor
@@ -1450,7 +1450,6 @@ def MicrosoftAnonTag : DiagGroup<"microsoft-anon-tag">;
def MicrosoftCommentPaste : DiagGroup<"microsoft-comment-paste">;
def MicrosoftEndOfFile : DiagGroup<"microsoft-end-of-file">;
def MicrosoftInaccessibleBase : DiagGroup<"microsoft-inaccessible-base">;
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/147030
>From 3060e6f416ea62bdf62470e6636278d736cc49d0 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Fri, 4 Jul 2025 02:50:38 -0700
Subject: [PATCH 1/3] [win][clang] Do not inject static_assert macro d
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/147030
In ms-compatibility mode we inject static_assert macro definition if
assert macro is defined. This is done by
8da090381d567d0ec555840f6b2a651d2997e4b3
for the sake of better diagnosing, in particular to emit a
https://github.com/Fznamznon converted_to_draft
https://github.com/llvm/llvm-project/pull/146854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
I noticed there is a problem with __builtin_sycl_unique_stable_name and
sycl_kernel_etnry_point attribute. If I add this wrapping of
__builtin_sycl_unique_stable_name calls AND sycl_kernel_entry_point attribute,
the strings disappear from the IR. They are in here
https://godb
https://github.com/Fznamznon ready_for_review
https://github.com/llvm/llvm-project/pull/146854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/146854
>From 9a640eefb5d27a65f236b5f7df1398bdf1bcc017 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Thu, 3 Jul 2025 03:46:41 -0700
Subject: [PATCH 1/2] [NFC][clang] Fix
CodeGenSYCL::unique_stable_nam
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/146854
The test checks x86 target in fsycl-is-device mode. x86 is not a valid
offloading target and IMO test meant to check fsycl-is-host mode to make sure
host invocations of __builtin_sycl_unique_stable_name work
@@ -1587,28 +1587,82 @@ namespace {
}
};
+ // This function implements generation of scalar deleting destructor body for
+ // the case when the destructor also accepts an implicit flag. Right now only
+ // Microsoft ABI requires deleting destructors to accept implicit
@@ -3101,6 +3101,17 @@ void CXXDestructorDecl::setOperatorDelete(FunctionDecl
*OD, Expr *ThisArg) {
}
}
+void CXXDestructorDecl::setOperatorGlobalDelete(FunctionDecl *OD) {
+ assert(!OD || (OD->getDeclName().getCXXOverloadedOperator() == OO_Delete &&
+
OD-
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 01/16] [win][clang] Align scalar deleting destructor
@@ -194,9 +217,31 @@ I::~I() { call_in_dtor(); }
// CHECK-MSABI32-LABEL: define {{.*}} @"??_GI@@UAEPAXI@Z"(
// CHECK-MSABI-NOT: call{{ }}
// CHECK-MSABI: load i32
-// CHECK-MSABI: icmp eq i32 {{.*}}, 0
-// CHECK-MSABI: br i1
+// CHECK-MSABI-NEXT: and i32 %[[IMP_PARAM:.*]], 4
+/
@@ -2886,6 +2887,16 @@ class CXXDestructorDecl : public CXXMethodDecl {
return getCanonicalDecl()->OperatorDelete;
}
+ const FunctionDecl *getOperatorGlobalDelete() const {
+return getCanonicalDecl()->OperatorGlobalDelete;
+ }
+
+ void setOperatorGlobalDelete(Func
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 01/11] [win][clang] Align scalar deleting destructor
@@ -2886,6 +2887,16 @@ class CXXDestructorDecl : public CXXMethodDecl {
return getCanonicalDecl()->OperatorDelete;
}
+ const FunctionDecl *getOperatorGlobalDelete() const {
+return getCanonicalDecl()->OperatorGlobalDelete;
+ }
+
+ void setOperatorGlobalDelete(Func
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 01/14] [win][clang] Align scalar deleting destructor
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/145497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/145497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2886,6 +2887,16 @@ class CXXDestructorDecl : public CXXMethodDecl {
return getCanonicalDecl()->OperatorDelete;
}
+ const FunctionDecl *getOperatorGlobalDelete() const {
+return getCanonicalDecl()->OperatorGlobalDelete;
+ }
+
+ void setOperatorGlobalDelete(Func
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 01/12] [win][clang] Align scalar deleting destructor
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/145497
For long enough _BitInt types we use different types for memory,
storing-loading and operations. Makes sure it is correct for mixed sign
__builtin_mul_overflow cases. Using pointer element type as a result ty
@@ -194,9 +217,31 @@ I::~I() { call_in_dtor(); }
// CHECK-MSABI32-LABEL: define {{.*}} @"??_GI@@UAEPAXI@Z"(
// CHECK-MSABI-NOT: call{{ }}
// CHECK-MSABI: load i32
-// CHECK-MSABI: icmp eq i32 {{.*}}, 0
-// CHECK-MSABI: br i1
+// CHECK-MSABI-NEXT: and i32 %[[IMP_PARAM:.*]], 4
+/
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2886,6 +2887,16 @@ class CXXDestructorDecl : public CXXMethodDecl {
return getCanonicalDecl()->OperatorDelete;
}
+ const FunctionDecl *getOperatorGlobalDelete() const {
+return getCanonicalDecl()->OperatorGlobalDelete;
+ }
+
+ void setOperatorGlobalDelete(Func
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 01/11] [win][clang] Align scalar deleting destructor
@@ -1590,25 +1590,70 @@ namespace {
void EmitConditionalDtorDeleteCall(CodeGenFunction &CGF,
Fznamznon wrote:
Added a comment.
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commit
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 01/10] [win][clang] Align scalar deleting destructor
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 1/8] [win][clang] Align scalar deleting destructors
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 1/7] [win][clang] Align scalar deleting destructors
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 1/5] [win][clang] Align scalar deleting destructors
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/144109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
Thanks @AaronBallman , It seems -fclang-abi-compat=20 doesn't work, so first we
need https://github.com/llvm/llvm-project/pull/144109 .
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@lists.ll
@@ -11,6 +12,7 @@ struct XMM2 : XMM1<0>, XMM1<1> {
};
// CHECK: define{{.*}} @_Z3foov({{.*}} [[ARG:%.*]]){{.*}}
+// CLANG-20: define{{.*}} <4 x double> @_Z3foov()
Fznamznon wrote:
I think this is the only test which is different between clang 20 and clang 21,
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/144109
The value was known already, but it was parsed as latest which is incorrect
because we are already doing clang 21.
>From a48dd54fb4918a89e6a98f82860332ab59be6df6 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva
https://github.com/Fznamznon approved this pull request.
https://github.com/llvm/llvm-project/pull/144068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -836,8 +836,7 @@ StmtResult Parser::ParseCaseStatement(ParsedStmtContext
StmtCtx,
Diag(ExpectedLoc, diag::err_expected_after)
<< "'case'" << tok::colon
- << FixItHint::CreateInsertion(ExpectedLoc,
-tok::getTo
https://github.com/Fznamznon commented:
Can we add a test?
https://github.com/llvm/llvm-project/pull/144068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/144068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
Ok, I added the release note.
> we'd use ABI version tags for it at that point.
@AaronBallman Could you please elaborate a bit more on that?
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@li
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 1/4] [win][clang] Align scalar deleting destructors
Fznamznon wrote:
> Was there a backport request created for this one?
No, when I applied the patch locally to release20.x branch, one of the tests
that this patch adds crashed, so probably additional fixes required to be
backported.
https://github.com/llvm/llvm-project/pull/135957
___
@@ -1589,25 +1589,74 @@ namespace {
void EmitConditionalDtorDeleteCall(CodeGenFunction &CGF,
llvm::Value *ShouldDeleteCondition,
bool ReturnAfterDelete) {
+const CXXDestructorDecl *Dtor = cast(CGF.C
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/139566
>From 1b0b6242e5749e776f02581ba8600d853bfef322 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Mon, 12 May 2025 07:25:57 -0700
Subject: [PATCH 1/2] [win][clang] Align scalar deleting destructors
https://github.com/Fznamznon approved this pull request.
https://github.com/llvm/llvm-project/pull/143546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
> I didn't add a test because this can't be reproduced yet in this repo, I
> reproduced this only in intel's fork with more SYCL support.
But that does sound specific to the downstream, right? Do we observe the issue
there because intel's fork used to add OpenCLKernelAttr impl
@@ -7179,6 +7179,12 @@ ProcessDeclAttribute(Sema &S, Scope *scope, Decl *D,
const ParsedAttr &AL,
case ParsedAttr::AT_EnumExtensibility:
handleEnumExtensibilityAttr(S, D, AL);
break;
+ case ParsedAttr::AT_SYCLKernel:
+S.SYCL().handleKernelAttr(D, AL);
+break
@@ -1,128 +1,128 @@
// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -fsycl-is-device
-disable-llvm-passes -emit-llvm %s -o - | FileCheck %s
void bar(int &Data) {}
-// CHECK: define dso_local void @[[RAW_REF:[a-zA-Z0-9_]+]](ptr noundef nonnull
align 4 dereferenceable(4) %
+// CHEC
@@ -0,0 +1,38 @@
+// RUN: %clang_cc1 -fsycl-is-device -fsyntax-only -verify %s
+
+// Semantic tests for sycl_external attribute
+
+[[clang::sycl_external(3)]] // expected-error {{'sycl_external' attribute
takes no arguments}}
+void bar() {}
+
+[[clang::sycl_external]] // expected
@@ -0,0 +1,16 @@
+// RUN: %clang_cc1 -fsycl-is-device -fsyntax-only -verify %s
+
+// expected-warning@+1{{'sycl_external' attribute only applies to functions}}
+[[clang::sycl_external]] int a;
+
+
+// expected-warning@+2{{'sycl_external' attribute only applies to functions}}
+stru
@@ -29,21 +29,10 @@ int foo() {
}
template
-__attribute__((sycl_kernel)) void kernel_single_task(const Func &kernelFunc) {
+[[clang::sycl_external]] void kernel_single_task(const Func &kernelFunc) {
Fznamznon wrote:
I think it was meant to be a kernel, so sy
@@ -25,20 +40,29 @@ int main() {
auto lambda2 = [](int){};
auto lambda3 = [](double){};
- kernel(lambda1);
- kernel2(lambda2);
- kernel3(lambda3);
+ kernel_wrapper(lambda1);
+ kernel2_wrapper(lambda2);
+ kernel3_wrapper(lambda3);
// Ensure the kernels are named
@@ -476,6 +476,33 @@ The SYCL kernel in the previous code sample meets these
expectations.
}];
}
+def SYCLExternalDocs : Documentation {
+ let Category = DocCatFunction;
+ let Heading = "sycl_external";
+ let Content = [{
+The ``sycl_external`` attribute (or the ``SYCL_E
@@ -476,6 +476,33 @@ The SYCL kernel in the previous code sample meets these
expectations.
}];
}
+def SYCLExternalDocs : Documentation {
+ let Category = DocCatFunction;
+ let Heading = "sycl_external";
+ let Content = [{
+The ``sycl_external`` attribute (or the ``SYCL_E
@@ -1046,6 +1046,9 @@ class DiagnosticsEngine : public
RefCountedBase {
bool EmitDiagnostic(const DiagnosticBuilder &DB, bool Force = false);
/// @}
+
+private:
+ void Report(Level DiagLevel, const Diagnostic &Info);
Fznamznon wrote:
Why not put it righ
@@ -658,13 +658,97 @@ void DiagnosticsEngine::Report(const StoredDiagnostic
&storedDiag) {
Level DiagLevel = storedDiag.getLevel();
Diagnostic Info(this, storedDiag.getLocation(), storedDiag.getID(),
DiagStorage, storedDiag.getMessage());
+ Report(DiagLe
@@ -658,13 +658,97 @@ void DiagnosticsEngine::Report(const StoredDiagnostic
&storedDiag) {
Level DiagLevel = storedDiag.getLevel();
Diagnostic Info(this, storedDiag.getLocation(), storedDiag.getID(),
DiagStorage, storedDiag.getMessage());
+ Report(DiagLe
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/143517
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon approved this pull request.
That makes sense to me, but I've never touched that before, so probably makes
sense to wait for the feedback from @AaronBallman too.
https://github.com/llvm/llvm-project/pull/143517
___
cfe-comm
@@ -2885,6 +2886,16 @@ class CXXDestructorDecl : public CXXMethodDecl {
return getCanonicalDecl()->OperatorDelete;
}
+ const FunctionDecl *getOperatorGlobalDelete() const {
+return getCanonicalDecl()->OperatorGlobalDelete;
+ }
+
+ void setOperatorGlobalDelete(Func
https://github.com/Fznamznon commented:
Thank you for the fix, this overall lg. But perhaps a release note makes sense,
and I agree with @Sirraide that canonical types need to be stored into the set.
https://github.com/llvm/llvm-project/pull/143244
__
Fznamznon wrote:
ping.
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
/cherry-pick 40417915a161e87b398f1cc3e9b7c159207abd77
https://github.com/llvm/llvm-project/pull/135957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon milestoned
https://github.com/llvm/llvm-project/pull/135957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon approved this pull request.
https://github.com/llvm/llvm-project/pull/141783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -359,3 +359,29 @@ struct alignment { // c17-error {{redefinition of
'alignment'}} \
c23-error {{type 'struct alignment' has a member with an
attribute which currently causes the types to be treated as though they are
incompatible}}
int x;
};
+
+//
@@ -12909,6 +12909,10 @@ bool ASTContext::DeclMustBeEmitted(const Decl *D) {
if (D->hasAttr())
return false;
+ if (LangOpts.SYCLIsDevice &&
+ (!D->hasAttr() ||
!D->hasAttr()))
Fznamznon wrote:
Shouldn't that be
```suggestion
if (LangOpts.SYCLI
Fznamznon wrote:
Ping.
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
https://github.com/Fznamznon approved this pull request.
That looks great imo
https://github.com/llvm/llvm-project/pull/141471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/140230
None
>From eeea84b4989b4497cc804f403258b986c09cf5ab Mon Sep 17 00:00:00 2001
From: Elizabeth Andrews
Date: Thu, 8 Aug 2024 18:05:48 -0700
Subject: [PATCH 1/5] [SYCL] Add support for __builtin_sycl_kernel_name
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/140230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -692,6 +692,86 @@ ExprResult Parser::ParseLambdaExpression() {
return ParseLambdaExpressionAfterIntroducer(Intro);
}
+bool Parser::IsLambdaAfterTypeCast() {
+ assert(getLangOpts().CPlusPlus && Tok.is(tok::l_square) &&
+ "Not at the start of a possible lambda expr
https://github.com/Fznamznon approved this pull request.
A couple of nits, otherwise LGTM
https://github.com/llvm/llvm-project/pull/139638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
@@ -52,7 +52,7 @@ static bool CheckWasmBuiltinArgIsInteger(Sema &S, CallExpr *E,
}
bool SemaWasm::BuiltinWasmRefNullExtern(CallExpr *TheCall) {
- if (TheCall->getNumArgs() != 0)
+ if (SemaRef.checkArgCount(TheCall, 0))
Fznamznon wrote:
```suggestion
if (S
@@ -168,7 +168,7 @@ bool Sema::checkArgCount(CallExpr *Call, unsigned
DesiredArgCount) {
Fznamznon wrote:
Maybe also assert that `ArgCount > 0`? In case `checkArgCountAtLeast` becomes
broken.
https://github.com/llvm/llvm-project/pull/139638
_
@@ -62,12 +62,8 @@ bool SemaWasm::BuiltinWasmRefNullExtern(CallExpr *TheCall) {
bool SemaWasm::BuiltinWasmRefNullFunc(CallExpr *TheCall) {
ASTContext &Context = getASTContext();
- if (TheCall->getNumArgs() != 0) {
-Diag(TheCall->getBeginLoc(), diag::err_typecheck_call_t
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/139638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/139566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/139566
While working on vector deleting destructors support (GH19772), I noticed that
MSVC produces different code in scalar deleting destructor body depending on
whether class defined its own operator delete. In MS
1 - 100 of 914 matches
Mail list logo
