[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c10256734cd: clang-tidy: Detect use-after-move in CXXCtorInitializer (authored by MarcoFalke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ ht

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke marked 2 inline comments as done. MarcoFalke added a comment. Minor NFC, I plan to land this tomorrow or Friday CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 ___ cfe-commits mailing list

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke updated this revision to Diff 507304. MarcoFalke added a comment. NFC CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst c

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke marked 3 inline comments as done. MarcoFalke added a comment. Thanks, addressed some more review comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1431 std::string val_; }; PiotrZSL wrote: > MarcoFalke

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke updated this revision to Diff 506632. MarcoFalke added a comment. address feedback about matcher, clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp cl

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:400 void UseAfterMoveCheck::registerMatchers(MatchFinder *Finder) { auto CallMoveMatcher = + callExpr( PiotrZSL wrote: > This is correct but conside

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke updated this revision to Diff 506586. MarcoFalke marked an inline comment as done. MarcoFalke added a comment. Took some review suggestions (Thanks!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 Files: clang-tools-extra/clang-t

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke updated this revision to Diff 506081. MarcoFalke added a comment. sort doc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/docs/ReleaseNotes.rs

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke updated this revision to Diff 506055. MarcoFalke added a comment. clang-format+doc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/docs/Release

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke created this revision. MarcoFalke added a project: clang-tools-extra. Herald added subscribers: PiotrZSL, carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. MarcoFalke requested review of this revision. Herald added a subscriber: cfe-commits. Fixes https://gi

[PATCH] D143375: clang-tidy: Count template constructors in modernize-use-default-member-init

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa491fefb0f8: clang-tidy: Count template constructors in modernize-use-default-member-init (authored by MarcoFalke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D143375: clang-tidy: Count template constructors in modernize-use-default-member-init

MarcoFalke updated this revision to Diff 501858. MarcoFalke added a comment. mv release note, rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143375/new/ https://reviews.llvm.org/D143375 Files: clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp clang-tools-ex

[PATCH] D143375: clang-tidy: Count template constructors in modernize-use-default-member-init

MarcoFalke updated this revision to Diff 500716. MarcoFalke added a comment. Thanks. Added release note. Lmk if I should go ahead and merge this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143375/new/ https://reviews.llvm.org/D143375 Files: clang-tools-extra/clang-tidy/modernize/U

[PATCH] D143375: clang-tidy: Count template constructors in modernize-use-default-member-init

MarcoFalke updated this revision to Diff 496104. MarcoFalke edited the summary of this revision. MarcoFalke added a comment. Remove both test cases that pass on current `main` on Linux, but fail on Windows. Seems unrelated to add/fix them here. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D143375: clang-tidy: Count template constructors in modernize-use-default-member-init

MarcoFalke updated this revision to Diff 496094. MarcoFalke added a comment. Simplify patch and remove test case failing on Windows, but passing on Linux CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143375/new/ https://reviews.llvm.org/D143375 Files: clang-tools-extra/clang-tidy/mod

[PATCH] D143375: clang-tidy: Count template constructors in modernize-use-default-member-init

MarcoFalke created this revision. MarcoFalke added a project: clang-tools-extra. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. MarcoFalke requested review of this revision. Herald added a subscriber: cfe-commits. The check should bomb out

[PATCH] D57528: [tools] Fix python DeprecationWarning: invalid escape sequence

MarcoFalke added a comment. No, I don't have commit right Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57528/new/ https://reviews.llvm.org/D57528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D57528: [tools] Fix python DeprecationWarning: invalid escape sequence

MarcoFalke created this revision. Herald added subscribers: cfe-commits, whisperity. Herald added a reviewer: serge-sans-paille. The python documentation says "it’s highly recommended that you use raw strings for all but the simplest expressions." (https://docs.python.org/3/library/re.html) So

[PATCH] D48098: clang-format-diff: Make it work with python3 too

MarcoFalke added a comment. In https://reviews.llvm.org/D48098#1174771, @krasimir wrote: > MarcoFalke: do you need someone to submit this for you? Yes, I'd appreciate any help on how to submit this for merge. https://reviews.llvm.org/D48098 ___ c

[PATCH] D48098: clang-format-diff: Switch to python3 by default, support python 2.7

MarcoFalke updated this revision to Diff 152867. MarcoFalke added a comment. Keep python2 by default for now https://reviews.llvm.org/D48098 Files: tools/clang-format/clang-format-diff.py Index: tools/clang-format/clang-format-diff.py

[PATCH] D48098: clang-format-diff: Switch to python3 by default, support python 2.7

MarcoFalke updated this revision to Diff 151260. MarcoFalke edited the summary of this revision. https://reviews.llvm.org/D48098 Files: tools/clang-format/clang-format-diff.py Index: tools/clang-format/clang-format-diff.py === --

[PATCH] D48098: clang-format-diff: Switch to python3 by default, support python 2.7

MarcoFalke added a comment. > why is this switch necessary? It is not necessary, but would be nice if the script run on python3 as well (as opposed to only python2, which is going to be deprecated https://pythonclock.org/) > what's expected to be supported with it? I'd assume python2.7 (w

[PATCH] D48098: clang-format-diff: Switch to python3 by default, support python 2.7

MarcoFalke updated this revision to Diff 151038. MarcoFalke added a comment. In python2.7: TypeError: 'encoding' is an invalid keyword argument for this function So remove it for now. https://reviews.llvm.org/D48098 Files: tools/clang-format/clang-format-diff.py Index: tools/clang-format/c

[PATCH] D48098: clang-format-diff: Switch to python3 by default, support python 2.7

MarcoFalke created this revision. Repository: rC Clang https://reviews.llvm.org/D48098 Files: tools/clang-format/clang-format-diff.py Index: tools/clang-format/clang-format-diff.py === --- tools/clang-format/clang-format-diff.