Re: r358104 - Don't emit an unreachable return block.

2019-04-11 Thread Marco Castelluccio via cfe-commits
Thanks, your fix looks good to me. - Marco. Il 11/04/19 05:05, John McCall ha scritto: > > > On 10 Apr 2019, at 21:50, wolfgang.p...@sony.com wrote: > >> Hi, >> This commit seems to be causing a test failure on several buildbots >> (e.g. >> http://lab.llvm.org:8011/builders/clang-ppc64be-linux-l

r347677 - Fix linker option for -fprofile-arcs -ftest-coverage

2018-11-27 Thread Marco Castelluccio via cfe-commits
Author: marco Date: Tue Nov 27 09:31:08 2018 New Revision: 347677 URL: http://llvm.org/viewvc/llvm-project?rev=347677&view=rev Log: Fix linker option for -fprofile-arcs -ftest-coverage Summary: Linux toolchain accidentally added "-u__llvm_runtime_variable" when "-fprofile-arcs -ftest-coverage",

Re: [PATCH] D45454: Add llvm_gcov_flush to be called outside a shared library

2018-06-29 Thread Marco Castelluccio via cfe-commits
OK! Sounds good to me to keep it hidden until https://reviews.llvm.org/D48538 is done (I'm going to try to finish it soon). Il 29/06/2018 19:34, David Li via Phabricator ha scritto: > davidxl added a comment. > > With the current gcov_flush implementation in LLVM, making gcov_flush's > visibilit

Re: [PATCH] D45454: Make __gcov_flush visible outside a shared library

2018-06-26 Thread Marco Castelluccio via cfe-commits
Yes, the behavior changed very recently, I would be surprised if somebody came to depend on it. It's more likely that some clients are depending on the old behavior. - Marco. Il 26/06/2018 22:43, Stephen Hines via Phabricator ha scritto: > srhines added a comment. > > In https://reviews.llvm.org

Re: [PATCH] D45454: Make __gcov_flush visible outside a shared library

2018-06-26 Thread Marco Castelluccio via cfe-commits
Wouldn't it be better to keep compatibility with GCC and make __gcov_flush have default visibility? - Marco. Il 26/06/2018 00:21, Xinliang David Li ha scritto: > I don't have an objection having another interface which is just a > simple wrapper to __gcov_flush but with default visibility. Also

r317709 - Add CoreOption flag to "-coverage" option to make it available for clang-cl

2017-11-08 Thread Marco Castelluccio via cfe-commits
Author: marco Date: Wed Nov 8 11:21:54 2017 New Revision: 317709 URL: http://llvm.org/viewvc/llvm-project?rev=317709&view=rev Log: Add CoreOption flag to "-coverage" option to make it available for clang-cl Summary: The -coverage option is not a CoreOption, so it is not available to clang-cl. Th