[clang] [Clang] Check explicit object parameter for defaulted operators properly (PR #100419)

marco-antognini-sonarsource wrote: @MitalAshok, I see -- that's fair enough. Thanks for digging up the process. https://github.com/llvm/llvm-project/pull/100419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [Clang] Check explicit object parameter for defaulted operators properly (PR #100419)

marco-antognini-sonarsource wrote: @MitalAshok, thanks for the fix! Do you think it could also go into the 19.x branch? https://github.com/llvm/llvm-project/pull/100419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [ASTMatchers] forCallable should not erase binding on success (PR #89657)

https://github.com/mantognini closed https://github.com/llvm/llvm-project/pull/89657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTMatchers] forCallable should not erase binding on success (PR #89657)

marco-antognini-sonarsource wrote: > LGTM aside from a small nit with the release notes. Do you need someone to > land this on your behalf? Thanks for asking. I should be fine -- I'll wait for the CI to complete and merge afterwards. https://github.com/llvm/llvm-project/pull/89657 ___

[clang] [ASTMatchers] forCallable should not erase binding on success (PR #89657)

@@ -832,6 +832,7 @@ Bug Fixes to AST Handling - Fixed malformed AST generated for anonymous union access in templates. (#GH90842) - Improved preservation of qualifiers and sugar in `TemplateNames`, including template keyword. +- ``forCallable`` now properly preserves binding

[clang] [ASTMatchers] forCallable should not erase binding on success (PR #89657)

https://github.com/marco-antognini-sonarsource updated https://github.com/llvm/llvm-project/pull/89657 >From ebc417fe98f1cb0e030ec77c17c0150c3fcca7f9 Mon Sep 17 00:00:00 2001 From: Marco Borgeaud <89914223+marco-antognini-sonarsou...@users.noreply.github.com> Date: Fri, 19 Apr 2024 17:33:22 +02

[clang] [ASTMatchers] forCallable should not erase binding on success (PR #89657)

marco-antognini-sonarsource wrote: > The changes look reasonable to me, but can you also add a release note to > clang/docs/ReleaseNotes.rst so that users of AST matchers know about the fix? Thanks, @AaronBallman, that's a good suggestion. I think I followed the expected format but let me know

[clang] [ASTMatchers] forCallable should not erase binding on success (PR #89657)

https://github.com/marco-antognini-sonarsource updated https://github.com/llvm/llvm-project/pull/89657 >From ebc417fe98f1cb0e030ec77c17c0150c3fcca7f9 Mon Sep 17 00:00:00 2001 From: Marco Borgeaud <89914223+marco-antognini-sonarsou...@users.noreply.github.com> Date: Fri, 19 Apr 2024 17:33:22 +02

[clang] [ASTMatchers] forCallable should not erase binding on success (PR #89657)

marco-antognini-sonarsource wrote: Could someone review this PR, please? Any feedback you can give me is welcome. The CI should be green and I've disabled keeping my email private. Pinging some recent contributors/reviewers to AST Matchers. @danix800, @AaronBallman, @shafik, @PiotrZSL, @steakh

[clang] [ASTMatchers] forCallable should not erase binding on success (PR #89657)

https://github.com/marco-antognini-sonarsource updated https://github.com/llvm/llvm-project/pull/89657 >From ebc417fe98f1cb0e030ec77c17c0150c3fcca7f9 Mon Sep 17 00:00:00 2001 From: Marco Borgeaud <89914223+marco-antognini-sonarsou...@users.noreply.github.com> Date: Fri, 19 Apr 2024 17:33:22 +02

[clang] [ASTMatchers] forCallable should not erase binding on success (PR #89657)

https://github.com/marco-antognini-sonarsource updated https://github.com/llvm/llvm-project/pull/89657 >From ebc417fe98f1cb0e030ec77c17c0150c3fcca7f9 Mon Sep 17 00:00:00 2001 From: Marco Borgeaud <89914223+marco-antognini-sonarsou...@users.noreply.github.com> Date: Fri, 19 Apr 2024 17:33:22 +02

[clang] [ASTMatchers] forCallable should not erase binding on success (PR #89657)

https://github.com/marco-antognini-sonarsource updated https://github.com/llvm/llvm-project/pull/89657 >From ebc417fe98f1cb0e030ec77c17c0150c3fcca7f9 Mon Sep 17 00:00:00 2001 From: Marco Borgeaud <89914223+marco-antognini-sonarsou...@users.noreply.github.com> Date: Fri, 19 Apr 2024 17:33:22 +02

[clang] [ASTMatchers] forCallable should not erase binding on success (PR #89657)

https://github.com/marco-antognini-sonarsource ready_for_review https://github.com/llvm/llvm-project/pull/89657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTMatchers] forCallable should not erase binding on success (PR #89657)

https://github.com/marco-antognini-sonarsource updated https://github.com/llvm/llvm-project/pull/89657 >From ebc417fe98f1cb0e030ec77c17c0150c3fcca7f9 Mon Sep 17 00:00:00 2001 From: Marco Borgeaud <89914223+marco-antognini-sonarsou...@users.noreply.github.com> Date: Fri, 19 Apr 2024 17:33:22 +02

[clang] [ASTMatchers] forCallable should not erase binding on success (PR #89657)

https://github.com/marco-antognini-sonarsource edited https://github.com/llvm/llvm-project/pull/89657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] forCallable should not erase binding on success (PR #89657)

https://github.com/marco-antognini-sonarsource created https://github.com/llvm/llvm-project/pull/89657 Do not erase Builder when the first check fails because it could succeed on the second stack frame. The problem was that `InnerMatcher.matches` erases the bindings when it returns false. The