[PATCH] D21741: Add test for D21736 + D21737.

This revision was automatically updated to reflect the committed changes. Closed by commit rL287689: Add test for D21736. (authored by koriakin). Changed prior to commit: https://reviews.llvm.org/D21741?vs=61922&id=78918#toc Repository: rL LLVM https://reviews.llvm.org/D21741 Files: cfe/t

[PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

This revision was automatically updated to reflect the committed changes. Closed by commit rL287688: [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else. (authored by koriakin). Changed prior to commit: https://reviews.llvm.org/D21737?vs=75550&id=78917#toc Repository: rL LLVM

[PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

koriakin added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:422 // Set up the per-function pass manager. + FPM.add(new TargetLibraryInfoWrapperPass(*TLII)); if (CodeGenOpts.VerifyModule) mehdi_amini wrote: > This seems unnecessary? This ensures

[PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

koriakin updated this revision to Diff 75550. koriakin added a comment. Added a comment explaining the reason. Repository: rL LLVM https://reviews.llvm.org/D21737 Files: lib/CodeGen/BackendUtil.cpp Index: lib/CodeGen/BackendUtil.cpp ===

[PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

koriakin added a comment. In https://reviews.llvm.org/D21737#468861, @mehdi_amini wrote: > Missing test. This is tested by https://reviews.llvm.org/D21741 (along with https://reviews.llvm.org/D21736). Repository: rL LLVM https://reviews.llvm.org/D21737 _

Re: [PATCH] D21741: Add test for D21736 and D21737.

koriakin added a comment. In http://reviews.llvm.org/D21741#467969, @vsk wrote: > Is the plan to commit this along with http://reviews.llvm.org/D21737? Yes, and with http://reviews.llvm.org/D21736+http://reviews.llvm.org/D21739. Repository: rL LLVM http://reviews.llvm.org/D21741 ___

Re: [PATCH] D21741: Add test for D21736 and D21737.

koriakin added inline comments. Comment at: test/Profile/cxx-indirect-call.cpp:3 @@ -2,3 +2,3 @@ -// RUN: %clang_cc1 %s -o - -emit-llvm -fprofile-instrument=clang -mllvm -enable-value-profiling -fexceptions -fcxx-exceptions -triple %itanium_abi_triple | FileCheck %s +// RUN: %

[PATCH] D21741: Add test for D21736 and D21737.

koriakin created this revision. koriakin added reviewers: vsk, betulb. koriakin added a subscriber: cfe-commits. koriakin set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D21741 Files: test/Profile/c-indirect-call.c test/Profile/cxx-indirect-call

[PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

koriakin created this revision. koriakin added a reviewer: asl. koriakin added a subscriber: cfe-commits. koriakin set the repository for this revision to rL LLVM. Currently, TargetLibraryInfoWrapperPass is inserted by PMBuilder. However, some passes are inserted manually before the PMBuilder ones

Re: [PATCH] D19589: [clang] [Builtin] Make __builtin_thread_pointer target-independent.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272893: [Builtin] Make __builtin_thread_pointer target-independent. (authored by koriakin). Changed prior to commit: http://reviews.llvm.org/D19589?vs=55216&id=60966#toc Repository: rL LLVM http://r

Re: [PATCH] D19891: [clang] [SystemZ] Add -mbackchain option.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268575: [SystemZ] Add -mbackchain option. (authored by koriakin). Changed prior to commit: http://reviews.llvm.org/D19891?vs=56072&id=56223#toc Repository: rL LLVM http://reviews.llvm.org/D19891 Fi

[PATCH] D19891: [clang] [SystemZ] Add -mbackchain option.

koriakin created this revision. koriakin added reviewers: uweigand, rjmccall. koriakin added a subscriber: cfe-commits. koriakin set the repository for this revision to rL LLVM. koriakin added a dependency: D19889: [SystemZ] Implement backchain attribute.. This option, like the corresponding gcc o

Re: [PATCH] D19589: [clang] [Builtin] Make __builtin_thread_pointer target-independent.

koriakin added a comment. In http://reviews.llvm.org/D19589#413924, @rjmccall wrote: > Why the random triple change on the test? > > Otherwise LGTM. See the comment above - arm64-apple-ios doesn't support TLS, so __builtin_thread_pointer is meaningless (it compiled before, but would result in

Re: [PATCH] D19589: [clang] [Builtin] Make __builtin_thread_pointer target-independent.

koriakin updated this revision to Diff 55216. koriakin added a comment. Updated version: changed triple in a test to linux - ios doesn't support TLS, so __builtin_thread_pointer now rightly fails. Repository: rL LLVM http://reviews.llvm.org/D19589 Files: include/clang/Basic/Builtins.def

[PATCH] D19589: [clang] [Builtin] Make __builtin_thread_pointer target-independent.

koriakin created this revision. koriakin added reviewers: asl, rjmccall. koriakin added a subscriber: cfe-commits. koriakin set the repository for this revision to rL LLVM. Herald added subscribers: jyknight, aemerson. This is now supported for ARM, AArch64, PowerPC, SystemZ, SPARC. Patches for X

Re: [PATCH] D19099: [clang] [AArch64] Fix D19098 fallout.

This revision was automatically updated to reflect the committed changes. Closed by commit rL266817: [AArch64] Fix D19098 fallout. (authored by koriakin). Changed prior to commit: http://reviews.llvm.org/D19099?vs=53667&id=54254#toc Repository: rL LLVM http://reviews.llvm.org/D19099 Files: