Re: [PATCH] D15998: Implement __attribute__((gc_leaf_function)).

2016-02-11 Thread Manuel Jacob via cfe-commits
mjacob abandoned this revision. mjacob added a comment. I experimented with another approach in the meantime. http://reviews.llvm.org/D15998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D15998: Implement __attribute__((gc_leaf_function)).

2016-01-12 Thread Manuel Jacob via cfe-commits
mjacob added a comment. In http://reviews.llvm.org/D15998#324757, @aaron.ballman wrote: > Can you point me to some documentation on what the semantics of this > attribute are? For instance, how does it play with other attributes (like > naked or dllexport), is there a reason it shouldn't apply

Re: [PATCH] D15998: Implement __attribute__((gc_leaf_function)).

2016-01-11 Thread Manuel Jacob via cfe-commits
mjacob added a comment. In http://reviews.llvm.org/D15998#324354, @reames wrote: > Also, before this gets exposed through Clang, we really should > formalize/document the attribute. In practice, it implies the lack of a > safepoint poll site inside the called function. Annoyingly, it's not a

Re: [PATCH] D15319: [Sema] Don't accept e.g. "(int *)(long)&x" as a constant expression if x is in address space != 0.

2015-12-21 Thread Manuel Jacob via cfe-commits
mjacob added a comment. ping http://reviews.llvm.org/D15319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15319: [Sema] Don't accept e.g. "(int *)(long)&x" as a constant expression if x is in address space != 0.

2015-12-07 Thread Manuel Jacob via cfe-commits
mjacob created this revision. mjacob added a reviewer: rsmith. mjacob added subscribers: cfe-commits, alex. The constant expression evaluator for pointers returns a base and an offset if successful. In this case, CodeGen generates a constant pointer cast, casting the base (with offset applied if

Re: [PATCH] D15169: [SemaCXX] Fix handling of C-style casts from void pointers to pointers in different address space.

2015-12-02 Thread Manuel Jacob via cfe-commits
mjacob added inline comments. Comment at: lib/Sema/SemaCast.cpp:1081-1083 @@ -1080,3 +1080,5 @@ } - Kind = CK_BitCast; + unsigned SrcAS = SrcPointee.getAddressSpace(); + unsigned DestAS = DestPointee.getAddressSpace(); + Kind = SrcAS