https://github.com/mgcarrasco updated
https://github.com/llvm/llvm-project/pull/167543
>From 0c3a34136d87a2c62143dba0b1a8ceb7a81172ca Mon Sep 17 00:00:00 2001
From: Manuel Carrasco
Date: Mon, 17 Nov 2025 05:17:45 -0600
Subject: [PATCH 1/5] [NFC][clang][driver] Improve readability of long and
c
https://github.com/mgcarrasco updated
https://github.com/llvm/llvm-project/pull/167543
>From 676bcbc754ba959e47dfcec9a12edf27ebf284c3 Mon Sep 17 00:00:00 2001
From: Manuel Carrasco
Date: Mon, 17 Nov 2025 05:17:45 -0600
Subject: [PATCH 1/5] [NFC][clang][driver] Improve readability of long and
c
https://github.com/mgcarrasco edited
https://github.com/llvm/llvm-project/pull/167543
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mgcarrasco edited
https://github.com/llvm/llvm-project/pull/167543
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -173,17 +172,40 @@ void AMDGCN::Linker::constructLinkAndEmitSpirvCommand(
const char *LinkedBCFilePath = HIP::getTempFile(C, LinkedBCFilePrefix, "bc");
InputInfo LinkedBCFile(&JA, LinkedBCFilePath, Output.getBaseInput());
+ bool UseSPIRVBackend =
+ Args.hasFlag(op
https://github.com/mgcarrasco edited
https://github.com/llvm/llvm-project/pull/167543
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5236,6 +5268,22 @@ Action *Driver::ConstructPhaseAction(
: types::TY_LLVM_BC;
return C.MakeAction(Input, Output);
}
+
+// The SPIRV backend compilation path for HIP must avoid external
+// dependencies. The default compilation path assembles
https://github.com/mgcarrasco updated
https://github.com/llvm/llvm-project/pull/167543
>From e1fb519dff8026c9c7abb7a8344b9364bc213cb7 Mon Sep 17 00:00:00 2001
From: Manuel Carrasco
Date: Mon, 17 Nov 2025 05:17:45 -0600
Subject: [PATCH 1/5] [NFC][clang][driver] Improve readability of long and
c
https://github.com/mgcarrasco updated
https://github.com/llvm/llvm-project/pull/167543
>From e1fb519dff8026c9c7abb7a8344b9364bc213cb7 Mon Sep 17 00:00:00 2001
From: Manuel Carrasco
Date: Mon, 17 Nov 2025 05:17:45 -0600
Subject: [PATCH 1/4] [NFC][clang][driver] Improve readability of long and
c
https://github.com/mgcarrasco updated
https://github.com/llvm/llvm-project/pull/164994
>From fc44fa9ca9e7e77052bf0285e7770552ca50769e Mon Sep 17 00:00:00 2001
From: Manuel Carrasco
Date: Mon, 17 Nov 2025 05:17:45 -0600
Subject: [PATCH] [NFC][clang][driver] Improve readability of long and comple
mgcarrasco wrote:
> I like this in concept, but a few of these take it a bit too far in the other
> direction, stuff like `IsAMDGPUOrHIP` isn't much more readable than `IsAMDGPU
> || IsHIP`. Try to simplify this a bit more and possible pull in some
> conditions from the previous and later line
https://github.com/mgcarrasco updated
https://github.com/llvm/llvm-project/pull/164994
>From 43455f0f4c8a1d108196a59500d799710428cfa1 Mon Sep 17 00:00:00 2001
From: Manuel Carrasco
Date: Mon, 17 Nov 2025 04:44:07 -0600
Subject: [PATCH] [NFC][clang][driver] Improve readability of long and comple
https://github.com/mgcarrasco updated
https://github.com/llvm/llvm-project/pull/164994
>From d08ef993fce1840fc606ac2fe4c58e26fe88ba52 Mon Sep 17 00:00:00 2001
From: Manuel Carrasco
Date: Mon, 17 Nov 2025 05:17:45 -0600
Subject: [PATCH] [NFC][clang][driver] Improve readability of long and comple
https://github.com/mgcarrasco created
https://github.com/llvm/llvm-project/pull/168521
`clang-linker-wrapper` was incorrectly calling `clang-offload-bundler` for AMD
SPIR-V. This resulted in a binary that couldn't be executed if built using the
new driver.
The runtime couldn't recognise the
https://github.com/mgcarrasco updated
https://github.com/llvm/llvm-project/pull/168521
>From 85f5f98823d8ade6a47b423570c14464615ed1ec Mon Sep 17 00:00:00 2001
From: Manuel Carrasco
Date: Tue, 18 Nov 2025 05:41:31 -0600
Subject: [PATCH] [clang][clang-linker-wrapper] Use the correct triple for
c
https://github.com/mgcarrasco converted_to_draft
https://github.com/llvm/llvm-project/pull/162282
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mgcarrasco updated
https://github.com/llvm/llvm-project/pull/166392
>From d5cf7ce8c47c291c560eb18939fa2c902e450629 Mon Sep 17 00:00:00 2001
From: Manuel Carrasco
Date: Tue, 4 Nov 2025 09:51:11 -0600
Subject: [PATCH] [clang][Driver] NFC: Fix failing test case due to missing
h
https://github.com/mgcarrasco created
https://github.com/llvm/llvm-project/pull/166392
This fixes a typo introduced in #165606 which makes the test case fail.
>From 0fdc0ec3a01e32285f01a945319f4706e83a18cb Mon Sep 17 00:00:00 2001
From: Manuel Carrasco
Date: Tue, 4 Nov 2025 09:51:11 -0600
Subj
https://github.com/mgcarrasco created
https://github.com/llvm/llvm-project/pull/165606
`clang -x hip foo.c --offload-arch=amdgcnspirv --offload-new-driver
-save-temps` was crashing with the following error:
```
/usr/bin/ld: input file 'foo-x86_64-unknown-linux-gnu.o' is the same as output
fil
https://github.com/mgcarrasco updated
https://github.com/llvm/llvm-project/pull/164994
>From 27d6418f9c5666bb42582401ac8e278d3743da7b Mon Sep 17 00:00:00 2001
From: Manuel Carrasco
Date: Fri, 24 Oct 2025 10:06:54 -0500
Subject: [PATCH] [NFC][clang][driver] Improve readability of long and comple
https://github.com/mgcarrasco updated
https://github.com/llvm/llvm-project/pull/164994
>From cfd6db25724fc5deb296cc1e84a494881c44e7ea Mon Sep 17 00:00:00 2001
From: Manuel Carrasco
Date: Fri, 24 Oct 2025 10:06:54 -0500
Subject: [PATCH] [NFC][clang][driver] Improve readability of long and comple
https://github.com/mgcarrasco created
https://github.com/llvm/llvm-project/pull/164994
None
>From ed03d9ddbbf84be1f01f6db145d17d8e981725c2 Mon Sep 17 00:00:00 2001
From: Manuel Carrasco
Date: Fri, 24 Oct 2025 10:06:54 -0500
Subject: [PATCH] [NFC][clang][driver] Improve readability of long and
@@ -3672,29 +3672,45 @@ class OffloadingActionBuilder final {
// compiler phases, including backend and assemble phases.
ActionList AL;
Action *BackendAction = nullptr;
+bool AssembleAndLink = true;
if (ToolChains.fro
Juan Manuel Martinez =?utf-8?q?Caamaño?= ,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco
Message-ID:
In-Reply-To:
https://github.com/mgcarrasco u
Juan Manuel Martinez =?utf-8?q?Caamaño?= ,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
Message-ID:
In-Reply-To:
@@ -0,0 +1,12 @@
+// COM: This test case validates the behavior of
-amdgpu-use-experimental-spirv-backen
https://github.com/mgcarrasco updated
https://github.com/llvm/llvm-project/pull/162282
>From e89ce89521602f651495cf936e016d8f0c926974 Mon Sep 17 00:00:00 2001
From: Manuel Carrasco
Date: Tue, 7 Oct 2025 06:05:21 -0700
Subject: [PATCH 1/5] [HIP][SPIRV] Enable the SPIRV backend instead of the
tr
mgcarrasco wrote:
Rebased. The PR no longer has dependencies on other pull requests.
https://github.com/llvm/llvm-project/pull/162282
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgcarrasco wrote:
Updated PR so clang emits SPIRV directly when using the SPIRV backend and
avoids the previous extra call.
https://github.com/llvm/llvm-project/pull/162282
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org
https://github.com/mgcarrasco updated
https://github.com/llvm/llvm-project/pull/162282
>From e89ce89521602f651495cf936e016d8f0c926974 Mon Sep 17 00:00:00 2001
From: Manuel Carrasco
Date: Tue, 7 Oct 2025 06:05:21 -0700
Subject: [PATCH] [HIP][SPIRV] Enable the SPIRV backend instead of the
transl
Juan Manuel Martinez =?utf-8?q?Caamaño?= ,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
Message-ID:
In-Reply-To:
https://github.com/mgcarrasco updated
https://github.com/llvm/llvm-project/pull/162282
>From 070d11c215c245ed518dd6605d3
Juan Manuel Martinez =?utf-8?q?Caamaño?= ,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco
Message-ID:
In-Reply-To:
@@ -168,19 +16
@@ -0,0 +1,12 @@
+// This test case validates the behavior of -use-experimental-spirv-backend
+
+// Test that -use-experimental-spirv-backend calls clang -cc1 with the SPIRV
triple.
mgcarrasco wrote:
@jhuber6, thanks. The PR is not changing the phases that are c
Juan Manuel Martinez =?utf-8?q?Caamaño?= ,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
Message-ID:
In-Reply-To:
@@ -168,19 +168,39 @@ void AMDGCN::Linker::constructLinkAndEmitSpirvCommand(
const InputInfo &Output
@@ -1421,6 +1421,18 @@ def fhip_emit_relocatable : Flag<["-"],
"fhip-emit-relocatable">,
HelpText<"Compile HIP source to relocatable">;
def fno_hip_emit_relocatable : Flag<["-"], "fno-hip-emit-relocatable">,
HelpText<"Do not override toolchain to compile HIP source to relo
Juan Manuel Martinez =?utf-8?q?Caamaño?= ,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
Message-ID:
In-Reply-To:
@@ -700,6 +700,6 @@
// SPIRV-ONLY-NEXT: 9: compiler, {8}, ir, (device-hip, amdgcnspirv)
// SPIRV-ONLY-N
Juan Manuel Martinez =?utf-8?q?Caamaño?= ,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco
Message-ID:
In-Reply-To:
https://github.com/mgcarrasco updated
https://github.com/llvm/llvm
Juan Manuel Martinez =?utf-8?q?Caamaño?= ,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
Message-ID:
In-Reply-To:
https://github.com/mgcarrasco updated
https://git
@@ -175,15 +175,33 @@ void AMDGCN::Linker::constructLinkAndEmitSpirvCommand(
constructLlvmLinkCommand(C, JA, Inputs, LinkedBCFile, Args);
- // Emit SPIR-V binary.
- llvm::opt::ArgStringList TrArgs{
- "--spirv-max-version=1.6",
- "--spirv-ext=+all",
- "--spi
https://github.com/mgcarrasco updated
https://github.com/llvm/llvm-project/pull/162282
>From e89ce89521602f651495cf936e016d8f0c926974 Mon Sep 17 00:00:00 2001
From: Manuel Carrasco
Date: Tue, 7 Oct 2025 06:05:21 -0700
Subject: [PATCH 1/4] [HIP][SPIRV] Enable the SPIRV backend instead of the
tr
@@ -0,0 +1,12 @@
+// This test case validates the behavior of -use-experimental-spirv-backend
+
+// Test that -use-experimental-spirv-backend calls clang -cc1 with the SPIRV
triple.
mgcarrasco wrote:
Now we have the test cases for `-ccc-print-bindings` and `-ccc
@@ -5483,6 +5483,20 @@ defm wavefrontsize64 : SimpleMFlag<"wavefrontsize64",
defm amdgpu_precise_memory_op
: SimpleMFlag<"amdgpu-precise-memory-op", "Enable", "Disable",
" precise memory mode (AMDGPU only)">;
+def amdgpu_use_experimental_spirv_backend
@@ -0,0 +1,12 @@
+// COM: This test case validates the behavior of
-hip-use-experimental-spirv-backend
mgcarrasco wrote:
Thanks. Removed.
https://github.com/llvm/llvm-project/pull/162282
___
cfe-commits mailing list
c
@@ -1421,6 +1421,16 @@ def fhip_emit_relocatable : Flag<["-"],
"fhip-emit-relocatable">,
HelpText<"Compile HIP source to relocatable">;
def fno_hip_emit_relocatable : Flag<["-"], "fno-hip-emit-relocatable">,
HelpText<"Do not override toolchain to compile HIP source to relo
https://github.com/mgcarrasco edited
https://github.com/llvm/llvm-project/pull/162282
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -175,15 +175,33 @@ void AMDGCN::Linker::constructLinkAndEmitSpirvCommand(
constructLlvmLinkCommand(C, JA, Inputs, LinkedBCFile, Args);
- // Emit SPIR-V binary.
- llvm::opt::ArgStringList TrArgs{
- "--spirv-max-version=1.6",
- "--spirv-ext=+all",
- "--spi
https://github.com/mgcarrasco edited
https://github.com/llvm/llvm-project/pull/162282
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mgcarrasco updated
https://github.com/llvm/llvm-project/pull/162282
>From e89ce89521602f651495cf936e016d8f0c926974 Mon Sep 17 00:00:00 2001
From: Manuel Carrasco
Date: Tue, 7 Oct 2025 06:05:21 -0700
Subject: [PATCH 1/2] [HIP][SPIRV] Enable the SPIRV backend instead of the
tr
Juan Manuel Martinez =?utf-8?q?Caamaño?= ,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco
Message-ID:
In-Reply-To:
@@ -995,7 +995
Juan Manuel Martinez =?utf-8?q?Caamaño?= ,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco
Message-ID:
In-Reply-To:
@@ -168,19 +168,39 @@ void AMDGCN::Linker::constru
Juan Manuel Martinez =?utf-8?q?Caamaño?= ,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
Message-ID:
In-Reply-To:
@@ -995,7 +995,7 @@ inferOffloadToolchains(Compilation &C, Action::Of
Juan Manuel Martinez =?utf-8?q?Caamaño?= ,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
,Manuel
Carrasco ,Manuel Carrasco
Message-ID:
In-Reply-To:
https://github.com/mgcarrasco updated
https://github.com/llvm/llvm-project/pull/16228
51 matches
Mail list logo
