[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

Manikishan marked an inline comment as done. Manikishan added inline comments. Comment at: lib/Format/FormatToken.h:524 +T = T->getPreviousNonComment(); +return (T->Tok.is(tok::comma) && Tok.is(tok::identifier) && +T->Next->Tok.is(tok::colon)); ---

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

Manikishan added a comment. >>! In D64695#1667696 , >>@MyDeveloperDay wrote: > Does this need landing? given that you have a number of patches in flight > perhaps it would be good to request commit access Yes, it would be good if it is landed. And can I

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

Manikishan updated this revision to Diff 216576. Manikishan edited the summary of this revision. Manikishan added a comment. I have removed the introduction to the NetBSDStyle, as there are some styles that are needed to implemented before launching the NetBSD style. Repository: rC Clang CHA

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

Manikishan added a comment. In D64695#1614386 , @MyDeveloperDay wrote: > Assuming this works and the other unit tests don't show issues then this > LGTM. Please consider running this on your NetBSD code base before > committing, if possible please also

[PATCH] D65648: [clang-format] Add support to SpacesBeforeTrailingComments to add spaces before Block comments.

Manikishan marked an inline comment as done. Manikishan added inline comments. Comment at: unittests/Format/FormatTest.cpp:3663 + FormatStyle Style = getGoogleStyle(); + Style.SpacesBeforeTrailingComments = 0; EXPECT_EQ("#define MACRO() \\\n"

[PATCH] D65648: [clang-format] Add support to SpacesBeforeTrailingComments to add spaces before Block comments.

Manikishan created this revision. Manikishan added reviewers: cfe-commits, mgorny, christos, MyDeveloperDay, rdwampler, lebedev.ri. Manikishan added a project: clang. Herald added a subscriber: krytarowski. Patch: SpacesBeforeTrailingBlockComments This patch is to support ```spacesBeforeTrailing

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 212978. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 Files: include/clang/Format/Format.h include/clang/Tooling/Inclusions/HeaderIncludes.h include/clang/Tooling/Inclusions/

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 212974. Manikishan added a comment. Added Tests for using and not using SortPriority Field, Now, even if the SortPriorityis not set it will be set to the value of Category by default Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1606256 , @rdwampler wrote: > In D64695#1605676 , @Manikishan > wrote: > > > In D64695#1590948 , @Manikishan > > wrote: > > > > > In D

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1590948 , @Manikishan wrote: > In D64695#1589818 , @lebedev.ri > wrote: > > > In D64695#1589740 , @Manikishan > > wrote: > > > > > In

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

Manikishan marked an inline comment as done. Manikishan added inline comments. Comment at: lib/Format/FormatToken.h:524 +T = T->getPreviousNonComment(); +return (T->Tok.is(tok::comma) && Tok.is(tok::identifier) && +T->Next->Tok.is(tok::colon)); ---

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1589818 , @lebedev.ri wrote: > In D64695#1589740 , @Manikishan > wrote: > > > In D64695#1589508 , @lebedev.ri > > wrote: > > > > > Is

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 210358. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 Files: include/clang/Tooling/Inclusions/HeaderIncludes.h include/clang/Tooling/Inclusions/IncludeStyle.h lib/Format/Form

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1589508 , @lebedev.ri wrote: > Is there sufficient test coverage as to what happens if `SortPriority` is not > set? If SortPriority is not set, the Includes will be grouped without sorting, For example: #include

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 210353. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 Files: include/clang/Tooling/Inclusions/HeaderIncludes.h include/clang/Tooling/Inclusions/IncludeStyle.h lib/Format/Form

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1589497 , @rdwampler wrote: > Thanks! Can you update the documentation too? Thanks! So, is this Implementation fine? But there is a thing, The values which we give two Priority does not really matter they need to be

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In the following patch I have modified Include categories by adding a new field "sortInlcudes" which defines the priority of the sort. And priority field will now only be used for grouping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 210218. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 Files: include/clang/Tooling/Inclusions/HeaderIncludes.h include/clang/Tooling/Inclusions/IncludeStyle.h lib/Format/Form

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1586157 , @MyDeveloperDay wrote: > I appreciate what you've done to make this patch less duplicated code..but > now you've almost got to the point where being able to control it all via > configuration. > > I'm with

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 209933. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/SortInclu

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

Manikishan marked an inline comment as done. Manikishan added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2921 + Right.is(tok::identifier) && (Right.Next->is(tok::colon))) + return true; if (Right.NewlinesBefore > 1 && Style.MaxEmptyLinesToKeep > 0) --

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

Manikishan marked 5 inline comments as done. Manikishan added inline comments. Comment at: unittests/Format/FormatTest.cpp:3671 + ); +} MyDeveloperDay wrote: > MyDeveloperDay wrote: > > please add a test with comments (it will get logged) > > > > > > ``` >

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1585835 , @lebedev.ri wrote: > In D64695#1585772 , @Manikishan > wrote: > > > In D64695#1585754 , @rdwampler > > wrote: > > > > > I am

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1585754 , @rdwampler wrote: > I am not quite sure why this change is required to sort the headers for > NetBSD, you can set the priorities via `IncludeStyle.IncludeCategories`. Is > that not sufficient? It can be d

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 209873. Manikishan added a comment. Is this change that was meant? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 209814. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/SortInclu

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. > I guess my comment was that you patche introduces a lot of code duplication, > could the small amount of code you added be say put into a lambda and past in > based on style? Yes, I will add that and submit a patch soon. Repository: rC Clang CHANGES SINCE LA

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added inline comments. Comment at: unittests/Format/SortIncludesTest.cpp:709 + "#include \"pathnames.h\"\n", + sort("#include \n" + "#include \n" MyDeveloperDay wrote: > should you add a test which has groups def

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 209776. Manikishan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 Files: include/clang/Format/Format.h lib/Format/Format.cpp Index: lib/Forma

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan marked an inline comment as done. Manikishan added a comment. In D64695#1584706 , @MyDeveloperDay wrote: > There also seems like alot of duplication between the existing sortCppIncludes > > I think the only difference here is really just > >

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1584630 , @MyDeveloperDay wrote: > Do you think there is anything about this algorithm that could be > parameterized so that other projects could utilize it? I think we can take input from users the header files wh

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 209685. Manikishan added a comment. This is the squashed commit of both Adding NetBSD Style and adding sortNetBSDIncludes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 Files:

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan created this revision. Manikishan added reviewers: cfe-commits, mgorny, christos, MyDeveloperDay. Herald added a subscriber: krytarowski. Herald added a project: clang. Manikishan added subscribers: mgorny, christos. This new Style rule is made as a part of adding support for NetBSD KNF

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

Manikishan updated this revision to Diff 204340. Manikishan marked 4 inline comments as done and 2 inline comments as done. Manikishan retitled this revision from "[clang-format] Added New Style Rule: OnePerLineBitFieldDecl" to "[clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

[PATCH] D63062: [clang-format] Added New Style Rule: OnePerLineBitFieldDecl

Manikishan updated this revision to Diff 204068. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63062/new/ https://reviews.llvm.org/D63062 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/F

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

Manikishan updated this revision to Diff 204040. Manikishan marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63062/new/ https://reviews.llvm.org/D63062 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndent

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

Manikishan updated this revision to Diff 204022. Manikishan marked 4 inline comments as done. Manikishan added a comment. Changed Style name to OnePerLineBitFieldDecl Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63062/new/ https://reviews.llvm.org/D63062 Files:

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

Manikishan updated this revision to Diff 203860. Manikishan marked 4 inline comments as done. Manikishan added a comment. Updated unittest Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63062/new/ https://reviews.llvm.org/D63062 Files: docs/ClangFormatStyleOpti

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

Manikishan updated this revision to Diff 203841. Manikishan added a comment. Made some missing style modifications in the last revision Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63062/new/ https://reviews.llvm.org/D63062 Files: docs/ClangFormatStyleOptions

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

Manikishan updated this revision to Diff 203838. Manikishan marked 4 inline comments as done. Manikishan added a comment. Added unittests and made the changes suggested by @mgorny Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63062/new/ https://reviews.llvm.org/D

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

Manikishan updated this revision to Diff 203833. Manikishan added a subscriber: mgorny. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63062/new/ https://reviews.llvm.org/D63062 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/

[PATCH] D63062: Added New Style Rule: BitFieldDeclsOnSeparateLines

Manikishan created this revision. Manikishan added reviewers: aaron.ballman, rsmith. Herald added a subscriber: krytarowski. Herald added a project: clang. This new Style rule is made as a part of adding support for NetBSD KNF in clang-format. This style Lines up BitField Declarations on consecut