My previous email details why we are doing this:
http://lists.llvm.org/pipermail/llvm-dev/2020-April/141167.html
Basically, we ran the PREfast static analysis tool on LLVM/Clang and it
reported a lot of warnings. I guess some of them are false positives after
all.
As David suggests that maybe I sh
Author: mgrang
Date: Fri May 24 12:24:08 2019
New Revision: 361664
URL: http://llvm.org/viewvc/llvm-project?rev=361664&view=rev
Log:
[Analyzer] Checker for non-determinism caused by iteration of unordered
container of pointers
Summary: Added a checker for non-determinism caused by iterating unor
Author: mgrang
Date: Fri May 3 14:12:24 2019
New Revision: 359932
URL: http://llvm.org/viewvc/llvm-project?rev=359932&view=rev
Log:
[COFF, ARM64] Fix ABI implementation of struct returns
Summary:
Related llvm patch: D60348.
Patch co-authored by Sanjin Sijaric.
Reviewers: rnk, efriedma, TomTan,
Author: mgrang
Date: Wed Mar 13 12:21:11 2019
New Revision: 356088
URL: http://llvm.org/viewvc/llvm-project?rev=356088&view=rev
Log:
[Analyzer] Clean up test/Analysis/ptr-sort.cpp
Modified:
cfe/trunk/test/Analysis/ptr-sort.cpp
Modified: cfe/trunk/test/Analysis/ptr-sort.cpp
URL:
http://llvm.
Author: mgrang
Date: Wed Mar 13 12:09:48 2019
New Revision: 356086
URL: http://llvm.org/viewvc/llvm-project?rev=356086&view=rev
Log:
[Analyzer] Update the LLVM license in PointerSortingChecker.cpp
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/PointerSortingChecker.cpp
Modified: cfe/trunk/l
Author: mgrang
Date: Fri Mar 8 12:35:25 2019
New Revision: 355726
URL: http://llvm.org/viewvc/llvm-project?rev=355726&view=rev
Log:
[docs] Fix checkers.rst doc for PointerSorting checker
Modified:
cfe/trunk/docs/analyzer/checkers.rst
Modified: cfe/trunk/docs/analyzer/checkers.rst
URL:
http
Author: mgrang
Date: Fri Mar 8 12:13:53 2019
New Revision: 355720
URL: http://llvm.org/viewvc/llvm-project?rev=355720&view=rev
Log:
[Analyzer] Checker for non-determinism caused by sorting of pointer-like
elements
Summary:
Added a new category of checkers for non-determinism. Added a checker fo
Author: mgrang
Date: Thu Feb 21 11:11:15 2019
New Revision: 354608
URL: http://llvm.org/viewvc/llvm-project?rev=354608&view=rev
Log:
[test] Fix typo: 's/ ot / to /' [NFC]
Modified:
cfe/trunk/test/CodeGenCXX/cxx11-special-members.cpp
Modified: cfe/trunk/test/CodeGenCXX/cxx11-special-members.c
Author: mgrang
Date: Fri Jan 18 10:45:26 2019
New Revision: 351573
URL: http://llvm.org/viewvc/llvm-project?rev=351573&view=rev
Log:
[clang] Change to range-based invocation of llvm::sort
Modified:
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trunk/lib/Format/Format.cpp
URL:
http://llvm.or
Author: mgrang
Date: Mon Jan 14 17:26:26 2019
New Revision: 351147
URL: http://llvm.org/viewvc/llvm-project?rev=351147&view=rev
Log:
[COFF, ARM64] Add __byteswap intrinsics
Reviewers: rnk, efriedma, ssijaric, TomTan, haripul
Reviewed By: efriedma
Subscribers: javed.absar, cfe-commits, kristof.b
Author: mgrang
Date: Mon Jan 14 15:45:58 2019
New Revision: 351137
URL: http://llvm.org/viewvc/llvm-project?rev=351137&view=rev
Log:
[Sema] Change std::sort to llvm::sort
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
Modified: cfe/trunk/lib/Sema/SemaChecking.cpp
URL:
http://llvm.org/viewvc/
Author: mgrang
Date: Mon Jan 14 15:26:01 2019
New Revision: 351135
URL: http://llvm.org/viewvc/llvm-project?rev=351135&view=rev
Log:
[COFF, ARM64] Add __nop intrinsic
Reviewers: rnk, efriedma, TomTan, haripul, ssijaric
Reviewed By: rnk, efriedma
Subscribers: javed.absar, kristof.beyls, cfe-comm
Author: mgrang
Date: Wed Dec 5 11:19:38 2018
New Revision: 348402
URL: http://llvm.org/viewvc/llvm-project?rev=348402&view=rev
Log:
Revert "[RISCV] Mark unit tests as "requires: riscv-registered-target""
This reverts commit 8908dd12e7bbfc74e264233e900206ad31e285f0.
Modified:
cfe/trunk/test/
Author: mgrang
Date: Tue Nov 27 14:53:57 2018
New Revision: 347720
URL: http://llvm.org/viewvc/llvm-project?rev=347720&view=rev
Log:
[RISCV] Mark unit tests as "requires: riscv-registered-target"
Some of these tests break if the RISCV backend has not been built.
Reland D54816.
Modified:
cfe
Author: mgrang
Date: Tue Nov 27 11:13:52 2018
New Revision: 347689
URL: http://llvm.org/viewvc/llvm-project?rev=347689&view=rev
Log:
Revert "[RISCV] Mark unit tests as "requires: riscv-registered-target""
This reverts commit 1a6a0c9ea2716378d55858c11adf5941608531f8.
Added:
cfe/trunk/test/Dri
Author: mgrang
Date: Tue Nov 27 11:13:13 2018
New Revision: 347688
URL: http://llvm.org/viewvc/llvm-project?rev=347688&view=rev
Log:
[RISCV] Mark unit tests as "requires: riscv-registered-target"
Summary: Some of these tests break if the RISCV backend has not been built.
Reviewers: asb, apazos,
Author: mgrang
Date: Mon Nov 5 21:07:43 2018
New Revision: 346208
URL: http://llvm.org/viewvc/llvm-project?rev=346208&view=rev
Log:
[COFF, ARM64] Implement InterlockedDecrement*_* builtins
This is eight in a series of patches to move intrinsic definitions out of
intrin.h.
Differential: https:/
Author: mgrang
Date: Mon Nov 5 21:05:32 2018
New Revision: 346207
URL: http://llvm.org/viewvc/llvm-project?rev=346207&view=rev
Log:
[COFF, ARM64] Implement InterlockedIncrement*_* builtins
This is seventh in a series of patches to move intrinsic definitions out of
intrin.h.
Differential: https
Author: mgrang
Date: Mon Nov 5 21:03:13 2018
New Revision: 346206
URL: http://llvm.org/viewvc/llvm-project?rev=346206&view=rev
Log:
[COFF, ARM64] Implement InterlockedAnd*_* builtins
This is sixth in a series of patches to move intrinsic definitions out of
intrin.h.
Differential: https://revie
Author: mgrang
Date: Mon Nov 5 20:55:20 2018
New Revision: 346205
URL: http://llvm.org/viewvc/llvm-project?rev=346205&view=rev
Log:
[COFF, ARM64] Implement InterlockedXor*_* builtins
This is fifth in a series of patches to move intrinsic definitions out of
intrin.h.
Note: This was reviewed and
Author: mgrang
Date: Mon Nov 5 17:11:25 2018
New Revision: 346190
URL: http://llvm.org/viewvc/llvm-project?rev=346190&view=rev
Log:
[COFF, ARM64] Implement InterlockedOr*_* builtins
This is fourth in a series of patches to move intrinsic definitions out of
intrin.h.
Modified:
cfe/trunk/inc
Author: mgrang
Date: Mon Nov 5 16:36:48 2018
New Revision: 346189
URL: http://llvm.org/viewvc/llvm-project?rev=346189&view=rev
Log:
[COFF, ARM64] Implement InterlockedCompareExchange*_* builtins
Summary: This is third in a series of patches to move intrinsic definitions out
of intrin.h.
Review
Author: mgrang
Date: Fri Nov 2 14:18:23 2018
New Revision: 346044
URL: http://llvm.org/viewvc/llvm-project?rev=346044&view=rev
Log:
[COFF, ARM64] Implement InterlockedExchange*_* builtins
Summary: Windows SDK needs these intrinsics to be proper builtins. This is
second in a series of patches t
Author: mgrang
Date: Fri Nov 2 11:10:07 2018
New Revision: 346024
URL: http://llvm.org/viewvc/llvm-project?rev=346024&view=rev
Log:
[COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.sponentry
Summary: ARM64 setjmp expects sp on entry instead of framepointer.
Patch by: Yin Ma (yi.
Author: mgrang
Date: Thu Nov 1 11:38:26 2018
New Revision: 345872
URL: http://llvm.org/viewvc/llvm-project?rev=345872&view=rev
Log:
Revert "[COFF, ARM64] Change setjmp for AArch64 Windows to use
Intrinsic.sponentry"
This reverts commit 619111f5ccf349b635e4987ec02d15777c571495.
Modified:
cf
Author: mgrang
Date: Wed Oct 31 18:35:34 2018
New Revision: 345808
URL: http://llvm.org/viewvc/llvm-project?rev=345808&view=rev
Log:
[COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAArch64.def
cfe/trunk/lib/CodeGen/CGBuiltin.cp
Author: mgrang
Date: Wed Oct 31 16:17:36 2018
New Revision: 345792
URL: http://llvm.org/viewvc/llvm-project?rev=345792&view=rev
Log:
[COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.sponentry
Summary: ARM64 setjmp expects sp on entry instead of framepointer.
Reviewers: mgrang, rn
Author: mgrang
Date: Thu Oct 18 17:05:26 2018
New Revision: 344767
URL: http://llvm.org/viewvc/llvm-project?rev=344767&view=rev
Log:
[COFF, ARM64] Enable unit test arm64-microsoft-status-reg.cpp only for aarch64
target
This should unbreak bots broken here:
http://lab.llvm.org:8011/builders/clang
Author: mgrang
Date: Thu Oct 18 16:35:35 2018
New Revision: 344765
URL: http://llvm.org/viewvc/llvm-project?rev=344765&view=rev
Log:
[COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics
Reviewers: rnk, compnerd, mstorsjo, efriedma, TomTan, haripul, javed.absar
Reviewed By: efriedma
Su
Author: mgrang
Date: Fri Oct 5 14:57:41 2018
New Revision: 343894
URL: http://llvm.org/viewvc/llvm-project?rev=343894&view=rev
Log:
[COFF, ARM64] Add _InterlockedAdd intrinsic
Reviewers: rnk, mstorsjo, compnerd, TomTan, haripul, javed.absar, efriedma
Reviewed By: efriedma
Subscribers: efriedma
Author: mgrang
Date: Fri Oct 5 12:49:36 2018
New Revision: 343881
URL: http://llvm.org/viewvc/llvm-project?rev=343881&view=rev
Log:
[COFF, ARM64] Add _InterlockedCompareExchangePointer_nf intrinsic
Reviewers: rnk, mstorsjo, compnerd, TomTan, haripul, efriedma
Reviewed By: efriedma
Subscribers:
Author: mgrang
Date: Thu Oct 4 15:32:42 2018
New Revision: 343824
URL: http://llvm.org/viewvc/llvm-project?rev=343824&view=rev
Log:
[COFF, ARM64] Add __getReg intrinsic
Reviewers: rnk, mstorsjo, compnerd, TomTan, haripul, javed.absar, efriedma
Reviewed By: efriedma
Subscribers: peter.smith, ef
Author: mgrang
Date: Wed Oct 3 10:24:21 2018
New Revision: 343699
URL: http://llvm.org/viewvc/llvm-project?rev=343699&view=rev
Log:
[COFF, ARM64] Add _ReadWriteBarrier intrinsic
Reviewers: rnk, mstorsjo, compnerd, TomTan, haripul, javed.absar
Reviewed By: rnk
Subscribers: kristof.beyls, chrib,
Author: mgrang
Date: Tue Jul 31 10:42:05 2018
New Revision: 338405
URL: http://llvm.org/viewvc/llvm-project?rev=338405&view=rev
Log:
[COFF, ARM64] Enable SEH for ARM64 Windows
Reviewers: rnk, mstorsjo, ssijaric, haripul, TomTan
Reviewed By: rnk
Subscribers: kristof.beyls, chrib, cfe-commits
Di
Author: mgrang
Date: Mon Jul 30 12:44:13 2018
New Revision: 338294
URL: http://llvm.org/viewvc/llvm-project?rev=338294&view=rev
Log:
[OpenEmbedded] Fix lib paths for OpenEmbedded targets
Summary:
The lib paths are not correctly picked up for OpenEmbedded sysroots (like
arm-oe-linux-gnueabi) for
Author: mgrang
Date: Thu Jul 26 11:07:59 2018
New Revision: 338050
URL: http://llvm.org/viewvc/llvm-project?rev=338050&view=rev
Log:
[COFF, ARM64] Decide when to mark struct returns as SRet
Summary:
Refer the MS ARM64 ABI Convention for the behavior for struct returns:
https://docs.microsoft.com/
Author: mgrang
Date: Tue Jul 17 15:03:24 2018
New Revision: 337327
URL: http://llvm.org/viewvc/llvm-project?rev=337327&view=rev
Log:
[COFF] Add more missing MSVC ARM64 intrinsics
Summary:
Added the following intrinsics:
_BitScanForward, _BitScanReverse, _BitScanForward64, _BitScanReverse64
_Inter
Author: mgrang
Date: Wed Jun 13 11:49:35 2018
New Revision: 334639
URL: http://llvm.org/viewvc/llvm-project?rev=334639&view=rev
Log:
[COFF] Add ARM64 intrinsics: __yield, __wfe, __wfi, __sev, __sevl
Summary: These intrinsics result in hint instructions. They are provided here
for MSVC ARM64 comp
Author: mgrang
Date: Sun Apr 22 17:49:25 2018
New Revision: 330561
URL: http://llvm.org/viewvc/llvm-project?rev=330561&view=rev
Log:
[XRay] Change std::sort to llvm::sort in response to r327219
r327219 added wrappers to std::sort which randomly shuffle the container before
sorting. This will hel
Author: mgrang
Date: Thu Apr 12 12:31:37 2018
New Revision: 329941
URL: http://llvm.org/viewvc/llvm-project?rev=329941&view=rev
Log:
[RISCV] Fix logic to check if frame pointer should be used
Summary: The logic was broken for Linux triples as it returns true in the
switch for Triple.isOSLinux().
Author: mgrang
Date: Tue Mar 27 09:50:00 2018
New Revision: 328636
URL: http://llvm.org/viewvc/llvm-project?rev=328636&view=rev
Log:
[clang] Change std::sort to llvm::sort in response to r327219
r327219 added wrappers to std::sort which randomly shuffle the container before
sorting. This will he
Author: mgrang
Date: Sat Feb 24 19:58:23 2018
New Revision: 326045
URL: http://llvm.org/viewvc/llvm-project?rev=326045&view=rev
Log:
[RISCV] Enable __int128_t and __uint128_t through clang flag
Summary:
If the flag -fforce-enable-int128 is passed, it will enable support for
__int128_t and __uint
Author: mgrang
Date: Wed Nov 29 12:55:13 2017
New Revision: 319357
URL: http://llvm.org/viewvc/llvm-project?rev=319357&view=rev
Log:
[SourceLocations] Use stronger sort predicate to remove non-deterministic
ordering
Summary:
This fixes the following failure uncovered by D39245:
Clang :: Index/
Author: mgrang
Date: Tue Nov 28 12:41:13 2017
New Revision: 319222
URL: http://llvm.org/viewvc/llvm-project?rev=319222&view=rev
Log:
[OpenMP] Stable sort Privates to remove non-deterministic ordering
Summary:
This fixes the following failures uncovered by D39245:
Clang :: OpenMP/task_firstpri
Author: mgrang
Date: Mon Nov 20 10:49:14 2017
New Revision: 318681
URL: http://llvm.org/viewvc/llvm-project?rev=318681&view=rev
Log:
[AutoComplete] Use stronger sort predicate for autocomplete candidates to
remove non-deterministic ordering
Summary: This fixes the failure in test/Driver/autocomp
Author: mgrang
Date: Mon Nov 13 16:22:24 2017
New Revision: 318121
URL: http://llvm.org/viewvc/llvm-project?rev=318121&view=rev
Log:
[Sema] Stable sort OverloadCandidates to remove non-deterministic ordering
Summary: This fixes failure in Misc/diag-template-diffing.cpp uncovered by
D39245.
Revi
Author: mgrang
Date: Mon Nov 13 11:29:31 2017
New Revision: 318074
URL: http://llvm.org/viewvc/llvm-project?rev=318074&view=rev
Log:
[clang] Remove redundant return [NFC]
Reviewers: rsmith, sfantao, mcrosier
Reviewed By: mcrosier
Subscribers: jholewinski, cfe-commits
Tags: #clang
Differentia
Author: mgrang
Date: Wed Sep 6 15:54:59 2017
New Revision: 312677
URL: http://llvm.org/viewvc/llvm-project?rev=312677&view=rev
Log:
[StaticAnalyzer] Fix failures due to the iteration order of ExplodedNode
Summary:
This fixes failures seen in the reverse iteration builder:
http://lab.llvm.org:801
Author: mgrang
Date: Thu Aug 24 15:40:32 2017
New Revision: 311720
URL: http://llvm.org/viewvc/llvm-project?rev=311720&view=rev
Log:
[clang] Remove unit test which uses reverse-iterate flag
Summary: This patch is in response to https://reviews.llvm.org/D35043 which
removed -reverse-iterate flag.
Author: mgrang
Date: Tue Jul 25 22:29:40 2017
New Revision: 309081
URL: http://llvm.org/viewvc/llvm-project?rev=309081&view=rev
Log:
[clang] Add ARM64 support to armintr.h for MSVC compatibility
Summary: This fixes compiling with headers from the Windows SDK for ARM64.
Reviewers: compnerd, ruiu,
Author: mgrang
Date: Tue Jul 25 16:00:02 2017
New Revision: 309049
URL: http://llvm.org/viewvc/llvm-project?rev=309049&view=rev
Log:
[clang] Add abi-breaking-checks support to clang
Summary: You can now use REQUIRES:abi-breaking-checks in clang too
Reviewers: chapuni, probinson, ddunbar, jroelof
Author: mgrang
Date: Mon Jul 17 14:10:45 2017
New Revision: 308222
URL: http://llvm.org/viewvc/llvm-project?rev=308222&view=rev
Log:
[COFF, ARM64] Set the data type widths and the data layout string
Summary: COFF ARM64 is LLP64 platform. So int is 4 bytes, long is 4 bytes and
long long is 8 byte
Author: mgrang
Date: Mon Jul 17 10:31:44 2017
New Revision: 308192
URL: http://llvm.org/viewvc/llvm-project?rev=308192&view=rev
Log:
[clang] Remove redundant check-prefix=CHECK from tests. NFC.
Reviewers: t.p.northover, mstorsjo, rsmith, mcrosier
Reviewed By: mstorsjo, mcrosier
Subscribers: mcr
Author: mgrang
Date: Thu Jul 6 11:49:57 2017
New Revision: 307296
URL: http://llvm.org/viewvc/llvm-project?rev=307296&view=rev
Log:
[Objective-C] Fix non-determinism in clang
Summary: Iteration of the unordered Ivars causes
objc-modern-metadata-visibility.mm (uncovered by reverse iterating Sma
Author: mgrang
Date: Tue Jun 27 16:56:34 2017
New Revision: 306489
URL: http://llvm.org/viewvc/llvm-project?rev=306489&view=rev
Log:
[COFF, ARM64] Add support for Windows ARM64 COFF format
Summary: This is the clang part of the initial implementation to support
Windows ARM64 COFF format.
Review
Author: mgrang
Date: Tue Jun 6 14:47:56 2017
New Revision: 304823
URL: http://llvm.org/viewvc/llvm-project?rev=304823&view=rev
Log:
[clang] Remove double semicolons. NFC.
Reviewers: rsmith, craig.topper, efriedma
Reviewed By: efriedma
Subscribers: efriedma, cfe-commits
Tags: #clang-c
Differe
Author: mgrang
Date: Mon Dec 5 20:49:16 2016
New Revision: 288762
URL: http://llvm.org/viewvc/llvm-project?rev=288762&view=rev
Log:
[clang] Fix D26214: Move error handling out of MC and to the callers.
Summary: Related llvm patch: https://reviews.llvm.org/D27359
Reviewers: echristo, t.p.northov
Author: mgrang
Date: Thu Dec 1 12:42:16 2016
New Revision: 288397
URL: http://llvm.org/viewvc/llvm-project?rev=288397&view=rev
Log:
[clang] Implement support for -defsym assembler option
Summary:
Adds support for -Wa,-defsym,abc=1 option.
Related llvm patch: https://reviews.llvm.org/D26214
Rev
mgrang added a comment.
I ran pep8 on this script:
line 742: E302 expected 2 blank lines, found 1
line 757: E302 expected 2 blank lines, found 1
line 819: E301 expected 1 blank line, found 0
Can you pep-ify this script?
https://reviews.llvm.org/D27005
___
Author: mgrang
Date: Mon Nov 14 11:31:24 2016
New Revision: 286846
URL: http://llvm.org/viewvc/llvm-project?rev=286846&view=rev
Log:
[clang docs] Minor fix in ClangCheck.rst
Reviewers: djasper, rengolin
Subscribers: Eugene.Zelenko
Tags: #clang-c
Differential Revision: https://reviews.llvm.org/
Author: mgrang
Date: Mon Oct 24 13:53:43 2016
New Revision: 285001
URL: http://llvm.org/viewvc/llvm-project?rev=285001&view=rev
Log:
[clang] Remove redundant --check-prefix=CHECK from tests
Reviewers: mkuper, rengolin, hans
Subscribers: cfe-commits
Tags: #clang-c
Differential Revision: https:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285001: [clang] Remove redundant --check-prefix=CHECK from
tests (authored by mgrang).
Changed prior to commit:
https://reviews.llvm.org/D25893?vs=75521&id=75620#toc
Repository:
rL LLVM
https://revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284931: [clang] Limit clang test to ARM and AArch64 only
(authored by mgrang).
Changed prior to commit:
https://reviews.llvm.org/D25842?vs=75368&id=75537#toc
Repository:
rL LLVM
https://reviews.llvm
Author: mgrang
Date: Sat Oct 22 19:53:03 2016
New Revision: 284931
URL: http://llvm.org/viewvc/llvm-project?rev=284931&view=rev
Log:
[clang] Limit clang test to ARM and AArch64 only
Summary: Limit clang/test/Frontend/gnu-mcount.c to ARM and AArch64 only.
Reviewers: abdulras, honggyu.kim, rengoli
mgrang created this revision.
mgrang added reviewers: hans, mkuper, rengolin.
mgrang added a subscriber: cfe-commits.
mgrang added a project: clang-c.
https://reviews.llvm.org/D25893
Files:
test/CodeGen/ms-mm-align.c
test/CodeGen/windows-on-arm-stack-probe-size.c
Index: test/CodeGen/windows
mgrang retitled this revision from "[clang] Limit clang test to ARM only" to
"[clang] Limit clang test to ARM and AArch64 only".
mgrang updated the summary for this revision.
mgrang updated this revision to Diff 75368.
mgrang added a comment.
Test limited only to ARM and AArch64.
https://review
mgrang created this revision.
mgrang added reviewers: abdulras, honggyu.kim.
mgrang added a subscriber: cfe-commits.
mgrang added a project: clang-c.
Herald added subscribers: rengolin, aemerson.
Limit clang/test/Frontend/gnu-mcount.c to ARM only.
https://reviews.llvm.org/D25842
Files:
test/F
mgrang added inline comments.
Comment at: lib/Driver/Tools.cpp:4502
+ if (Args.hasFlag(options::OPT_mpie_copy_relocations,
options::OPT_mno_pie_copy_relocations,
+ false)) {
Please fix indentation.
Comment at: lib/Frontend
Author: mgrang
Date: Tue Oct 18 14:22:20 2016
New Revision: 284517
URL: http://llvm.org/viewvc/llvm-project?rev=284517&view=rev
Log:
Fix clang tests
Summary:
Add REQUIRES for target specific tests.
Patch by Azharuddin Mohammed.
Reviewers: apazos, weimingz, rsmith, ddunbar, spop, mgrang
Subscri
mgrang added a comment.
Thanks Renato for your comments. I guess I will not upstream my patches then.
--Mandeep
http://reviews.llvm.org/D22254
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
mgrang added a comment.
Hi Tim/Renato,
On a similar note, I have a patch which adds the breakpoint intrinsic (for ARM
and Thumb):
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0491c/CJAHBCFH.html
Could you please let me know if this is something which the community would
like
mgrang added a subscriber: mgrang.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3719
@@ +3718,3 @@
+/// matches twice, once with "b" binding "A1::f" and "d" binding "C::f", and
+/// once with "b" binding "A2::f" and "d" binding "C::f", and
+AST_MATCHER_P(CXXMethodDecl,
Author: mgrang
Date: Tue Apr 19 20:02:18 2016
New Revision: 266843
URL: http://llvm.org/viewvc/llvm-project?rev=266843&view=rev
Log:
[Clang] Remove unwanted --check-prefix=CHECK from unit tests. NFC.
Summary:
Removed unwanted --check-prefix=CHECK from the following unit tests:
test/CXX/
mgrang added a comment.
LGTM.
Could you please check who owns the files you modified and then add a couple of
reviewers. You can try "git blame " or check CODE_OWNERS.TXT file to
get the owners.
http://reviews.llvm.org/D19278
___
cfe-commits maili
mgrang added a subscriber: mgrang.
Comment at: lib/Sema/SemaDeclCXX.cpp:438
@@ +437,3 @@
+ assert(New && "New function decalration is NULL, aborting merge.");
+ assert(Old && "Old function decalration is NULL, aborting merge.");
+
typo: decalration ==> declarati
mgrang added a subscriber: mgrang.
Comment at: lib/Driver/Tools.cpp:580
@@ -573,1 +579,3 @@
+ if (IsIAMCU)
+getToolChain().AddIAMCUIncludeArgs(Args, CmdArgs);
}
Is it better to move this above in the else part of the condition "if
(!IsIAMCU)"?
mgrang added a subscriber: mgrang.
Comment at: include/clang/AST/ASTContext.h:903
@@ +902,3 @@
+#define IMAGE_TYPE(ImgType, Id, SingletonId, Access, Suffix)
\
+ CanQualType SingletonId;
+#include "clang/AST/OpenCLImageTypes.def"
remove extra sp
mgrang added a subscriber: mgrang.
Comment at: test/SemaOpenCL/storageclass-cl20.cl:9
@@ -8,2 +8,3 @@
global int *global GP6 = 0;
+global int * GP7 = 0;
Pointers should align to the right. Like:
global int *GP7 = 0;
http://reviews.llvm.org/D17345
mgrang added a subscriber: mgrang.
Comment at: lib/Sema/SemaDecl.cpp:6605
@@ +6604,3 @@
+ // Program scope pointers can only point to data at the constant or
global
+ // address space.
+ const PointerType *PT = nullptr;
Check alignment of comments
Author: mgrang
Date: Wed Feb 10 15:06:10 2016
New Revision: 260433
URL: http://llvm.org/viewvc/llvm-project?rev=260433&view=rev
Log:
Test commit, fixed "clang" to "Clang" in docs
Reviewers: weimingz
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D17085
Modified:
cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260433: Test commit, fixed "clang" to "Clang" in docs
(authored by mgrang).
Changed prior to commit:
http://reviews.llvm.org/D17085?vs=47493&id=47510#toc
Repository:
rL LLVM
http://reviews.llvm.org/
81 matches
Mail list logo
