[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm added a comment. In D110257#3133934 , @JonChesterfield wrote: > In D110257#3133895 , @hsmhsm wrote: > >> In D110257#3133879 , >> @JonChesterfield wrote: >> >>> In

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm added a comment. In D110257#3133879 , @JonChesterfield wrote: > In D110257#3133866 , @hsmhsm wrote: > >> This is not something specific to AMDGPU backend, but AMDGPU backend at >> present requires this c

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm added a comment. In D110257#3133838 , @JonChesterfield wrote: > Please change the commit message to say why this change is necessary / an > improvement on what we have now. > > My recollection is that the amdgpu backend crashes on some IR and thi

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b9a85d10ac7: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas (authored by hsmhsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm added a comment. Thanks @rnk and @yaxunl . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm added a comment. This patch is waiting for an action for a long time. I am expecting at-least anyone of the reviewers to either say "yes" or "no" or "further required improvements" on this patch so that I can take further action on this patch. If you say "no" to this patch with a strong

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm updated this revision to Diff 384661. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D112791: [IR] Merge createReplacementInstr into ConstantExpr::getAsInstruction

hsmhsm accepted this revision. hsmhsm added a comment. This revision is now accepted and ready to land. Thanks for this clean-up patch. Looks good to me. However, please wait for some time if in case other reviewers have any comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm added a comment. @rjmccall I assume, I have fixed all your review comments. In case, if I have missed something OR if you think, few more changes are required for the patch, please do let me know so that I will proceed as per the comments/suggestions. I would like to bring this patch to

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm updated this revision to Diff 380871. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm updated this revision to Diff 380320. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm updated this revision to Diff 379918. hsmhsm marked 2 inline comments as done. hsmhsm added a comment. Rebase + minor clean-up to patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: cla

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm marked 2 inline comments as done. hsmhsm added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:115 +if (AllocaInsertedAtAllocaInsertPt) + AllocaAddrSpaceInsertPt = dyn_cast(V)->getIterator(); } arichardson wrote: > Shouldn't this use

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm updated this revision to Diff 379682. hsmhsm added a comment. Fix review comments by @rjmccall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/Cod

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm updated this revision to Diff 378875. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D111324: [CFE][Codegen] Remove CodeGenFunction::InitTempAlloca()

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb9c2d775130: [CFE][Codegen] Remove CodeGenFunction::InitTempAlloca() (authored by hsmhsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111324/new/ https:

[PATCH] D111316: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7de6962c85b: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca() (authored by hsmhsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111316

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm updated this revision to Diff 378424. hsmhsm added a comment. Introduce a new instruction pointer which aid all the addressspace casts of static allocas to appear in the source order immediately after all static allocas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111324: [CFE][Codegen] Remove CodeGenFunction::InitTempAlloca()

hsmhsm updated this revision to Diff 378413. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111324/new/ https://reviews.llvm.org/D111324 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenFunction.h I

[PATCH] D111316: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

hsmhsm updated this revision to Diff 378412. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111316/new/ https://reviews.llvm.org/D111316 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRunt

[PATCH] D111293: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04816829968c: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca() (authored by hsmhsm). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D111293: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

hsmhsm updated this revision to Diff 378408. hsmhsm added a comment. Remove newly added test CodeGenObjC/static-alloc-init.m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111293/new/ https://reviews.llvm.org/D111293 Files: clang/lib/CodeGen/Code

[PATCH] D111293: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

hsmhsm updated this revision to Diff 378157. hsmhsm added a comment. Rebase to latest trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111293/new/ https://reviews.llvm.org/D111293 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/test/Cod

[PATCH] D111324: [CFE][Codegen] Remove CodeGenFunction::InitTempAlloca()

hsmhsm updated this revision to Diff 378094. hsmhsm added a comment. Move OpenMP GPU offloading codegen related changes from here to https://reviews.llvm.org/D111324. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111324/new/ https://reviews.llvm.o

[PATCH] D111316: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

hsmhsm updated this revision to Diff 378093. hsmhsm added a comment. Move OpenMP GPU offloading codegen related changes from https://reviews.llvm.org/D111324 to here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111316/new/ https://reviews.llvm.o

[PATCH] D111293: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

hsmhsm updated this revision to Diff 378092. hsmhsm added a comment. Add lit test - CodeGenObjC/static-alloc-init.m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111293/new/ https://reviews.llvm.org/D111293 Files: clang/lib/CodeGen/CGObjCGNU.cpp

[PATCH] D111316: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

hsmhsm created this revision. hsmhsm added reviewers: rjmccall, tra, yaxunl, jdoerfert. hsmhsm requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Sequel patch to https://reviews.llvm.org/D111293. Remove call to CodeGenFunction::InitT

[PATCH] D111293: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

hsmhsm created this revision. hsmhsm added reviewers: rjmccall, tra, yaxunl, jdoerfert. hsmhsm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CodeGenFunction::InitTempAlloca() inits the static alloca within the entry block which may *not*

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm marked 8 inline comments as done. hsmhsm added a comment. In D110257#3047166 , @rjmccall wrote: > In the other, you're moving the store emitted by `InitTempAlloca` so that it > becomes interleaved with the sequence of `alloca`s, but only when ther

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm updated this revision to Diff 377742. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGenCUDA/builtins-amdgcn.

[PATCH] D110676: [CFE][Codegen] Update auto-generated check lines for few GPU lit tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG393581d8a5cb: [CFE][Codegen] Update auto-generated check lines for few GPU lit tests (authored by hsmhsm). Repository: rG LLVM Github Monorepo CH

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D110676: [CFE][Codegen] Update auto-generated check lines for few GPU lit tests

hsmhsm added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110676/new/ https://reviews.llvm.org/D110676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm updated this revision to Diff 375789. hsmhsm added a comment. Fix review comments by @jdoerfert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/C

[PATCH] D110676: [CFE][Codegen] Update auto-generated check lines for few GPU lit tests

hsmhsm updated this revision to Diff 375788. hsmhsm added a comment. Only update lit tests which undergo changes within https://reviews.llvm.org/D110257 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110676/new/ https://reviews.llvm.org/D110676 Fi

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:151 + // allocas. + Builder.CreateStore(Init, Var); } jdoerfert wrote: > hsmhsm wrote: > > jdoerfert wrote: > > > I'm not even sure this is necessarily correct. > > > > > > How do we know

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added a comment. In D110257#3027633 , @jdoerfert wrote: > While I understand people are eager to receive feedback on their patches, it > is not helpful to ping/remind the reviewers constantly. > This does generate noise for them and can consequent

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added a comment. @yaxunl / @jdoerfert / @tra Can I expect your further comment/decision on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm updated this revision to Diff 375472. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGenCUDA/builtins-amdgcn.

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:103 +if (!ArraySize) { + auto *EBB = AllocaInsertPt->getParent(); + auto Iter = AllocaInsertPt->getIterator(); rnk wrote: > hsmhsm wrote: > > jdoerfert wrote: > > > arsenm wrote:

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm updated this revision to Diff 374869. hsmhsm added a comment. Remove "!llvm.access.group" metadata from check lines in test files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:103 +if (!ArraySize) { + auto *EBB = AllocaInsertPt->getParent(); + auto Iter = AllocaInsertPt->getIterator(); jdoerfert wrote: > arsenm wrote: > > Why is there a special AllocaI

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added inline comments. Comment at: clang/test/OpenMP/distribute_parallel_for_simd_if_codegen.cpp:264 // CHECK1: omp.inner.for.cond: -// CHECK1-NEXT:[[TMP7:%.*]] = load i32, i32* [[DOTOMP_IV]], align 4 -// CHECK1-NEXT:[[TMP8:%.*]] = load i32, i32* [[DOTOMP_UB

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added inline comments. Comment at: clang/test/OpenMP/distribute_parallel_for_simd_if_codegen.cpp:264 // CHECK1: omp.inner.for.cond: -// CHECK1-NEXT:[[TMP7:%.*]] = load i32, i32* [[DOTOMP_IV]], align 4 -// CHECK1-NEXT:[[TMP8:%.*]] = load i32, i32* [[DOTOMP_UB

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm updated this revision to Diff 374486. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGenCUDA/builtins-amdgcn.

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:102-106 + auto *EBB = AllocaInsertPt->getParent(); + auto Iter = AllocaInsertPt->getIterator(); + if (Iter != EBB->end()) +++Iter; + Builder.SetInsertPoint(EBB, Iter); -

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm updated this revision to Diff 374419. hsmhsm added a comment. Update source comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGenCUDA/b

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added a comment. In D110257#3016113 , @rnk wrote: > In D110257#3015641 , @hsmhsm wrote: > >> The logic at >> https://github.com/llvm/llvm-project/blob/main/llvm/lib/Transforms/Utils/InlineFunction.cpp#L209

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added a comment. In D110257#3015553 , @arsenm wrote: > I do think it's cleaner/more canonical IR to cluster these at the top of the > block, but I don't understand this comment: > >> otherwise, inliner's attempt to move static allocas from callee

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm updated this revision to Diff 374252. hsmhsm added a comment. Update source comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGenCUDA/b

[PATCH] D110257: [CFE][Codegen] Do not the break contiguity of static allocas.

hsmhsm created this revision. hsmhsm added reviewers: arsenm, rampitec, jdoerfert, lebedev.ri, nhaehnle, rjmccall, yaxunl, AndreyChurbanov. Herald added a subscriber: jvesely. hsmhsm requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald added a project: c

[PATCH] D75402: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code

This revision was automatically updated to reflect the committed changes. Closed by commit rGcac068600e55: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code (authored by hsmhsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D75402: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code

hsmhsm added a comment. In D75402#1901471 , @hsmhsm wrote: > Take care review comments by hliao. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75402/new/ https://reviews.llvm.org/D75402 __

[PATCH] D75402: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code

hsmhsm updated this revision to Diff 247689. hsmhsm added a comment. Take care review comments by hliao. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75402/new/ https://reviews.llvm.org/D75402 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/

[PATCH] D75402: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code

hsmhsm added a comment. In D75402#1901361 , @hliao wrote: > BTW, why that variable cannot have an initializer? Suppose that initializer > is a trivial one, initializing to 0, would that cause any issue in the > compilation? Initialization makes the glo

[PATCH] D75402: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code

hsmhsm marked an inline comment as done. hsmhsm added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1919 void CodeGenModule::addUsedGlobal(llvm::GlobalValue *GV) { LLVMUsed.emplace_back(GV); hliao wrote: > hsmhsm wrote: > > yaxunl wrote:

[PATCH] D75402: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code

hsmhsm marked an inline comment as done. hsmhsm added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1919 void CodeGenModule::addUsedGlobal(llvm::GlobalValue *GV) { LLVMUsed.emplace_back(GV); yaxunl wrote: > hliao wrote: > > This check sho

[PATCH] D75402: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code

hsmhsm created this revision. hsmhsm added reviewers: yaxunl, tra. Herald added a project: clang. Herald added a subscriber: cfe-commits. hip-pinned-shadow global var should remain in the final code object irrespective of whether it is used or not within the code. Add it to used list, so that it w