[clang] [AArch64] Remove strict checks from init-aarch64.c (PR #134338)

2025-04-04 Thread Madhur Amilkanthwar via cfe-commits
madhur13490 wrote: Thanks all. Abandoning this change, will find an appropriate solution for downstream. https://github.com/llvm/llvm-project/pull/134338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [AArch64] Remove strict checks from init-aarch64.c (PR #134338)

2025-04-04 Thread Madhur Amilkanthwar via cfe-commits
https://github.com/madhur13490 closed https://github.com/llvm/llvm-project/pull/134338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Remove strict checks from init-aarch64.c (PR #134338)

2025-04-03 Thread Madhur Amilkanthwar via cfe-commits
madhur13490 wrote: > The other tests should be strengthened to always use -NEXT. The exact set of > macros should be tested; don't want others hiding in the gaps Thanks, @arsenm. However, the strict checks are creating problems in our downstream compiler and rebasing. Our downstream compiler e

[clang] [AArch64] Remove strict checks from init-aarch64.c (PR #134338)

2025-04-03 Thread Madhur Amilkanthwar via cfe-commits
https://github.com/madhur13490 created https://github.com/llvm/llvm-project/pull/134338 The checks in init-aarch64.c expect macros to be back-to-back which seems very strict. This change aims to relax this and use just AARCH64 instead of AARCH64-NEXT. This way, we maintain the order of the mac

[clang] [llvm] [AArch64][SVE] Improve fixed-length addressing modes. (PR #129732)

2025-03-04 Thread Madhur Amilkanthwar via cfe-commits
@@ -7380,12 +7380,27 @@ bool AArch64DAGToDAGISel::SelectAddrModeIndexedSVE(SDNode *Root, SDValue N, return false; SDValue VScale = N.getOperand(1); - if (VScale.getOpcode() != ISD::VSCALE) + int64_t MulImm = std::numeric_limits::max(); + if (VScale.getOpcode() == ISD

[clang] [CMake] Fix variable name (PR #127967)

2025-02-20 Thread Madhur Amilkanthwar via cfe-commits
madhur13490 wrote: > > The fix is NOT correct. You need to enclose in quotes as @tstellar mentions > > in #126876 > > ` llvm_canonicalize_cmake_booleans` converts the string to an integer so you > don't need the quotes now that this function is called with the correct > variable. This is what

[clang] [CMake] Fix variable name (PR #127967)

2025-02-20 Thread Madhur Amilkanthwar via cfe-commits
madhur13490 wrote: Please merge this soon. This has broken our CI miserably and has blocked all our testing. Thanks! https://github.com/llvm/llvm-project/pull/127967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [llvm] [Clang][Driver] Add an option to control loop-interchange (PR #125830)

2025-02-06 Thread Madhur Amilkanthwar via cfe-commits
https://github.com/madhur13490 edited https://github.com/llvm/llvm-project/pull/125830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][Driver] Add an option to control loop-interchange (PR #125830)

2025-02-06 Thread Madhur Amilkanthwar via cfe-commits
https://github.com/madhur13490 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/125830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CMake] Preserve clang-prebolt (PR #109351)

2024-09-23 Thread Madhur Amilkanthwar via cfe-commits
madhur13490 wrote: Here are CMAKE variables we use downstream.  ``` -DLLVM_ENABLE_PROJECTS=bolt;clang;openmp;lld    

[clang] [llvm] [CMake] Preserve clang-prebolt (PR #109351)

2024-09-23 Thread Madhur Amilkanthwar via cfe-commits
madhur13490 wrote: This commit is breaking LTO-PGO-BOLT build while optimizing clang with BOLT. ``` [3064/3065] Merging BOLT fdata Using legacy profile format. Profile from 2 files merged. [3064/3065] Optimizing Clang with BOLT BOLT-INFO: shared object or position-independent executable detecte

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-09-04 Thread Madhur Amilkanthwar via cfe-commits
madhur13490 wrote: @mizvekov Is it possible to revert this until you work on the solution? SPEC is failing since this patch is landed. https://github.com/llvm/llvm-project/pull/100692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [AArch64] Add getHostCPUFeatures to query for enabled features in cpu… (PR #97749)

2024-07-04 Thread Madhur Amilkanthwar via cfe-commits
https://github.com/madhur13490 edited https://github.com/llvm/llvm-project/pull/97749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Add getHostCPUFeatures to query for enabled features in cpu… (PR #97749)

2024-07-04 Thread Madhur Amilkanthwar via cfe-commits
https://github.com/madhur13490 edited https://github.com/llvm/llvm-project/pull/97749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Add getHostCPUFeatures to query for enabled features in cpu… (PR #97749)

2024-07-04 Thread Madhur Amilkanthwar via cfe-commits
@@ -445,4 +445,21 @@ void aarch64::getAArch64TargetFeatures(const Driver &D, if (Args.getLastArg(options::OPT_mno_bti_at_return_twice)) Features.push_back("+no-bti-at-return-twice"); + + // Parse AArch64 CPU Features + const Arg *CPUArg = Args.getLastArg(options::OPT_m

[clang] [AMDGPU] Correctly determine the toolchain linker (PR #89803)

2024-04-23 Thread Madhur Amilkanthwar via cfe-commits
madhur13490 wrote: Thanks for fixing this after our discord chats! https://github.com/llvm/llvm-project/pull/89803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Correctly determine the toolchain linker (PR #89803)

2024-04-23 Thread Madhur Amilkanthwar via cfe-commits
@@ -24,3 +24,9 @@ // RUN: -L. -fconvergent-functions %s 2>&1 | FileCheck -check-prefix=MCPU %s // LTO: clang{{.*}} "-flto=full"{{.*}}"-fconvergent-functions" // MCPU: ld.lld{{.*}}"-L."{{.*}}"-plugin-opt=mcpu=gfx906" + +// We do not suppor the BFD linker, but we should be able