[PATCH] D139029: [clang-format] Don't move comments if AlignTrailingComments: Kind: Leave

mairacanal updated this revision to Diff 479455. mairacanal marked 8 inline comments as done. mairacanal added a comment. Remove \n from the end of the test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139029/new/ https://reviews.llvm.org/D139029 Files: clang/lib/Format/Whites

[PATCH] D139029: [clang-format] Don't move comments if AlignTrailingComments: Kind: Leave

mairacanal updated this revision to Diff 479312. mairacanal added a comment. Reset `Style.MaxEmptyLinesToKeep` after the test case to avoid side effects for other test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139029/new/ https://reviews.llvm.org/D139029 Files: clang/lib/

[PATCH] D139029: [clang-format] Don't move comments if AlignTrailingComments: Kind: Leave

mairacanal added a comment. In D139029#3961512 , @HazardyKnusperkeks wrote: > Thanks, nice work. > > Do you need someone to push it for you? In that case we need a name and an > email address for the commit. Yes, I would need someone to push for me. My

[PATCH] D139029: [clang-format] Don't move comments if AlignTrailingComments: Kind: Leave

mairacanal updated this revision to Diff 479055. mairacanal added a comment. - Instead of using Changes[i].NewlinesBefore use Changes[i].Tok->NewlinesBefore - Create test cases of multiple blank lines - Separate \n\n on test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139029/new/

[PATCH] D139029: [clang-format] Don't move comments if AlignTrailingComments: Kind: Leave

mairacanal added a comment. In D139029#3961446 , @HazardyKnusperkeks wrote: > In D139029#3961444 , > @HazardyKnusperkeks wrote: > >> In D139029#3961438 , @mairacanal >>

[PATCH] D139029: [clang-format] Don't move comments if AlignTrailingComments: Kind: Leave

mairacanal added a comment. In D139029#3961372 , @HazardyKnusperkeks wrote: > Can you please add a test with more than one newline? Hi @HazardyKnusperkeks! Thanks for the feedback. It looks like `Changes[i].NewlinesBefore` values 1 even if I put multip

[PATCH] D139029: [clang-format] Don't move comments if AlignTrailingComments: Kind: Leave

mairacanal created this revision. mairacanal added reviewers: MyDeveloperDay, owenpan, yusuke-kadowaki, HazardyKnusperkeks. Herald added a project: All. mairacanal requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For comments that start aft