Maetveis wrote:
Rebased to fix conflict.
Ping @Sirraide
https://github.com/llvm/llvm-project/pull/131477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Maetveis updated
https://github.com/llvm/llvm-project/pull/131477
From 66d0105572f7aba8c633d0d5cb5ff7cb8cf44408 Mon Sep 17 00:00:00 2001
From: Gergely Meszaros
Date: Sat, 15 Mar 2025 22:37:07 +0100
Subject: [PATCH 1/2] [Clang][Sema] Fix -Whigher-precision-for-complex-division
@@ -10555,6 +10555,43 @@ static void checkArithmeticNull(Sema &S, ExprResult
&LHS, ExprResult &RHS,
<< LHS.get()->getSourceRange() << RHS.get()->getSourceRange();
}
+static void DetectPrecisionLossInComplexDivision(Sema &S, QualType DivisorTy,
+
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
https://github.com/Maetveis closed
https://github.com/llvm/llvm-project/pull/131925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Maetveis edited
https://github.com/llvm/llvm-project/pull/131925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Maetveis wrote:
> Running both mem2reg and sroa is redunant; just run sroa.
>
> If the undefs are getting introduced by sroa, that's fine; they'll go away
> when we fix sroa.
Okay, thanks. I've updated the PR to remove explicit mem2reg.
https://github.com/llvm/llvm-project/pull/131925
___
https://github.com/Maetveis ready_for_review
https://github.com/llvm/llvm-project/pull/131925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Maetveis edited
https://github.com/llvm/llvm-project/pull/131925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,534 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,534 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,534 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,534 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,534 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,534 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
https://github.com/Maetveis updated
https://github.com/llvm/llvm-project/pull/131477
From 99b453917d3176e240d8b8a91f7eab83b1a8d330 Mon Sep 17 00:00:00 2001
From: Gergely Meszaros
Date: Sat, 15 Mar 2025 22:37:07 +0100
Subject: [PATCH 1/2] [Clang][Sema] Fix -Whigher-precision-for-complex-division
https://github.com/Maetveis edited
https://github.com/llvm/llvm-project/pull/131925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Maetveis closed
https://github.com/llvm/llvm-project/pull/131453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Maetveis edited
https://github.com/llvm/llvm-project/pull/131453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Maetveis updated
https://github.com/llvm/llvm-project/pull/131453
From f2a2bf5f94990535637c24c3192dbeb96e17b488 Mon Sep 17 00:00:00 2001
From: Gergely Meszaros
Date: Sat, 15 Mar 2025 12:53:32 +0100
Subject: [PATCH] [Clang][CodeGen] Promote in complex compound divassign
When
https://github.com/Maetveis closed
https://github.com/llvm/llvm-project/pull/131451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Maetveis updated
https://github.com/llvm/llvm-project/pull/131451
From 576741444f85d55787d9b1caadfecaf0618cddf2 Mon Sep 17 00:00:00 2001
From: Gergely Meszaros
Date: Sat, 15 Mar 2025 11:54:12 +0100
Subject: [PATCH] [Clang][CodeGen] Do not promote if complex divisor is real
R
Maetveis wrote:
### Merge activity
* **Mar 19, 2:22 AM EDT**: A user started a stack merge that includes this pull
request via
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/131451).
https://github.com/llvm/llvm-project/pull/131451
___
https://github.com/Maetveis updated
https://github.com/llvm/llvm-project/pull/131451
From 631db26acc1e5476431e0b60b326c96829d7b824 Mon Sep 17 00:00:00 2001
From: Gergely Meszaros
Date: Sat, 15 Mar 2025 11:54:12 +0100
Subject: [PATCH] [Clang][CodeGen] Do not promote if complex divisor is real
R
https://github.com/Maetveis edited
https://github.com/llvm/llvm-project/pull/131451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Maetveis closed
https://github.com/llvm/llvm-project/pull/131447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Maetveis wrote:
> > This is a lot of tests... do we really need every combination of
> > type/operator/flag? I guess it makes sure we don't have gaps, but thousands
> > of lines of tests seems excessive.
>
> It does seem like a lot of testing, but I'd rather we be excessive than take
> our hi
https://github.com/Maetveis created
https://github.com/llvm/llvm-project/pull/131477
- Fix false positive when divisor is a real number
- Fix false negative when divident is real, but divisor is complex
- Fix false negative when due to promotion the division is performed in higher
precision tha
https://github.com/Maetveis ready_for_review
https://github.com/llvm/llvm-project/pull/131447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Maetveis wrote:
* **#131447** https://app.graphite.dev/github/pr/llvm/llvm-project/131447?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/131
Maetveis wrote:
Hey @GeorgeKA, there's still some unaddressed comments from my previous review,
I thought you were still working on it, so I did not want to post more
comments. I realize the latency I'm taking to respond is dragging this out
quite a bit. If you're okay with it I can implement
https://github.com/Maetveis closed
https://github.com/llvm/llvm-project/pull/126068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Maetveis wrote:
Ping @MaskRay @AaronBallman I thought you might be interested in reviewing
since you reviewed https://reviews.llvm.org/D154688.
https://github.com/llvm/llvm-project/pull/126068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
https://github.com/Maetveis edited
https://github.com/llvm/llvm-project/pull/120900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
https://github.com/Maetveis requested changes to this pull request.
Thanks, this is starting to look right. I'm sorry for the long response time, I
could not justify spending work time on the review this time, and my weekends
have been somewhat busy.
I'll try to get some other reviewers to loo
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,472 @@
+#!/usr/bin/env python3
+
+"""generate_unsupported_in_drivermode.py
+
+This script generates Lit regression test files that validate that options are
only exposed to intended driver modes.
+
+The options and driver modes are parsed from Options.td, whose path sh
https://github.com/Maetveis updated
https://github.com/llvm/llvm-project/pull/126068
From 105e5467662248ea2eb41edcfe0ce9a0cc97d044 Mon Sep 17 00:00:00 2001
From: Gergely Meszaros
Date: Thu, 6 Feb 2025 02:55:43 -0800
Subject: [PATCH 1/2] [verify] Improve the error messages with multiple active
https://github.com/Maetveis edited
https://github.com/llvm/llvm-project/pull/126068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
https://github.com/Maetveis requested changes to this pull request.
Phew, first round in. Please don't take the number of suggestions as a
negative, the basic structure looks good there's just many small tweaks to be
made :).
https://github.com/llvm/llvm-project/pull/120900
___
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
https://github.com/Maetveis edited
https://github.com/llvm/llvm-project/pull/120900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,626 @@
+#!/usr/bin/env python3
+
+""" generate_unsupported_in_drivermode.py
+
+usage: python generate_unsupported_in_drivermode.py /Options.td
[/llvm-tblgen]
+
+This script generates a Lit regression test file that validates that options
+are only exposed to intended d
Maetveis wrote:
> Hi @Maetveis . This is ready for review.
>
> There are a few things that I came across while making the script that I
> should highlight :
>
> 1. clang -cc1 test directory
>
>
> [test/Driver/lit.local.cfg](https://github.com/llvm/llvm-project/blob/e10d551aa482ee185a8021
Maetveis wrote:
Sorry I was caught up with work, and didn't find the time to look at this until
now.
> @Maetveis Do you have any thoughts on the following two groups of options
> that are unexpectedly succeeding? I'll note that I did come across some
> options for which the driver appears to
Maetveis wrote:
> @Maetveis
>
> All of the Visibility fields appear to be not null, but that's a good check
> to add anyway. Thanks. After adding it though, the same failures occur.
> Here's an example. Maybe there's a gap in my understanding:
>
> The script generates tests for both flang & c
Maetveis wrote:
Hi,Thanks for working on this issue. I wanted to preface this by feel free to
ignore this during the holidays, zero pressure. I like to interact with the
community in my free time, but that obviously does not need to extend to
everyone :).
What kind of failures are you seeing
https://github.com/Maetveis closed
https://github.com/llvm/llvm-project/pull/120644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Maetveis approved this pull request.
Great work, Thank you very much!
https://github.com/llvm/llvm-project/pull/120644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
@@ -664,6 +664,15 @@
// RUN: not %clang_cl /guard:foo -### -- %s 2>&1 | FileCheck
-check-prefix=CFGUARDINVALID %s
// CFGUARDINVALID: invalid value 'foo' in '/guard:'
+// The test doesn't run in a PTY, so "auto" defaults to off.
+// RUN: %clang_cl -fdiagnostics-color=auto -###
@@ -0,0 +1,8 @@
+// The test doesn't run in a PTY, so "auto" defaults to off.
Maetveis wrote:
Similarly here I think its enough to check that the option is accepted, no real
need to verify what it does.
```c
// RUN: %clang_dxc \
// RUN: -fcolor-diagnostics \
//
https://github.com/Maetveis edited
https://github.com/llvm/llvm-project/pull/120644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Maetveis requested changes to this pull request.
Thank you, mostly looks good, I think the tests can be made simpler. And I
think adding release notes would benefit users.
You can add a new point to "New Compiler Flags" in the clang release notes that
clang-cl and clang-dxc n
1 - 100 of 153 matches
Mail list logo
