[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-10-17 Thread Luca Di sera via cfe-commits
https://github.com/diseraluca closed https://github.com/llvm/llvm-project/pull/67566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-10-17 Thread Luca Di sera via cfe-commits
diseraluca wrote: Closing this one, as we intend to maintain our own local version. https://github.com/llvm/llvm-project/pull/67566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-10-04 Thread Luca Di sera via cfe-commits
diseraluca wrote: > > @vgvassilev If that is an acceptable interface for the LLVM interface then, > > yes, it would be perfect from our side, and I'm more than happy to update > > the PR in the next few days. > > Just to be sure that I understood your proposal. > > `getFullyQualified*` calls wi

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-10-01 Thread Luca Di sera via cfe-commits
diseraluca wrote: @vgvassilev If that is an acceptable interface for the LLVM interface then, yes, it would be perfect from our side, and I'm more than happy to update the PR in the next few days. Just to be sure that I understood your proposal. `getFullyQualified*` calls will accept a new p

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-10-01 Thread Luca Di sera via cfe-commits
diseraluca wrote: > I still do not see why the proposed solution would not work. If it solves > the minimal case that you provided in the description of this PR, I am afraid > that there is some bit from the Qt setup that we do not understand. I cannot for certain say if there is an issue or

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-09-30 Thread Luca Di sera via cfe-commits
diseraluca wrote: > > > > I gave it a quick try, and we would still end up with the same result > > > > in our codebase. But, generally, this would not probably be feasible > > > > for us as a solution. > > > > > > > > > do you have an idea why? Can you show the diff of the changes you made?

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-09-29 Thread Luca Di sera via cfe-commits
diseraluca wrote: > > I gave it a quick try, and we would still end up with the same result in > > our codebase. But, generally, this would not probably be feasible for us as > > a solution. > > do you have an idea why? Can you show the diff of the changes you made? Is > the void specializati

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-09-29 Thread Luca Di sera via cfe-commits
diseraluca wrote: > @diseraluca, thanks for the thorough description. The point of these routines > is to produce code that compiles. I am not sure if we change `Foo::Bar` > with `Foo::Bar` it will compile. > > > Due to the way the current codebase is set up, the chosen specialization is > >

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-09-27 Thread Luca Di sera via cfe-commits
diseraluca wrote: Run clang-format on the patch. I made a bit of a mess as I haven't used the PR model in a very long time. Hopefully this is correct. https://github.com/llvm/llvm-project/pull/67566 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-09-27 Thread Luca Di sera via cfe-commits
https://github.com/diseraluca edited https://github.com/llvm/llvm-project/pull/67566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-09-27 Thread Luca Di sera via cfe-commits
https://github.com/diseraluca edited https://github.com/llvm/llvm-project/pull/67566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Qualify non-dependent types of a class template with the class declar… (PR #67566)

2023-09-27 Thread Luca Di sera via cfe-commits
https://github.com/diseraluca updated https://github.com/llvm/llvm-project/pull/67566 >From d19d716609034465bf6be814a322f26c1ea619c9 Mon Sep 17 00:00:00 2001 From: Luca Di Sera Date: Wed, 27 Sep 2023 15:20:22 +0200 Subject: [PATCH] Qualify non-dependent types of a class template with its decla

[clang] Qualify non-dependent types of a class template with the class declar… (PR #67566)

2023-09-27 Thread Luca Di sera via cfe-commits
https://github.com/diseraluca updated https://github.com/llvm/llvm-project/pull/67566 >From 34b4e7939c88627ce433c96cdcc5e54d71ada94d Mon Sep 17 00:00:00 2001 From: Luca Di Sera Date: Wed, 27 Sep 2023 15:20:22 +0200 Subject: [PATCH 1/2] Qualify non-dependent types of a class template with the c

[clang] Qualify non-dependent types of a class template with the class declar… (PR #67566)

2023-09-27 Thread Luca Di sera via cfe-commits
diseraluca wrote: This might be a breaking change, so I'm not sure if it will be possible to merge it, but I would like to give some context on where the change is coming from. I'm trying (in my position as an employee of The Qt Company), to migrate our documentation generation tool, QDoc, which

[clang] Qualify non-dependent types of a class template with the class declar… (PR #67566)

2023-09-27 Thread Luca Di sera via cfe-commits
https://github.com/diseraluca created https://github.com/llvm/llvm-project/pull/67566 …ation When `clang::TypeName::getFullyQualifiedType`/`clang::TypeName::getFullyQualifiedName` encounter a non-dependent type/type alias that is defined under a templated class/struct, it qualifies the type/t

[clang] 0a51bc7 - Add clang_CXXMethod_isExplicit to libclang

2023-01-27 Thread Luca Di Sera via cfe-commits
Author: Luca Di Sera Date: 2023-01-27T13:23:41+01:00 New Revision: 0a51bc731bcc2c27e4fe97957a83642d93d989be URL: https://github.com/llvm/llvm-project/commit/0a51bc731bcc2c27e4fe97957a83642d93d989be DIFF: https://github.com/llvm/llvm-project/commit/0a51bc731bcc2c27e4fe97957a83642d93d989be.diff

[clang] 1af7164 - Revert "Add clang_CXXMethod_isExplicit to libclang"

2023-01-23 Thread Luca Di Sera via cfe-commits
Author: Luca Di Sera Date: 2023-01-23T12:55:34+01:00 New Revision: 1af716499d6bc29afd9ff2903200890df774859f URL: https://github.com/llvm/llvm-project/commit/1af716499d6bc29afd9ff2903200890df774859f DIFF: https://github.com/llvm/llvm-project/commit/1af716499d6bc29afd9ff2903200890df774859f.diff

[clang] ddbe140 - Add clang_CXXMethod_isExplicit to libclang

2023-01-23 Thread Luca Di Sera via cfe-commits
Author: Luca Di Sera Date: 2023-01-23T11:30:38+01:00 New Revision: ddbe14084da7f31d4b4b53e13d9f868d759f3673 URL: https://github.com/llvm/llvm-project/commit/ddbe14084da7f31d4b4b53e13d9f868d759f3673 DIFF: https://github.com/llvm/llvm-project/commit/ddbe14084da7f31d4b4b53e13d9f868d759f3673.diff

[clang] 5c67cf0 - Add clang_CXXMethod_isMoveAssignmentOperator to libclang

2022-11-14 Thread Luca Di Sera via cfe-commits
Author: Luca Di Sera Date: 2022-11-14T15:21:36+01:00 New Revision: 5c67cf0a7fdc00c9b9c55578b770e768f5618bed URL: https://github.com/llvm/llvm-project/commit/5c67cf0a7fdc00c9b9c55578b770e768f5618bed DIFF: https://github.com/llvm/llvm-project/commit/5c67cf0a7fdc00c9b9c55578b770e768f5618bed.diff

[clang] 476a497 - Add clang_CXXMethod_isCopyAssignmentOperator to libclang

2022-10-26 Thread Luca Di Sera via cfe-commits
Author: Luca Di Sera Date: 2022-10-27T06:55:11+02:00 New Revision: 476a497f729a408ba436f75fc50a41254ce65bc8 URL: https://github.com/llvm/llvm-project/commit/476a497f729a408ba436f75fc50a41254ce65bc8 DIFF: https://github.com/llvm/llvm-project/commit/476a497f729a408ba436f75fc50a41254ce65bc8.diff