[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

2023-01-03 Thread Lounarok via Phabricator via cfe-commits
Lounarok added a comment. > (//data member// is a variable inside a struct/class, but not a > "freestanding" one) Thanks for pointing that out. I misunderstood what //data member// is... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118743/new/ h

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

2022-12-01 Thread Lounarok via Phabricator via cfe-commits
Lounarok added a comment. I tried this patch and it's really helpful! However I found that it warns when it comes to `constexpr static` variable. Snippet: `constexpr static int UNDEFINED_ERROR{0};` Warning msg: `warning: global constant 'UNDEFINED_ERROR' should be marked as 'inline' [modernize-