Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

2016-08-02 Thread Loki Astari via cfe-commits
LokiAstari added a comment. > That should already be doable with a negative offset today, right? Yes. So I don't need to add any changes. right? https://reviews.llvm.org/D22505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

2016-08-02 Thread Loki Astari via cfe-commits
LokiAstari added a comment. I don't have a problem changing it so the default behaviour is: class C { int v1; private: int v2; }; But I would like to retain the functionality that if there is no explicit public/private/protected that it follows the original. But if there is

Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

2016-08-01 Thread Loki Astari via cfe-commits
LokiAstari added a comment. @djasper@klimek Just want to bring this to the top of your queue again :-) Any further thoughts on the processes? Loki https://reviews.llvm.org/D22505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

2016-07-25 Thread Loki Astari via cfe-commits
LokiAstari added a comment. Hope you don't mind me chiming in: > Roughly go ahead with what you are suggesting, although the option should not > be called AccessModifierStandardIndent, as that carries no meaning and > actually is far from the "standard" way. Reasonable names that spring to mind

Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

2016-07-25 Thread Loki Astari via cfe-commits
LokiAstari added a comment. @djasper@klimek Hi guys, I am not sure how to move this PR forward. I am not sure if you are uninterested or if this is two minor in comparison to other issues. If there is some other task I need to do to move this forward I more than happy to do some leg wo

Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

2016-07-20 Thread Loki Astari via cfe-commits
LokiAstari added a comment. @djasper@klimek Is that a sufficient example? Or do I need to do some more exhaustive search of github for projects? https://reviews.llvm.org/D22505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

2016-07-19 Thread Loki Astari via cfe-commits
LokiAstari added a comment. Each new style option must :: - be used in a project of significant size (have dozens of contributors) - have a publicly accessible style guide - have a person willing to contribute and maintain patches Example: https://github.com/openframeworks/openFrameworks St

[PATCH] D22505: Access Modifier Use Normal Indent

2016-07-19 Thread Loki Astari via cfe-commits
LokiAstari created this revision. LokiAstari added reviewers: djasper, klimek. LokiAstari added a subscriber: cfe-commits. Herald added a subscriber: klimek. Access Modifiers (public/protected/private) causes standard indent. ``` class MyClass { int value1;// standard indent. publ