[PATCH] D99181: [analyzer] Fix crash on spaceship operator (PR47511)

loic-joly-sonarsource added inline comments. Comment at: clang/test/Analysis/PR47511.cpp:5 + +#include "Inputs/std-compare.h" + For such a simple test, there is no need to use the full-fledged header, the following would suffice: ``` namespace std { struct stro

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

loic-joly-sonarsource added a comment. Can someone with write access merge this please? Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80025/new/ https://reviews.llvm.org/D80025 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

loic-joly-sonarsource updated this revision to Diff 270893. loic-joly-sonarsource added a comment. Removing memoization for non recursive matches CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80025/new/ https://reviews.llvm.org/D80025 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

loic-joly-sonarsource marked an inline comment as done. loic-joly-sonarsource added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:46-49 +enum class MatchDirection { + Ancestors, + Descendants +}; klimek wrote: > loic-joly-sonarsource wro

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

loic-joly-sonarsource added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:46-49 +enum class MatchDirection { + Ancestors, + Descendants +}; klimek wrote: > loic-joly-sonarsource wrote: > > klimek wrote: > > > Nice find! Why don't we need

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

loic-joly-sonarsource added a comment. In D80025#2041247 , @njames93 wrote: > This needs rebasing against trunk I'm doing it Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:46-49 +enum class MatchDirection { + Ancestors, + Desc

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

loic-joly-sonarsource updated this revision to Diff 264709. loic-joly-sonarsource added a comment. Take into account transitive/non transitive request Clarify unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80025/new/ https://reviews.llvm.org/D80025 Files: clang/lib/ASTMatch

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

loic-joly-sonarsource created this revision. loic-joly-sonarsource added a reviewer: klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. In ASTMatcher, when we have `has(...)` and `hasParent(...)` called with the same internal matcher on the same node, the memoization p