[PATCH] D145491: [clang] Replace Member Expressions During Instantiation If Necessary

This revision was automatically updated to reflect the committed changes. Closed by commit rG3951c28b37ff: [clang] Replace Member Expressions During Instantiation If Necessary (authored by lime). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145491/n

[PATCH] D145491: [clang] Replace Member Expressions During Instantiation If Necessary

lime updated this revision to Diff 504535. lime added a comment. Update and ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145491/new/ https://reviews.llvm.org/D145491 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/TreeTransform.h clang/test/CodeGenCXX/decl-ref-inheritanc

[PATCH] D145491: [clang] Replace Member Expressions During Instantiation If Necessary

lime created this revision. lime added reviewers: aaron.ballman, cor3ntin, erichkeane, clang-language-wg. lime added projects: All, clang, clang-language-wg. lime requested review of this revision. Herald added a subscriber: cfe-commits. This patch replace member accesses to declaration references

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8498ba6c2860: [clang] Add the check of membership for the issue #58674 and improve the lookup… (authored by lime). Repository: rG LLVM Github Mono

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

lime updated this revision to Diff 499374. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143840/new/ https://reviews.llvm.org/D143840 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp clang/test/Cod

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

lime updated this revision to Diff 499339. lime edited the summary of this revision. lime added a comment. Updated as suggested. I will do a stage-2 build before landing the patch to confirm whether it would case another crash, and it takes time. CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

lime added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143840/new/ https://reviews.llvm.org/D143840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D140614: [C++20] Mark lambdas in lambda specifiers as dependent if necessary

lime added a comment. Crashes were gone although via avoiding diagnostics directly in D140838 . Considering this does not fix the acceptance of the ill code here , should I abandon this

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

lime added inline comments. Comment at: clang/lib/AST/CXXInheritance.cpp:84 [BaseDecl](const CXXBaseSpecifier *Specifier, CXXBasePath &Path) { return Specifier->getType()->getAsRecordDecl() && FindBaseClass(Specifier, Path, BaseDecl); -

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

lime updated this revision to Diff 496742. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143840/new/ https://reviews.llvm.org/D143840 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp clang/test/Cod

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

lime created this revision. lime added reviewers: aaron.ballman, erichkeane, cor3ntin, clang-language-wg. Herald added a subscriber: yaxunl. Herald added a project: All. lime requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch includ

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01adf96ebc86: [clang] Add the check of membership in decltype for the issue #58674 (authored by lime). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 493058. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142437/new/ https://reviews.llvm.org/D142437 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp clang/test/Sem

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 493057. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142437/new/ https://reviews.llvm.org/D142437 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp clang/test/Sem

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 493055. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142437/new/ https://reviews.llvm.org/D142437 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp clang/test/Sem

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 491981. lime added a comment. Updated as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142437/new/ https://reviews.llvm.org/D142437 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 491717. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142437/new/ https://reviews.llvm.org/D142437 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp clang/test/Sem

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

lime created this revision. lime added reviewers: aaron.ballman, erichkeane, cor3ntin, clang-language-wg. lime added a project: clang. Herald added a subscriber: yaxunl. Herald added a project: All. lime requested review of this revision. Herald added a subscriber: cfe-commits. D137531

[PATCH] D140554: [C++20] Determine the dependency of unevaluated lambdas more accurately

lime added a comment. Could you please help to commit this? My name and email are `Liming Liu ` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140554/new/ https://reviews.llvm.org/D140554 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D140554: [C++20] Determine the dependency of unevaluated lambdas more accurately

lime updated this revision to Diff 486764. lime added a comment. Just rebased, and the `check-profile` target passed on my local machine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140554/new/ https://reviews.llvm.org/D140554 Files: clang/docs/ReleaseNotes.rst clang/include/clan

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

lime added a comment. Is there a place to see the log of the powerpc64le self-built buildbot? @erichkeane Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 ___ c

[PATCH] D140554: [C++20] Determine the dependency of unevaluated lambdas more accurately

lime updated this revision to Diff 486591. lime added a comment. Added release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140554/new/ https://reviews.llvm.org/D140554 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h clang/lib/Sema/TreeTransform.h cla

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 486275. lime added a comment. Rebased. Could you please help to commit this patch? My signature is `Liming Liu `. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 Files: clang/docs/ReleaseNotes.rst clang/

[PATCH] D140614: [C++20] Mark lambdas in lambda specifiers as dependent if necessary

lime added a comment. There should be a more general solution. This patch does not solve the issue here . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140614/new/ https://reviews.llvm.org/D140614 ___ cfe-com

[PATCH] D140614: [C++20] Mark lambdas in lambda specifiers as dependent if necessary

lime updated this revision to Diff 485276. lime retitled this revision from "[C++20] Check the dependency of declaration contexts before pumping diagnostics" to "[C++20] Mark lambdas in lambda specifiers as dependent if necessary". lime edited the summary of this revision. CHANGES SINCE LAST ACT

[PATCH] D140614: [C++20] Check the dependency of declaration contexts before pumping diagnostics

lime added a comment. I submitted it a little early. The correct fix may be letting the declaration be dependent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140614/new/ https://reviews.llvm.org/D140614 _

[PATCH] D140614: [C++20] Check the dependency of declaration contexts before pumping diagnostics

lime created this revision. lime added reviewers: cor3ntin, shafik, erichkeane, aaron.ballman, ychen, clang-language-wg. lime added a project: clang. Herald added a project: All. lime requested review of this revision. Herald added a subscriber: cfe-commits. Unevaluated lambdas can cause the inst

[PATCH] D140554: [C++20] Determine the dependency of unevaluated lambdas more accurately

lime created this revision. lime added reviewers: cor3ntin, shafik, erichkeane, aaron.ballman, clang-language-wg. lime added a project: clang. Herald added a project: All. lime requested review of this revision. Herald added a subscriber: cfe-commits. During template instantiation, the instantiat

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 483815. lime added a comment. Rebase and ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/decltype.cpp Index: clan

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 479898. lime added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/decltype.cpp Index: clang/test/Se

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 477737. lime added a comment. Undo unrelated format changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/decltype.cp

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 477735. lime added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/decltype.cpp Index: clang/test/Se

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

lime added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 475768. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/decltype.cpp Index: clang/test/SemaCXX/decltype.cpp =

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 474987. lime retitled this revision from "[clang] Add the check of decltype in derived templates for issue #58674" to "[clang] Add the check of membership in decltype for the issue #58674". lime added a comment. Herald added a subscriber: yaxunl. Remove an if-s

[PATCH] D137531: [clang] Add the check of decltype in derived templates for issue #58674

lime updated this revision to Diff 474731. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/decltype.cpp Index: clang/test/SemaCXX/decltype.cpp =

[PATCH] D137531: [clang] Add the check of decltype in derived templates for issue #58674

lime updated this revision to Diff 473943. lime retitled this revision from "[clang] Fix the GitHub issue #58674" to "[clang] Add the check of decltype in derived templates for issue #58674". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 File

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

lime added a comment. `Liming Liu ` It is also included in the patch file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128 ___ cfe-commits mailing list cfe-com

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

lime updated this revision to Diff 471046. lime added a comment. Update as suggested. Could you please help me apply this patch (F25074675: 0001-P0857R0-Part-B-Allows-require-clauses-appearing-in-t(1).patch )? It seems unsuitable to grant a fresh account the

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

lime updated this revision to Diff 470816. lime added a comment. Update commit message, and remove the "for" in release notes, which should make the phrase correct in grammar. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://revie

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

lime updated this revision to Diff 470800. lime retitled this revision from "Resubmit an implemention for constrained template template parameters [P0857R0 Part B]" to "[P0857R0 Part B] Resubmit an implemention for constrained template template parameters". lime added a comment. Update release n

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 470779. lime added a comment. The previous update for conflicts lacks a comma, and the comma was added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128 Files: clang/in

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 470746. lime added a comment. Solve the conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseTempla

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 470739. lime added a comment. Solve the format issue further. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseTemplate.cpp clang/lib/Sema/Sema

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 470702. lime added a comment. Update for the format check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/Par

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 470686. lime added a comment. Solve the conflicts, and the issue about `CMakeLists.txt` had been solved by upstream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128 Fil

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 470679. lime added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Update as required. Also, I need the following modification to complete `ninja check-all`. Maybe, I should submit another pa

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 469982. lime added a comment. Update for the format check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/Par

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 469976. lime added a comment. I updated the patch based on D136468 . I added a change which I think could be a fix to the specialization problem. It is just skipping the addition of the level where the specialization specialize

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime added a comment. > which isn't clear to me what you mean - In the function `Sema::CheckTemplateArgument` at line 5725, `Params` has been substituted in a way all `TemplateTypeParmDecl`s are instantiated with a smaller depth, and so are constraints of them at SemaTemplateInstantiateDecl.cp

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime added a comment. I think I located the problem. In the line 1014 of the file `SemaTemplateInstantiateDecl.cpp`, the requires clause is not instantiated as the parameters of the template parameter list, and these parameters have been instantiated with a shallower depth. So that's the reason

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:590 +// FIXME: may be incomplete +static unsigned CalculateTemplateDepthForConstraints(const Expr *Constr) { erichkeane wrote: > I'd like some sort of assert in the case where you don't know

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:706 + std::tie(OldConstr, NewConstr) = + AdjustConstraintDepth::UnifyConstraintDepthFromDecl(*this, Old, OldConstr, + New, NewConstr); --

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime added a comment. > Unless I'm missing something, I don't think this idea of 'unify constraint > depth' is correct. We should be able, from the decl itself, to determine the > depths? What is the difference here that I'm not getting? It is explained by the inline comments in sequence. > Ca

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 467039. lime added a comment. I updated the patch as I said, while kept the key of `NormalizationCache` relatively heavy. That means I: - changed the parameter of `IsAtLeastAsConstrained` to `MutableArrayRef`, - and let the new `CalculateTemplateDepthForConstra

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 466056. lime added a comment. > The changes in Sema.h and the changes of CalculateTemplateDepthForConstraints I think it might be fine now. The above changes are related to `NormalizationCache`. This cache used to take `NamedDecl` as its key. However, as const

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 465750. lime added a comment. I updated patch to fix the previous problem that failed to pass unit tests. And, isn't this patch accepted a little quickly? BTW, `NormalizationCache` becomes heavier than before. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 465652. lime added a comment. Thanks for the advice. I used `AdjustConstraintDepth` before `subsume`. The adjusted constraints are assigned to new addresses, but I think `MutableArrayRef` could be used here. > what do you mean by 'tailing' here? I wanted to e

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 465395. lime added a comment. I provided a solution for the problem I mentioned above, although it may look ugly. Then, I will take a look at `friend` related stuffs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime added a comment. I'm wondering whether classes like `TemplateArgumentLoc` could refer to the template head of the `TemplateArgument`, so the comparison of parameter mappings could be modified, and then the refered variable could be accepted. Comment at: clang/test/CXX/te

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 464465. lime added a comment. I rearranged the error messages. But after I rebased this patch on D126907 , the file `p3-2a.cpp` no longer passed. So I did some investigations there . Th

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime added a comment. Well, Something happened after rebasing this patch on D126907 . `s41` below was rejected as the constrain generated from `template ` was no longer considered to subsume the constrain generated from `template requires C` in the template te

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime added a comment. I have not looked deep into D126907 , but the rule it referred seems related to something as follows: template concept C = true; template struct S { template U> typename> friend void foo(S) {} }; // Does the rule sa

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime added a comment. In D134128#3798127 , @cor3ntin wrote: > Thanks for working on this. > I'll be honest though, I still have absolutely no understanding what the use > cases or intents of this features are. I think we were waiting for core to > clari

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime created this revision. lime added reviewers: aaron.ballman, h-vetinari, erichkeane, cor3ntin, tahonermann. lime added a project: clang. Herald added a project: All. lime requested review of this revision. Herald added a subscriber: cfe-commits. This function had been submitted by @erichkeane